Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 07:08 schrieb Allan Rae: > IMO, if the silly class change dialog had been shifted to be > handled when Okay/Apply were pressed this bug also would have been > fixed. > > > I suspect that one of the first lines of the following part of > > FormDocument.C is to blam

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Angus Leeming
On Thursday 20 September 2001 11:21, Juergen Spitzmueller wrote: > Question: do we need this comparision at all? I deleted it and now all > works like a charm. Will there be any unwanted sideeffects, apart from > the case that the class options will be reset to default even if the > user choses

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Angus Leeming
On Thursday 20 September 2001 11:33, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Is that not an unwanted side-effect? Why not post a message > Angus> rather than a question and only when the params are applied, > Angus> not input, as Allan s

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 12:35 schrieb Angus Leeming: > On Thursday 20 September 2001 11:21, Juergen Spitzmueller wrote: > > Question: do we need this comparision at all? I deleted it and now > > all works like a charm. Will there be any unwanted sideeffects, > > apart from the case that

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Vigna
On 20-Sep-2001 Juergen Spitzmueller wrote: > Auto Reset means that the settings will be reset on any action with the > class choice, and I think the LyX users are intelligent enough to get > this ;-). Personally, I was always annoyed by that question. It > reminded me a little bit on a silly

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 14:00 schrieb Juergen Vigna: > IMO we should still check if there was no change! It's easy enough > and it needs only a private class variable in the FormDocument. So we > won't do anything if we didn't really do anything. But it should work (not like the previou

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Vigna
On 20-Sep-2001 Juergen Spitzmueller wrote: > Am Donnerstag, 20. September 2001 14:00 schrieb Juergen Vigna: >> IMO we should still check if there was no change! It's easy enough >> and it needs only a private class variable in the FormDocument. So we >> won't do anything if we didn't really do an

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 12:29 schrieb Jean-Marc Lasgouttes: > Juergen, is there something special about this patch? I get: > > patch: malformed patch at line 183: + * FormPreferences.C: > Handle that button Oups... sorry. Here's a (hopefully) better one. Jürgen > JMarc doc

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Allan Rae
On Thu, 20 Sep 2001, Juergen Spitzmueller wrote: [...] > Auto Reset means that the settings will be reset on any action with the > class choice, and I think the LyX users are intelligent enough to get > this ;-). [...] > IMHO the new approach is much better than the old one. But of course > you ca

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Allan Rae
On 20 Sep 2001, Jean-Marc Lasgouttes wrote: > > "Garst" == Garst R Reese <[EMAIL PROTECTED]> writes: > > Garst> I do that when I am making a new template or just a new file > Garst> that I want set up like some old file. Open old.lyx and > Garst> new.lyx, look at the comboxes in old, set up n

Re: What's wrong here? [w/ PATCH]

2001-09-21 Thread Juergen Spitzmueller
Am Freitag, 21. September 2001 09:14 schrieb Allan Rae: > Document it. In NEWS and in whichever user manual Mike thinks fits > best (User Guide? but certainly in the Reference manual). Good idea. I will do (after it is decided that this approach will go in and how). Maybe Mike can tell me wher

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 17:20 schrieb Jean-Marc Lasgouttes: > I took a quick look at it and have two remarks: > > 1/ the save button is too small for its label > > 2/ it should not be in a frame together with "reset", since the list > of arguments afected by this is different. Actually,

Re: What's wrong here? [w/ PATCH] (+ Reference manual comment)

2001-09-21 Thread Mike Ressler
Mike weighs in :-) On Fri, 21 Sep 2001, Juergen Spitzmueller wrote: > Am Freitag, 21. September 2001 09:14 schrieb Allan Rae: > > Document it. In NEWS and in whichever user manual Mike thinks fits > > best (User Guide? but certainly in the Reference manual). > > Good idea. I will do (after it i