Le 09/06/16 à 19:14, Guillaume Munch a écrit :
I was about to push the rebased version with the corrections suggested
by your tests. I can either push now, or please can you confirm that the
attached RefChanger.h compiles?
I'll take a look.
Independently, can we drop clang 3.0? Starting from
Le 09/06/2016 09:53, Jean-Marc Lasgouttes a écrit :
Le 08/06/2016 à 01:30, Guillaume Munch a écrit :
I believe clang is right and gcc is wrong. gcc treats rc as an rvalue,
which makes the conversion into unique_ptr valid. But rc
should not be considered as an rvalue, because the standard only
Le 09/06/2016 18:14, Guillaume Munch a écrit :
As for unicode.cpp, the error is in gcc 4.7 as well, thanks to which I
could check that it is corrected as I suggested, that is, explicitly
defining the move constructor as defaulted. This departs from the
specification and is very annoying. To
alue to a non-const reference of any
kind. RefChanger provides a flexible and uniform generalisation of the various
scope guards previously derived from the old Changer class in MetricsInfo.h.
As before, a temporary assignment lasts as long as the Changer object lives. But
the new Changer is movabl
Le 08/06/2016 à 01:30, Guillaume Munch a écrit :
Try changing 'return rc;' to 'return std::move(rc);' (twice).
Unfortunately, with Georg's recent changes, I don't think that your
patches still apply. The best would be to publish the branch you are
working on in the features repository and
Le 07/06/2016 15:05, Jean-Marc Lasgouttes a écrit :
Le 07/06/2016 à 09:04, Jean-Marc Lasgouttes a écrit :
Le 05/06/2016 01:01, Guillaume Munch a écrit :
12. This is a new helper class that I wrote because the Changer class
from MetricsInfo was too cumbersome (essentially a TeX \def
Le 07/06/2016 à 09:04, Jean-Marc Lasgouttes a écrit :
Le 05/06/2016 01:01, Guillaume Munch a écrit :
12. This is a new helper class that I wrote because the Changer class
from MetricsInfo was too cumbersome (essentially a TeX \def with
shadowing). This commit entirely replaces the latter
Le 05/06/2016 01:01, Guillaume Munch a écrit :
12. This is a new helper class that I wrote because the Changer class
from MetricsInfo was too cumbersome (essentially a TeX \def with
shadowing). This commit entirely replaces the latter with a better
alternative. While I am not sure
