Re: [PATCH] Allow removing words from the personal dictionary, that weren't previously added

2022-11-20 Thread Stephan Witt
Am 20.11.2022 um 12:01 schrieb Jürgen Spitzmüller : > > Am Mittwoch, dem 16.11.2022 um 07:55 +0100 schrieb Stephan Witt: >> I’ve made two patches on top of Isaacs patch to make it work again on >> Mac. >> See attached patches. 1st one is the patch from Isaac, 2nd and 3rd

Re: [PATCH] Allow removing words from the personal dictionary, that weren't previously added

2022-11-20 Thread Jürgen Spitzmüller
Am Sonntag, dem 20.11.2022 um 12:01 +0100 schrieb Jürgen Spitzmüller: > It works for me with Hunspell (note that the lists are only saved > upon > LyX closure). > > What I find odd, though, is the naming in the menu. When I click on a > word that is in the main dictionary, e.g. "table", it offers

Re: [PATCH] Allow removing words from the personal dictionary, that weren't previously added

2022-11-20 Thread Jürgen Spitzmüller
Am Mittwoch, dem 16.11.2022 um 07:55 +0100 schrieb Stephan Witt: > I’ve made two patches on top of Isaacs patch to make it work again on > Mac. > See attached patches. 1st one is the patch from Isaac, 2nd and 3rd > are mine. Thanks! > 1. There are code paths with SpellChecke

Re: New features/killqt4 branch (was: Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog)

2022-11-19 Thread Jean-Marc Lasgouttes
Le 19/11/2022 à 11:38, Jürgen Spitzmüller a écrit : Am Freitag, dem 18.11.2022 um 17:33 +0100 schrieb Jean-Marc Lasgouttes: What can you do to help? * have look at the diff in src to spot what I broke Looks good from what I can tell. Thanks for checking. * and look at KILLQT4 annotations t

Re: New features/killqt4 branch (was: Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog)

2022-11-19 Thread Jürgen Spitzmüller
Am Freitag, dem 18.11.2022 um 17:33 +0100 schrieb Jean-Marc Lasgouttes: > What can you do to help? > * have look at the diff in src to spot what I broke Looks good from what I can tell. > * and look at KILLQT4 annotations to see whethe rsome of them are in > your ballpark > * look for things to

Re: New features/killqt4 branch (was: Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog)

2022-11-18 Thread Jean-Marc Lasgouttes
Le 18/11/2022 à 18:03, Scott Kostyshak a écrit : What can you do to help? * have look at the diff in src to spot what I broke * and look at KILLQT4 annotations to see whethe rsome of them are in your ballpark * look for things to do in TODO.killqt4 I think this was meant for Jürgen, but to be c

Re: New features/killqt4 branch (was: Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog)

2022-11-18 Thread Scott Kostyshak
On Fri, Nov 18, 2022 at 05:33:43PM +0100, Jean-Marc Lasgouttes wrote: > Le 17/11/2022 à 07:34, Jürgen Spitzmüller a écrit : > > Am Mittwoch, dem 16.11.2022 um 11:11 -0500 schrieb Scott Kostyshak: > > > Does anyone object then to supporting only Qt5 for > > > 2.4.0 (and forward)? > > > > No. I thin

New features/killqt4 branch (was: Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog)

2022-11-18 Thread Jean-Marc Lasgouttes
Le 17/11/2022 à 07:34, Jürgen Spitzmüller a écrit : Am Mittwoch, dem 16.11.2022 um 11:11 -0500 schrieb Scott Kostyshak: Does anyone object then to supporting only Qt5 for 2.4.0 (and forward)? No. I think now is the time to do it. I created a new branch killqt4 that removes #ifdefs in src and

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-11-16 Thread Jürgen Spitzmüller
Am Mittwoch, dem 16.11.2022 um 11:11 -0500 schrieb Scott Kostyshak: > Does anyone object then to supporting only Qt5 for > 2.4.0 (and forward)? No. I think now is the time to do it. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-deve

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-11-16 Thread Scott Kostyshak
On Wed, Nov 16, 2022 at 06:03:04PM +0100, Jean-Marc Lasgouttes wrote: > Le 16/11/2022 à 17:57, Scott Kostyshak a écrit : > > I don't know. What do others think? Do we go all-in and drop Qt4 and do > > all the clean up now to simplify the code? That would indeed feel nice. > > > > Or do we leave it

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-11-16 Thread Jean-Marc Lasgouttes
Le 16/11/2022 à 17:57, Scott Kostyshak a écrit : I don't know. What do others think? Do we go all-in and drop Qt4 and do all the clean up now to simplify the code? That would indeed feel nice. Or do we leave it as is, and just officially not support Qt4, so that if some (from what I understand,

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-11-16 Thread Scott Kostyshak
On Wed, Nov 16, 2022 at 05:51:30PM +0100, Jean-Marc Lasgouttes wrote: > Le 16/11/2022 à 17:11, Scott Kostyshak a écrit : > > On Wed, Nov 16, 2022 at 02:37:18PM +0100, Thibaut Cuvelier wrote: > > > > > Well, if barely anyone tests with Qt 4 (I'm only using Qt 5.15), it's > > > already unsupported i

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-11-16 Thread Jean-Marc Lasgouttes
Le 16/11/2022 à 17:11, Scott Kostyshak a écrit : On Wed, Nov 16, 2022 at 02:37:18PM +0100, Thibaut Cuvelier wrote: Well, if barely anyone tests with Qt 4 (I'm only using Qt 5.15), it's already unsupported in practice and making the necessary changes would be (1) cumbersome and (2) a waste of re

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-11-16 Thread Scott Kostyshak
On Wed, Nov 16, 2022 at 02:37:18PM +0100, Thibaut Cuvelier wrote: > Well, if barely anyone tests with Qt 4 (I'm only using Qt 5.15), it's > already unsupported in practice and making the necessary changes would be > (1) cumbersome and (2) a waste of resources (little gain in supporting > versions

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-11-16 Thread Thibaut Cuvelier
On Mon, 14 Nov 2022 at 19:38, Scott Kostyshak wrote: > On Tue, Oct 18, 2022 at 10:51:34AM -0400, Scott Kostyshak wrote: > > On Tue, Oct 18, 2022 at 03:12:40PM +0200, Pavel Sanda wrote: > > > On Fri, Oct 07, 2022 at 05:05:43PM +0200, Jean-Marc Lasgouttes wrote: > > > > Still, I am wondering why we

Re: [PATCH] Allow removing words from the personal dictionary, that weren't previously added

2022-11-15 Thread Stephan Witt
Am 25.10.2022 um 09:19 schrieb Jürgen Spitzmüller : > > I'd like this nice feature not to be forgotten. > > Stephan, do you think the problems on Mac can be resolved? Could we add > the patch with Mac support disabled for the time being? > > Thanks, > Jürgen I’

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-11-14 Thread Scott Kostyshak
On Tue, Oct 18, 2022 at 10:51:34AM -0400, Scott Kostyshak wrote: > On Tue, Oct 18, 2022 at 03:12:40PM +0200, Pavel Sanda wrote: > > On Fri, Oct 07, 2022 at 05:05:43PM +0200, Jean-Marc Lasgouttes wrote: > > > Still, I am wondering why we insist on supporting Qt4 for 2.4.0 > > > (especially > > > co

Re: [PATCH] Semantic Linefeeds

2022-11-09 Thread Jean-Marc Lasgouttes
add fileformat increase & empty lyx2lyx conversion routines in case we need to do some damage control later? I'm not against a file format change, but I would guess that the code in Yuriy's patch would be tweaked after committing to master. e.g., a new punctuation symbol could be add

Re: [PATCH] Semantic Linefeeds

2022-11-08 Thread Scott Kostyshak
consequences in case we overlooked something > > > perhaps we should add fileformat increase & empty lyx2lyx conversion > > > routines > > > in case we need to do some damage control later? > > > > I'm not against a file format change, but I would

Re: [PATCH] Semantic Linefeeds

2022-11-08 Thread Pavel Sanda
add fileformat increase & empty lyx2lyx conversion > > routines > > in case we need to do some damage control later? > > I'm not against a file format change, but I would guess that the code in > Yuriy's patch would be tweaked after committing to master. e.g., a ne

Re: patch: adding alertenv (and other friends) for beamer layout

2022-11-06 Thread Scott Kostyshak
On Sun, Nov 06, 2022 at 07:33:40PM +, José Matos wrote: > On Sun, 2022-11-06 at 11:25 -0500, Scott Kostyshak wrote: > > On Sun, Nov 06, 2022 at 03:46:50PM +, José Matos wrote: > > > On Sun, 2022-11-06 at 10:20 -0500, Scott Kostyshak wrote: > > > > And also every time I come across something

Re: patch: adding alertenv (and other friends) for beamer layout

2022-11-06 Thread José Matos
On Sun, 2022-11-06 at 11:25 -0500, Scott Kostyshak wrote: > On Sun, Nov 06, 2022 at 03:46:50PM +, José Matos wrote: > > On Sun, 2022-11-06 at 10:20 -0500, Scott Kostyshak wrote: > > > And also every time I come across something like this, I wonder > > > if we > > > can generalize the process of

Re: patch: adding alertenv (and other friends) for beamer layout

2022-11-06 Thread Scott Kostyshak
On Sun, Nov 06, 2022 at 03:46:50PM +, José Matos wrote: > On Sun, 2022-11-06 at 10:20 -0500, Scott Kostyshak wrote: > > And also every time I come across something like this, I wonder if we > > can generalize the process of converting a new layout to ERT for > > older formats. i.e., I just want

Re: patch: adding alertenv (and other friends) for beamer layout

2022-11-06 Thread José Matos
On Sun, 2022-11-06 at 10:20 -0500, Scott Kostyshak wrote: > And also every time I come across something like this, I wonder if we > can generalize the process of converting a new layout to ERT for > older formats. i.e., I just want to put a one-liner with "alertenv", > and I want lyx2lyx to talk to

Re: patch: adding alertenv (and other friends) for beamer layout

2022-11-06 Thread Scott Kostyshak
On Sun, Nov 06, 2022 at 03:05:38PM +, José Matos wrote: > On Sat, 2022-11-05 at 12:49 -0400, Scott Kostyshak wrote: > > Thanks, I'll try to do the lyx2lyx stuff and fileformat for this when > > I can. > > > > Scott > > Essentially this is only relevant to reversion, right? > The conversion co

Re: patch: adding alertenv (and other friends) for beamer layout

2022-11-06 Thread José Matos
On Sat, 2022-11-05 at 12:49 -0400, Scott Kostyshak wrote: > Thanks, I'll try to do the lyx2lyx stuff and fileformat for this when > I can. > > Scott Essentially this is only relevant to reversion, right? The conversion code should be empty. Best regards, -- José Abílio -- lyx-devel mailing lis

Re: patch: adding alertenv (and other friends) for beamer layout

2022-11-05 Thread Scott Kostyshak
On Wed, Oct 26, 2022 at 07:13:30AM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 25.10.2022 um 21:15 -0400 schrieb Scott Kostyshak: > > Is this something you think I can do for 2.4.0 or should I hold off? > > I forget what the current status is. > > The problem is nobody knows that. Personal

Re: [PATCH] Semantic Linefeeds

2022-11-05 Thread Scott Kostyshak
On Fri, Nov 04, 2022 at 04:53:36PM +0100, Pavel Sanda wrote: > On Fri, Nov 04, 2022 at 10:09:24AM +0200, Yuriy Skalko wrote: > > Now the patch also contains most punctuation marks for non-European > > languages after which it is worth to put a linebreak. > > > > Is it

Re: [PATCH] Semantic Linefeeds

2022-11-05 Thread Scott Kostyshak
On Fri, Nov 04, 2022 at 10:09:24AM +0200, Yuriy Skalko wrote: > Now the patch also contains most punctuation marks for non-European > languages after which it is worth to put a linebreak. > > Is it ready to commit now? I haven't tested, but how does this work when those punctu

Re: [PATCH] Semantic Linefeeds

2022-11-04 Thread Pavel Sanda
On Fri, Nov 04, 2022 at 10:09:24AM +0200, Yuriy Skalko wrote: > Now the patch also contains most punctuation marks for non-European > languages after which it is worth to put a linebreak. > > Is it ready to commit now? I know this change "shouldn't" matter when it

Re: [PATCH] Allow removing words from the personal dictionary, that weren't previously added

2022-11-04 Thread Stephan Witt
Am 25.10.2022 um 09:19 schrieb Jürgen Spitzmüller : > > I'd like this nice feature not to be forgotten. > > Stephan, do you think the problems on Mac can be resolved? Could we add > the patch with Mac support disabled for the time being? I’ll review the patch again and pos

[PATCH] Semantic Linefeeds

2022-11-04 Thread Yuriy Skalko
Now the patch also contains most punctuation marks for non-European languages after which it is worth to put a linebreak. Is it ready to commit now? Yuriy diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp index 4ce94415f7..7b3d5bd4f7 100644 --- a/src/Paragraph.cpp +++ b/src/Paragraph.cpp

[PATCH] Semantic Linefeeds

2022-11-03 Thread Yuriy Skalko
Here is an updated patch with Chinese punctuation marks. Also now linebreak is added after em-dash even without next space (for English). Yuriy diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp index 4ce94415f7..7156d442bf 100644 --- a/src/Paragraph.cpp +++ b/src/Paragraph.cpp @@ -1746,16

Re: patch: adding alertenv (and other friends) for beamer layout

2022-10-25 Thread Jürgen Spitzmüller
Am Dienstag, dem 25.10.2022 um 21:15 -0400 schrieb Scott Kostyshak: > Is this something you think I can do for 2.4.0 or should I hold off? > I forget what the current status is. The problem is nobody knows that. Personally I am trying to hold back all new features. I do not find adding a few style

Re: patch: adding alertenv (and other friends) for beamer layout

2022-10-25 Thread Scott Kostyshak
. > > > > Attached is an example patch. > > Sure. I think beamer has now quite a number we don't cover yet. > > Don't forget the lyx2lyx stuff and format change. I indeed (embarrassingly) forgot about those. Thanks for the reminder. Is this something you think

Re: [PATCH] Allow removing words from the personal dictionary, that weren't previously added

2022-10-25 Thread Jürgen Spitzmüller
I'd like this nice feature not to be forgotten. Stephan, do you think the problems on Mac can be resolved? Could we add the patch with Mac support disabled for the time being? Thanks, Jürgen Am Montag, dem 30.05.2022 um 06:39 + schrieb Isaac Oscar Gariano: > Dear Stephen, > So

Re: patch: adding alertenv (and other friends) for beamer layout

2022-10-24 Thread Jürgen Spitzmüller
Am Sonntag, dem 23.10.2022 um 12:03 -0400 schrieb Scott Kostyshak: > Can I add a layout for alertenv? And similarly, for other envs (I > haven't checked yet which other ones we don't cover yet). > > Attached is an example patch. Sure. I think beamer has now quite a num

patch: adding alertenv (and other friends) for beamer layout

2022-10-23 Thread Scott Kostyshak
Can I add a layout for alertenv? And similarly, for other envs (I haven't checked yet which other ones we don't cover yet). Attached is an example patch. Scott From c4440edbcc2d908a6b257245362dae4ce83a0f45 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Sun, 23 Oct 2022 11:5

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-18 Thread Pavel Sanda
On Tue, Oct 18, 2022 at 06:27:00PM +0200, Jean-Marc Lasgouttes wrote: > >That was decided when we planned to release 2.4 at the end of 2019. > >It's clear we won't be able to push 2.4 even for next debian stable > >and I think we can relax Qt4 support and move on. > > What do you mean by "relax" ?

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-18 Thread Jean-Marc Lasgouttes
Le 18/10/2022 à 15:12, Pavel Sanda a écrit : On Fri, Oct 07, 2022 at 05:05:43PM +0200, Jean-Marc Lasgouttes wrote: Still, I am wondering why we insist on supporting Qt4 for 2.4.0 (especially considering that we will have to continue this game for 2+ years after that). That was decided when we

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-18 Thread Scott Kostyshak
On Tue, Oct 18, 2022 at 03:12:40PM +0200, Pavel Sanda wrote: > On Fri, Oct 07, 2022 at 05:05:43PM +0200, Jean-Marc Lasgouttes wrote: > > Still, I am wondering why we insist on supporting Qt4 for 2.4.0 (especially > > considering that we will have to continue this game for 2+ years after > > that).

Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-18 Thread Pavel Sanda
On Fri, Oct 07, 2022 at 05:05:43PM +0200, Jean-Marc Lasgouttes wrote: > Still, I am wondering why we insist on supporting Qt4 for 2.4.0 (especially > considering that we will have to continue this game for 2+ years after > that). That was decided when we planned to release 2.4 at the end of 2019.

[Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-07 Thread Yuriy Skalko
Still, I am wondering why we insist on supporting Qt4 for 2.4.0 (especially considering that we will have to continue this game for 2+ years after that). I join to your wondering. And here is the patch to at least clean conditional code portions for Qt < 4.8. Yuriy F

Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-07 Thread Yuriy Skalko
You can use branchCO->itemData(branchCO->currentIndex()).toString() This works in Qt 4 and upwards. Thanks, Jürgen! This way even dedicated Qt4 users will be able to enjoy this update :) Committed. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listin

Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-07 Thread Jürgen Spitzmüller
Am Freitag, dem 07.10.2022 um 18:02 +0300 schrieb Yuriy Skalko: > Now with "(master)" suffix in combobox labels we cannot use them > directly as branch names. Is is OK to disable this for Qt4 > alltogether, > as README says that LyX is only compilable on Qt4? You can use branchCO->itemData(bran

[Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-07 Thread Jean-Marc Lasgouttes
Le 07/10/2022 à 17:02, Yuriy Skalko a écrit : Now with "(master)" suffix in combobox labels we cannot use them directly as branch names. Is is OK to disable this for Qt4 alltogether, as README says that LyX is only compilable on Qt4? This seems like an acceptable solution, if the code is simpl

[PATCH] Show branches from master document in branch inset dialog

2022-10-07 Thread Yuriy Skalko
> toqstr(bformat( _("%1$s[[branch]] (%2$s)[[master]]"), >toqstr(branch), qt_("master"; > > since with RTL scripts your precomposed string will be wrong I think. > > -- > Jürgen Thanks for the suggestion, I've updated the pa

Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-07 Thread Jean-Marc Lasgouttes
Le 06/10/2022 à 19:39, Yuriy Skalko a écrit : Hello all, Currently in LyX you can insert into child documents the insets for branches defined in master document only. But it is impossible to change the branch afterwards for such inset because master branches are not shown in the "Branch Setti

Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-07 Thread Jürgen Spitzmüller
Am Freitag, dem 07.10.2022 um 09:43 +0200 schrieb Jürgen Spitzmüller: > branchCO->addItem( > toqstr(bformat( _("%1$s[[branch]] > (%2$s)[[master]]"), >    toqstr(branch), qt_("master"; that should be _("master") of course. -- Jürgen signature.asc Description: This is a digit

Re: [PATCH] Show branches from master document in branch inset dialog

2022-10-07 Thread Jürgen Spitzmüller
aster branches are not > shown in the "Branch Settings" dialog. > > The attached patch fixes this. Looks good. One nitpick: + if (!branchlist.find(branch)) { + branchCO->addItem(toqstr(branch + _(" (master)")

[PATCH] Show branches from master document in branch inset dialog

2022-10-06 Thread Yuriy Skalko
Hello all, Currently in LyX you can insert into child documents the insets for branches defined in master document only. But it is impossible to change the branch afterwards for such inset because master branches are not shown in the "Branch Settings" dialog. The attached patch

Re: [RFC][PATCH] Improved synctex support

2022-09-14 Thread Stephan Witt
Am 14.09.2022 um 20:17 schrieb Enrico Forestieri : > > On Sun, Aug 14, 2022 at 11:44:52PM +0200, Enrico Forestieri wrote: >> >> Only a suggestion: I would simply check for "-synctex=" rather than >> "--synctex=1" because the double dash is optional and any value >> different from 0 would do (I don'

Re: [RFC][PATCH] Improved synctex support

2022-09-14 Thread Enrico Forestieri
On Sun, Aug 14, 2022 at 11:44:52PM +0200, Enrico Forestieri wrote: > > Only a suggestion: I would simply check for "-synctex=" rather than > "--synctex=1" because the double dash is optional and any value > different from 0 would do (I don't think someone would specify it). I did that at 90551a03

Re: [PATCH] "Here Applies" module

2022-08-30 Thread madmurphy
, Jürgen Spitzmüller wrote: > > Am Freitag, dem 26.08.2022 um 01:05 +0100 schrieb madmurphy: > > > Any updates on this? In the meanwhile I have update the module. > > > Please find the updated version of the patch attached. > > > > Sorry for keeping you waiting.

Re: [PATCH] "Here Applies" module

2022-08-30 Thread Pavel Sanda
On Tue, Aug 30, 2022 at 09:30:44AM +0200, Jürgen Spitzmüller wrote: > Am Freitag, dem 26.08.2022 um 01:05 +0100 schrieb madmurphy: > > Any updates on this? In the meanwhile I have update the module. > > Please find the updated version of the patch attached. > > Sorry for keep

Re: [PATCH] "Here Applies" module

2022-08-30 Thread Jürgen Spitzmüller
Am Freitag, dem 26.08.2022 um 01:05 +0100 schrieb madmurphy: > Any updates on this? In the meanwhile I have update the module. > Please find the updated version of the patch attached. Sorry for keeping you waiting. Most people are currently on holidays or otherwise busy. I don't kn

Re: [PATCH] "Here Applies" module

2022-08-25 Thread madmurphy
Any updates on this? In the meanwhile I have update the module. Please find the updated version of the patch attached. --madmurphy On Wed, Aug 17, 2022 at 12:58 AM madmurphy wrote: > Hi, > > I am the author of the *Here Applies* LaTeX package > <https://www.ctan.org/pkg/herea

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Pavel Sanda
nal notes collected few weeks back when I was looking into the issue. 1) On the trigger. The nice part of Daniel's patch was that it did not trigger statistics recount at *every* cursor action, most importantly the update did not happen when you start moving with cursor (and hold) but o

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Jürgen Spitzmüller
Am Freitag, dem 19.08.2022 um 07:06 +0200 schrieb Jürgen Spitzmüller: > The crash is fixed in the attached patch, which works well for me. I have still crashes (when pasting). I don't have time to work on it further for the time being, so I put it on hold. -- Jürgen signature.asc Des

Re: [patch] Selection stats in statusbar[RESOLVED]

2022-08-19 Thread Kornel Benko
Am Fri, 19 Aug 2022 10:47:06 +0200 schrieb Kornel Benko : > Am Fri, 19 Aug 2022 10:44:23 +0200 > schrieb Kornel Benko : > > > Am Fri, 19 Aug 2022 10:16:43 +0200 > > schrieb "Jürgen Spitzmüller" : > > > > > Am Freitag, dem 19.08.2022 um 10:07 +0200 schrieb Kornel Benko: > > > > Both.

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Kornel Benko
Am Fri, 19 Aug 2022 10:44:23 +0200 schrieb Kornel Benko : > Am Fri, 19 Aug 2022 10:16:43 +0200 > schrieb "Jürgen Spitzmüller" : > > > Am Freitag, dem 19.08.2022 um 10:07 +0200 schrieb Kornel Benko: > > > Both. > > > > Interesting. I'd need a recipe for the latter. > > > > Nothing speci

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Kornel Benko
Am Fri, 19 Aug 2022 10:16:43 +0200 schrieb "Jürgen Spitzmüller" : > Am Freitag, dem 19.08.2022 um 10:07 +0200 schrieb Kornel Benko: > > Both. > > Interesting. I'd need a recipe for the latter. > Nothing specific. Does not matter what or how I select some parts, the number of spaces is wrong (

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Jürgen Spitzmüller
Am Freitag, dem 19.08.2022 um 10:07 +0200 schrieb Kornel Benko: > Both. Interesting. I'd need a recipe for the latter. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Kornel Benko
Am Fri, 19 Aug 2022 09:59:45 +0200 schrieb "Jürgen Spitzmüller" : > Am Freitag, dem 19.08.2022 um 09:54 +0200 schrieb Kornel Benko: > > I seen it in the status bar. Dialog shows OK. > > And only of you select whole words (e.g. via double click)? Or also if > you select manually? > Both.

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Jürgen Spitzmüller
Am Freitag, dem 19.08.2022 um 09:54 +0200 schrieb Kornel Benko: > I seen it in the status bar. Dialog shows OK. And only of you select whole words (e.g. via double click)? Or also if you select manually? -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Kornel Benko
Am Fri, 19 Aug 2022 09:34:29 +0200 schrieb "Jürgen Spitzmüller" : > Am Freitag, dem 19.08.2022 um 08:42 +0200 schrieb Kornel Benko: > > There is something not correct with showing number of spaces in > > Chinese docs. > > > > 1.) Open zh_CN/Tutorial.lyx > > 2.) Select a single word e.g. 参考文献和交叉引用

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Jürgen Spitzmüller
Am Freitag, dem 19.08.2022 um 08:42 +0200 schrieb Kornel Benko: > There is something not correct with showing number of spaces in > Chinese docs. > > 1.) Open zh_CN/Tutorial.lyx > 2.) Select a single word e.g. 参考文献和交叉引用有点像 >     => you get >    number of words1 >    number of char 

Re: [patch] Selection stats in statusbar

2022-08-19 Thread Kornel Benko
f interesting bugs... It would be better > > > if we could avoid them > > > > The UX difference to the timer approach is huge. The threaded > > calculation feels smooth and is almost instant. > > > > The crash is fixed in the attached patch, which works well f

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Kornel Benko
ifference to the timer approach is huge. The threaded > calculation feels smooth and is almost instant. > > The crash is fixed in the attached patch, which works well for me. > There is something not correct with showing number of spaces in Chinese docs. 1.) Open zh_CN/Tutorial.

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
ash is fixed in the attached patch, which works well for me. -- Jürgen diff --git a/src/Buffer.cpp b/src/Buffer.cpp index da630da90a..88f21ced0e 100644 --- a/src/Buffer.cpp +++ b/src/Buffer.cpp @@ -4223,6 +4223,13 @@ void Buffer::structureChanged() const } +void Buffer::updateStats(bool th

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jean-Marc Lasgouttes
Indeed, threads create lots of interesting bugs... It would be better if we could avoid them JMarc Le 18 août 2022 18:13:38 GMT+02:00, "Jürgen Spitzmüller" a écrit  >Performance is an issue in larger documents (e.g., UserGuide). > >This one, using threads, is snappy and seems to update relia

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 11:42 +0200 schrieb Jürgen Spitzmüller: > The attached seems to work basically. But I haven't check for all > cases (I am dure there are cases I missed) and didn't push hard for > performance (currently the timer is commented out; if this is too > expensive, process

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jean-Marc Lasgouttes
Le 18 août 2022 14:25:28 GMT+02:00, "Jürgen Spitzmüller" a écrit : >> My method: statistics update only when idle for a long enough time >> and only once, hence, cannot interfere with continuous typing and are >> very unlikely to interfere at all. > >And it updated after that timing whether it

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Daniel
On 18/08/2022 14:25, Jürgen Spitzmüller wrote: Am Donnerstag, dem 18.08.2022 um 14:08 +0200 schrieb Daniel: No function exits early on that approach. The function does not get called in the first place. I think it is really better. Currently: statistics update continuously and, hence, can inter

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 14:08 +0200 schrieb Daniel: > No function exits early on that approach. The function does not get > called in the first place. I think it is really better. > > Currently: statistics update continuously and, hence, can interfere > with continuous typing. Which is

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Daniel
On 18/08/2022 11:44, Jürgen Spitzmüller wrote: Am Donnerstag, dem 18.08.2022 um 11:31 +0200 schrieb Daniel: This shouldn't be an issue. The idea is that statistics are only generated after some time has passed without interruption. They are not shown immediately. Hence, continuous arrow key move

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Scott Kostyshak
On Thu, Aug 18, 2022 at 11:44:49AM +0200, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 18.08.2022 um 11:31 +0200 schrieb Daniel: > > This shouldn't be an issue. The idea is that statistics are only > > generated after some time has passed without interruption. They are > > not > > shown immedia

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 11:31 +0200 schrieb Daniel: > This shouldn't be an issue. The idea is that statistics are only > generated after some time has passed without interruption. They are > not > shown immediately. Hence, continuous arrow key movement would not > trigger statistics at

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 09:55 +0200 schrieb Jürgen Spitzmüller: > You need a more suitable signal that only emits when text is edited > or loaded. The attached seems to work basically. But I haven't check for all cases (I am dure there are cases I missed) and didn't push hard for performa

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Daniel
On 18/08/2022 09:55, Jürgen Spitzmüller wrote: Am Mittwoch, dem 17.08.2022 um 19:40 +0200 schrieb Daniel: What I did in https://www.lyx.org/trac/attachment/ticket/12422/0001-Show-word-count-in-status-bar.patch was just to hook it on GuiView::showMessage() because this would be updated in all c

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Mittwoch, dem 17.08.2022 um 19:40 +0200 schrieb Daniel: > What I did in > > https://www.lyx.org/trac/attachment/ticket/12422/0001-Show-word-count-in-status-bar.patch > > was just to hook it on GuiView::showMessage() because this would be > updated in all cases where text stuff changes.  show

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Daniel
figured this out in my patch but maybe not. (Or that is a part where you where wondering why it was as it was.) I agree this would be much better. Also, async calculation (via QFuture) would probably help with managing the calculation processes and mitigate delays. What is not so easy, I think, is to

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Jürgen Spitzmüller
ought that I had figured this out in my > patch > but maybe not. (Or that is a part where you where wondering why it > was > as it was.) I agree this would be much better. Also, async calculation (via QFuture) would probably help with managing the calculation processes and mitigate d

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Daniel
better then the current one. However, as it is now, the word count gets updated sometimes while continuously typing. I thought that I had figured this out in my patch but maybe not. (Or that is a part where you where wondering why it was as it was.) Yes, your patch didn't make it clear i

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Jürgen Spitzmüller
Am Mittwoch, dem 17.08.2022 um 14:21 +0200 schrieb Pavel Sanda: > I am travelling now, so please do as you see fit, I trust your UI > eye. Thanks, done. Have a good trip. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Pavel Sanda
On Wed, Aug 17, 2022 at 11:00:39AM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 16.08.2022 um 12:44 +0200 schrieb Jürgen Spitzmüller: > > I've seen now that you flagged it for localization. But this is still > > to anglocentric. Use bformat to construct the string. BTW there is > > also > >

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Kornel Benko
Am Wed, 17 Aug 2022 12:39:01 +0200 schrieb "Jürgen Spitzmüller" : > Am Mittwoch, dem 17.08.2022 um 12:35 +0200 schrieb Daniel: > > 1 slovo > > Počet slov: 2... (Wordcount: 2... if I understood correctly) > > This could be done on po-level if desired. No code change needed. It is that way in my

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Kornel Benko
Am Wed, 17 Aug 2022 12:35:05 +0200 schrieb Daniel : > On 17/08/2022 12:01, Jürgen Spitzmüller wrote: > > Am Mittwoch, dem 17.08.2022 um 11:56 +0200 schrieb Jürgen Spitzmüller: > >> If the number of inter-language variations is limited, this can be > >> supported as well. > > > > OTOH the prob

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Jürgen Spitzmüller
Am Mittwoch, dem 17.08.2022 um 12:35 +0200 schrieb Daniel: > 1 slovo > Počet slov: 2... (Wordcount: 2... if I understood correctly) This could be done on po-level if desired. No code change needed. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel maili

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Daniel
On 17/08/2022 12:01, Jürgen Spitzmüller wrote: Am Mittwoch, dem 17.08.2022 um 11:56 +0200 schrieb Jürgen Spitzmüller: If the number of inter-language variations is limited, this can be supported as well. OTOH the problem is also unsolved in the existing statistics dialog. Word uses 1 slovo

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Daniel
On 17/08/2022 11:57, Jürgen Spitzmüller wrote: Am Mittwoch, dem 17.08.2022 um 11:28 +0200 schrieb Daniel: If the usage of QStringList is fine, it can also be written a bit more concise as. Sure. Though it doesn't buy much. I guess one should choose (even slightly) less complex code whenever

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Jürgen Spitzmüller
Am Mittwoch, dem 17.08.2022 um 11:56 +0200 schrieb Jürgen Spitzmüller: > If the number of inter-language variations is limited, this can be > supported as well. OTOH the problem is also unsolved in the existing statistics dialog. -- Jürgen signature.asc Description: This is a digitally signed

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Jürgen Spitzmüller
Am Mittwoch, dem 17.08.2022 um 11:28 +0200 schrieb Daniel: > If the usage of QStringList is fine, it can also be written a bit > more concise as.  Sure. Though it doesn't buy much. > Also, chars_with_blanks should probably be inside the > second "if statement" No, this is re-used further below.

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Jürgen Spitzmüller
Am Mittwoch, dem 17.08.2022 um 11:41 +0200 schrieb Kornel Benko: > What about languages with different plurals. > > In Slovak for example it would be > 1 slovo > 2..4 slová > 5..\infty slov If the number of inter-language variations is limited, this can be supported as well. -- Jürgen signatu

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Kornel Benko
hat users seldom need all three stats values. The value they need > >> might depend on the editorial instructions they get. These might rely > >> on either of the three. So give the user the choice to see what they > >> need. > > > > Updated patch which accounts

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Daniel
they need. Updated patch which accounts for the proper number (1 Word, 2 Words). If the usage of QStringList is fine, it can also be written a bit more concise as. Also, chars_with_blanks should probably be inside the second "if statement": QStringList stats; if (word_count_enabled_)

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Jürgen Spitzmüller
ord) > > The rationale besides the accessibility argument is that I'd figure > that users seldom need all three stats values. The value they need > might depend on the editorial instructions they get. These might rely > on either of the three. So give the user the choice to

Re: [patch] Selection stats in statusbar

2022-08-17 Thread Jürgen Spitzmüller
Am Dienstag, dem 16.08.2022 um 12:44 +0200 schrieb Jürgen Spitzmüller: > I've seen now that you flagged it for localization. But this is still > to anglocentric. Use bformat to construct the string. BTW there is > also > a qt_() function, no need for toqstr(_()). > > My point that one-letter abbre

[PATCH] "Here Applies" module

2022-08-16 Thread madmurphy
lies/lyx-module>. Please find attached a patch for shipping it with LyX. All the best --madmurphy <> -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [patch] Selection stats in statusbar

2022-08-16 Thread Jürgen Spitzmüller
Am Dienstag, dem 16.08.2022 um 12:12 +0200 schrieb Jürgen Spitzmüller: > It's horrible, really. You need not only to spell it out, but also > localize it. I've seen now that you flagged it for localization. But this is still to anglocentric. Use bformat to construct the string. BTW there is also a

<    1   2   3   4   5   6   7   8   9   10   >