[EMAIL PROTECTED] writes:
Author: lasgouttes
Date: Wed Sep 17 18:28:33 2008
New Revision: 26432
URL: http://www.lyx.org/trac/changeset/26432
Log:
Fix bug 2746: http://bugzilla.lyx.org/show_bug.cgi?id=2746
References autoupdate is not undone during UNDO operation
* InsetLabel.cpp
Jean-Marc Lasgouttes wrote:
Juergen, concerning this one, we could
a) do nothing in 1.5.7
b) do a recordUndoFullDocument that will properly fix the behaviour at
the cost of risking blots after repetitive use (like we do in replace
all)
c) do separate recordUndo calls that will be undone one
Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Hm. Since I don't like b) and c) looks like much work, I think we
could live with a.)
OK.
JMarc
[EMAIL PROTECTED] writes:
> Author: lasgouttes
> Date: Wed Sep 17 18:28:33 2008
> New Revision: 26432
>
> URL: http://www.lyx.org/trac/changeset/26432
> Log:
> Fix bug 2746: http://bugzilla.lyx.org/show_bug.cgi?id=2746
> References autoupdate is not undone during UNDO operation
>
> *
Jean-Marc Lasgouttes wrote:
> Juergen, concerning this one, we could
>
> a) do nothing in 1.5.7
> b) do a recordUndoFullDocument that will properly fix the behaviour at
> the cost of risking blots after repetitive use (like we do in replace
> all)
> c) do separate recordUndo calls that will be
Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
> Hm. Since I don't like b) and c) looks like much work, I think we
> could live with a.)
OK.
JMarc
[EMAIL PROTECTED] wrote:
Author: lasgouttes
Date: Wed Sep 17 18:28:33 2008
New Revision: 26432
URL: http://www.lyx.org/trac/changeset/26432
Log:
Fix bug 2746: http://bugzilla.lyx.org/show_bug.cgi?id=2746
References autoupdate is not undone during UNDO operation
* InsetLabel.cpp
* InsetLabel.cpp (updateCommand): record undo for each of the label
changes (and put everything in a group to make sure it will be
undone
in one step).
That's very nice.
Thanks :) Are you aware of other places where this would be needed?
What I have to do now is look at
Jean-Marc Lasgouttes wrote:
* InsetLabel.cpp (updateCommand): record undo for each of the label
changes (and put everything in a group to make sure it will be
undone
in one step).
That's very nice.
Thanks :) Are you aware of other places where this would be needed?
I'll try
What I have to do now is look at each of the
recordUndoFullDocument and kill them.
We need a recordUndoDocumentParams instead.
Yes, that would be nice. Backing up the whole document whenever the
_view_ of a document changes (counter, etc) is not very clever :-)
Where do we do that? I am
Jean-Marc Lasgouttes wrote:
What I have to do now is look at each of the recordUndoFullDocument
and kill them.
We need a recordUndoDocumentParams instead.
Yes, that would be nice. Backing up the whole document whenever the
_view_ of a document changes (counter, etc) is not very clever :-)
Le 17 sept. 08 à 22:44, Abdelrazak Younes a écrit :
IIUC, whenever BufferParams is changed after touching the Document
Settings, the whole document contents is saved because
recordUndoFullDocument() is called, isn't it?
Yes, it is one of the points I want to look at. I thought you were
[EMAIL PROTECTED] wrote:
Author: lasgouttes
Date: Wed Sep 17 18:28:33 2008
New Revision: 26432
URL: http://www.lyx.org/trac/changeset/26432
Log:
Fix bug 2746: http://bugzilla.lyx.org/show_bug.cgi?id=2746
References autoupdate is not undone during UNDO operation
* InsetLabel.cpp
* InsetLabel.cpp (updateCommand): record undo for each of the label
changes (and put everything in a group to make sure it will be
undone
in one step).
That's very nice.
Thanks :) Are you aware of other places where this would be needed?
What I have to do now is look at
Jean-Marc Lasgouttes wrote:
* InsetLabel.cpp (updateCommand): record undo for each of the label
changes (and put everything in a group to make sure it will be
undone
in one step).
That's very nice.
Thanks :) Are you aware of other places where this would be needed?
I'll try
What I have to do now is look at each of the
recordUndoFullDocument and kill them.
We need a recordUndoDocumentParams instead.
Yes, that would be nice. Backing up the whole document whenever the
_view_ of a document changes (counter, etc) is not very clever :-)
Where do we do that? I am
Jean-Marc Lasgouttes wrote:
What I have to do now is look at each of the recordUndoFullDocument
and kill them.
We need a recordUndoDocumentParams instead.
Yes, that would be nice. Backing up the whole document whenever the
_view_ of a document changes (counter, etc) is not very clever :-)
Le 17 sept. 08 à 22:44, Abdelrazak Younes a écrit :
IIUC, whenever BufferParams is changed after touching the Document
Settings, the whole document contents is saved because
recordUndoFullDocument() is called, isn't it?
Yes, it is one of the points I want to look at. I thought you were
18 matches
Mail list logo
