Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-29 Thread Jürgen Spitzmüller
Andre Poenitz wrote: > > As I stated several times, if we do this, we will have to adapt many many > > strings of the current UI which would infringe such a convention. > > That reason is different from the "HIG" one, isn't it? Yes, but it's related. The general argument is that I'd like to have

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-29 Thread Andre Poenitz
On Mon, Jun 29, 2009 at 08:16:26AM +0200, Jürgen Spitzmüller wrote: > Andre Poenitz wrote: > > I do not completely disagree, but the environment is called "align", not > > "Align". I would consider this as some kind of opposite of a "proper > > noun" that's not subject to changes by capitalization.

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-28 Thread Jürgen Spitzmüller
Andre Poenitz wrote: > I do not completely disagree, but the environment is called "align", not > "Align". I would consider this as some kind of opposite of a "proper > noun" that's not subject to changes by capitalization. As I stated several times, if we do this, we will have to adapt many many

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-28 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > If it was done consistently. But it isn't. > > but the solution is not to smash the correct ones. considering > that tex is case sensitive and case sensitivity comes in play > eg \huge vs \Huge, making such capitalization in menu tends to > confuse things. Do you really thin

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-28 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > having latex keywords in > > menu verbatim-like is constinent just from another angle. > > If it was done consistently. But it isn't. but the solution is not to smash the correct ones. considering that tex is case sensitive and case sensitivity c

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-28 Thread Andre Poenitz
On Sat, Jun 27, 2009 at 07:13:32AM +0200, Jürgen Spitzmüller wrote: > And not only that. > > After re-consulting a HIG (the Gnome HIG since KDE's is inaccessible ATM, but > they should be identical in this regard), I came up with the following > changes. > > Objections? > > Jürgen > Index: li

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-28 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > having latex keywords in > menu verbatim-like is constinent just from another angle. If it was done consistently. But it isn't. Jürgen

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-28 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > You "feel", but the Inteface Design Standards state otherwise. I do not say > that your feeling counts less than the Standards, but I think it would make > more sense to do what most apps do. hig shouldn't be applied blindly as a rule and having latex keywords in menu

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-28 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > Anyway, we can as well decide to follow the Windows User Experience > Interaction Guidelines. As long as we follow any Standard. BTW even though the Windows User Experience Interaction Guidelines recommend sentence-style for Menus, they also point out that one should r

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-28 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > well, i feel that the layout combo is a different thing, but i'm not going > to flame for this. You "feel", but the Inteface Design Standards state otherwise. I do not say that your feeling counts less than the Standards, but I think it would make more sense to do what most

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-28 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > I don't think we should setup our own rules, but do what most other > > applications do. Since the rules are surprisingly coherent in the HIGs I > > consulted, so I do not see a reason why we should diverge from that. > > Fine. However, I would take them as guidelines r

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-27 Thread Enrico Forestieri
On Sat, Jun 27, 2009 at 05:28:53PM +0200, Jürgen Spitzmüller wrote: > I don't think we should setup our own rules, but do what most other > applications do. Since the rules are surprisingly coherent in the HIGs I > consulted, so I do not see a reason why we should diverge from that. Fine. Howev

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-27 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > i agree here with Enrico. adhering to latex keywords has nothing to do with > > 'our diverging aesthetical preferences' but are rather good hint for latex > > self-education when working with lyx. > > My aim is coherence. If you opt for lowcasing

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-27 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > i agree here with Enrico. adhering to latex keywords has nothing to do with > 'our diverging aesthetical preferences' but are rather good hint for latex > self-education when working with lyx. My aim is coherence. If you opt for lowcasing these expressions, you will also hav

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-27 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > > Menu "ams_environment" > > > - Item "AMS align Environment|a" "math-mutate align" > > > - Item "AMS alignat Environment|t" "math-mutate alignat" > > > - Item "AMS flalign Environment|f" "math-mutate flalign" > > >

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-27 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > Menu "ams_environment" > > - Item "AMS align Environment|a" "math-mutate align" > > - Item "AMS alignat Environment|t" "math-mutate alignat" > > - Item "AMS flalign Environment|f" "math-mutate flalign" > > - Item "AMS gather E

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-27 Thread Enrico Forestieri
On Sat, Jun 27, 2009 at 07:13:32AM +0200, Jürgen Spitzmüller wrote: > After re-consulting a HIG (the Gnome HIG since KDE's is inaccessible ATM, but > they should be identical in this regard), I came up with the following > changes. > > Objections? [...] > Menu "ams_environment" > -

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > Vincent van Ravesteijn wrote: > > Shouldn't it be "Number Whole Formula|N" and "Number This Line", as I > > read that the casing should be unified ? > > Yes. The stdcontext file is not very coherent in style. And not only that. After re-consulting a HIG (the Gnome HIG

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > Shouldn't it be "Number Whole Formula|N" and "Number This Line", as I > read that the casing should be unified ? Yes. The stdcontext file is not very coherent in style. I'll fix that. Jürgen

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Vincent van Ravesteijn
Jürgen Spitzmüller schreef: Jürgen Spitzmüller wrote: Since the checkbox was already there, I just changed the string. As far as branch is concerned, we have some more occurrences. See attached patch. Before I commit: is this part OK or did the semantics of math-number- toggle change

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Vincent van Ravesteijn
Also, I'm not sure I understood this feature, but wouldn't a string such as "Lock File in Repository" be more adequate? I do not like the verb "toggle" in the UI context. Also, I would use a menu checkbox (FuncFlags::setOnOff) that is checked if the file is locked. Then you'd have three states

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > i meant enabled_on/enabled_off/disable. and i saw meanwhile it works... > hope you are more happy now ;) Yes. Thanks. Jürgen

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > >+string LyXVC::lockingToggle() > >+{ > >+ LYXERR(Debug::LYXVC, "LyXVC: toggle locking property"); > >+ return vcs->lockingToggle(); > > Here, you don't need to check if vcs is valid, i.e. > > return vcs && vcs->lockingToggle(); > > as in lockingTogg

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > This kind of grepping is irrelevant. The question here is about menus. > > > > i didnt get you talk only about menus. is there any way how to make > > toolbar icon tristate? > > What do you mean by "tristate"? Toolbar buttons also have the onOff

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > This kind of grepping is irrelevant. The question here is about menus. > > i didnt get you talk only about menus. is there any way how to make > toolbar icon tristate? What do you mean by "tristate"? Toolbar buttons also have the onOff and enabled/disabled facility. Jürgen

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > So you mean "Use Locking Property" ? yes. > >>I do not like the verb "toggle" in > >> the UI context. > > > > Feel free to suggest better naming. We use it anyway in different UIs > > $ cat cs.po|grep -i toggle|grep -v ^#|wc -l > > 16 > > This kind of grepping is

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > As far as branch is concerned, we have some more occurrences. See attached > patch. Before I commit: is this part OK or did the semantics of > math-number- toggle change in trunk? > > - OptItem "Toggle Labeling/Numbering|T" "math-number-toggle" > +

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > Since the checkbox was already there, I just changed the string. As far as branch is concerned, we have some more occurrences. See attached patch. Before I commit: is this part OK or did the semantics of math-number- toggle change in trunk? - OptItem "To

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > > Of these, only the last one is interesting, since we do not change > > classic.ui anymore (although we may want to make them in line with > > default?) > > > > This last one should changed to "Show Label", > > Indeed. Since the checkbox was already there, I just chang

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > #: lib/ui/stdcontext.inc:133 > msgid "Toggle Label|L" > -- > > Of these, only the last one is interesting, since we do not change > classic.ui anymore (although we may want to make them in line with > default?) > > This last one should changed to "Show Label", Indeed.

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > you can recognize locking state enabled by title and vc toolbar > once you commited it. So why don't you use that information to set flag.setOnOff and rename the menu entry to "Use Locking Property"? Menu items should be self-explanatory, without the need to memorize actions

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Pavel Sanda
Pavel Sanda wrote: > i was wrong that we do not use automatical check of properties once we are > under svn control -- we use it... which leads me to the idea how to add revision info into bufferparams in the current state of things :) pavel

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: >> Also, I'm not sure I understood this feature, but wouldn't a string such as >> "Lock File in Repository" be more adequate? > > No, because it doesn't lock anything. Locking is done by svn when > updating/commiting and this command just tells svn that it should use > this lo

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Pavel Sanda
Pavel Sanda wrote: > > But if it's a toggle, how is the user supposed to see whether s/he toggles > > the > > locking mechanism on or off? > > its very similar to register function. if you used it you have to remember > until > you commit it. once you commit it, it can be recognized by the stat

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > >+ OptItem "Toggle locking property|T" "vc-locking-toggle" > > > > > > Please unify the casing, i.e. "Toggle Locking Property|T" > > > > will fix it > > > > > Also, I'm not sure I understood this feature, but wouldn't a string such

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > >+ OptItem "Toggle locking property|T" "vc-locking-toggle" > > > > Please unify the casing, i.e. "Toggle Locking Property|T" > > will fix it > > > Also, I'm not sure I understood this feature, but wouldn't a string such > > as "Lock File in Repository" be more a

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > Juergen, i would like to have this in branch too. pavel > > OK, but I have some minor question and comments on the changes: > > >Modified: lyx-devel/trunk/lib/ui/stdmenus.inc > >

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-26 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > Juergen, i would like to have this in branch too. pavel OK, but I have some minor question and comments on the changes: >Modified: lyx-devel/trunk/lib/ui/stdmenus.inc > >== --- lyx-devel/trunk/lib/ui/

Re: r30255 - in lyx-devel/trunk: lib/doc lib/images lib/ui src

2009-06-25 Thread Pavel Sanda
sa...@lyx.org wrote: > Author: sanda > Date: Thu Jun 25 16:48:11 2009 > New Revision: 30255 > URL: http://www.lyx.org/trac/changeset/30255 > > Log: > Guify setting of svn locking property Juergen, i would like to have this in branch too. pavel