Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Vincent van Ravesteijn
rgheck schreef: On 08/15/2009 09:30 AM, Pavel Sanda wrote: We agreed on the list that we better wanted to make sure that hidden buffers were not dirty. i would be more happy if the condition instead of "hidden buffers were not dirty" was "buffers hidden _in all windows_ were not dirt

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread rgheck
On 08/15/2009 09:30 AM, Pavel Sanda wrote: We agreed on the list that we better wanted to make sure that hidden buffers were not dirty. i would be more happy if the condition instead of "hidden buffers were not dirty" was "buffers hidden _in all windows_ were not dirty." I think th

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Vincent van Ravesteijn
Pavel Sanda schreef: Vincent van Ravesteijn wrote: to sum up: 1. new file1,new file2 2. write some text in file 2 3. new window,open both files 1,2 4. try to hide file 2 -> impossible without saving (cripling #1) -> if file has its name introducing danger of dataloss (lyx asks fo

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Pavel Sanda
Vincent van Ravesteijn wrote: >> to sum up: >> 1. new file1,new file2 >> 2. write some text in file 2 >> 3. new window,open both files 1,2 >> 4. try to hide file 2 >>-> impossible without saving (cripling #1) >>-> if file has its name introducing danger of dataloss (lyx asks >> for s

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Vincent van Ravesteijn
now you made impossible to hide buffer from the second window without saving buffer which is what 'feels wrong'. to ask for discarding changes opened in another window would lead imho to more dataloss problems the the issue you are trying to solve. Yes, I already acknowledged in the previou

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Kornel Benko
Am Samstag 15 August 2009 schrieb Vincent van Ravesteijn: > Pavel Sanda schreef: > > Vincent van Ravesteijn wrote: > What's then the difference between close tab and hide tab when a > document is opened in another view ? > > I guess there is no difference. > >>> > >>> close asks

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Pavel Sanda
Vincent van Ravesteijn wrote: >> i fail to understand the question :) >> maybe i was not clear myself - i the 'close tab' (in context menu on >> tabbar) >> is related to buffer (thats why asking for save etc) while 'hide tab' is >> (was) >> only view thing. >> >> pavel >> > Shall we rename thi

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Vincent van Ravesteijn
Pavel Sanda schreef: Vincent van Ravesteijn wrote: What's then the difference between close tab and hide tab when a document is opened in another view ? I guess there is no difference. close asks for saving, with hide i dont need to care (before your patch of course)

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Pavel Sanda
Vincent van Ravesteijn wrote: >>> What's then the difference between close tab and hide tab when a document >>> is opened in another view ? >>> >>> I guess there is no difference. >>> >> >> close asks for saving, with hide i dont need to care (before your patch of >> course) >> >> > That

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Vincent van Ravesteijn
Pavel Sanda schreef: Vincent van Ravesteijn wrote: What's then the difference between close tab and hide tab when a document is opened in another view ? I guess there is no difference. close asks for saving, with hide i dont need to care (before your patch of course) That would

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > What's then the difference between close tab and hide tab when a document > is opened in another view ? > > I guess there is no difference. close asks for saving, with hide i dont need to care (before your patch of course) pavel

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > >> have you checked its not dataloss from multiple windows view as i have >> warned before? >> if you have two windows, which have opened the same file and then try to >> hide buffer in one of >> the windows, you will ask for save. this imho shouldn't happen, secon

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Abdelrazak Younes
On 15/08/2009 14:40, Vincent van Ravesteijn wrote: Abdelrazak Younes schreef: On 15/08/2009 14:22, Vincent van Ravesteijn wrote: have you checked its not dataloss from multiple windows view as i have warned before? if you have two windows, which have opened the same file and then try to hide

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Vincent van Ravesteijn
Vincent van Ravesteijn schreef: have you checked its not dataloss from multiple windows view as i have warned before? if you have two windows, which have opened the same file and then try to hide buffer in one of the windows, you will ask for save. this imho shouldn't happen, secondly if hit

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Vincent van Ravesteijn
Abdelrazak Younes schreef: On 15/08/2009 14:22, Vincent van Ravesteijn wrote: have you checked its not dataloss from multiple windows view as i have warned before? if you have two windows, which have opened the same file and then try to hide buffer in one of the windows, you will ask for save

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Abdelrazak Younes
On 15/08/2009 14:22, Vincent van Ravesteijn wrote: have you checked its not dataloss from multiple windows view as i have warned before? if you have two windows, which have opened the same file and then try to hide buffer in one of the windows, you will ask for save. this imho shouldn't happen

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-15 Thread Vincent van Ravesteijn
have you checked its not dataloss from multiple windows view as i have warned before? if you have two windows, which have opened the same file and then try to hide buffer in one of the windows, you will ask for save. this imho shouldn't happen, secondly if hit don't save i get reload and lose

Re: r31043 - lyx-devel/trunk/src/frontends/qt4

2009-08-14 Thread Pavel Sanda
v...@lyx.org wrote: > Author: vfr > Date: Sat Aug 15 01:12:21 2009 > New Revision: 31043 > URL: http://www.lyx.org/trac/changeset/31043 > > Log: > Extend saveBufferIsNeeded with a parameter indicating whether the buffer is > going into a hidden state. If so, and the user discards his changes, the