Re: certsync: Please test patches on systems 10.9

2014-08-31 Thread Joshua Root
On 2014-8-30 19:54 , Clemens Lang wrote: Hi, Builds without warnings on Leopard but fails to run: $ ./certsync Failed to extract certificate description for untrusted certificate: Error Domain=NSOSStatusErrorDomain Code=-25303 UserInfo=0x14d350 SecCertificateCopyCommonName() failed ( /

Re: certsync: Please test patches on systems 10.9

2014-08-30 Thread Clemens Lang
Hi, Builds without warnings on Leopard but fails to run: $ ./certsync Failed to extract certificate description for untrusted certificate: Error Domain=NSOSStatusErrorDomain Code=-25303 UserInfo=0x14d350 SecCertificateCopyCommonName() failed ( / The attribute does not exist.) Segmentation

Re: certsync: Please test patches on systems 10.9

2014-08-30 Thread Clemens Lang
Hi, Some warnings on Tiger, but it builds and seems to work. certsync.m: In function 'certificatesForTrustDomain': certsync.m:298: warning: implicit declaration of function 'SecTrustSettingsCopyTrustSettings' certsync.m: In function 'exportCertificates': certsync.m:406: warning: implicit

Re: certsync: Please test patches on systems 10.9

2014-08-28 Thread Joshua Root
On 2014-8-8 22:23 , Clemens Lang wrote: Hi, certsync.m: In function ‘ValidateSystemTrust’: certsync.m:163: error: ‘SecPolicyCreateBasicX509’ undeclared (first use in this function) certsync.m:163: error: (Each undeclared identifier is reported only once certsync.m:163: error: for each

Re: certsync: Please test patches on systems 10.9

2014-08-08 Thread Clemens Lang
Hi, certsync.m: In function ‘ValidateSystemTrust’: certsync.m:163: error: ‘SecPolicyCreateBasicX509’ undeclared (first use in this function) certsync.m:163: error: (Each undeclared identifier is reported only once certsync.m:163: error: for each function it appears in.) certsync.m:164:

Re: certsync: Please test patches on systems 10.9

2014-06-10 Thread Joshua Root
The new version builds and appears to work correctly on 10.6. But see below regarding 10.5. On 2014-6-6 09:08 , Clemens Lang wrote: Leopard: certsync.m:162: warning: implicit declaration of function ‘SecPolicyCreateBasicX509’ I've provided an alternative implementation of the same behavior

Re: certsync: Please test patches on systems 10.9

2014-06-06 Thread Joshua Root
On 2014-6-6 12:57 , Eric Gallager wrote: On 6/5/14, Clemens Lang c...@macports.org wrote: built-in:0: warning: Mac OS X version 10.5 or later is needed for use of the new objc abi I'm not sure what that means. new means 64-bit in that case. You get that warning when you compile for a

Re: certsync: Please test patches on systems 10.9

2014-06-06 Thread Clemens Lang
Hi, Why does it hardcode -mmacosx-version-min=10.4 anyway? Seems like it should be using $macosx_deployment_target there. I don't know. Landon? -- Clemens Lang ___ macports-dev mailing list macports-dev@lists.macosforge.org

Re: certsync: Please test patches on systems 10.9

2014-06-06 Thread Landon J Fuller
On Jun 6, 2014, at 6:29 AM, Clemens Lang c...@macports.org wrote: Hi, Why does it hardcode -mmacosx-version-min=10.4 anyway? Seems like it should be using $macosx_deployment_target there. I don't know. Landon? I originally wrote this to also work outside of MacPorts; the code was

Re: certsync: Please test patches on systems 10.9

2014-06-05 Thread Joshua Root
On 2014-6-3 08:39 , Clemens Lang wrote: Hi, I'd like to ask one of the devs with access to systems or VMs Mavericks to test the attached patch against certsync's certsync.m file. You'll find the file in $(port dir certsync)/files. Please test - Compilation: Run $ sudo port

Re: certsync: Please test patches on systems 10.9

2014-06-05 Thread Clemens Lang
Hi, Thanks for the feedback everyone. More details inline below: Like we do with the Portfiles in trunk, could you split the patch between the whitespace changes and the functionality changes? I could, but it would mean extra work for me because our version control system does not support

Re: certsync: Please test patches on systems 10.9

2014-06-05 Thread Eric Gallager
On 6/5/14, Clemens Lang c...@macports.org wrote: Hi, Thanks for the feedback everyone. More details inline below: Like we do with the Portfiles in trunk, could you split the patch between the whitespace changes and the functionality changes? I could, but it would mean extra work for me

Re: certsync: Please test patches on systems 10.9

2014-06-05 Thread David Evans
On 6/5/14 4:08 PM, Clemens Lang wrote: Please test again (and feel free to patch for Tiger, especially if you can test on this system, because I'm fishing in muddy waters there, given I can't verify only the *trusted* roots are exported). Revised patch builds and tests OK on 10.8.5.

Re: certsync: Please test patches on systems 10.9

2014-06-04 Thread Eric Gallager
Like we do with the Portfiles in trunk, could you split the patch between the whitespace changes and the functionality changes? Right now with the two of them together, it is kind of harder to know which sections of the patch to focus on when reading it... On Mon, Jun 2, 2014 at 6:41 PM,

certsync: Please test patches on systems 10.9

2014-06-02 Thread Clemens Lang
Hi, I'd like to ask one of the devs with access to systems or VMs Mavericks to test the attached patch against certsync's certsync.m file. You'll find the file in $(port dir certsync)/files. Please test - Compilation: Run $ sudo port destroot certsync. - Functionality: $ cd $(port

Re: certsync: Please test patches on systems 10.9

2014-06-02 Thread Clemens Lang
Hi, […] test the attached patch […] Attached, sorry. -- Clemens Lang Index: certsync.m === --- certsync.m (revision 120592) +++ certsync.m (working copy) @@ -25,6 +25,8 @@ * OTHER DEALINGS IN THE SOFTWARE. */ +#import