You can achieve that nicely by either editing the revert commit
after-the-fact (git commit --amend) or you can actually ask revert to
not auto-commit (git revert -n).
This way you can make further necessary edits while keeping to one solid
revert commit.
On 05/30/2017 08:34 PM, Helmut K. C. Tessa
On 2017-05-30 20:25, Sterling Smith wrote:
>> 1) git revert xyz
>> 2) makes changes and sets v1.2
>> 3) commit
>> 4) git push
>>
>> The last 4 lines were local, so it is ok to have the version changed
>> temporarily back to pre-1.1 in step 1 (the git revert).
> This is only true if the bad commit
On May 30, 2017, at 8:03PM, Helmut K. C. Tessarek wrote:
> On 2017-05-30 17:36, Ryan Schmidt wrote:
>> Wouldn't requiring a certain number of reviews make things more
>> difficult than they are now, where we don't require reviews?
>
> Well, this depends. I haven't administered github projects f
On 2017-05-30 17:36, Ryan Schmidt wrote:
> Wouldn't requiring a certain number of reviews make things more
> difficult than they are now, where we don't require reviews?
Well, this depends. I haven't administered github projects for large
groups, so I don't know if this is even possible with githu
On May 30, 2017, at 16:36, Ryan Schmidt wrote:
> On May 30, 2017, at 13:23, Helmut K. C. Tessarek wrote:
>
>> Maybe you could allow maintainers to review and approve other pull requests.
>>
>> This is git. It's very easy to revert a broken commit. Since almost all
>> of these commits are not con
> On May 30, 2017, at 13:23, Helmut K. C. Tessarek wrote:
>
> Hello,
>
> Maybe we can streamline the github process a bit.
Sure. Those familiar with GitHub should chime in. I'm not familiar so I won't
answer most of your questions, except:
> As Mojca mentioned
> earlier, the macports projec
Hello,
Maybe we can streamline the github process a bit. As Mojca mentioned
earlier, the macports project is heavily understaffed.
Is there a way to allow maintainers to set labels? (e.g. the
'maintainer' or 'update' label)
Also you could block merges until 1 or 2 people have reviewed and
approv
Ryan,
Note that by adding ?w=1 to a web commit address, you get the non-whitespace
diff:
https://github.com/macports/macports-ports/commit/560e36d7a4b25f21d06db69b5325e8f866b8e898?w=1
-Sterling
On May 28, 2017, at 11:58PM, Ryan Schmidt wrote:
>
>> On May 9, 2017, at 08:25, Frank Schima wrot
