Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Steven Smith
Thank you for all the helpful guidance! The latest commit shows a working build. Here’s a working Portfile:

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Joshua Root
On 2019-11-24 02:03 , Mojca Miklavec wrote: > On Sat, 23 Nov 2019 at 15:53, Joshua Root wrote: >> I'm pretty sure the CMakeLists is just buggy. The missing symbols are >> defined in libjsonnet.cpp, while is compiled to libjsonnet.cpp.o, but >> there's just no attempt to include any libraries or .o

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Mojca Miklavec
On Sat, 23 Nov 2019 at 15:53, Joshua Root wrote: > On 2019-11-24 01:35 , Mojca Miklavec wrote: > > On Sat, 23 Nov 2019 at 14:56, Steven Smith wrote: > >> > >> > >> Here’s the current not-working Portfile: > >> > >>

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Joshua Root
On 2019-11-24 01:35 , Mojca Miklavec wrote: > On Sat, 23 Nov 2019 at 14:56, Steven Smith wrote: >> >> >> Here’s the current not-working Portfile: >> >> https://github.com/macports/macports-ports/blob/4a9cd2d6b34e6d48e22bfb608529e900f49f8dcb/devel/jsonnet/Portfile > > It builds perfectly fine for

Re: error: thread-local storage is not supported

2019-11-23 Thread Ken Cunningham
yes, it can cause confusion that the C thread local and the c++ thread_local are different animals. But as I hope we don't want two different compiler.thread_local_storage commands, one for C and one for c++, we need to cover them both with one command. Or have two, if you like... I'll look

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Mojca Miklavec
On Sat, 23 Nov 2019 at 14:56, Steven Smith wrote: > > > Here’s the current not-working Portfile: > > https://github.com/macports/macports-ports/blob/4a9cd2d6b34e6d48e22bfb608529e900f49f8dcb/devel/jsonnet/Portfile It builds perfectly fine for me (I built it with "sudo port -vt destroot"), it only

Re: error: thread-local storage is not supported

2019-11-23 Thread Marcus Calhoun-Lopez
macOS has supported thread-local storage since Mac OS X Lion. So __thread (GNU extension) and _Thread_local (C11) could be used. However, the C++11 keyword was not supported until Xcode 8 [1,2]. There is a pull request that attempts to improve the situation [3]. -Marcus 1.

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Christopher Jones
> On 23 Nov 2019, at 1:56 pm, Steven Smith wrote: > > Per https://guide.macports.org/#reference.phases.installation.list-modifiers > , > I’ll try starting with a blanket -delete of everything, try to get to the >

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Steven Smith
Per https://guide.macports.org/#reference.phases.installation.list-modifiers , I’ll try starting with a blanket -delete of everything, try to get to the basic working make, and divide-and-conquer to isolate the issue.

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Chris Jones
> On 23 Nov 2019, at 12:57 pm, Steven Smith wrote: > >  >> >> You need to try and isolate the one causing the issue, if you believe it is >> something MacPorts is appending to the env, and then address that >> specifically. > > That’s what I’m asking for help to do. > > How are these

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Steven Smith
> You need to try and isolate the one causing the issue, if you believe it is > something MacPorts is appending to the env, and then address that > specifically. That’s what I’m asking for help to do. How are these flags and environment variables set within a Portfile? I don’t know enough

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Christopher Jones
> On 23 Nov 2019, at 12:29 pm, Steven Smith wrote: > > This is a 100% MacPorts default flags or env issue, and nothing to do with > Google’s upstream repo or code. > > First, the repo’s make command works on macOS > >: >

Re: Undefined symbols for architecture x86_64 on jsonnet submission

2019-11-23 Thread Steven Smith
This is a 100% MacPorts default flags or env issue, and nothing to do with Google’s upstream repo or code. First, the repo’s make command works on macOS >: > make CC=clang CXX=clang++ Second, Homebrew uses this formula for