Re: Releasing 2.4.3

2018-04-10 Thread Joshua Root
On 2018-4-11 03:49 , Ryan Schmidt wrote: > > On Apr 10, 2018, at 12:44, Rainer Müller wrote: > >> Building package installers is the most time-consuming operation in our >> release process. Therefore I was asking whether it is actually worth to >> wait for them to appear before releasing to selfu

Re: Releasing 2.4.3

2018-04-10 Thread Rainer Müller
On 2018-04-10 19:39, Ryan Schmidt wrote: > Do you want to merge this performance enhancement too: [...] > And these bugfixes: I assigned this to the MacPorts 2.4.4 milestone, so we do not forget about them: https://trac.macports.org/ticket/56267 Rainer

Re: Releasing 2.4.3

2018-04-10 Thread Rainer Müller
On 2018-04-10 21:06, Ryan Schmidt wrote: > I'm not going to merge them, because I don't know how, and don't have the > energy to attempt to learn how to do so, given the zillion other things I'm > trying to do right now. This is even documented: https://trac.macports.org/wiki/WorkingWithGit#cher

Re: Releasing 2.4.3

2018-04-10 Thread Ryan Schmidt
On Apr 10, 2018, at 13:47, Rainer Müller wrote: > On 2018-04-10 20:26, Ryan Schmidt wrote: >> >> On Apr 10, 2018, at 12:54, Rainer Müller wrote: >>> >>> At some point we should make a cut and not add many changes in the last >>> minute... >> >> Well I can't force you to merge them. > > I canno

Re: Releasing 2.4.3

2018-04-10 Thread Ken Cunningham
On 2018-04-10, at 12:02 PM, Ryan Schmidt wrote: > > On Apr 10, 2018, at 13:55, Ken Cunningham wrote: > Mixing libc++ and libstdc++ results in a link failure. Mixing old libstdc++ > and new libstdc++ did not previously result in a link failure; it resulted in > a runtime crash which was diffic

Re: Releasing 2.4.3

2018-04-10 Thread Ryan Schmidt
On Apr 10, 2018, at 13:55, Ken Cunningham wrote: > On 2018-04-10, at 11:47 AM, Rainer Müller wrote: >>> >>> I don't want to release 2.4.3 with the libstdc++ ABI issue unanswered. I >>> believe it will cause problems. >> >> Then we should revert this change for 2.4.3 and we have one more reason

Re: Releasing 2.4.3

2018-04-10 Thread Ken Cunningham
On 2018-04-10, at 11:47 AM, Rainer Müller wrote: >> >> I don't want to release 2.4.3 with the libstdc++ ABI issue unanswered. I >> believe it will cause problems. > > Then we should revert this change for 2.4.3 and we have one more reason > to go for a 2.4.4 release. > > Rainer I would have

Re: Releasing 2.4.3

2018-04-10 Thread Rainer Müller
On 2018-04-10 20:26, Ryan Schmidt wrote: > > On Apr 10, 2018, at 12:54, Rainer Müller wrote: >> >> At some point we should make a cut and not add many changes in the last >> minute... > > Well I can't force you to merge them. I cannot stop you either... I am just afraid that by merging changes i

Re: Releasing 2.4.3

2018-04-10 Thread Ryan Schmidt
On Apr 10, 2018, at 12:54, Rainer Müller wrote: > > On 2018-04-10 19:39, Ryan Schmidt wrote: >> >> On Apr 10, 2018, at 12:07, Ryan Schmidt wrote: >> >>> On Apr 9, 2018, at 17:15, Rainer Müller wrote: >>> If nobody objects, I am going to tag a new release on Tuesday and prepare tarbal

Re: Releasing 2.4.3

2018-04-10 Thread Rainer Müller
On 2018-04-10 19:39, Ryan Schmidt wrote: > > On Apr 10, 2018, at 12:07, Ryan Schmidt wrote: > >> On Apr 9, 2018, at 17:15, Rainer Müller wrote: >> >>> If nobody objects, I am going to tag a new release on Tuesday and >>> prepare tarballs. >> >> Please merge my other two commits from this ticket:

Re: Releasing 2.4.3

2018-04-10 Thread Ryan Schmidt
On Apr 10, 2018, at 12:44, Rainer Müller wrote: > Building package installers is the most time-consuming operation in our > release process. Therefore I was asking whether it is actually worth to > wait for them to appear before releasing to selfupdate. I am rebuilding our installer creation pro

Re: Releasing 2.4.3

2018-04-10 Thread Ryan Schmidt
I am not comfortable releasing a version of MacPorts that includes a MacPorts gcc in the default compiler list (which 2.4.3 now does) without having answered the new-vs-old ABI question satisfactorily. I believe releasing that will lead to the libstdc++ mismatch crashes that were the reason why

Re: Releasing 2.4.3

2018-04-10 Thread Rainer Müller
On 2018-04-10 19:07, Ryan Schmidt wrote: > > On Apr 9, 2018, at 17:15, Rainer Müller wrote: > >> If nobody objects, I am going to tag a new release on Tuesday and >> prepare tarballs. > > Please merge my other two commits from this ticket: > > https://trac.macports.org/ticket/55492 > > My firs

Re: Releasing 2.4.3

2018-04-10 Thread Ryan Schmidt
On Apr 10, 2018, at 12:07, Ryan Schmidt wrote: > On Apr 9, 2018, at 17:15, Rainer Müller wrote: > >> If nobody objects, I am going to tag a new release on Tuesday and >> prepare tarballs. > > Please merge my other two commits from this ticket: > > https://trac.macports.org/ticket/55492 > > My

Re: Releasing 2.4.3

2018-04-10 Thread Mojca Miklavec
On 10 April 2018 at 00:15, Rainer Müller wrote: > > If nobody objects, I am going to tag a new release on Tuesday and > prepare tarballs. In case you didn't do the tagging yet, I would suggest cherry-picking also the commit which adds "size ..." to checksums. While this is not strictly a bugfix, i

Re: Releasing 2.4.3

2018-04-10 Thread Ryan Schmidt
On Apr 9, 2018, at 17:15, Rainer Müller wrote: > If nobody objects, I am going to tag a new release on Tuesday and > prepare tarballs. Please merge my other two commits from this ticket: https://trac.macports.org/ticket/55492 My first commit, which you merged, was buggy and needed fixing. >

Re: Releasing 2.4.3

2018-04-10 Thread Ryan Schmidt
On Apr 9, 2018, at 22:43, Eric A. Borisch wrote: > I'd still like to see the opportunistic (via libarchive / bsdtar) compression > (pull request #45) integrated at some point; with modern machines and their > soldered-down storage, it's all the more useful. Sure, but this thread is about 2.4.3

Re: Releasing 2.4.3

2018-04-09 Thread Eric A. Borisch
[Sending from the correct address this time] I'd still like to see the opportunistic (via libarchive / bsdtar) compression (pull request #45) integrated at some point; with modern machines and their soldered-down storage, it's all the more useful. Shall I open a ticket in trac as a feature reques

Releasing 2.4.3

2018-04-09 Thread Rainer Müller
Hello, according to our milestone on Trac, there is nothing left to be fixed or backported to the release-2.4 branch for MacPorts 2.4.3. The ChangeLog was already updated and reflects the changes this release will contain: https://github.com/macports/macports-base/blob/release-2.4/ChangeLog See