Re : More proposed changes across code

2008-10-20 Thread deneche abdelhakim
5. BruteForceTravellingSalesman says copyright Daniel Dwyer -- can this be replaced by the standard copyright header? Oups, I tought I changed them all ! Yes you can replace it. __ Do You Yahoo!? En finir avec le spam? Yahoo! Mail vous offre la

Re: More proposed changes across code

2008-10-20 Thread deneche abdelhakim
--- En date de : Dim 19.10.08, Grant Ingersoll [EMAIL PROTECTED] a écrit : De: Grant Ingersoll [EMAIL PROTECTED] Objet: Re: More proposed changes across code À: mahout-dev@lucene.apache.org Date: Dimanche 19 Octobre 2008, 18h30 On Oct 19, 2008, at 11:16 AM, Sean Owen wrote: On Sun

Re: More proposed changes across code

2008-10-20 Thread Sean Owen
PS Looks like Hadoop does have a DoubleWritable now -- I'll switch to that where approrpriate as part of this pretty-big change list I am preparing. Also, while scouring the code I spotted what I believe is a common misconception that has led to a bug or two: {Double,Float}.MIN_VALUE is *not* the

Re: More proposed changes across code

2008-10-20 Thread Sean Owen
Ugh, yeah, thinking about that a couple more seconds would have been useful. That is completely right. On Mon, Oct 20, 2008 at 3:33 PM, Ted Dunning [EMAIL PROTECTED] wrote: Double.longBitsToDouble(Random.nextLong()) NO!!

Re: More proposed changes across code

2008-10-19 Thread Grant Ingersoll
On Oct 19, 2008, at 8:58 AM, Sean Owen wrote: Since I'm back on this topic, here are some items I'd propose to change. Yeah I know you can say they're small, but they get harder to fix as time goes on. But nevertheless what do you think of... 1. serialVersionUID should not be used. The

Re: More proposed changes across code

2008-10-19 Thread Sean Owen
On Sun, Oct 19, 2008 at 4:07 PM, Grant Ingersoll [EMAIL PROTECTED] wrote: Doesn't the javadoc tool used @inherit to fill in the inherited docs when viewing? Yes... I suppose I find that redundant. The subclass method gets documented exactly as the superclass does. It looks like the subclass had

Re: More proposed changes across code

2008-10-19 Thread Grant Ingersoll
On Oct 19, 2008, at 11:16 AM, Sean Owen wrote: On Sun, Oct 19, 2008 at 4:07 PM, Grant Ingersoll [EMAIL PROTECTED] wrote: Doesn't the javadoc tool used @inherit to fill in the inherited docs when viewing? Yes... I suppose I find that redundant. The subclass method gets documented exactly

Re: More proposed changes across code

2008-10-19 Thread Ted Dunning
On Sun, Oct 19, 2008 at 5:58 AM, Sean Owen [EMAIL PROTECTED] wrote: 1. serialVersionUID should not be used. +1 2. Javadoc that just read (non-javadoc) with a @see tag, or just has [EMAIL PROTECTED], adds no value and can be removed. +1 I read Grant's comments, but I would rather have an