No, sorry for the inconvenience
___
Mailman-Developers mailing list -- mailman-developers@python.org
To unsubscribe send an email to mailman-developers-le...@python.org
https://mail.python.org/mailman3/lists/mailman-developers.python.org/
Mailman FAQ: htt
@ritwak p Are you still working on this issue? Please let us know.
--
Mark Sapiro The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
___
Mailman-Developers mailing list -- mailman-developers@pyth
Please disregard this:
> I'm getting member as not-None when the member confirms their subscription.
> But the comments said (which you corrected), that the member will be None
> when subscribing.
Sorry for the wrong doubt.
___
Mailman-Developers mailing
On 1/7/20 7:35 AM, ritwik p wrote:
> Mark Sapiro wrote:
>
>> The comment says
>> # We can't assert anything about member. It will be None when
>> # the workflow we're confirming is an unsubscription request,
>> # and non-None when we're confirming a subscription request.
>> # This class doesn't k
Mark Sapiro wrote:
> No. You do not want to change the confirm(token) function. You want
> to
> change mailman/commands/eml_confirm.py to do the right thing.
Ok.
Also,
I'm getting member as `not-None` when the member confirms their subscription.
But the comments said (which you corrected), that
Mark Sapiro wrote:
> The comment says
> # We can't assert anything about member. It will be None when
> # the workflow we're confirming is an unsubscription request,
> # and non-None when we're confirming a subscription request.
> # This class doesn't know which is happening.
> That's backwards.
On 1/4/20 5:10 AM, ritwik p wrote:
> Mark Sapiro wrote:
>
>> Because the comment is backwards.
>
> What do you mean by this??
The comment says
# We can't assert anything about member. It will be None when
# the workflow we're confirming is an unsubscription request,
# and non-None when we're
On 1/4/20 5:13 AM, ritwik p wrote:
> Mark Sapiro wrote:
>
>> That's exactly the issue. The code doesn't fully account for
>> unsubscription. (And comments don't always agree with what the code
>> actually does.)
>
> So basically I need to modify/update/rewrite the `confirm(token)` function?
> Whe
Mark Sapiro wrote:
> That's exactly the issue. The code doesn't fully account for
> unsubscription. (And comments don't always agree with what the code
> actually does.)
So basically I need to modify/update/rewrite the `confirm(token)` function?
Where can I start with this?
Also any pointers as t
Mark Sapiro wrote:
> Because the comment is backwards.
What do you mean by this??
> because member exists when when we are unsubscribing a member and member
> doesn't yet exist when we are subscribing a new member.
> The comment We can't assert anything about member. actually applies to
> all th
On 1/3/20 11:21 AM, ritwik p wrote:
> Line 53 in `eml_confirm.py` is: new_token, token_owner, member =
> ISubscriptionManager(mlist).confirm(token)
>
> I checked the return of function `confirm` of class `ISubscriptionManager` in
> `/mailman/src/interfaces/subscriptions.py` which says -->
>
> A
On 1/3/20 7:57 AM, ritwik p wrote:
> The mentioned issue: https://gitlab.com/mailman/mailman/issues/553
>
> So, the line 65 in `eml_confirm.py` in `/src/mailman/commands/`
> which raises the error is `assert member is None, member`
>
> Basically what this line is doing is checking if the `member
Line 53 in `eml_confirm.py` is: new_token, token_owner, member =
ISubscriptionManager(mlist).confirm(token)
I checked the return of function `confirm` of class `ISubscriptionManager` in
`/mailman/src/interfaces/subscriptions.py` which says -->
A 3-tuple is returned where the first element is th
13 matches
Mail list logo
