[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803071#comment-15803071 ] Daniel Templeton commented on MAPREDUCE-6715: - Yay! LGTM +1 I'll commit shortly. > Fix

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802891#comment-15802891 ] Hadoop QA commented on MAPREDUCE-6715: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802785#comment-15802785 ] Hadoop QA commented on MAPREDUCE-6715: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802758#comment-15802758 ] Daniel Templeton commented on MAPREDUCE-6715: - That part looks fine to me. I'm looking

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802717#comment-15802717 ] Yufei Gu commented on MAPREDUCE-6715: - Thanks for the review. After deeper looking, I realize this

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15801651#comment-15801651 ] Daniel Templeton commented on MAPREDUCE-6715: - LGTM. About that pointless null check...

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796124#comment-15796124 ] Hadoop QA commented on MAPREDUCE-6715: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796048#comment-15796048 ] Yufei Gu commented on MAPREDUCE-6715: - Thanks [~templedf] for the review. I uploaded patch 004 for

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795977#comment-15795977 ] Daniel Templeton commented on MAPREDUCE-6715: - Thanks for the updates. Just noticed a

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784290#comment-15784290 ] Hadoop QA commented on MAPREDUCE-6715: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783953#comment-15783953 ] Daniel Templeton commented on MAPREDUCE-6715: - Thanks, [~yufeigu]. Some comments: * In

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746909#comment-15746909 ] Hadoop QA commented on MAPREDUCE-6715: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743809#comment-15743809 ] Hadoop QA commented on MAPREDUCE-6715: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||