Re: [Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

2015-07-24 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124440/ --- (Updated July 24, 2015, 11:23 a.m.) Review request for Marble and Gábor P

Re: [Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

2015-07-24 Thread Mihail Ivchenko
> On July 24, 2015, 1:38 a.m., Dennis Nienhüser wrote: > > Would it be possible to pass the QPointf parameters as const references > > also? Yes, fixed. - Mihail --- This is an automatically generated e-mail. To reply, visit: https://g

Re: [Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

2015-07-24 Thread Torsten Rahn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124440/#review82853 --- src/apps/marble_maps/MainScreen.qml (line 4)

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

2015-07-24 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124441/ --- (Updated July 24, 2015, 11:41 a.m.) Review request for Marble and Gábor P

Re: [Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

2015-07-24 Thread Torsten Rahn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124440/#review82854 --- Ship it! Ship It! - Torsten Rahn On Juli 24, 2015, 7:23 vo

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

2015-07-24 Thread Torsten Rahn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124441/#review82855 --- Ship it! Ship It! - Torsten Rahn On Juli 24, 2015, 7:41 vo

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

2015-07-24 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124441/ --- (Updated July 24, 2015, 1:07 p.m.) Review request for Marble and Gábor Pé

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

2015-07-24 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124441/ --- (Updated July 24, 2015, 1:38 p.m.) Review request for Marble and Gábor Pé

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

2015-07-24 Thread Torsten Rahn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124441/#review82867 --- Ship it! Ship It! - Torsten Rahn On Juli 24, 2015, 9:38 vo

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

2015-07-24 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124441/ --- (Updated July 24, 2015, 10:06 a.m.) Status -- This change has been m

Re: [Marble-devel] Review Request 124438: [MarbleMaps] Set default theme and plugins visibility for Marble Maps app.

2015-07-24 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124438/ --- (Updated July 24, 2015, 10:06 a.m.) Status -- This change has been m

Re: [Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

2015-07-24 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124440/ --- (Updated July 24, 2015, 10:06 a.m.) Status -- This change has been m

[Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

2015-07-24 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124457/ --- Review request for Marble and Gábor Péterffy. Repository: marble Descri

Re: [Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

2015-07-24 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124457/#review82916 --- Looks fine. Can you push it on behalf of Gabor? - Dennis Nien

Re: [Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

2015-07-24 Thread Mihail Ivchenko
> On July 24, 2015, 11:36 p.m., Dennis Nienhüser wrote: > > Looks fine. Can you push it on behalf of Gabor? I'll be happy, but I dont' know how. Can you help? - Mihail --- This is an automatically generated e-mail. To reply, visit: http

Re: [Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

2015-07-24 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124457/#review82918 --- Ship it! Ship It! - Dennis Nienhüser On July 24, 2015, 7:3

Re: [Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

2015-07-24 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124457/ --- (Updated July 24, 2015, 8 p.m.) Status -- This change has been marke

Re: [Marble-devel] Review Request 124337: Basic plugin install mechanism for Android

2015-07-24 Thread Gábor Péterffy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124337/ --- (Updated July 24, 2015, 8 p.m.) Status -- This change has been marke

Re: [Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

2015-07-24 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124457/#review82919 --- Is dependency on Qt5Sql connected to the Android stuff in this

Re: [Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

2015-07-24 Thread Dennis Nienhüser
Hi Alexander, the dependency is indirectly connected to Android: LocalOsmSearchPlugin requires it and dynamic library loading does not work on Android, so something must load it directly. Another approach than linking the marble_maps application against QtSql would be to add QtSql as a depend

Re: [Marble-devel] Review Request 124346: Working zoom for Marble Maps

2015-07-24 Thread Gábor Péterffy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124346/ --- (Updated July 24, 2015, 9:26 p.m.) Status -- This change has been ma

Re: [Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

2015-07-24 Thread Alexander Potashev
Thanks Dennis! 2015-07-25 0:22 GMT+03:00 Dennis Nienhüser : > Hi Alexander, > > the dependency is indirectly connected to Android: LocalOsmSearchPlugin > requires it and dynamic library loading does not work on Android, so > something must load it directly. Another approach than linking the > marb

Re: [Marble-devel] Review Request 124421: Route preview was not working. Fixed!

2015-07-24 Thread Sanjiban Bairagya
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124421/ --- (Updated July 25, 2015, 5:19 a.m.) Status -- This change has been ma

Re: [Marble-devel] Review Request 124396: Adding a menu for Marble Maps

2015-07-24 Thread Gábor Péterffy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124396/ --- (Updated July 25, 2015, 5:21 a.m.) Status -- This change has been di

Re: [Marble-devel] Review Request 124287: Allow changing angle unit with right click on status bar

2015-07-24 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124287/#review82921 --- Ship it! Ship It! - Dennis Nienhüser On July 8, 2015, 12:1

Re: [Marble-devel] Review Request 124287: Allow changing angle unit with right click on status bar

2015-07-24 Thread Alexey Bugrov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124287/ --- (Updated July 25, 2015, 5:43 a.m.) Status -- This change has been ma

[Marble-devel] Jenkins-kde-ci: marble Applications-15.08 stable-qt4 » Linux,gcc - Build # 3 - Fixed!

2015-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/marble%20Applications-15.08%20stable-qt4/PLATFORM=Linux,compiler=gcc/3/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 25 Jul 2015 05:27:33 + Build duration: 17 min CHANGE SET Revision 1e7b9d66b71fccf4884398d853ba