Re: Review Request 122725: Adds the possibility to choose between multiple formats for exporting coordinates via clipboard.

nerated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122725/#review102370 --- On April 29, 2015, 4:42 p.m., Marius Stanciu wrote: > > --- > This is an automaticall

Re: [Marble-devel] Review Request 124570: gsoc: Keeping OsmPlacemarkData synchronized with geometries while editing

marked as submitted. Review request for Marble. Changes --- Submitted with commit 897374b608219008f906116a26e794039cdaaf06 by Marius Stanciu to branch master. Repository: marble Description --- In order to achieve this, the following has been done: Wherever geometries are altered

Re: [Marble-devel] Review Request 124781: gsoc: integrates the OsmTagEditorWidget and OsmRelationManagerWidget to the annotate editors

marked as submitted. Review request for Marble. Changes --- Submitted with commit ce7381a5b7090d1c4544defb4d940ec4e207f4e0 by Marius Stanciu to branch master. Repository: marble Description --- !! Due to dependency issues on reviewboard, could not include the final version of src

Re: [Marble-devel] Review Request 124822: gsoc: Introduces custom relation editing to placemarks within the AnnotatePlugin

marked as submitted. Review request for Marble. Changes --- Submitted with commit 9283a4cdd2c6a7f2a54f0caeed87cea9e3d91e89 by Marius Stanciu to branch master. Repository: marble Description --- !!Integrating this ui to the annotate plugin is coming in a separate patch; These are

Re: [Marble-devel] Review Request 124780: gsoc: Introduces the OsmTagEditorWidget

marked as submitted. Review request for Marble. Changes --- Submitted with commit 2a88ec8974ed07aa04d649c309e169db6c786588 by Marius Stanciu to branch master. Repository: marble Description --- !!! depends on the OsmPresetLibrary patch ( 124672 ) If you want to test this

Re: [Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

). I'll make sure he knows about my changes - Marius --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124672/#review84174 -----------

Re: [Marble-devel] Review Request 124570: gsoc: Keeping OsmPlacemarkData synchronized with geometries while editing

it: https://git.reviewboard.kde.org/r/124570/#review84172 --- On Aug. 16, 2015, 4:55 p.m., Marius Stanciu wrote: > > --- > This is an automatically generated e-mail. To rep

Re: [Marble-devel] Review Request 124781: gsoc: integrates the OsmTagEditorWidget and OsmRelationManagerWidget to the annotate editors

s (updated) final version of osm/CMakeLists.txt https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b3f1ecf8-b6d1-4bec-b38a-5017f039042a__CMakeLists.txt Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde

Re: [Marble-devel] Review Request 124822: gsoc: Introduces custom relation editing to placemarks within the AnnotatePlugin

src/lib/marble/osm/OsmRelationEditorDialog.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124822/diff/ Testing --- created new placemarks, added them to relations. Created relations, modified them, removed them. Seems to work fine. Thanks, Marius Stanciu

Re: [Marble-devel] Review Request 124780: gsoc: Introduces the OsmTagEditorWidget

EATION Diff: https://git.reviewboard.kde.org/r/124780/diff/ Testing --- testing is done for the next patch ( the ui is not yet integrated in the annotate plugin ) Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://

Re: [Marble-devel] Review Request 124820: gsoc: Adds custom relation support to the OsmPlacemarkData class

marked as submitted. Review request for Marble. Changes --- Submitted with commit 92d9e282763763eab18d852002a078c8863883ef by Marius Stanciu to branch master. Repository: marble Description --- added a hash that has the following meaning: the placemark is part of the relation

Re: [Marble-devel] Review Request 124817: gsoc: Moving the OsmObjectManager from the OsmPlugin

marked as submitted. Review request for Marble. Changes --- Submitted with commit b36a1683d6d10d83a8b9c1602fea5bf33bd9ac10 by Marius Stanciu to branch master. Repository: marble Description --- the osmObjectManager class assigns unique ids to newly created osm placemarks. In the

Re: [Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

marked as submitted. Review request for Marble. Changes --- Submitted with commit 72c2f65471e48bf7980d6773bb082453a9f8a5f2 by Marius Stanciu to branch master. Repository: marble Description --- Moved the osm presets from the GeoDataFeature to a separate class. This makes accessing

Re: [Marble-devel] Review Request 124781: gsoc: integrates the OsmTagEditorWidget and OsmRelationManagerWidget to the annotate editors

relations, removed relations, edited relations works as expected. Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 124822: gsoc: Introduces custom relation editing to placemarks within the AnnotatePlugin

://git.reviewboard.kde.org/r/124822/diff/ Testing --- created new placemarks, added them to relations. Created relations, modified them, removed them. Seems to work fine. Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https

[Marble-devel] Review Request 124820: gsoc: Adds custom relation support to the OsmPlacemarkData class

--- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

--- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124817: gsoc: Moving the OsmObjectManager from the OsmPlugin

/OsmObjectAttributeWriter.cpp b0cbd8d src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp 73f115b src/plugins/runner/osm/writers/OsmWayTagWriter.cpp 0b8484c Diff: https://git.reviewboard.kde.org/r/124817/diff/ Testing --- compiles fine, no other tests needed Thanks, Marius Stanciu

Re: [Marble-devel] Review Request 124780: gsoc: Introduces the OsmTagEditorWidget

PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124780/diff/ Testing --- testing is done for the next patch ( the ui is not yet integrated in the annotate plugin ) Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org

[Marble-devel] Review Request 124817: gsoc: Moving the OsmObjectManager from the OsmPlugin

://git.reviewboard.kde.org/r/124817/diff/ Testing --- compiles fine, no other tests needed Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124780: gsoc: Introduces the OsmTagEditorWidget

--- testing is done for the next patch ( the ui is not yet integrated in the annotate plugin ) Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

src/plugins/runner/json/JsonParser.cpp 2c1de39 src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp f21220d src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp 148ea7d Diff: https://git.reviewboard.kde.org/r/124672/diff/ Testing --- Thanks, Marius Stanciu

[Marble-devel] Review Request 124781: gsoc: integrates the OsmTagEditorWidget ui in the annotate plugin tools

--- Created placemarks, polylines, polygons, added tags, removed tags, changed styles... works as expected. Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124780: gsoc: Introduces the OsmTagEditorWidget

et integrated in the annotate plugin ) Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 124780: gsoc: Introduces the OsmTagEditorWidget

the annotate plugin ) Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

marked as submitted. Review request for Marble. Changes --- Submitted with commit b0facbb668284acb65def96a6d8fb66f30442cbd by Marius Stanciu to branch master. Repository: marble Description --- - This completes the parsing/writing cycle: load ".osm" -> export as &quo

Re: [Marble-devel] Review Request 124775: gsoc: additional accesors and function name refactoring for the OsmPlacemarkData class

marked as submitted. Review request for Marble. Changes --- Submitted with commit 13ec0aebbf64d201f8ae2f00e37067cb3b37521e by Marius Stanciu to branch master. Repository: marble Description --- changed the generic named functions: reference > nodeReference, memberRefere

Re: [Marble-devel] Review Request 124570: gsoc: Keeping OsmPlacemarkData synchronized with geometries while editing

ys to modify placemarks, I might have skipped a few please report any bugs :) Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124570: gsoc: Keeping OsmPlacemarkData synchronized with geometries while editing

to use a comma initializer and only initialize one of the > > variables. the initialOsmData is not a pointer, that's why i didn't initialize it. I separated the declaration from the initialization into 2 lines - Marius --

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

quot;.kml" > import ".kml" > export ".osm" compared the initial ".osm" file with the last one, they are the same. ( except tag order inconsistencies cause by the QHash mechanism ) Unit tests coming soon. Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

quot; compared the initial ".osm" file with the last one, they are the same. ( except tag order inconsistencies cause by the QHash mechanism ) Unit tests coming soon. Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

On Aug. 6, 2015, 6:23 p.m., Marius Stanciu wrote: > > Can you check the various documentation snippets whether the mx: namespace > > is consistently included? > > Marius Stanciu wrote: > you mean check marble's documentation ? or make sure KML standards allo

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

On Aug. 6, 2015, 6:23 p.m., Marius Stanciu wrote: > > Can you check the various documentation snippets whether the mx: namespace > > is consistently included? you mean check marble's documentation ? or make sure KML standards allow declaring a name

Re: [Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

/GeoDataFeature.h ea23cd8 src/lib/marble/geodata/data/GeoDataFeature.cpp 4443162 src/lib/marble/geodata/data/GeoDataFeature_p.h 962f0d5 Diff: https://git.reviewboard.kde.org/r/124672/diff/ Testing --- Thanks, Marius Stanciu ___ Marble

[Marble-devel] Review Request 124775: gsoc: additional accesors and function name refactoring for the OsmPlacemarkData class

, everything works as expected Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

2c1de39 src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp f21220d src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp 148ea7d Diff: https://git.reviewboard.kde.org/r/124672/diff/ Testing --- Thanks, Marius Stanciu ___ Marble

Re: [Marble-devel] Review Request 124511: Merged the decoration(124154) and the label placement(124498) review requests.

> On Aug. 10, 2015, 11:25 a.m., Dennis Nienhüser wrote: > > src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp, line 80 > > > > > > Can you check some zoo mappings in OSM to see if this is a building

[Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

/OsmNominatimSearchRunner.cpp f21220d src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp 148ea7d Diff: https://git.reviewboard.kde.org/r/124672/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https

Re: [Marble-devel] Review Request 124663: gsoc: Fixes style referencing for new polygons and polylines in the annotation plugin

neDialog.h 4d383b8 src/plugins/render/annotate/EditPolylineDialog.cpp fe7abc9 Diff: https://git.reviewboard.kde.org/r/124663/diff/ Testing --- creating polyline/polygons>setting styles--->exporting--->importing: results are as

Re: [Marble-devel] Review Request 124663: gsoc: Fixes style referencing for new polygons and polylines in the annotation plugin

te/EditPolylineDialog.cpp fe7abc9 Diff: https://git.reviewboard.kde.org/r/124663/diff/ Testing --- creating polyline/polygons>setting styles--->exporting--->importing: results are as expected Thanks, Marius Stanciu ___ Marble-devel

[Marble-devel] Review Request 124663: gsoc: Fixes style referencing for new polygons and polylines in the annotation plugin

-- creating polyline/polygons>setting styles--->exporting--->importing: results are as expected Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 124570: gsoc: Keeping OsmPlacemarkData synchronized with geometries while editing

g/r/124570/diff/ Testing --- Tested every case: loading placemarks from files, creating placemarks, modifying loaded placemarks in every way that i thought of. The results are okay. There are a lot of ways to modify placemarks, I might have skipped a few please report any bugs :)

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

.osm" compared the initial ".osm" file with the last one, they are the same. ( except tag order inconsistencies cause by the QHash mechanism ) Unit tests coming soon. Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

esting --- created stuff within editor then done the cycle: export as ".osm" > load ".osm" > export as ".kml" > import ".kml" > export ".osm" compared the initial "

Re: [Marble-devel] Review Request 124553: gsoc: Changes key type for the member hash within OsmPlacemarkData

marked as submitted. Review request for Marble. Changes --- Submitted with commit 3a83ed99b6aa852a770c97cad6c363d05f49994e by Marius Stanciu to branch master. Repository: marble Description --- It seems storing data with pointer keys within a QHash wasn't a good idea: A poly

Re: [Marble-devel] Review Request 124521: gsoc: Preparation for adding the KML OsmPlacemarkData writers/handlers

marked as submitted. Review request for Marble. Changes --- Submitted with commit 73d69065414fc252f253348388911533ba05ea5d by Marius Stanciu to branch master. Repository: marble Description --- - Added the "mx" namespace, needed to separate the upcoming custom XML schema

[Marble-devel] Review Request 124553: gsoc: Changes key type for the member hash within OsmPlacemarkData

RelationTagWriter.cpp 8f79a17 Diff: https://git.reviewboard.kde.org/r/124553/diff/ Testing --- Usual tests ( added polygons, imported, exported, reimported ), stuff works as expected. Thanks, Marius Stanciu ___ Marble-devel mailing li

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

then done the cycle: export as ".osm" > load ".osm" > export as ".kml" > import ".kml" > export ".osm" compared the initial ".osm" file with the last one, they are the same. ( except tag order inconsistencies cause by th

[Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

eated stuff within editor then done the cycle: export as ".osm" > load ".osm" > export as ".kml" > import ".kml" > export ".osm" compared the initial ".osm" file with the last one, t

[Marble-devel] Review Request 124521: gsoc: Preparation for adding the KML OsmPlacemarkData writers/handlers

runner/osm/handlers/OsmTagTagHandler.cpp d3fd2f2 src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp cb84d5c Diff: https://git.reviewboard.kde.org/r/124521/diff/ Testing --- compiles fine, no real changes to test. Thanks, Marius Stanciu ___ Ma

Re: [Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

marked as submitted. Review request for Marble. Changes --- Submitted with commit 4533ec9f780423b96c6e32009cd3b68c90f16cf3 by Marius Stanciu to branch master. Repository: marble Description --- Choosing .osm file format when saving annotation file now correctly outputs osm files

Re: [Marble-devel] Review Request 124097: gsoc: Translator classes used in writing osm files

marked as submitted. Review request for Marble. Changes --- Submitted with commit 850587966cf2d5aa218d23de37b45399b3b972f0 by Marius Stanciu to branch master. Repository: marble Description --- These classes are used to translate the GeoDataDocuments into syntactically correct osm

Re: [Marble-devel] Review Request 124096: gsoc: osm writer classes

marked as submitted. Review request for Marble. Changes --- Submitted with commit 6c64f0e66b2d88f4b381c30ba9098316d16558ac by Marius Stanciu to branch master. Repository: marble Description --- Classes with static functions that make writing typical osm tags convenient

Re: [Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

marked as submitted. Review request for Marble. Changes --- Submitted with commit cf192fd5c7a2b16c16afa5a42b9c42d431bd1f90 by Marius Stanciu to branch master. Repository: marble Description --- The OsmObjectManager is a temporary solution for managing OSM id ( used to ref osm tags

Re: [Marble-devel] Review Request 123837: gsoc: Solves coloring issue when loading OSM files

27;s water tag ). Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124233: gsoc: Modifying the osm handlers to store OsmPlacemarkData

marked as submitted. Review request for Marble. Changes --- Submitted with commit 987be5fa157ddac8d6dd3bd08ba5647c785ff7f1 by Marius Stanciu to branch master. Repository: marble Description --- Sorry about this long patch, but i really could not separate it. Even though it looks

Re: [Marble-devel] Review Request 124232: gsoc: Easy, safe accessor for OsmPlacemarkData objects

marked as submitted. Review request for Marble. Changes --- Submitted with commit 32946954065268cebae3e23f330700ff58d33d10 by Marius Stanciu to branch master. Repository: marble Description --- Adding this to the GeoDataPlacemark might not be really the best idea, but this makes

Re: [Marble-devel] Review Request 124231: gsoc: Adds the OsmPlacemarkData class

marked as submitted. Review request for Marble. Changes --- Submitted with commit 987b3b089541b327ec4bebc90b95b42805a12aa0 by Marius Stanciu to branch master. Repository: marble Description --- See comment on the header on what the class is for: A new folder lib/marble/osm was

Re: [Marble-devel] Review Request 124233: gsoc: Modifying the osm handlers to store OsmPlacemarkData

dlers/OsmTagTagHandler.cpp deaf32e src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp df15102 Diff: https://git.reviewboard.kde.org/r/124233/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org

Re: [Marble-devel] Review Request 124233: gsoc: Modifying the osm handlers to store OsmPlacemarkData

r.cpp deaf32e src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp df15102 Diff: https://git.reviewboard.kde.org/r/124233/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/ma

Re: [Marble-devel] Review Request 123594: Refactoring (delegate and view proxy) classes from MapViewWidget

marked as submitted. Review request for Marble. Changes --- Submitted with commit a00421b0931dde8867e575a3939de11fb2a6ade3 by Dennis Nienhüser on behalf of Marius Stanciu to branch master. Repository: marble Description --- Separated the refactoring part of the Map Change patch

Re: [Marble-devel] Review Request 124233: gsoc: Modifying the osm handlers to store OsmPlacemarkData

ugins/runner/osm/handlers/OsmTagTagHandler.cpp deaf32e src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp df15102 Diff: https://git.reviewboard.kde.org/r/124233/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-

Re: [Marble-devel] Review Request 124096: gsoc: osm writer classes

. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124096: gsoc: osm writer classes

:) - Marius --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124096/#review82582 --- On July 15, 2015, 2:41 p.m., Marius

Re: [Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

ial file and the final one are the same ( except order difference caused by QHash mechanism ) Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124097: gsoc: Translator classes used in writing osm files

fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124096: gsoc: osm writer classes

later patches. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

iters/OsmTagTagWriter.h PRE-CREATION src/plugins/runner/osm/writers/OsmTagTagWriter.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124095/diff/ Testing --- No testing can be done, as these are just helper classes. Compiles fine Thanks, Marius St

Re: [Marble-devel] Review Request 124096: gsoc: osm writer classes

static functions, will taste in later patches. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124232: gsoc: Easy, safe accessor for OsmPlacemarkData objects

/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

/runner/osm/writers/OsmTagTagWriter.h PRE-CREATION src/plugins/runner/osm/writers/OsmTagTagWriter.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124095/diff/ Testing --- No testing can be done, as these are just helper classes. Compiles fine Thanks, Marius Stanciu

Re: [Marble-devel] Review Request 124096: gsoc: osm writer classes

. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124233: gsoc: Modifying the osm handlers to store OsmPlacemarkData

dlers/OsmTagTagHandler.cpp deaf32e src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp df15102 Diff: https://git.reviewboard.kde.org/r/124233/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kd

Re: [Marble-devel] Review Request 124231: gsoc: Adds the OsmPlacemarkData class

/OsmPlacemarkData.h PRE-CREATION src/lib/marble/osm/OsmPlacemarkData.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124231/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https

Re: [Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

s not declared" if i don't include or - Marius --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124095/#review82406 ------- On

Re: [Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

isit: https://git.reviewboard.kde.org/r/124099/#review82414 ------- On July 10, 2015, 12:55 p.m., Marius Stanciu wrote: > > --- > This is an automatically generated

Re: [Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

;.osm" file. The initial file and the final one are the same ( except order difference caused by QHash mechanism ) Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124096: gsoc: osm writer classes

. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124097: gsoc: Translator classes used in writing osm files

later patches. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

://git.reviewboard.kde.org/r/124095/diff/ Testing --- No testing can be done, as these are just helper classes. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124233: gsoc: Modifying the osm handlers to store OsmPlacemarkData

dlers/OsmTagTagHandler.cpp deaf32e src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp df15102 Diff: https://git.reviewboard.kde.org/r/124233/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org

Re: [Marble-devel] Review Request 124232: gsoc: Easy, safe accessor for OsmPlacemarkData objects

sting --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124231: gsoc: Adds the OsmPlacemarkData class

/osm/OsmPlacemarkData.h PRE-CREATION src/lib/marble/osm/OsmPlacemarkData.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124231/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https

Re: [Marble-devel] Review Request 124231: gsoc: Adds the OsmPlacemarkData class

types as > > https://wiki.openstreetmap.org/wiki/Elements#Common_attributes suggests. > > Otherwise they'd have to be validated when writing. > > Marius Stanciu wrote: > thing is, they have to be validated, as they might be missing. Eg. > placemarks created within th

Re: [Marble-devel] Review Request 124231: gsoc: Adds the OsmPlacemarkData class

lly generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124231/#review82005 ------- On July 2, 2015, 4 p.m., Marius Stanciu wrote: > > --- > T

Re: [Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

file. Exported it to another ".osm" file. The initial file and the final one are the same ( except order difference caused by QHash mechanism ) Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124096: gsoc: osm writer classes

taste in later patches. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124097: gsoc: Translator classes used in writing osm files

functions, will taste in later patches. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

-CREATION Diff: https://git.reviewboard.kde.org/r/124095/diff/ Testing --- No testing can be done, as these are just helper classes. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org

[Marble-devel] Review Request 124233: gsoc: Modifying the osm handlers to store OsmPlacemarkData

Diff: https://git.reviewboard.kde.org/r/124233/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 124232: gsoc: Easy, safe accessor for OsmPlacemarkData objects

/data/GeoDataData.cpp e565c2c src/lib/marble/geodata/data/GeoDataPlacemark.h 726befb src/lib/marble/geodata/data/GeoDataPlacemark.cpp 7af4f9a Diff: https://git.reviewboard.kde.org/r/124232/diff/ Testing --- Thanks, Marius Stanciu ___ M

[Marble-devel] Review Request 124231: gsoc: Adds the OsmPlacemarkData class

PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124231/diff/ Testing --- Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

/124099/diff/ Testing --- Created a bunch of features in the edit mode and saved them. Reloaded the file in marble, it worked! Thanks, Marius Stanciu ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble

Re: [Marble-devel] Review Request 124096: gsoc: osm writer classes

PRE-CREATION src/plugins/runner/osm/writers/OsmWayTagWriter.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124096/diff/ Testing --- No testing was done yet as these are just static functions, will taste in later patches. Compiles fine Thanks, Marius Stanciu

Re: [Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

/plugins/runner/osm/writers/OsmTagTagWriter.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124095/diff/ Testing --- No testing can be done, as these are just helper classes. Compiles fine Thanks, Marius Stanciu ___ Marble-devel mailing

Re: [Marble-devel] Review Request 124097: gsoc: Translator classes used in writing osm files

/OsmPlacemarkTagTranslator.h PRE-CREATION src/plugins/runner/osm/translators/OsmPlacemarkTagTranslator.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124097/diff/ Testing --- No testing was done yet as these are just static functions, will taste in later patches. Compiles fine Thanks, Marius Stanciu

Re: [Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

> On June 15, 2015, 8:23 p.m., Dennis Nienhüser wrote: > > src/plugins/render/annotate/AnnotatePlugin.cpp, line 354 > > <https://git.reviewboard.kde.org/r/124099/diff/1/?file=379892#file379892line354> > > > > why not? > > Marius Stanciu wrote: >

Re: [Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

visit: https://git.reviewboard.kde.org/r/124099/#review81493 ----------- On June 14, 2015, 8:46 p.m., Marius Stanciu wrote: > > --- > This is an automatically generated e-mail. To

Re: [Marble-devel] Review Request 122686: Adds a right click menu to the statusbar that allows the user to quickly change the Angle display unit

src/apps/marble-qt/QtMainWindow.cpp c4280c6 src/lib/marble/QtMarbleConfigDialog.h 1fbee43 src/lib/marble/QtMarbleConfigDialog.cpp ed5b62c Diff: https://git.reviewboard.kde.org/r/122686/diff/ Testing --- it works on my machine. Thanks, Marius Stanciu

  1   2   >