[Marble-devel] Review Request 125740: Added merging for unclosed ways in OsmRelation.

- File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2015/10/21/140f72c6-d149-47cb-a62f-3164552ef9eb__snapshot13.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/10/21/e5fa2f98-d6c1-4cf5-8934-5cfe433f93a2__snapshot12.png Than

[Marble-devel] Review Request 124669: [MarbleMaps] Change width of SearchField.

://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/08905cb1-1532-4b9e-bbb1-2489db8e73fa__2015-08-09-13-08-41.png Samsung Galaxy Tab Pro 12.2 (portrait) https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/16100a81-b106-461a-a81d-6a8adca52fae__2015-08-09-13-09-04.png Thanks, Mihail

Re: [Marble-devel] Review Request 124664: [MarbleMaps] Add icons to search results.

5.1.1). > > > File Attachments > ---- > > Screenshot_2015-08-08-18-12-42.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/08/35dd9737-c1b1-4415-90fd-96392210940f__Screenshot_2015-08-08-18-12-42.png > > > Thanks, > > Mihail Ivchenko > > ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124664: [MarbleMaps] Add icons to search results.

edia/uploaded/files/2015/08/08/35dd9737-c1b1-4415-90fd-96392210940f__Screenshot_2015-08-08-18-12-42.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124664: [MarbleMaps] Add icons to search results.

Nexus 5 & Nexus 9 (both are Android 5.1.1). File Attachments (updated) Screenshot_2015-08-08-18-12-42.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/08/35dd9737-c1b1-4415-90fd-96392210940f__Screenshot_2015-08-08-18-12-42.png Thanks, Mihail Ivch

[Marble-devel] Review Request 124664: [MarbleMaps] Add icons to search results.

icons to search results in Marble Maps. Diffs - src/apps/marble-maps/SearchResults.qml f6caad10943769f002465ab2618d7900e35817a5 Diff: https://git.reviewboard.kde.org/r/124664/diff/ Testing --- Works well on Nexus 5 & Nexus 9 (both are Android 5.1.1). Thanks, Mihail Ivch

Re: [Marble-devel] Review Request 124609: [MarbleMaps] Hide Position Button while search results are visible.

-8c6a7b869de2__Screenshot_2015-08-04-10-14-58.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/135e6a19-7469-4a0b-a942-b2ca8c02ac93__Screenshot_2015-08-04-10-18-48.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel

[Marble-devel] Review Request 124609: [MarbleMaps] Hide Position Button while search results are visible.

://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/56417520-f547-4c8d-b849-8c6a7b869de2__Screenshot_2015-08-04-10-14-58.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/135e6a19-7469-4a0b-a942-b2ca8c02ac93__Screenshot_2015-08-04-10-18-48.png Thanks, Mihail Ivchenko

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

https://git.reviewboard.kde.org/media/uploaded/files/2015/08/01/9ab0b212-2ba8-4c6b-963e-4af2956c0134__Screenshot_2015-08-01-19-37-11.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

files/2015/07/31/6d497bac-01ea-424d-a636-da1b2a5d0311__Screenshot_2015-08-01-01-06-26.png Screenshot_2015-08-01-19-37-11.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/01/9ab0b212-2ba8-4c6b-963e-4af2956c0134__Screenshot_2015-08-01-19-37-11.png Thanks, Mihail Ivc

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

de.org/media/uploaded/files/2015/07/31/386444f1-8d4e-43de-96fd-9810f91e5a14__Screenshot_2015-08-01-01-06-16.png > Screenshot_2015-08-01-01-06-22.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/490fe2b2-8cf3-4456-82c1-08b9a81dcc89__

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

6.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/6d497bac-01ea-424d-a636-da1b2a5d0311__Screenshot_2015-08-01-01-06-26.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/lis

[Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

11-23-06.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124504: [MarbleMaps] Use system palette for Marble Maps instead of our own.

/800da415-2873-4ff1-b652-884f7428b414__Screenshot_2015-07-28-11-48-31.png Screenshot_2015-07-28-11-48-54.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/8d849958-c844-41f1-8244-254d7134ccdc__Screenshot_2015-07-28-11-48-54.png Thanks, Mihail Ivchenko

Re: [Marble-devel] Review Request 124504: [MarbleMaps] Use system palette for Marble Maps instead of our own.

-884f7428b414__Screenshot_2015-07-28-11-48-31.png Screenshot_2015-07-28-11-48-54.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/8d849958-c844-41f1-8244-254d7134ccdc__Screenshot_2015-07-28-11-48-54.png Thanks, Mihail Ivchenko ___ Marble

[Marble-devel] Review Request 124504: [MarbleMaps] Use system palette for Marble Maps instead of our own.

.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/8d849958-c844-41f1-8244-254d7134ccdc__Screenshot_2015-07-28-11-48-54.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman

Re: [Marble-devel] Review Request 124466: [MarbleMaps] Add search bar and "Theme item" for Marble Maps.

/ce250cea-47e9-4829-b705-370daf431742__Screenshot_2015-07-26-00-42-50.png Screenshot_2015-07-26-00-43-05.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/e5ebe15e-b394-42ce-a2d1-ba729cf00780__Screenshot_2015-07-26-00-43-05.png Thanks, M

Re: [Marble-devel] Review Request 124466: [MarbleMaps] Add search bar and "Theme item" for Marble Maps.

b394-42ce-a2d1-ba729cf00780__Screenshot_2015-07-26-00-43-05.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 124466: [MarbleMaps] Add search bar and "Theme item" for Marble Maps.

5.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124461: Fix addSearchResult in SearchRunnerManager.

unique one. This patch fixes that, so count only of unique placemarks is passed. Diffs - src/lib/marble/SearchRunnerManager.cpp 2da60ec Diff: https://git.reviewboard.kde.org/r/124461/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble

Re: [Marble-devel] Review Request 124461: Fix addSearchResult in SearchRunnerManager.

/SearchRunnerManager.cpp 2da60ec Diff: https://git.reviewboard.kde.org/r/124461/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 124461: Fix addSearchResult in SearchRunnerManager.

--- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

.1.1) Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

il. To reply, visit: https://git.reviewboard.kde.org/r/124457/#review82916 --- On July 24, 2015, 11:32 p.m., Mihail Ivchenko wrote: > > --- > This is an automatically generated e-ma

[Marble-devel] Review Request 124457: [MarbleMaps] Basic plugin install mechanism for Android.

--- Works well on Nexus 5 & Nexus 9 (both are Android 5.1.1) Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124438: [MarbleMaps] Set default theme and plugins visibility for Marble Maps app.

b9b7-41dd72eab375__Default_theme.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

96238c5 src/lib/marble/MarbleQuickItem.h b90e803 src/lib/marble/MarbleQuickItem.cpp e6757fd Diff: https://git.reviewboard.kde.org/r/124440/diff/ Testing --- Works on Nexus 5 & Nexus 9 (both Android 5.1.1). Thanks, Mihail Ivchenko ___ Ma

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

k non-fullscreen.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/4c96aaa9-b06e-4cdf-9b8a-09ff9f1daae3__Holo_Dark_non-fullscreen.png Holo Dark non-fullscreen 2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/1fe9f00b-434d-49d2-ae4d-4341b64f13c8__Holo_Dark_non-fulls

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

-fullscreen.png Holo Dark non-fullscreen 2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/1fe9f00b-434d-49d2-ae4d-4341b64f13c8__Holo_Dark_non-fullscreen_2.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

non-fullscreen 2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/1fe9f00b-434d-49d2-ae4d-4341b64f13c8__Holo_Dark_non-fullscreen_2.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

a-09ff9f1daae3__Holo_Dark_non-fullscreen.png Holo Dark non-fullscreen 2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/1fe9f00b-434d-49d2-ae4d-4341b64f13c8__Holo_Dark_non-fullscreen_2.png Thanks, Mihail Ivchenko ___ Marble-devel mail

Re: [Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

y, visit: https://git.reviewboard.kde.org/r/124440/#review82846 --- On July 24, 2015, 11:23 a.m., Mihail Ivchenko wrote: > > --- > This is an automatically generated e-mail.

Re: [Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

90e803 src/lib/marble/MarbleQuickItem.cpp e6757fd Diff: https://git.reviewboard.kde.org/r/124440/diff/ Testing --- Works on Nexus 5 & Nexus 9 (both Android 5.1.1). Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org

[Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

.1.1). Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 124441: [MarbleMaps] Move Marble Maps to QQmlApplicationEngine and QtQuick components.

07/23/63c4a2ff-ea1d-47d9-a004-46cc056d7468__Holo_Dark_3.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 124438: [MarbleMaps] Set default theme and plugins visibility for Marble Maps app.

ttps://git.reviewboard.kde.org/media/uploaded/files/2015/07/23/26f0b61b-9c9f-4cd2-b9b7-41dd72eab375__Default_theme.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 122077: [GCI] Fix adding placemark from the "Edit Maps" - first approach

- src/plugins/render/annotate/AnnotatePlugin.cpp faefeda Diff: https://git.reviewboard.kde.org/r/122077/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: [Marble-devel] Review Request 124396: Adding a menu for Marble Maps

> On July 20, 2015, 3:19 p.m., Mihail Ivchenko wrote: > > Am I right that you are implementing your own "Menu bar"? Isn't it better > > to use standard [MenuBar from > > QtQuick.Controls](http://doc.qt.io/qt-5/qml-qtquick-controls-menubar.html)? > >

Re: [Marble-devel] Review Request 124396: Adding a menu for Marble Maps

aterial_Dark.png) * [Material Light](http://s8.postimg.org/bd850obyt/Material_Light.png) P.S. Dennis and Torsten, what do you think about that? P.P.S. Also, I personnaly prefer Material Icons if it's possible, so it will look more like standard Material Design. - Mihail Ivchenko On July 2

Re: [Marble-devel] Review Request 122078: [GCI] Fix adding placemark from the "Edit Maps" - second approach

Diffs - src/plugins/render/annotate/AnnotatePlugin.h b59fe00 src/plugins/render/annotate/AnnotatePlugin.cpp faefeda Diff: https://git.reviewboard.kde.org/r/122078/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list

[Marble-devel] Review Request 122113: Fix behavior of Update::Change and Update::Delete

findFeature\findIds\etc. Diffs - src/lib/marble/TourItemDelegate.cpp 9eb0b66 Diff: https://git.reviewboard.kde.org/r/122113/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https

Re: [Marble-devel] Review Request 122075: [GCI] Fix behavior of "Add path" in the "Edit Maps".

/annotate/EditPolylineDialog.cpp 3697af6 src/plugins/render/annotate/PolylineAnnotation.cpp 7464957 Diff: https://git.reviewboard.kde.org/r/122075/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org

Re: [Marble-devel] Review Request 122076: [GCI] Do not allow to remove/update element with empty id in Tours.

/PlaybackAnimatedUpdateItem.cpp 48e5d3f Diff: https://git.reviewboard.kde.org/r/122076/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 122077: [GCI] Fix adding placemark from the "Edit Maps" - first approach

://git.reviewboard.kde.org/r/122077/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 122078: [GCI] Fix adding placemark from the "Edit Maps" - second approach

/annotate/AnnotatePlugin.cpp faefeda Diff: https://git.reviewboard.kde.org/r/122078/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 122076: [GCI] Do not allow to remove/update element with empty id in Tours.

, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 122075: [GCI] Fix behavior of "Add path" in the "Edit Maps".

7464957 Diff: https://git.reviewboard.kde.org/r/122075/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 122052: [GCI] Fix behavior of "create" item in tours.

://git.reviewboard.kde.org/r/122052/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 122052: [GCI] Fix behavior of "create" item in tours.

/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 122052: [GCI] Fix behavior of "create" item in tours.

de.org/r/122052/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 122052: [GCI] Fix behavior of "create" item in tours.

src/lib/marble/geodata/handlers/kml/KmlDocumentTagHandler.cpp 4cb9479 Diff: https://git.reviewboard.kde.org/r/122052/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman

Re: [Marble-devel] Review Request 122030: [GCI] Add a node tab to the EditPolygonDialog and EditPolylineDialog.

/ Testing --- File Attachments nodes.png https://git.reviewboard.kde.org/media/uploaded/files/2015/01/13/dd4148bb-ab02-40e9-aa0a-5d6f0888f274__nodes.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org

[Marble-devel] Review Request 122030: [GCI] Add a node tab to the EditPolygonDialog and EditPolylineDialog.

/media/uploaded/files/2015/01/13/dd4148bb-ab02-40e9-aa0a-5d6f0888f274__nodes.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 122002: [GCI] Add image and link from richtext view.

--- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 122003: Do not close dialogs with incorrect values even if "enter" is hold.

olygonDialog.ui 264b477 src/plugins/render/annotate/EditPolylineDialog.cpp 2d67bac src/plugins/render/annotate/EditPolylineDialog.ui 13d1c2c Diff: https://git.reviewboard.kde.org/r/122003/diff/ Testing --- Thanks, Mihail Ivchenko _

Re: [Marble-devel] Review Request 122003: Do not close dialogs with incorrect values even if "enter" is hold.

render/annotate/EditPolylineDialog.cpp 2d67bac src/plugins/render/annotate/EditPolylineDialog.ui 13d1c2c Diff: https://git.reviewboard.kde.org/r/122003/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https

Re: [Marble-devel] Review Request 122002: [GCI] Add image and link from richtext view.

: https://git.reviewboard.kde.org/r/122002/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 122003: Do not close dialogs with incorrect values even if "enter" is hold.

src/plugins/render/annotate/EditPolylineDialog.ui 13d1c2c Diff: https://git.reviewboard.kde.org/r/122003/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 122002: [GCI} Add image and link from richtext view.

/marble/EditTextAnnotationDialog.h db2ad94 src/lib/marble/EditTextAnnotationDialog.cpp 1472a6f src/lib/marble/EditTextAnnotationDialog.ui fe64dc2 Diff: https://git.reviewboard.kde.org/r/122002/diff/ Testing --- Thanks, Mihail Ivchenko

Re: [Marble-devel] Review Request 121987: [GCI] Extend the richtext view in "Add placemark".

Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121987: [GCI] Extend the richtext view in "Add placemark".

://git.reviewboard.kde.org/media/uploaded/files/2015/01/11/d52a831b-e7d7-4691-9858-13b0dfcbc9c2__insert-image.png insert-link.png https://git.reviewboard.kde.org/media/uploaded/files/2015/01/11/fb48d670-25e1-4304-8dea-a7004507ee78__insert-link.png Thanks, Mihail Ivchenko

[Marble-devel] Review Request 121987: [GCI] Extend the richtext view in "Add placemark".

/2015/01/11/d52a831b-e7d7-4691-9858-13b0dfcbc9c2__insert-image.png insert-link.png https://git.reviewboard.kde.org/media/uploaded/files/2015/01/11/fb48d670-25e1-4304-8dea-a7004507ee78__insert-link.png Thanks, Mihail Ivchenko ___ Marble-devel mailing

Re: [Marble-devel] Review Request 121975: [GCI] Add rechtext view to "Add Placemark".

https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/d1353984-917c-4ccb-ad34-280327941809__format-text-italic.png format-text-underline.png https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/02963b9a-7fb1-440e-9e31-56a682640289__format-text-underline.png Thanks, Mihail

[Marble-devel] Review Request 121975: [GCI] Add rechtext view to "Add Placemark".

-280327941809__format-text-italic.png format-text-underline.png https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/02963b9a-7fb1-440e-9e31-56a682640289__format-text-underline.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel

Re: [Marble-devel] Review Request 121940: Viewing properties for placemarks from FileView panel

tps://git.reviewboard.kde.org/r/121940/#comment51297> This one is not necessary since line 465 already contains same. - Mihail Ivchenko On Jan. 11, 2015, 12:36 a.m., Illya Kovalevskyy wrote: > > --- > This is an automatically generated e

Re: [Marble-devel] Review Request 121966: [GCI] Load GeoDataGroungOverlay in AnnotationPlugin too.

/121966/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121965: [GCI] Fix seeking of the Tour.

src/lib/marble/TourPlayback.cpp dad9b40 Diff: https://git.reviewboard.kde.org/r/121965/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121967: [GCI] Do not add polygon with less than 3 nodes.

/121967/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121967: [GCI] Do not add polygon with less than 3 nodes.

--- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121965: [GCI] Fix seeking of the Tour.

/git.reviewboard.kde.org/r/121965/#review73664 --- On Jan. 10, 2015, 7:10 p.m., Mihail Ivchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

[Marble-devel] Review Request 121965: [GCI] Fix seeking of the Tour.

/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 121966: [GCI] Load GeoDataGroungOverlay in AnnotationPlugin too.

task: http://www.google-melange.com/gci/task/view/google/gci2014/5825051425243136 Diffs - src/plugins/render/annotate/AnnotatePlugin.cpp be6bb93 Diff: https://git.reviewboard.kde.org/r/121966/diff/ Testing --- Thanks, Mihail Ivchenko

[Marble-devel] Review Request 121967: [GCI] Do not add polygon with less than 3 nodes.

task: http://www.google-melange.com/gci/task/view/google/gci2014/5825051425243136 Diffs - src/plugins/render/annotate/EditPolygonDialog.cpp 1079aaa Diff: https://git.reviewboard.kde.org/r/121967/diff/ Testing --- Thanks, Mihail Ivchenko

Re: [Marble-devel] Review Request 121940: Viewing properties for placemarks from FileView panel

appear. Also, maybe we shouldn't set "id" while opening in read-only mode? (For example, "Vidisha" from cityplacemarks has no ID and it's set to "vidisha" after opening). - Mihail Ivchenko On Jan

Re: [Marble-devel] Review Request 121939: Do not write name of GeoDataOveray twice.

>name() );" was already called by KmlFeatureTagWriter. Diffs - src/lib/marble/geodata/writers/kml/KmlOverlayTagWriter.cpp fd9490e Diff: https://git.reviewboard.kde.org/r/121939/diff/ Testing --- Thanks, Mihail Ivchenko ___ M

[Marble-devel] Review Request 121939: Do not write name of GeoDataOveray twice.

/lib/marble/geodata/writers/kml/KmlOverlayTagWriter.cpp fd9490e Diff: https://git.reviewboard.kde.org/r/121939/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121933: Set baseUrl for placemark's balloon to url of tour.

arble/TourPlayback.cpp 8bd43b3 src/lib/marble/TourWidget.cpp 57ac134 Diff: https://git.reviewboard.kde.org/r/121933/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/m

[Marble-devel] Review Request 121933: Set baseUrl for placemark's balloon to url of tour.

https://git.reviewboard.kde.org/r/121933/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121926: [GCI] Enable test for CDATA.

for ? Diffs - tests/TestGeoDataWriter.cpp 6ef6a84 tests/data/CDATATest.kml 654b563 Diff: https://git.reviewboard.kde.org/r/121926/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https

Re: [Marble-devel] Review Request 121919: [GCI] Fix CDATA handling for the edit text annotation dialog.

/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121918: Show balloon (if it's enabled) after creation placemark in Tour.

sting --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121925: [GCI] Fix reading of CDATA status in description.

t endElement. So, it always returns false in this case Diffs - src/lib/marble/geodata/handlers/kml/KmlDescriptionTagHandler.cpp 56f8918 Diff: https://git.reviewboard.kde.org/r/121925/diff/ Testing --- Thanks, Mihail Ivchenko ___ Ma

Re: [Marble-devel] Review Request 121926: [GCI] Enable test for CDATA.

) - tests/TestGeoDataWriter.cpp 6ef6a84 tests/data/CDATATest.kml 654b563 Diff: https://git.reviewboard.kde.org/r/121926/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman

[Marble-devel] Review Request 121926: [GCI] Enable test for CDATA.

Diff: https://git.reviewboard.kde.org/r/121926/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 121925: [GCI] Fix reading of CDATA status in description.

ta/handlers/kml/KmlDescriptionTagHandler.cpp 56f8918 Diff: https://git.reviewboard.kde.org/r/121925/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 121919: [GCI] Fix CDATA handling for the edit text annotation dialog.

task: http://www.google-melange.com/gci/task/view/google/gci2014/5805500734111744 Diffs - src/lib/marble/EditTextAnnotationDialog.cpp f3dd80b Diff: https://git.reviewboard.kde.org/r/121919/diff/ Testing --- Thanks, Mihail Ivchenko

[Marble-devel] Review Request 121918: Show balloon (if it's enabled) after creation placemark in Tour.

--- Show balloon (if it's enabled) after creation placemark in Tour. Diffs - src/lib/marble/PlaybackAnimatedUpdateItem.cpp 2eb98ea Diff: https://git.reviewboard.kde.org/r/121918/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-

Re: [Marble-devel] Review Request 121897: Add elapsed/total time to Tours.

://git.reviewboard.kde.org/r/121897/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121896: [GCI] Do not remove created item from update::create.

e7b4f90 Diff: https://git.reviewboard.kde.org/r/121896/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121898: [GCI] Fix behavior of first flyTo in Tour

/TourItemDelegate.h 25485a9 src/lib/marble/TourItemDelegate.cpp c4c5b24 src/lib/marble/TourWidget.cpp c837f1d Diff: https://git.reviewboard.kde.org/r/121898/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble

[Marble-devel] Review Request 121898: [GCI] Fix behavior of first flyTo in Tour

/TourWidget.cpp c837f1d Diff: https://git.reviewboard.kde.org/r/121898/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 121897: Add elapsed/total time to Tours.

task: http://www.google-melange.com/gci/task/view/google/gci2014/5859444181172224 Diffs - src/lib/marble/TourWidget.cpp c837f1d src/lib/marble/TourWidget.ui 5d437b0 Diff: https://git.reviewboard.kde.org/r/121897/diff/ Testing --- Thanks, Mihail Ivchenko

[Marble-devel] Review Request 121896: [GCI] Do not remove created item from update::create.

task: http://www.google-melange.com/gci/task/view/google/gci2014/5859444181172224 Diffs - src/lib/marble/PlaybackAnimatedUpdateItem.h 6c8b33d src/lib/marble/PlaybackAnimatedUpdateItem.cpp e7b4f90 Diff: https://git.reviewboard.kde.org/r/121896/diff/ Testing --- Thanks, Mihail

Re: [Marble-devel] Review Request 121824: [GCI] Add "Change item" to Tours.

/EditTextAnnotationDialog.cpp 877f340 Diff: https://git.reviewboard.kde.org/r/121824/diff/ Testing --- File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/01/04/0780aafa-04d1-4256-b315-8dfc2dd2eb6a__Change_item.png Thanks, Mihail Ivchenko

Re: [Marble-devel] Review Request 121821: [GCI] Make name field in PlacemarkEditWidget be bold

/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 121822: [GCI] Rename "Remove item" to "Remove placemark" in Tours

://git.reviewboard.kde.org/r/121822/diff/ Testing --- Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel

[Marble-devel] Review Request 121824: [GCI] Add "Change item" to Tours.

--- File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/01/04/0780aafa-04d1-4256-b315-8dfc2dd2eb6a__Change_item.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https

[Marble-devel] Review Request 121822: [GCI] Rename "Remove item" to "Remove placemark" in Tours

task: http://www.google-melange.com/gci/task/view/google/gci2014/5884484377378816 Diffs - src/lib/marble/TourWidget.h 37abbed src/lib/marble/TourWidget.cpp 9442db0 Diff: https://git.reviewboard.kde.org/r/121822/diff/ Testing --- Thanks, Mihail Ivchenko

[Marble-devel] Review Request 121821: [GCI] Make name field in PlacemarkEditWidget be bold

task: http://www.google-melange.com/gci/task/view/google/gci2014/5884484377378816 Diffs - src/lib/marble/PlacemarkEditHeader.ui 63cbafc Diff: https://git.reviewboard.kde.org/r/121821/diff/ Testing --- Thanks, Mihail Ivchenko

Re: [Marble-devel] Review Request 121795: [GCI] Add "remove item" to Tours.

Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/01/02/0adc05aa-5455-4fb0-81b8-0d024a72f74f__Add_remove_item.png Thanks, Mihail Ivchenko ___ Marble-devel mailing list Marble-devel@kde.org https

  1   2   >