Hi, Sergey!
On May 07, Sergey Vojtovich wrote:
> On Thu, May 07, 2015 at 01:04:24PM +0200, Sergei Golubchik wrote:
> > Hi, Sergey!
> >
> > On Mar 17, s...@mariadb.org wrote:
> > > revision-id: 93e746afb2d1a23cb933291ad736a20858b5ac3e
> > > parent(s): c
Hi, Alexander!
On Apr 09, Alexander Barkov wrote:
> Hi Sergei,
>
> Please review the patch for:
>
> MDEV-7807 information_schema.processlist truncates queries with binary
> strings
>
> The patch is for 10.1, as agreed with the reporter.
> Previously in 10.1 we fixe
Hi, Alexander!
On Mar 25, Alexander Barkov wrote:
> Hi Sergei,
>
> Please review a patch for mdev-7824.
>
> It's based on a MySQL patch for
> http://bugs.mysql.com/bug.php?id=68041
>
> and is a blocker for:
>
> MDEV-3929 Add full support for auto-initialize
biguous in such case.
>
> Fixed by temporary substitution of default database with being discovered
> table
> database.
ok to push
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists
g S and upgrading to SR "didn't solve the problem" and now it
suddenly does?
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
ee them again..
I think they don't *really* have CRLF endings (some of these files were
not changed for years). It's due to recent changes in the .gitattributes
file - git now converts them to windows line endings on checkout. We'll
fix it.
Regards,
Sergei
_
likely(apc_target->have_apc_requests()))
> +{
> + if (thd == current_thd)
> +apc_target->process_apc_requests();
> +}
> return THD_IS_NOT_KILLED;
> + }
Why did you put process_apc_requests() under thd->killed == NOT_KILLED ?
>return thd-&
. Create a variant of Sql_alloc (say, Sql_alloc_explicit, a
parent of Sql_alloc) that does not use current_thd but requires MEM_ROOT
to be specified explicitly. And use it for classes where you want it.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-devel
ossible
> - remnants of status_change() moved to sql_profile.h so it can be inlined
>
> PROFILING::status_change() overhead dropped 0.1% -> out of radar.
ok to push
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
inter whenever it is needed.
>
> Number of sql_alloc() calls reduced 345 -> 41 per OLTP RO transaction.
> pthread_getspecific() overhead dropped 0.76 -> 0.59
> sql_alloc() overhed dropped 0.25 -> 0.06
ok to push
Regards,
Sergei
e push 10 MDL requests instead of one.
Which may be fine, if MDL subsystem places only one lock in this case
(iirc, it does). But what is cheaper - collapse identical schemas into
one mdl request here (with Hash_set) or let mdl sort it out later?
> mdl_requests.push_front(&table->
> > Which may be fine, if MDL subsystem places only one lock in this
> > case (iirc, it does). But what is cheaper - collapse identical
> > schemas into one mdl request here (with Hash_set) or let mdl sort it
> > out later?
> MDL doesn't eliminate them, but rather c
nfo(THD *thd_arg,
> TABLE_LIST *tables, Item *cond
>DBUG_RETURN(0);
> }
> +
> +
> +void PROFILING::reset()
> +{
> + enabled= thd->variables.option_bits & OPTION_PROFILING;
> +}
Why is this not inlined?
Regards,
Sergei
and() overhead didn't increase.
Sure, why would it increase?
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
isn't, why are you eliminating Hash_set?
> Because Hash_set was created for DML too. :(
I see.
I believe it's rather unusual to have DDL that involves many tables,
so fine, ok to push.
Regards,
Sergei
___
Mailing list: https://launchp
sync plugin, if it uses current_thd, then
it can also use it for thd_killed().
But if you'll require thd_killed() always to take THD as an argument,
then other plugins (that work strictly within plugin api limits)
won't be able to check kil
t;
> Which one do you like most?
"on demand" one. Let's go with your patch. But add a comment (near
DBUG_ASSERT(thd) or in the function comment) that if we'll get a use
case where a plugin needs to call thd_killed and where it has no thd
availab
t;rotate_state.active_threads--;
> + /* Remember that we can try to rotate tablespaces with
> + FIL_SPACE_ENCRYPTION_OFF and we might want to scrub them
> + also. */
Do you mean that when rotating FIL_SPACE_ENCRYPTION_OFF spaces
crypt_data->rotate_state.active_threads
Hi, Vicențiu!
On May 17, Vicențiu Ciorbaru wrote:
> Hi Sergei!
>
> I've done some work on this issue. I've read MySQL's implementation of this
> and have looked at our implementation. They have done a bit of refactoring,
> introducing an enforce_ssl flag, as well
Hi, Sergey!
On May 27, Sergey Vojtovich wrote:
> On Tue, May 26, 2015 at 03:37:36PM +0200, s...@mariadb.org wrote:
> > revision-id: 8a595a9825de286ad073f6f043db4c0dce88a2ea
> > parent(s): 3e55ef26d49a900782d2c2bb2c03470faed6ec9d
> > committer: Sergei Golubchik
> > branc
Hi, Sergey!
On May 27, Sergey Vojtovich wrote:
> Hi Sergei,
>
> looks good. Ok to push, a few minor suggestions inline.
>
> > diff --git a/storage/maria/ma_check.c b/storage/maria/ma_check.c
> > index 8c012d2..d50528e 100644
> > --- a/storage/maria/ma_check.c
>
Hi, Sergey!
On May 27, Sergey Vojtovich wrote:
> Hi Sergei,
>
> my concern was that we do if (!rep_quick) twice in a very short distance.
> Anyway, this was just a minor wish. Final decision is up to you.
I've already fixed it.
Regards,
Sergei
> > > Why
Hi, Sergey!
On May 27, Sergey Vojtovich wrote:
> Hi Sergei,
>
> I'm lost now. In Aria you did change very similar code and kept
> init_io_cache(-1) while init_io_cache(info->dfile) was moved down
> and replaced with init_io_cache(new_file). This sounds reasonable.
>
DEV-8202 - st_select_lex::master_unit() takes 0.17% in OLTP RO
>
> To make st_select_lex::master_unit() inlinable:
> - moved it's definition to sql_lex.h
> - removed base class virtual master_unit() declaration since this method is
> specific t
when PFS is on).
I'm not sure about it. P_S will be used more and more over time, let's
not intentionally penalize it.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchp
max_statement_time);
}
So, I'd think that reset_query_timer() could look like
void reset_query_timer()
{
if (spcont || in_sub_stmt || slave_thread)
return;
if (!query_timer.expired)
thr_timer_end(&query_timer);
}
Regards,
Sergei
precated),
> qr(WSREP: --wsrep-casual-reads=ON takes precedence over
> --wsrep-sync-wait=0),
> + qr|WSREP: access file\(gvwstate.dat\) failed\(No such file or
> directory\)|,
why?
> );
>
> diff --git a/sql/mysqld.cc b/sql/mysqld.cc
> index 14d904b..49a639b 100644
let me know if you still don't like this so that I can push at least part
> of this patch that we agreed upon.
Yes, please push that.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@li
Log Time not consistent with InnoDB errors nor with MySQL error
> log time format
Ok to push
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad
+ pthread_detach_this_thread();
> +
>for(;;) /* iterations of checkpoints and dirty page flushing */
>{
How does that help? What was wrong with pthread_detach()?
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-de
us.
> If so, would you like me to report and fix it before mdev-7824?
No, certainly not before mdev-7824. And may be not at all. I don't care
much. It's apparently not a bug. It could be a new minor feature. But as
nobody ever wanted it, I wouldn't bother.
Regards,
Serg
Hi, Sergey!
On Jun 02, Sergey Vojtovich wrote:
> Hi Sergei,
>
> ok to push. Should we always prefer "static inline" over macroses?
I generally prefer static inline functions to macros and only use macros
when a function cannot do the job (which is still pretty often :)
Hi, Alexander!
Okay, I agree.
Regards,
Sergei
On Jun 02, Alexander Barkov wrote:
> Hi Sergei,
>
> Can we move these bugs from 10.0 to 10.1:
>
> (MDEV-8167) XOR returns bad results for an indexed column
> (MDEV-6973) XOR aggregates argument collations
>
> ?
>
>
Hi, Alexander!
MDEV-6691 seems to be unrelated. What bug did you mean?
Regards,
Sergei
On Jun 02, Alexander Barkov wrote:
> Hi Sergei,
>
> I suggest to move MDEV-6691 to 10.1:
>
> Reasons:
>
> 1. It will be easier to fix it on top of:
>
> MDEV-6991 GROUP_MIN_MAX
Hi, Alexander!
On Jun 02, Alexander Barkov wrote:
> Hi Sergei,
>
> I suggest to move MDEV-6691 to 10.1:
>
> Reasons:
>
> 1. It will be easier to fix it on top of:
>MDEV-6991 GROUP_MIN_MAX optimization is erroneously applied in some
>cases
>So fixing be
instead of a
abbreviation?
Perhaps it'd be safer to filter out all timezones with extra-long
"abbreviations"?
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
07 - ALTER VIEW does not change ALGORITM
>
> Fixed that ALTER VIEW ALGORITHM=UNDEFINED behaved as if algorithm was not
> specified.
ok to push, thanks!
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : mar
Hi, Sergey!
On Jun 03, Sergey Vojtovich wrote:
> Hi Sergei,
>
> speaking of IANA time zone database, there seem to be no other long
> abbreviations:
>
> But as we can see TZ if permits abbreviations longer than 8 characters (while
> MariaDB/MySQL doesn't). In theory
Hi, Alexander!
On Jun 04, Alexander Barkov wrote:
> Hi Sergei,
>
> Please review a joint patch for:
>
> MDEV-7269 mysqlbinlog Don't know how to handle column type=0 meta=0 ()#
>
> MDEV-8267 Add /*old*/ comment into I_S.COLUMN_TYPE for old DECIMAL
Ok to push!
How
in CAST.
> + {
> +args[1]->print(str, query_type);
> +return;
> + }
> +
>/* see create_func_dyncol_get */
>DBUG_ASSERT(str->length() >= 5);
>DBUG_ASSERT(strncmp(str->ptr() + str->length() - 5, "cast(", 5) == 0);
R
Hi, Alexander!
On Jun 04, Alexander Barkov wrote:
> On 06/04/2015 06:20 PM, Sergei Golubchik wrote:
> > On Jun 04, Alexander Barkov wrote:
> >>
> >> Please review a joint patch for:
> >>
> >> MDEV-7269 mysqlbinlog Don't know how to handle column t
up with
> something more solid.
What Item_dyncol_get is doing with cast is already a hack.
I'd rather fix that, but we cannot do it in 5.5.
Let's keep your fix, but please mention in the comment that this happens
(str.length() == 0) when called from wrong_precision_error(), fro
list
does not work on MariaDB at the moment.
You can still work on that feature and you can of course ask and expect
help in everything MariaDB related. But there's nobody in charge who
could help you with MMC and WMI.
Regards,
Sergei
___
Mailing
nd_ok_packet
the first method will have everything of the current
select_insert::send_eof but without ::my_ok part.
Then select_insert::send_eof() will be just
bool select_insert::send_eof()
{
return prepare_eof() || send_ok_packet();
}
and select_create::send_eof() wi
s, please, in this case you can wait for the query to
complete before opening a new connection.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
of
| > select_insert::send_ok_packet
| < select_insert::send_ok_packet
< select_insert::send_eof
So, either write like
bool res= prepare_eof() || send_ok_packet();
DBUG_RETURN(res);
or fix DBUG_RETURN() macro. Whatever you prefer :)
Otherwise the patch is ok.
Regards,
Hi, Alexander!
On Jun 09, Alexander Barkov wrote:
> Hi Sergei,
>
> Please review a patch for mdev-7268.
Ok to push, of course.
Thanks!
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-d
fully
> initialized. Accessing such variables concurrently may reference uninitialized
> memory, specifically sys_var_pluginvar::plugin.
>
> Fixed by initializing sys_var_pluginvar::plugin early, before variable is
> registered.
ok to push!
Regards,
Sergei
0 - Valgrind warnings on OPTIMIZE MyISAM or Aria TABLE with disabled
> keys
>
> Fixed that OPTIMIZE TABLE against MyISAM/Aria table may write uninitialized
> key
> root position for disabled keys.
ok to push, thanks!
Regards,
Sergei
evaluation).
Good, you cannot know if your API is useful, unless you actually try to
use it (by writing few table function examples).
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.l
e" type, you always *must*
cast it to something. If strict mode won't turn these warnings into
errors, there will be no way to do that. Normally you add a cast to
insert with warnings and remove a cast to let strict mode turn warnings
into errors (here I assume the case
t; }
>}
>delete file;
May be you'd rather fix it in the caller? Let's state that the first
argument of mysql_rename_table() can never be NULL.
While mysql_rename_table() is called in many places, the only place
where it can actually get a NULL hton is sql_rename.cc, if
ha_t
that, there will be no way to catch conversion
> > warnings in dynamic columns. Unless you introduce STRICT_DYNAMIC_COLUMNS
> > mode :)
>
> Does this mean that we should also introduce STRICT_CAST,
> STRICT_OPERATORS for the things like:
>
> SELECT CAST(''
TIME_INVALID_DATES, was_cut) < 0)
return -1;
-ltime->year= ltime->month= ltime->day= 0;
-ltime->time_type= MYSQL_TIMESTAMP_TIME;
-*was_cut= MYSQL_TIME_NOTE_TRUNCATED;
return 0;
}
The only test that changed results was type_ti
val elements immutable. That would be
preferred, of course, but I'm not sure it's possible.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe :
t(mysql)) ||
> + !(row= mysql_fetch_row(res)))
> +{
> + fprintf(stderr, "Warning: Couldn't determine if table %s has a "
> +"primary key (%s). "
> + "--innodb-optimize-keys may work inefficiently.\n",
> +
patterns[]=
{
{ '-mm-dd' , parse_date },
{ 'hh:mm:ss.uu', parse_time },
...
}
Note, I wrote "like". I do not mean literally these patterns or string
patterns whatsoever. I'd prefer something much faster. May be some
compact &qu
ng something reasonable might be not very
easy. And it's a corner case anyway.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
oxy doesn't have it, as far as I
understand.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
s?
It would be a pity if you'll work very hard and in August we'll find
that we cannot use any of that because of some small mistake that you
did in June and that all your later code depends on. It would be better
for me to look cont
pen_table 0.21% -> 0.18%
> close_thread_table 0.05% -> 0.05%
Really? I don't believe it. handler::rebind_psi() and
handler::unbind_psi() are empty methods, not doing anything. There's
only a cost a virtual function call. And you'r
oesn't make any sense, it's a big,
complex, and expensive function. One current_thd doesn't change
anything.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
U
t; unow ? unow - utime : 0;
1.
Please add an assert here that utime<=unow. It uses
microsecond_interval_timer(), which is supposed to be strictly
increasing (unlike my_hrtime()).
2.
You might need to update mysqld_list_processes() too.
>table->field[5]->store(utime / HRTIME_
h no our
binaries use.
But you can push it if you want.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
Hi, Sergey!
On Jun 18, Sergey Vojtovich wrote:
> On Thu, Jun 18, 2015 at 12:06:30PM +0200, Sergei Golubchik wrote:
> > On Jun 17, s...@mariadb.org wrote:
> > > revision-id: 2e08ec24623e0b3d3db02333e16658dcfaa0535c
> > > parent(s): b776f8d3a8afff55d5f8208da7bdfce9aa33e
43 - pthread_getspecific() takes 0.76% in OLTP RO
>
> Pass THD to Item_field (and all derivatives) constructors.
> This reduces number of pthread_getspecific() calls from 322 to 292.
ok to push
Regards,
Sergei
___
Mailing list: https://launch
56: Assertion failure in file log0crypt.cc line 220 on server restart
>
> Instead of asserting print informative error message to error log
> and return failure from innodb_init causing the server to shutdown.
A test case would've been nice
Regards,
Sergei
__
Hi, Alexander!
On May 25, Alexander Barkov wrote:
>Hi Sergei,
>
> For simplicity I decided to split:
>
> MDEV-8036 Fix all collations to compare broken bytes as "greater than
> any non-broken character"
>
> into sub-tasks.
>
> Please review a pa
MDEV-7528 GIS: Functions return NULL instead of specified -1 for NULL
> arguments.
> The behaviour required by the standard seems too weird to expect.
If the function can never return NULL, please set maybe_null
accordingly.
Regards,
Sergei
_
ues in
> +
> + @return
> +@retval false Success.
> +@retval true Failure.
> +*/
> +
> +bool TABLE::validate_default_values_of_unset_fields(THD *thd) const
> +{
> + DBUG_ENTER("TABLE::validate_default_values_of_unset_fields");
please, add
DBUG_ASSERT(!thd->is_error());
here, because you're relying on it later to detect errors.
> + for (Field **fld= field; *fld; fld++)
> + {
> +if (!bitmap_is_set(write_set, (*fld)->field_index) &&
> +!((*fld)->flags & NO_DEFAULT_VALUE_FLAG))
> +{
> + if (!(*fld)->is_null_in_record(s->default_values) &&
> + (*fld)->validate_value_in_record_with_warn(thd, s->default_values)
> &&
> + thd->is_error())
> +DBUG_RETURN(true); // strict mode converted WARN to ERROR
> +}
> + }
> + DBUG_RETURN(false);
> +}
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
ight of an illegal byte.
> >> + Must be greater than weight of any normal character.
> >> + Two bad bytes are compared binary.
> >> +*/
> >> +#ifndef WEIGHT_ILSEQ
> >> +#define WEIGHT_ILSEQ(x) (0xFF00 + (x))
> >
> > why #ifndef? it cre
table_plugin) : NULL;
Please, no. Global variable should not be used like that, it simply sets
a default value for the session variable for new connections.
The way you've done it now, one cannot disable enforced_table_plugin per
session at all.
>bool no_substitution= thd-
/* Non instrumented code */
> -socket_accept.fd= accept(socket_listen.fd, addr, &addr_length);
> +socket_accept.fd= accept4(socket_listen.fd, addr, &addr_length,
> + SOCK_CLOEXEC);
>}
Regards,
Sergei
mit now and, luckily, MDEV-7631 has all the
information about this issue.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-develope
Hi, Alexander!
On Jun 25, Alexander Barkov wrote:
> Hi Sergei,
>
> >> diff --git a/sql/field_conv.cc b/sql/field_conv.cc
> >> index e31f7c5..14f2947 100644
> >> --- a/sql/field_conv.cc
> >> +++ b/sql/field_conv.cc
> >> @@ -859,7 +859,8
; into a new shared file mysql-test/include/type_temporal_zero_default.inc
>
> Does git citool support partial commit in such case?
> I.e. if I want to add a part of a new file in the first commit, and then
> add the rest of the new file in the second commit?
Yes.
ok to push
Rega
: enforce_storage_engine cannot be set globally
>
> Change session only variable enforce_storage_engine to be
> session variable and make sure that also global value
> is used if session variable is not set.
Ok to push, thanks!
Regards,
Sergei
___
les
> directly.
ok to push
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
Hi, Alexander!
On Jul 08, Alexander Barkov wrote:
>Hi Sergei,
>
> Please review my patch for mdev-8372.
> I found only a few places to reuse the new methods.
>
> Also, had to add some more helper methods to make
> the code clearer.
>
> Thanks.
>
> diff --
Hi, Alexander!
On Jul 13, Alexander Barkov wrote:
> Hi Sergei,
>
> Please review a patch that merges a new read-only variables
> --explicit-defaults-for-timestamp from MySQL.
>
> Note, the original MySQL patch updates many tests,
> to make the tests independent from th
inction between basic and functional tests will
start to disappear now, as we no longer create obligatory basic tests
for every new variable. So, it's ok not to rename.
> Okey to push after rename?
No, sorry, I haven't checked the patch yet, I only replied to this your
email.
Regards,
- Wrong error message on attempt to kill somebody else's query ID
>
> Attempting to kill query owned by different user now returns better error:
> "You are not owner of query N" instead of "You are not owner of thread N".
Ok to push!
Nice test.
Regards,
Serge
997 - MySQL bug#11759114 - '51401: GRANT TREATS NONEXISTENT
> FUNCTIONS/PRIVILEGES DIFFERENTLY'
ok to push
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsub
u want with it (it = the code inside #ifdef MAIN ... #endif)
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
Hi, Alexander!
On Jul 24, Alexander Barkov wrote:
> Hi Sergei,
>
> Sorry for delay, I was busy with 10.1 issues.
That's perfectly fine. And even good - there's little sense to spend
time on 10.0 bugs when the next release in line is 10.1.
> Thanks for review. A new patch
7;s definer cannot:
--connection default
CREATE DEFINER=user@localhost SQL SECURITY DEFINER VIEW v1_baddefiner AS
SELECT * FROM t1;
--error ER_ACCESS_DENIED_ERROR
SELECT * FROM v1_baddefiner;
See the commit mail with the complete patch.
Regards,
Sergei
IF EXISTS p1;
> CREATE PROCEDURE p1() SQL SECURITY DEFINER
>CREATE TABLE t1 (a INT) ENGINE=CONNECT TABLE_TYPE=fix FILE_NAME='t1.fix';
>
> # Run this as a user with no FILE_ACL
> CALL p1();
>
> and it also worked as expected, CALL p1() succeeded.
>
> The pa
quot;Initializinig plugins specified by command
> line");
"Initializinig plugins specified on the command line"
> while (NULL != (item= iter++))
>plugin_load_list(&tmp_root, item->ptr);
>
> if (!(flags & PLUGIN_INIT_SKIP_PLUGIN_TABLE))
> +
p of the server, there's no protection
against it in the plugin api. nor against loading plugins into a debug
server. or other stuff like that.
but as far as galera is concerned, the issue will go away in 10.1, so I
think we'll just wait and we'll be fine :)
Regards,
Sergei
__
#x27;ve put "Initializing optional plugins".
> > Actually, a better message would be "Initializing other built-in plugins"
> > or " Initializing remaining built-in plugins".
> Sorry, I missed this. But do we need to distinguish between mandatory and
> optional built-ins? May be change "Initializing mandatory plugins" with
> "Initializing built-in plugins"?
That's fine too. I was only saying that not all built-in plugins are
mandatory.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
d)
2. Add a test case with row items
3. In your test case - if you remove GROUP BY you get a crash again.
This might be a different bug, though.
Regards,
Sergei
diff --git a/sql/item_subselect.cc b/sql/item_subselect.cc
index e04f5ff..5aa5b6f 100644
--- a/sql/item_subselect.cc
+++ b/sql/item_sub
_cache::get_cache(*ref0
> DBUG_RETURN(1);
>if (args[0] != (*ref0))
> -current_thd->change_item_tree(args, (*ref0));
> +args[0]= (*ref0);
>DBUG_PRINT("info", ("actual fix fields"));
Regards,
Sergei
___
Mail
Hi, Oleksandr!
On Aug 05, Oleksandr Byelkin wrote:
> On 12.06.15 13:09, Sergei Golubchik wrote:
> > Hi, Sanja!
> >
> > On May 06, sa...@mariadb.com wrote:
> >> revision-id: 3eceb51e697d5a514e70c374a06e7eef6b5a37a0
> >> parent(s): aa5095627e2619bdad7916d33d1
2-bit or 64-bit MAX
UNSIGNED>/;
Then in every sysvar*.test file you can do, like
--source sysvar32bitrepl
--replace_regex $replace_regexes
select * from information_schema.system_variables
where variable_name in (list of ulong variables);
Regards,
Sergei
___
;}
> - if (var->type != OPT_GLOBAL &&
> - global_system_variables.query_cache_type == 0 &&
> - var->value->val_int() != 0)
> +
> + if (var->type != OPT_GLOBAL && global_system_variables.query_cache_type ==
> 0)
>{
> -my_error(ER_QUERY_CACHE_IS_GLOBALY_DISABLED, MYF(0));
> -return true;
> - }
> +uint value= 0 /*default is off*/;
> +if (var->value)
> +{
> + if (var->value->result_type() == INT_RESULT)
> +value= var->value->val_int();
> + else
> + {
> +char buff[STRING_BUFFER_USUAL_SIZE];
> +String str(buff, sizeof(buff), system_charset_info), *res;
> +if (!(res=var->value->val_str(&str)))
> + return true;
> +if (res->length() != 3 ||
> +my_toupper(res->charset(), res->ptr()[0]) != 'O' ||
> +my_toupper(res->charset(), res->ptr()[1]) != 'F' ||
> +my_toupper(res->charset(), res->ptr()[2]) != 'F')
eh? query_cache_type is ENUM variable, there is no need to compare
string values manually.
> + value= 1; // set to something not 0
> + }
> +}
>
> +if (value != 0)
> +{
> + my_error(ER_QUERY_CACHE_IS_GLOBALY_DISABLED, MYF(0));
> + return true;
> +}
> + }
>return false;
> }
> +
> +
> static bool fix_query_cache_type(sys_var *self, THD *thd, enum_var_type type)
> {
>if (type != OPT_GLOBAL)
> diff --git a/unittest/mysys/CMakeLists.txt b/unittest/mysys/CMakeLists.txt
> index 8c09a46..6564e09 100644
> --- a/unittest/mysys/CMakeLists.txt
> +++ b/unittest/mysys/CMakeLists.txt
> @@ -13,7 +13,7 @@
> # along with this program; if not, write to the Free Software
> # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
>
> -MY_ADD_TESTS(bitmap base64 my_vsnprintf my_atomic my_rdtsc lf my_malloc
> +MY_ADD_TESTS(bitmap base64 my_vsnprintf my_atomic my_rdtsc lf my_malloc
> my_getopt
Ah, that's great, thanks!
Long overdue.
> LINK_LIBRARIES mysys)
>
> MY_ADD_TESTS(ma_dyncol
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
t; >> + if (var->value->result_type() == INT_RESULT)
> >> +value= var->value->val_int();
> >> + else
> >> + {
> >> +char buff[STRING_BUFFER_USUAL_SIZE];
> >> +String str(buff, sizeof(buff), system_char
review
> process.)
Don't worry about that.
I've configured buildbot to pull changes from your
https://github.com/f4rnham/server fork instead.
So you can continue pushing to your forked repository.
You just need to name your branches to start from "bb-" as Kristian
said, if you want
until 10.0 is the next release.
The release schedule is also in jira.
Regards,
Sergei
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria
Hi, Alangi!
On Aug 21, Alangi Derick wrote:
> >The release schedule is also in jira.
> A link will really help here. I will like to see the schedules.
Sure. mariadb.org/jira :)
Seriously, the roadmap is on the front page.
Regard
release, whatever". This usually goes into
<>...<>.
> 4. How should I prepare the pull request? Should I rebase my branch on
> the top of current branch before that?
That would be good, yes. Although first someone will review the pull
request, and only after it'
1101 - 1200 of 1983 matches
Mail list logo
