Re: [Maria-developers] 39e20ca7e28: MDEV-29748 ASAN errors or server crash in File_parser::parse upon concurrent view operations

Hi, Sergei! On Thu, Oct 20, 2022 at 6:23 PM Sergei Golubchik wrote: > Hi, Oleksandr, > > On Oct 19, Oleksandr Byelkin wrote: > > On Wed, Oct 19, 2022 at 5:09 PM Sergei Golubchik > wrote: > > > On Oct 19, Oleksandr Byelkin wrote: > > > > >

Re: [Maria-developers] 39e20ca7e28: MDEV-29748 ASAN errors or server crash in File_parser::parse upon concurrent view operations

Hi, Sergei! On Wed, Oct 19, 2022 at 5:09 PM Sergei Golubchik wrote: > Hi, Oleksandr, > > Looks good. > Just one question below: > > On Oct 19, Oleksandr Byelkin wrote: > > revision-id: 39e20ca7e28 (mariadb-10.3.36-107-g39e20ca7e28) > > parent(s): d6707ab11f6

Re: [Maria-developers] 5265f7001c6: MDEV-17124: mariadb 10.1.34, views and prepared statements: ERROR 1615 (HY000): Prepared statement needs to be re-prepared

The check of triggers (if present) need only if definition did not changed. Before the check need all that if would be just "return true". Sergei Golubchik schrieb am Mi., 28. Sept. 2022, 19:15: > Hi, Oleksandr, > > On Sep 28, Oleksandr Byelkin wrote: >

Re: [Maria-developers] 5265f7001c6: MDEV-17124: mariadb 10.1.34, views and prepared statements: ERROR 1615 (HY000): Prepared statement needs to be re-prepared

Hi, Sergei! On Tue, Sep 27, 2022 at 2:36 PM Sergei Golubchik wrote: > Hi, Oleksandr, > > Few minor comments, see below > > On Sep 27, Oleksandr Byelkin wrote: > > revision-id: 5265f7001c6 (mariadb-10.3.36-60-g5265f7001c6) > > parent(s): 86953d3df0a > > author

Re: [Maria-developers] 349283c5e7a: MDEV-17124: mariadb 10.1.34, views and prepared statements: ERROR 1615 (HY000): Prepared statement needs to be re-prepared

Hi! Fixed. On Thu, Jan 27, 2022 at 9:15 PM Sergei Golubchik wrote: > Hi, Oleksandr, > > On Jan 27, Oleksandr Byelkin wrote: > > commit 349283c5e7a > > Author: Oleksandr Byelkin > > Date: Wed Apr 17 15:50:59 2019 +0200 > > > > MDEV-17124: mariadb

Re: [Maria-developers] 349283c5e7a: MDEV-17124: mariadb 10.1.34, views and prepared statements: ERROR 1615 (HY000): Prepared statement needs to be re-prepared

Hi! Sergei Golubchik schrieb am Mo., 26. Sept. 2022, 21:20: > Hi, Oleksandr, > > On Sep 26, Oleksandr Byelkin wrote: > > > >LEX_STRING name; /* name for named prepared statements */ > > > >LEX *lex; // parse tree

Re: [Maria-developers] 349283c5e7a: MDEV-17124: mariadb 10.1.34, views and prepared statements: ERROR 1615 (HY000): Prepared statement needs to be re-prepared

Hi! On Thu, Jan 27, 2022 at 9:15 PM Sergei Golubchik wrote: > Hi, Oleksandr, > > On Jan 27, Oleksandr Byelkin wrote: > > commit 349283c5e7a > > Author: Oleksandr Byelkin > > Date: Wed Apr 17 15:50:59 2019 +0200 > > > > MDEV-17124: mariadb 10.1.34

Re: [Maria-developers] fcf2c5fff14: MDEV-26299: Some views force server (and mysqldump) to generate invalid SQL for their definitions

Hi! Sergei Golubchik schrieb am Sa., 16. Okt. 2021, 10:23: > Hi, Oleksandr! > > On Oct 16, Oleksandr Byelkin wrote: > > revision-id: fcf2c5fff14 (mariadb-10.2.40-78-gfcf2c5fff14) > > parent(s): d5a15f04f4a > > author: Oleksandr Byelkin > > committer: Oleksandr

Re: [Maria-developers] ca4ef7185da: MDEV-9245 password "reuse prevention" validation plugin

Hi, Serg On Tue, Sep 7, 2021 at 7:22 PM Sergei Golubchik wrote: > Hi, Oleksandr! > > you forgot to check in the result file > > On Sep 07, Oleksandr Byelkin wrote: > > revision-id: ca4ef7185da (mariadb-10.6.1-79-gca4ef7185da) > > parent(s): 271afbc88e4 &g

Re: [Maria-developers] 27060eb6ba5: MDEV-21916: COM_STMT_BULK_EXECUTE with RETURNING insert wrong values

Hi Sergei! On Mon, Oct 12, 2020 at 5:36 PM Sergei Golubchik wrote: > Hi, Oleksandr! > > On Oct 12, Oleksandr Byelkin wrote: > > revision-id: 27060eb6ba5 (mariadb-10.5.4-220-g27060eb6ba5) > > parent(s): 861cd4ce286 > > author: Oleksandr Byelkin > > committer:

Re: [Maria-developers] 2792940391a: MDEV-23327 Can't uninstall UDF if the implementation library file doesn't exist

HI, Sergei! On Sat, Oct 10, 2020 at 11:16 PM Sergei Golubchik wrote: > Hi, Oleksandr! > > Mostly ok, one problem below: > > On Oct 10, Oleksandr Byelkin wrote: > > revision-id: 2792940391a (mariadb-10.2.31-343-g2792940391a) > > parent(s): 2107e3bb9c0 > > author:

Re: [Maria-developers] 6f211b1f01b: MDEV-23518 Syntax error in ond SP results in misleading message on SHOW CREATE PROCEDURE

Hi, Sergei! On Thu, Oct 1, 2020 at 7:23 PM Sergei Golubchik wrote: > Hi, Oleksandr! > > On Oct 01, Oleksandr Byelkin wrote: > > revision-id: 6f211b1f01b (mariadb-10.4.11-369-g6f211b1f01b) > > parent(s): 571764c04fc > > author: Oleksandr Byelkin > > committer:

Re: [Maria-developers] f854ac4d9e0: MDEV-21916: COM_STMT_BULK_EXECUTE with RETURNING insert wrong values

HI, Sergei! On Wed, Jul 29, 2020 at 7:47 PM Sergei Golubchik wrote: > Hi, Oleksandr! > > On Jul 29, Oleksandr Byelkin wrote: > > revision-id: f854ac4d9e0 (mariadb-10.5.4-20-gf854ac4d9e0) > > parent(s): 6cee9b1953b > > author: Oleksandr Byelkin > > committer:

Re: [Maria-developers] 7311586ca25: MDEV-15703 Crash in EXECUTE IMMEDIATE 'CREATE OR REPLACE TABLE t1 (a INT DEFAULT ?)' USING DEFAULT

Hi! On Wed, Jul 29, 2020 at 2:39 PM Sergei Golubchik wrote: > Hi, Oleksandr! > > On Jul 29, Oleksandr Byelkin wrote: > > revision-id: 7311586ca25 (mariadb-10.2.31-317-g7311586ca25) > > parent(s): a1e52e7f32c > > author: Oleksandr Byelkin > > committer: Oleksand

Re: [Maria-developers] Regarding GSoc :ADD FULL OUTER JOIN

ing the swapping of table (similar to right join in this part  ;(line no. 11992-12030))     the result of this will be stored in another temporary table ->tab2 3.Union all clause:     implementation of union all clause to combine tab1 and tab2. So , Oleksandr Byelkin sir replied to me that , ad

Re: [Maria-developers] Regarding GSoc :ADD FULL OUTER JOIN

Hi, Jeeukrishnan! Am 21.03.20 um 15:05 schrieb Jeeukrishnan Kayshyap.: Hi  , I studied the join_table part of sql_yacc.yy and the the convert_right_join() part from sql_parse.cc . Sir to add the full outer join : if we add a /*Full outer join variant */ , where first we will do  left outer

Re: [Maria-developers] 4c263b6d30b: MDEV-20632: Recursive CTE cycle detection using CYCLE clause

Am 26.02.20 um 22:15 schrieb Sergei Golubchik: Hi, Oleksandr! On Feb 26, Oleksandr Byelkin wrote: On Wed, Feb 26, 2020 at 1:44 PM Sergei Golubchik wrote: Hi, Sanja! _some_ comments are below. The main thing, I still don't understand your changes in sql_select.cc. Why did you create

Re: [Maria-developers] GSoC: On completing the MDEV-6017 (Add support for Indexes on Expressions)

Hi, Alexey! Am 01.10.19 um 14:29 schrieb Alexey Mogilyovkin: Hello, I would like to finish the task I was working on during GSoC. Nikita told me that there are some architectural questions to my code. Can you tell about them in more detail? Here you can find list of related MDEVs (as well as

Re: [Maria-developers] d7b274fa257: MDEV-16932: ASAN heap-use-after-free in my_charlen_utf8 / my_well_formed_char_length_utf8 on 2nd execution of SP with ALTER trying to add bad CHECK

Am 15.07.19 um 19:21 schrieb Sergei Golubchik: Hi, Oleksandr! A couple of minor comments, see below On Jul 15, Oleksandr Byelkin wrote: revision-id: d7b274fa257 (mariadb-10.2.25-63-gd7b274fa257) parent(s): 64900e3d7c3 author: Oleksandr Byelkin committer: Oleksandr Byelkin timestamp: 2019-07

Re: [Maria-developers] [Commits] bf951046e8d: MDEV-15296: wrong result with window function inside a subquery

Hi, Varun! This bug shows us whole class of the same problem in the code which slip of our scope during window function development. so please check and fix them (one or separate change-set as you wish). See comment below. Am 29.04.19 um 16:40 schrieb Varun: revision-id:

Re: [Maria-developers] 7c782988845: MDEV-16240: Assertion `0' failed in row_sel_convert_mysql_key_to_innobase

Am 13.12.18 um 19:11 schrieb Sergei Golubchik: Hi, Oleksandr! On Dec 13, Oleksandr Byelkin wrote: revision-id: 7c782988845dec9f0f26a539911f66ed8cecdf83 (mariadb-10.2.19-51-g7c782988845) parent(s): ad3346dddf419aed3e5d16066471fd5022af1795 author: Oleksandr Byelkin committer: Oleksandr Byelkin

Re: [Maria-developers] 49b63dcc048: MDEV-15073: Generic UDAF parser code in server for windows functions

Am 21.11.18 um 20:00 schrieb Sergei Golubchik: Hi, Oleksandr! On Nov 21, Oleksandr Byelkin wrote: revision-id: 49b63dcc0482bcb0fc7f642b0c19c8e24740ab27 (mariadb-10.4.0-20-g49b63dcc048) parent(s): b5ac863f1494920b5e7035c9dfa0ebfdaa50a15d author: Oleksandr Byelkin committer: Oleksandr Byelkin

Re: [Maria-developers] 031efde365c: MDEV-16217: Assertion `!table || (!table->read_set || bitmap_is_set(table->read_set, field_index))' failed in Field_num::get_date

Am 13.11.18 um 11:07 schrieb Sergei Golubchik: Hi, Oleksandr! On Nov 13, Oleksandr Byelkin wrote: Am 12.11.18 um 13:24 schrieb Sergei Golubchik: On Nov 07, Oleksandr Byelkin wrote: revision-id: 031efde365c674dbdbaada95aa6d42a4274db438 (mariadb-10.2.18-65-g031efde365c) parent(s

Re: [Maria-developers] 031efde365c: MDEV-16217: Assertion `!table || (!table->read_set || bitmap_is_set(table->read_set, field_index))' failed in Field_num::get_date

Hi! Am 12.11.18 um 13:24 schrieb Sergei Golubchik: Hi, Oleksandr! On Nov 07, Oleksandr Byelkin wrote: revision-id: 031efde365c674dbdbaada95aa6d42a4274db438 (mariadb-10.2.18-65-g031efde365c) parent(s): 89f948c766721a26e110bc9da0ca5ebc20f65112 author: Oleksandr Byelkin committer: Oleksandr

Re: [Maria-developers] cd41d376d41: MDEV-16697: Fix difference between 32bit/windows and 64bit systems in allowed select nest level

or any arbitrary >64 nesting depth. Is this your goal? What feature do you need it for? My thoughts was like this: 1) we need the same length 2) bitmap64 as efficient as ulonglong 3) why not use something more flexible On Nov 06, Oleksandr Byelkin wrote: revision-id: cd41d376d413d066f3d49

Re: [Maria-developers] [Commits] 7fc57734575: MDEV-6439: Server crashes in Explain_union::print_explain with explain in slow log, tis620 charset

Hi! See small comment inline. (fix and OK to push) Am 15.08.2018 um 13:36 schrieb Sergey Petrunia: MDEV-6439: Server crashes in Explain_union::print_explain with explain in slow log, tis620 charset Item_subselect::is_expensive() used to return FALSE (Inexpensive) whenever

Re: [Maria-developers] 6df4e4a855f: MDEV-16217: Assertion `!table || (!table->read_set || bitmap_is_set(table->read_set, field_index))' failed in Field_num::get_date

Hi, Sergei! Am 09.08.2018 um 12:34 schrieb Sergei Golubchik: Hi, Oleksandr! See questions below. There are few changes that I'm not quite sure about. On Aug 08, Oleksandr Byelkin wrote: revision-id: 6df4e4a855fe223988c12681f8caec6c49b2f629 (mariadb-10.2.16-66-g6df4e4a855f) parent(s

Re: [Maria-developers] 980a5c31880: MDEV-14572: Assertion `! is_set()' failed in Diagnostics_area::set_eof_status upon EXPLAIN UPDATE in PS

Hi, Sergei! Am 18.06.2018 um 14:14 schrieb Sergei Golubchik: Hi, Oleksandr! On Jun 11, Oleksandr Byelkin wrote: Am 29.01.2018 um 01:02 schrieb Sergei Golubchik: On Jan 28, Oleksandr Byelkin wrote: Hi, Sergei! Flag in SELECT_LEX options dropped at the end of execution (in our case prepare

Re: [Maria-developers] 46e0c8a9219: MDEV-11071: Assertion `thd->transaction.stmt.is_empty()' failed in Locked_tables_list::unlock_locked_table

Am 14.06.2018 um 14:19 schrieb Sergei Golubchik: Hi, Oleksandr! On Jun 14, Oleksandr Byelkin wrote: Am 14.06.2018 um 11:44 schrieb Sergei Golubchik: On Jun 14, Oleksandr Byelkin wrote: Am 13.06.2018 um 12:08 schrieb Sergei Golubchik: diff --git a/sql/sql_table.cc b/sql/sql_table.cc index

Re: [Maria-developers] 46e0c8a9219: MDEV-11071: Assertion `thd->transaction.stmt.is_empty()' failed in Locked_tables_list::unlock_locked_table

Am 14.06.2018 um 11:44 schrieb Sergei Golubchik: Hi, Oleksandr! On Jun 14, Oleksandr Byelkin wrote: Am 13.06.2018 um 12:08 schrieb Sergei Golubchik: diff --git a/sql/sql_table.cc b/sql/sql_table.cc index 9e7973b745c..f3cb85f01d3 100644 --- a/sql/sql_table.cc +++ b/sql/sql_table.cc @@ -4894,7

Re: [Maria-developers] 46e0c8a9219: MDEV-11071: Assertion `thd->transaction.stmt.is_empty()' failed in Locked_tables_list::unlock_locked_table

Am 13.06.2018 um 12:08 schrieb Sergei Golubchik: Hi, Oleksandr! Looks good, but please see a few comments below. On May 08, Oleksandr Byelkin wrote: revision-id: 46e0c8a921978e7b95adf3f17f3c85b18d9f9ef6 (mariadb-10.2.14-78-g46e0c8a9219) parent(s): 9bcd0f5fea8ca26742b10d37b95a966c69909ff1

Re: [Maria-developers] 980a5c31880: MDEV-14572: Assertion `! is_set()' failed in Diagnostics_area::set_eof_status upon EXPLAIN UPDATE in PS

Am 29.01.2018 um 01:02 schrieb Sergei Golubchik: Hi, Oleksandr! On Jan 28, Oleksandr Byelkin wrote: Hi, Sergei! Flag in SELECT_LEX options dropped at the end of execution (in our case prepare). All commands where EXPLAIN is possible restore the flag in main SELECT_LEX (in mysql_explain_union

Re: [Maria-developers] 346c8ab9533: MDEV-11975: SQLCOM_PREPARE of EXPLAIN & ANALYZE statement do not return correct metadata info

Hi, Sergei! Am 20.04.2018 um 09:29 schrieb Sergei Golubchik: Hi, Oleksandr! On Apr 20, Oleksandr Byelkin wrote: Am 19.04.2018 um 11:31 schrieb Sergei Golubchik: +# cat MYSQL_TMP_DIR/test_explain_meta.out.log +# okay, altought I'd rather add prepare

Re: [Maria-developers] 346c8ab9533: MDEV-11975: SQLCOM_PREPARE of EXPLAIN & ANALYZE statement do not return correct metadata info

Am 19.04.2018 um 11:31 schrieb Sergei Golubchik: Hi, Oleksandr! On Apr 18, Oleksandr Byelkin wrote: revision-id: 346c8ab9533a3de6a4cb348428402ffee2aa8da2 (mariadb-10.3.6-16-g346c8ab9533) parent(s): cff60be7fe159fdcb2517ce8441610ad512aa7d0 author: Oleksandr Byelkin committer: Oleksandr Byelkin

Re: [Maria-developers] Fwd: [Commits] b32031991e4: initial oracle parser fix

Hi, Alexander! Am 10.04.2018 um 15:00 schrieb Alexander Barkov: Hello Sanja, [skip] Can you give an example of a query that is not parsed by the current 10.3 parser, but is parsed in 10.3-MDEV-11953 ? There is mysql-test/main/brackets.test ___

Re: [Maria-developers] Fwd: [Commits] b32031991e4: initial oracle parser fix

Am 10.04.2018 um 10:58 schrieb Alexander Barkov: Hello Sanja, I reviewed your recent changes in "10.3-MDEV-11953" (and the attached additional patch for sql_yacc_ora.yy) I have some proposals: 1. Can you please move huge pieces of the code from sql_yacc.yy to LEX or other relevant

Re: [Maria-developers] [Commits] 4b4267288cb: MDEV-14743: Server crashes in Item_func_match::init_search

so next will be correct) On Jan 10, Oleksandr Byelkin wrote: revision-id: 4b4267288cb2668717cc70537eb7e79cecaff58a (mariadb-5.5.58-24-g4b4267288cb) parent(s): a408e881cf73d06fc92097fce6ef9584e16edf77 author: Oleksandr Byelkin committer: Oleksandr Byelkin timestamp: 2018-01-10 12:22:56 +0100 mess

Re: [Maria-developers] [Commits] fbe0fc2: Fixed mdev-14879 Lost rows for query using recursive CTE

Hi, Igor! Am 06.01.2018 um 18:32 schrieb IgorBabaev: revision-id: fbe0fc2d87cb1bdb9f7040d44ad3c58a94857e20 (mariadb-10.2.12-14-gfbe0fc2) parent(s): 15b1840f43be8c660382458826e9d5a47d148a67 author: Igor Babaev committer: Igor Babaev timestamp: 2018-01-06 09:32:47 -0800 message: Fixed

Re: [Maria-developers] [Commits] de21526: This is a full cost-based implementation of the optimization that employs

Hi, Igor! Am 29.12.2017 um 01:47 schrieb IgorBabaev: revision-id: de215264682a9f3291ca028fb3ae052ecb191ca3 (mariadb-10.3.3-4-gde21526) parent(s): 7a66e0ab8f52f3bd32850463daa05f9a2401e6b1 author: Igor Babaev committer: Igor Babaev timestamp: 2017-12-28 16:47:25 -0800 message: This is a full

Re: [Maria-developers] [Commits] 730a22c: Fixed bug mdev-13453 Executing a query via CTE requires more permissions

Am 14.11.2017 um 01:06 schrieb IgorBabaev: revision-id: 730a22c1ce1010e853e7a3e807d1d07409ec4dfc (mariadb-10.2.10-28-g730a22c) parent(s): 1e2d4f677e08294691a7d218acb3b9f78727ae18 author: Igor Babaev committer: Igor Babaev timestamp: 2017-11-13 16:06:04 -0800 message: Fixed bug mdev-13453

Re: [Maria-developers] 1 Transaction and several threads

that are not needed from table and rebuild them after bulk load. R: Jan On Thu, Aug 3, 2017 at 12:09 PM, Oleksandr Byelkin <sa...@mariadb.com> wrote: I am thinking about efficient inserting in a table using several threads (LOAD), is it possible (and how difficult if it does) to make inserts wit

Re: [Maria-developers] [Commits] 05b678bc8c1: MDEV-12489 The select stmt may fail due to "having clause is ambiguous" unexpected

Hi, Sergei! Am 12.07.2017 um 18:13 schrieb s...@mariadb.org: revision-id: 05b678bc8c166c9015ca3dc3ccd9e9c89094f3ca (mariadb-5.5.56-42-g05b678bc8c1) parent(s): c83d6ff881dcfd1cc68124a9663c2a31ca7e2dce author: Sergei Golubchik committer: Sergei Golubchik timestamp: 2017-07-12 17:46:19 +0200

Re: [Maria-developers] [Commits] be55bbc2b20: MDEV-7826 Server crashes in Item_subselect::enumerate_field_refs_processor

Hi, Sergei! Am 12.07.2017 um 12:49 schrieb s...@mariadb.org: revision-id: be55bbc2b206f2fe295ad4179b23791c3119fe02 (mariadb-5.5.56-39-gbe55bbc2b20) parent(s): c5975eaea174460e774e77717e972a8d32e6c8de author: Sergei Golubchik committer: Sergei Golubchik timestamp: 2017-07-12 12:49:29 +0200

Re: [Maria-developers] [Commits] c5975eaea17: MDEV-7339 Server crashes in Item_func_trig_cond::val_int

Hi! Am 12.07.2017 um 10:39 schrieb s...@mariadb.org: revision-id: c5975eaea174460e774e77717e972a8d32e6c8de (mariadb-5.5.56-38-gc5975eaea17) parent(s): f305a7ce4bccbd56520d874e1d81a4f29bc17a96 author: Sergei Golubchik committer: Sergei Golubchik timestamp: 2017-07-12 10:39:02 +0200 message:

Re: [Maria-developers] [Commits] 2d6649aa24c: MDEV-13186: main.win failure post MDEV-12336

Hi, Vicentiu! Am 27.06.2017 um 11:31 schrieb vicentiu: revision-id: 2d6649aa24c77321df349de5cee576dab1e344f4 (mariadb-10.2.6-55-g2d6649aa24c) parent(s): c036d5ada7a5816d25915a2c6e0b6836b0cd6743 author: Vicențiu Ciorbaru committer: Vicențiu Ciorbaru timestamp: 2017-06-27 12:26:38 +0300 message:

Re: [Maria-developers] [Commits] 01b2bb79bb78e42108e32af02f1418a660ca861d Fixed the bug mdev-13064.

Hi, Igor! Am 15.06.2017 um 23:43 schrieb Igor Babaev: commit 01b2bb79bb78e42108e32af02f1418a660ca861d Author: Igor Babaev Commit: Igor Babaev Fixed the bug mdev-13064. This is another attempt to fix the bug mdev-12992. This patch

Re: [Maria-developers] MDEV-9217 Split Item::tmp_table_field_from_field_type() into virtual methods in Type_handler

Hi, Alexander! Am 23.04.2017 um 22:39 schrieb Alexander Barkov: Hello Sanja, Monty has pushed his patch changing Item::name and Field::field_name to LEX_CSTRING. I have adjusted my patch accordingly. On 04/21/2017 11:33 PM, Alexander Barkov wrote: Hello Sanja, I wrote extended commit

Re: [Maria-developers] [External] Re: 23959479689: MDEV-11419: Report all INSERT ID for bulk operation INSERT

Hi, Jean-Francois! Am 14.03.2017 um 20:31 schrieb Jean-Francois B. Gagne: Hi Sergei and Oleksandr, if we implement this (MDEV-11419: Report all INSERT ID for bulk operation INSERT), does this mean that we could allow innodb_autoinc_lock_mode=2 and still be safe for SBR ? [1]:

Re: [Maria-developers] 23959479689: MDEV-11419: Report all INSERT ID for bulk operation INSERT

Hi, Sergei! Here is better answer (I had time to dig in the sources) Am 14.03.2017 um 12:27 schrieb Sergei Golubchik: Hi, Oleksandr! On Jan 17, Oleksandr Byelkin wrote: revision-id: 23959479689f47bdfe5aa33cb6cd5e1171b5f8a8 (mariadb-10.2.2-128-g23959479689) parent(s

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

Am 01.03.2017 um 15:04 schrieb Sergei Golubchik: Hi, Oleksandr! On Mar 01, Oleksandr Byelkin wrote: So, I see few possible approaches to this and other similar queries: 1. We specify that no Item's val method can modify the buffer of the arguments. That is, CONCAT will always have

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

Hi! Am 01.03.2017 um 13:56 schrieb Sergei Golubchik: Hi, Alexander! On Feb 28, Alexander Barkov wrote: commit af8887b86ccbaea8782cf54fe445cf53aaef7c06 Author: Alexander Barkov Date: Tue Feb 28 10:28:09 2017 +0400 MDEV-10306 Wrong results with combination of CONCAT,

[Maria-developers] How correctly allocate memory to avoid problems with 2nd execution (instruction)

Hi! It is for all who decide to write or already is writing something for server. There is 2 ways to execute query/statement: 1) conventional (one time) 2) with storing the statement and executing it many times (Prepared statements (PS)/ Stored Procedures(SP)) Also there is so called

Re: [Maria-developers] [Commits] 8bfc350: MDEV-10148: Database crashes in the query to the View

Hi, Sergei! On 12/16/2016 03:16 PM, Sergei Petrunia wrote: revision-id: 8bfc35041195b46c8f4666dd02f600e878f45643 parent(s): 96d2e0480ffbc36c803db5a7d5bcefd3470c5f72 committer: Sergei Petrunia branch nick: 5.5 timestamp: 2016-12-16 17:16:02 +0300 message: MDEV-10148: Database crashes in the

Re: [Maria-developers] MDEV-11360 Dynamic SQL: DEFAULT as a bind parameter

Hi, Alexander! On 11/27/2016 02:07 PM, Alexander Barkov wrote: Hello Sanja, This is a new version, with some cleanups in "switch" statements in various Item_param methods, and with a test covering Item_param::eq() added. OK, to push after adding DBUG_ASSERT we agreed. Thanks! On

Re: [Maria-developers] Please review a 10.3 patch "Moving functions cast_stmt_xxx and add_select_to_union_list as methods to LEX"

Hi, Alexander! On 11/24/2016 07:09 AM, Alexander Barkov wrote: Hello Sanja, As we agreed during our discussion on slack, we should port a few preparatory patches from bb-10.2-compatibility to 10.3, to make our further compatibility related development easier. This is the first patch. Please

Re: [Maria-developers] [Commits] 9ed264a391b160ef84121c8699bb3ff61c0059ce Fixed bug mdev-11072. In a general case the conditions with outer fields cannot be pushed into materialized views / derived ta

Hi, Igor! On 11/15/2016 08:23 AM, Igor Babaev wrote: commit 9ed264a391b160ef84121c8699bb3ff61c0059ce Author: Igor Babaev Commit: Igor Babaev Fixed bug mdev-11072. In a general case the conditions with outer fields cannot be pushed into

Re: [Maria-developers] Please review a fix for MDEV-10780 (and likely for MDEV-10806 and MDEV-10910)

Hi, Alexander! On 10.11.2016 13:42, Alexander Barkov wrote: Hello Sanja, [skip] Here's an updated version with a comment and with a very small addition fixing another bugs. Patch is OK to push. (I'd removed "Start of 10.1 tests" becaus we mart normally ends only, but it is OK leave it as

Re: [Maria-developers] Please review a fix for MDEV-10780 (and likely for MDEV-10806 and MDEV-10910)

Hi, Alexander! On 09.11.2016 16:28, Alexander Barkov wrote: Hello Sanja, Elena, Wlad, Sanja, please review a patch for MDEV-10780. The patch is for 10.1. I could not reproduce it in 10.0. But it should be safe to push it into 10.0 anyway. This patch is most likely fixing MDEV-10806 (assigned

Re: [Maria-developers] [Commits] 13b5098: MDEV-9531: GROUP_CONCAT with ORDER BY inside takes a lot of memory while it's executed

On 26.09.2016 19:03, Sergei Golubchik wrote: Hi, Oleksandr! On Sep 26, Oleksandr Byelkin wrote: A hackish workaround could be to adjust tree->elements_limit (in Item_func_group_concat::add) after each insertion. But in this case it would be simpler to limit the tree by size (in by

Re: [Maria-developers] [Commits] 13b5098: MDEV-9531: GROUP_CONCAT with ORDER BY inside takes a lot of memory while it's executed

On 22.09.2016 17:10, Sergei Golubchik wrote: Hi, Oleksandr! On Jun 28, Oleksandr Byelkin wrote: revision-id: 13b5098fcaa888173472d255e29aff22bcc5baae (mariadb-10.1.13-18-g13b5098) parent(s): 732adec0a4c75d99389230feeb0deca0ad668de7 committer: Oleksandr Byelkin timestamp: 2016-06-28 10:59:59

Re: [Maria-developers] Freeing options & wrappers.

Hi, Kristian! On 16.08.2016 17:29, Kristian Nielsen wrote: Oleksandr Byelkin <sa...@montyprogram.com> writes: OK, I checked sources of the connector, ad did not see how it can work, so build and test the test program, it also has the problem (so user just probably tested old version) H

Re: [Maria-developers] Freeing options & wrappers.

Hi, Kristian. On 16.08.2016 16:23, Kristian Nielsen wrote: Oleksandr Byelkin <sa...@montyprogram.com> writes: Making something more I think do not worth it because: 1) in 10.2 C/C will replace the library and it has no the problem But Connector-C should have exactly the same p

[Maria-developers] Freeing options & wrappers.

Hi! (sorry I forgot mailing list so resending the e-mail) So it is about https://jira.mariadb.org/browse/MDEV-10559 Original problem was that database drivers in Python & Perl (probably other) do not call mysql_close for MYSQL object if there was no connection happing (memory leak). MySQL

Re: [Maria-developers] [Commits] 475cab8: MDEV-10050: Crash in subselect

Hi! On 23.06.2016 23:49, Sergey Petrunia wrote: Hi Sanja, On Wed, Jun 22, 2016 at 02:17:06PM +0200, Oleksandr Byelkin wrote: revision-id: 475cab835fb48c91d5cca649ab93917ec1718d75 (mariadb-5.5.50-6-g475cab8) parent(s): a482e76e65a4fee70479e877929381c86b1ec62f committer: Oleksandr Byelkin

Re: [Maria-developers] MDEV-10035 DBUG_ASSERT on CREATE VIEW v1 AS SELECT * FROM t1 FOR UPDATE

On 16.05.2016 16:05, Sergei Golubchik wrote: Hi, Oleksandr! On May 16, Oleksandr Byelkin wrote: That's different. See: CREATE VIEW v1 AS SELECT * FROM t1 FOR UPDATE; SELECT * FROM v1, t2; This is different from SELECT * FROM t1, t2 FOR UPDATE; the first locks only t1

Re: [Maria-developers] MDEV-10035 DBUG_ASSERT on CREATE VIEW v1 AS SELECT * FROM t1 FOR UPDATE

On 16.05.2016 14:56, Sergei Golubchik wrote: Hi, Oleksandr! On May 16, Oleksandr Byelkin wrote: On May 16, Alexander Barkov wrote: Just now this parameter for VIEWs effectively (and silently) ignored. So error IMHO is better. It will break existing application where users have FOR UPDATE

Re: [Maria-developers] MDEV-10035 DBUG_ASSERT on CREATE VIEW v1 AS SELECT * FROM t1 FOR UPDATE

Hi! On 16.05.2016 14:26, Sergei Golubchik wrote: Hi, Alexander! On May 16, Alexander Barkov wrote: Just now this parameter for VIEWs effectively (and silently) ignored. So error IMHO is better. It will break existing application where users have FOR UPDATE in the view definition. But,

Re: [Maria-developers] MDEV-10035 DBUG_ASSERT on CREATE VIEW v1 AS SELECT * FROM t1 FOR UPDATE

Hi! On 16.05.2016 06:00, Alexander Barkov wrote: Hi Sanja, Sergei, Sanja, you asked me to review a patch for MDEV-10035: revision-id: 4ffe2295e78538dde93df078421726f0c5a7d2a2 (mariadb-10.2.0-29-g4ffe229) parent(s): b79944950e5e5db40cf7ad49061edf5f105512c4 committer: Oleksandr Byelkin

Re: [Maria-developers] 7e70658: MDEV-9947: COM_MULTI united response

On 10.05.2016 10:16, Sergei Golubchik wrote: Hi, Sanja! Looks ok to me. You're simply disable net_flush as far as I can see. For comments and questions, see below... On May 09, Oleksandr Byelkin wrote: revision-id: 7e70658d1e88b4a255e3c28426f8259e5e596a85 (mariadb-10.2.0-20-g7e70658) parent

Re: [Maria-developers] [Commits] b1ddc7d: MDEV-9487: Server crashes in Time_and_counter_tracker::incr_loops with UNION in ALL subquery

Hi, Vicențiu! On 04.05.2016 18:50, Vicențiu Ciorbaru wrote: Hi Sanja, Sergey, I think Sergey might have mean the same thing but it is not clear to me. in_optimize never gets set to true. By mentioning that it is redundant that means that it can be removed from the current code right? It was

[Maria-developers] Generated (AKA virtual) column limit of 256 charecters? WAS: Dynamic column expression limitat - 252 characters

Hi, Sergey! On 21.04.2016 02:03, Sergey Petrunia wrote: https://mariadb.com/kb/en/mariadb/virtual-computed-columns/ says the expression cannot exceed 252 characters in length. I've got a complaint about this limitation. You probably mean generated (AKA virtual) columns? Do we have any

Re: [Maria-developers] [Commits] 308cee547f6573a9825b5f08f938d4452d0095d9 Fixed bug mdev-9931.

Hi, Igor! On 20.04.2016 00:37, Igor Babaev wrote: commit 308cee547f6573a9825b5f08f938d4452d0095d9 Author: Igor Babaev Commit: Igor Babaev Fixed bug mdev-9931. When the specification of a WITH table referred to a view that used a

Re: [Maria-developers] 4c51152: MDEV-8931: (server part of) session state tracking

: 4c51152d9f43e271e17a2bc266f5887ce092c00f (mariadb-10.1.8-187-g4c51152) parent(s): 69b5c4a4220c8fa98bbca8b3f935b2a3735e19ac committer: Oleksandr Byelkin timestamp: 2016-03-28 19:19:54 +0200 message: MDEV-8931: (server part of) session state tracking diff --git a/include/mysql_com.h b/include

Re: [Maria-developers] MDEV-9841: Window functions: embedded server fails to start due to error code conflicts

Hi! On 31.03.2016 12:33, Sergey Petrunia wrote: Hi Serg, We added a number of new error messages for window functions, and now server error codes have collided with the client. The text in MDEV-9841 has the details. Sanja mentioned that you were aware of the possibility of this and had a

Re: [Maria-developers] MDEV-7773, Aggregate Stored Functions

Hi, Soham! On 30.03.2016 16:28, Soham Mankad wrote: [skip] Please let me know whether I am working in right direction or not and whether the methods I have mentioned can be used or not to implement the project. Sorry, but you e-mail makes me think that you have not read comments to the

Re: [Maria-developers] 72b709a: MDEV-9701: CREATE VIEW with GROUP BY or ORDER BY and constant produces invalid definition

On 17.03.2016 10:21, Sergei Golubchik wrote: Hi, Oleksandr! On Mar 16, Oleksandr Byelkin wrote: On Mar 16, OleksandrByelkin wrote: revision-id: 72b709ac7503ae6dd2b5e9049322fefb90b0ebbe (mariadb-10.1.12-16-g72b709a) parent(s): 9b53d84d14a9b031d193f6beae382a232aa738e3 committer: Oleksandr

Re: [Maria-developers] 72b709a: MDEV-9701: CREATE VIEW with GROUP BY or ORDER BY and constant produces invalid definition

Hi! On 16.03.2016 20:42, Sergei Golubchik wrote: Hi, Sanja! On Mar 16, OleksandrByelkin wrote: revision-id: 72b709ac7503ae6dd2b5e9049322fefb90b0ebbe (mariadb-10.1.12-16-g72b709a) parent(s): 9b53d84d14a9b031d193f6beae382a232aa738e3 committer: Oleksandr Byelkin timestamp: 2016-03-16 19:49:17

Re: [Maria-developers] Questions regarding GSoC 2016 and Import / Export

acquainted with the code base. I hope I am not underestimating the projects and some guidance from one of the mentors (Oleksandr Byelkin, Georg Richter or Alexey Botchkov - Holyfoot) is certainly welcome. I will focus on "Import and export popular data formats from and to dynamic co

Re: [Maria-developers] GSoC 2016 CONC-125

Hi, Christian! On 06.03.2016 12:23, Christian Massey wrote: Hi everyone, I am Christian Massey a computer science student at York University and I wish to work on Providing import and export functions for popular data formats like JSON, XML , PHP, ... for Connector/C and MariaDB Server. I

Re: [Maria-developers] [Commits] 5dd6eb4: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

On 01.02.2016 22:34, Sergei Golubchik wrote: Hi, Sanja! On Jan 28, OleksandrByelkin wrote: revision-id: 5dd6eb45c418f61c749a7884d7b3e13d62f3bfb9 (mariadb-10.1.8-113-g5dd6eb4) parent(s): 14d79a5e99f9992cabb7489203989ccdaacadb78 committer: Oleksandr Byelkin timestamp: 2016-01-28 14:58:12 +0100

Re: [Maria-developers] Aliasing slave_parallel_workers/slave_parallel_threads

On 26.01.2016 15:13, Kristian Nielsen wrote: Colin Charles writes: MySQL 5.7 has been released and I’m sure you realise that it uses the variable slave_parallel_workers (http://dev.mysql.com/doc/refman/5.7/en/replication-options-slave.html#sysvar_slave_parallel_workers). In

Re: [Maria-developers] MDEV-8615: Assertion `m_cpp_buf <= begin_ptr && begin_ptr <= m_cpp_buf + m_buf_length' failed in Lex_input_stream::body_utf8_start

Hi! On 21.01.2016 17:16, Sergei Golubchik wrote: Hi, Sanja! On Dec 25, OleksandrByelkin wrote: revision-id: 684bd68c33284f6106551188d9567f35b18593ed (mariadb-10.1.9-21-g684bd68) parent(s): 59fcd7ff2315d007045eb987da5f21abbea6f6f1 committer: Oleksandr Byelkin timestamp: 2015-12-25 18:39:43

Re: [Maria-developers] [Commits] cae1945: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

On 16.01.2016 21:56, Sergei Golubchik wrote: Hi, Sanja! On Nov 25, OleksandrByelkin wrote: revision-id: cae19452eec1d3be47fa04759dd2dda6d061543e (mariadb-10.1.8-69-gcae1945) parent(s): 55e67c3e344317c6f349f5391e5d117ec51ae062 committer: Oleksandr Byelkin timestamp: 2015-11-25 18:09:39 +0100

[Maria-developers] MDEV-8789: diff comments

Hi! Generally the patch made very good impression but lack of many tests which made reviewing more dificult (I made simple tests just to check basic functionality), naturally that test cowerage shoud be extended (see liist in comments). Also there are several small notes (except probably

Re: [Maria-developers] For review https://mariadb.atlassian.net/browse/MDEV-9058

Hi, Monty! On 12.01.2016 15:13, Oleksandr Byelkin wrote: [skip] +if (maria_multi_check(thd, packet, packet_length)) + break; +{ + /* We have to store next length because it will be destroyed by '\0' */ + uint next_subpacket_length= uint3korr(packet); + unsigned

Re: [Maria-developers] MDEV-8789: * expanding problem

On 11.01.2016 20:36, Oleksandr Byelkin wrote: Hi! create table t1(a int, b int); insert into t1 values (1,1),(2,2),(10,10),(20,20); create table t2(c int, d int); insert into t2 values (10,1),(20,2); create database test2; create table test2.t2(c int, d int); insert into test2.t2 values (10,1

[Maria-developers] MDEV-8789: fully qualified field name resolving problem

Hi! I decided to show my finding as soon as I have them found (to give time to explain/fix, also I think that name resolving fix could possibly cause some big rewriting) but if you prefer "all togather" do not hesitate to say it. So the test suite which demostrate the problem: -

Re: [Maria-developers] [Commits] 59fcd7f: MDEV-9118 ANALYZE TABLE for Engine independent status fetchs blob/text columns without use

wrote: revision-id: 59fcd7ff2315d007045eb987da5f21abbea6f6f1 (mariadb-10.1.9-20-g59fcd7f) parent(s): 953d5680a3c050273a8f29253f7386984679f92b committer: Oleksandr Byelkin timestamp: 2015-12-18 12:23:45 +0100 message: MDEV-9118 ANALYZE TABLE for Engine independent status fetchs blob/text columns without use Do not

Re: [Maria-developers] [Commits] daad482: MDEV-8615: Assertion `m_cpp_buf <= begin_ptr && begin_ptr <= m_cpp_buf + m_buf_length' failed in Lex_input_stream::body_utf8_start

On 21.12.2015 20:54, Sergei Golubchik wrote: Hi, Sanja! On Dec 21, OleksandrByelkin wrote: revision-id: daad4828b078485ee7ac60af4fc165ae35684395 (mariadb-10.1.9-21-gdaad482) parent(s): 59fcd7ff2315d007045eb987da5f21abbea6f6f1 committer: Oleksandr Byelkin timestamp: 2015-12-21 20:13:12 +0100

Re: [Maria-developers] [Commits] 2606b87: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

Hi, Serg! On 24.11.2015 20:38, Sergei Golubchik wrote: [skip] Ok, but I think it'll be needed in Connector/C, when it connects to the old MariaDB server. I informed Georg and he found it reasonable. While I am trying to fix git triggers for mail, here is the after-review patch diff --git

Re: [Maria-developers] [Commits] 2606b87: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

On 25.11.2015 14:03, Oleksandr Byelkin wrote: +++ b/sql-common/client.c @@ -2486,7 +2486,7 @@ static int send_client_reply_packet(MCPVIO_EXT *mpvio, if (mysql->client_flag & CLIENT_PROTOCOL_41) { /* 4.1 server and 4.1 client has a 32 byte option flag */ -int4store(buf

Re: [Maria-developers] [Commits] 2606b87: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

On 24.11.15 12:27, Sergei Golubchik wrote: Hi, Oleksandr! On Nov 23, Oleksandr Byelkin wrote: diff --git a/include/mysql.h b/include/mysql.h index f088ad6..d398734 100644 --- a/include/mysql.h +++ b/include/mysql.h @@ -270,7 +270,7 @@ typedef struct st_mysql unsigned long thread_id

Re: [Maria-developers] [Commits] 5f461a9: MDEV-7640: CHANGE MASTER TO doesn't work with prepared statements

Hi! On 17.09.15 00:10, Nirbhay Choubey wrote: revision-id: 5f461a94a5aa2e1a20fa559ca612d96b53201e4e parent(s): 29ac245dd04c5416d57a90b0ab3c4d08cbc4d723 committer: Nirbhay Choubey branch nick: 5.5 timestamp: 2015-09-16 18:10:06 -0400 message: MDEV-7640: CHANGE MASTER TO doesn't work with

Re: [Maria-developers] [Commits] ee656a4: MDEV-7846: postreview fix

postreview is here: revision-id: 74f1ae282f9395dd704f94c5f21acbee35de898c (mariadb-5.5.45-15-g74f1ae2) parent(s): e3ad2f4e545101bd1f48001225df03bab6865e5c committer: Oleksandr Byelkin timestamp: 2015-10-06 12:07:46 +0200 message: MDEV-7846: postreview fix

Re: [Maria-developers] [Commits] 8983790: MDEV-7970: EXPLAIN FORMAT=JSON does not print HAVING

1000, "r_total_time_ms": 18.597, "filtered": 100, "r_filtered": 100, "attached_condition": "(t1.a between 0 and 1000)" } } } } } oops, I'll fix. Smal

Re: [Maria-developers] [Commits] 93a7c11: MDEV-8380: Subquery parse error

On 12.09.15 21:12, Sergei Golubchik wrote: Hi, Sanja! On Aug 31, sa...@mariadb.com wrote: revision-id: 93a7c11c51e2f5c0ca98600924172e452b6188b6 (mariadb-10.1.6-24-g93a7c11) parent(s): d07b780db239a909e667edf5657e3633e80d1451 committer: Oleksandr Byelkin timestamp: 2015-08-31 13:10:01 +0200

Re: [Maria-developers] [Commits] 0a1b60a: MDEV-8450: PATCH] Wrong macro expansion in Query_cache::send_result_to_client()

: 0a1b60a8aee4bce3235fd5a1d8cb2231b51ff5cc (mariadb-10.0.21-7-g0a1b60a) parent(s): 4b41e3c7f33714186c97a6cc2e6d3bb93b050c61 committer: Oleksandr Byelkin timestamp: 2015-09-01 11:47:06 +0200 message: MDEV-8450: PATCH] Wrong macro expansion in Query_cache::send_result_to_client() Expression in macro protected

Re: [Maria-developers] New Hacker

Hi, Aniket! On 27.08.15 07:00, Aniket Shukla wrote: Hey MariaDB team,this is Aniket.I'm a final year undegraduate student and would like to contribute to MariaDB.Since this is my first open source project, I have no idea where to begin.I have good knowledge of python,c++ and have benn using

Re: [Maria-developers] [Commits] 686761f: MDEV-6066: Merge new defaults from 5.6 and 5.7 (part 1 (no hash serch) v2)

wrote: revision-id: 686761fbb0fc36e4fa781b68aba24af21599822d parent(s): 302bf7c4664b904482ecc133476e822d497b114d committer: Oleksandr Byelkin branch nick: server could you update your post-commit trigger? thanks. OK timestamp: 2015-07-14 00:11:25 +0200 message: MDEV-6066: Merge new defaults

Re: [Maria-developers] 3eceb51: MDEV-7990: ERROR 1526 when procedure executed for second time ALTER TABLE partition ... pMAX values less than MAXVALUE

Hi, Sergei! On 12.06.15 13:09, Sergei Golubchik wrote: Hi, Sanja! On May 06, sa...@mariadb.com wrote: revision-id: 3eceb51e697d5a514e70c374a06e7eef6b5a37a0 parent(s): aa5095627e2619bdad7916d33d1016802a84a9e1 committer: Oleksandr Byelkin branch nick: server timestamp: 2015-05-06 13:19:22 +0200

  1   2   3   >