Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-11-05 Thread Maximilian Albert
Hi all, apologies for the delay in getting back to you! The end of last week was quite busy and I was away from my computer during the weekend. 2012/11/1 Ryan May rma...@gmail.com: You might have more luck using a temp-file based writer. By default, movies are created by piping in the data to

Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-11-05 Thread Maximilian Albert
P.S.: As an aside, when I run ffmpeg on my machine it issues a deprecation warning and suggests to use avconv instead. Is it worth converting animation.py from ffmpeg to avconv, too? The command line arguments should be virtually identicaly (as far as I know - I only use it very occasionally,

Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-11-01 Thread Maximilian Albert
Hi all, quick update on this: I pushed a small change to make the default argument immutable (thanks to Jens for pointing this out). Just a couple more questions/comments: 1) Should there be a test for this? I couldn't find any tests for the Animation class, so I haven't added one. But perhaps I

Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-11-01 Thread Ryan May
On Thu, Nov 1, 2012 at 5:38 AM, Maximilian Albert maximilian.alb...@gmail.com wrote: Hi all, quick update on this: I pushed a small change to make the default argument immutable (thanks to Jens for pointing this out). Just a couple more questions/comments: 1) Should there be a test for

[matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-10-31 Thread Maximilian Albert
[I sent this email a few weeks ago already, but I wasn't subscribed to matplotlib-devel at the time and it seems that the message was never approved by the moderator. So here comes my second attempt. :)] Hi all, this is my first post to this mailing list, so let me take the opportunity to thank

Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-10-31 Thread Damon McDougall
On Wed, Oct 31, 2012 at 7:04 AM, Maximilian Albert maximilian.alb...@gmail.com wrote: [I sent this email a few weeks ago already, but I wasn't subscribed to matplotlib-devel at the time and it seems that the message was never approved by the moderator. So here comes my second attempt. :)] Hi

Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-10-31 Thread Maximilian Albert
Hi Damon, many thanks for the quick (and positive :)) reply, Sounds like a great idea! Would you feel comfortable having a go at an implementation? You can make a pull request out of it. The rest of the developers can then deliberate and provide feedback for you. I attached a patch to my

Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-10-31 Thread Damon McDougall
On Wed, Oct 31, 2012 at 7:40 AM, Maximilian Albert maximilian.alb...@gmail.com wrote: Hi Damon, many thanks for the quick (and positive :)) reply, Sounds like a great idea! Would you feel comfortable having a go at an implementation? You can make a pull request out of it. The rest of the

Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-10-31 Thread Eric Firing
On 2012/10/31 2:04 AM, Maximilian Albert wrote: [I sent this email a few weeks ago already, but I wasn't subscribed to matplotlib-devel at the time and it seems that the message was never approved by the moderator. So here comes my second attempt. :)] Hi all, this is my first post to this

Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-10-31 Thread Jens Nielsen
I think Eric idea is a good solution. This is just to point out that I did something similar with kw args to savefig in the image comparison decorator for tests. See the changes in decorators.py in this pull request https://github.com/matplotlib/matplotlib/pull/1420 . Seems to work fine.

Re: [matplotlib-devel] Animation class: let save() accept **kwargs which are passed on to savefig()?

2012-10-31 Thread Maximilian Albert
Awesome, many thanks for the detailed instructions, as well as for the valuable suggestions by Eric and Jens. I have now created a pull request containing the proposed change, including the suggested modifications: https://github.com/matplotlib/matplotlib/pull/1442 Any comments/feedback would