Re: [matplotlib-devel] fancy box around text

2008-09-17 Thread Jae-Joon Lee
Thanks John, Everything seems fine. Thanks again, -JJ On Wed, Sep 17, 2008 at 4:53 PM, John Hunter <[EMAIL PROTECTED]> wrote: > On Wed, Sep 17, 2008 at 2:49 PM, Jae-Joon Lee <[EMAIL PROTECTED]> wrote: > I uploaded my patch. https://sourceforge.net/tracker/index.php?func=detail&ai

Re: [matplotlib-devel] fancy box around text

2008-09-17 Thread John Hunter
On Wed, Sep 17, 2008 at 2:49 PM, Jae-Joon Lee <[EMAIL PROTECTED]> wrote: >>> I uploaded my patch. >>> >>> https://sourceforge.net/tracker/index.php?func=detail&aid=2116614&group_id=80706&atid=560722 OK, I've applied it. I reformatted some of the docstrings and incorporated a bunch of the comment

Re: [matplotlib-devel] fancy box around text

2008-09-17 Thread John Hunter
s On Wed, Sep 17, 2008 at 2:50 PM, Jae-Joon Lee <[EMAIL PROTECTED]> wrote: > One thing I forgot to mention is that, in the Text class, draw() > method calls _draw_bbox() method. If I call the _draw_bbox() methods > after gc in draw() is created, then _draw_bbox call somehow changes > the gc in the

Re: [matplotlib-devel] fancy box around text

2008-09-17 Thread Jae-Joon Lee
One thing I forgot to mention is that, in the Text class, draw() method calls _draw_bbox() method. If I call the _draw_bbox() methods after gc in draw() is created, then _draw_bbox call somehow changes the gc in the original draw() method, which I think is not supposed to happen. I haven't looked a

Re: [matplotlib-devel] fancy box around text

2008-09-17 Thread Jae-Joon Lee
Thanks John, I made a single diff file and uploaded it. https://sourceforge.net/tracker/index.php?func=detail&aid=2116614&group_id=80706&atid=560722 Regards, -JJ On Wed, Sep 17, 2008 at 3:01 PM, John Hunter <[EMAIL PROTECTED]> wrote: > On Wed, Sep 17, 2008 at 1:30 PM, Jae-Joon Lee <[EMAIL

Re: [matplotlib-devel] fancy box around text

2008-09-17 Thread John Hunter
On Wed, Sep 17, 2008 at 1:30 PM, Jae-Joon Lee <[EMAIL PROTECTED]> wrote: > Hi, > > I uploaded my patch. > > https://sourceforge.net/tracker/index.php?func=detail&aid=2116614&group_id=80706&atid=560722 Hi Jae Joon -- thanks for uploading this. I have read through it once and it looks pretty good

Re: [matplotlib-devel] fancy box around text

2008-09-17 Thread Jae-Joon Lee
Hi, I uploaded my patch. https://sourceforge.net/tracker/index.php?func=detail&aid=2116614&group_id=80706&atid=560722 I added a FancyBboxPatch class in the patches.py. And changed text.Text class to support it. Two examples are attached with this email. I hope I have put enough documentation, bu

Re: [matplotlib-devel] fancy box around text

2008-09-12 Thread John Hunter
On Fri, Sep 12, 2008 at 2:46 PM, Jae-Joon Lee <[EMAIL PROTECTED]> wrote: > Thanks John, > > I think I'd better use a sf patch initially so that you or others can > review and improve it. I'll definitely need some help with > documentation as my English can be horrible sometime. On the other > hand,

Re: [matplotlib-devel] fancy box around text

2008-09-12 Thread Michael Droettboom
Jae-Joon Lee wrote: > I guess this fancy box thing can be used with other artist objects > also, although the legend object is an only object I can think of now. > And my personal inclination is put those support code into patches.py > and have a patch class around it, i.e., a FancyBoxPatch class

Re: [matplotlib-devel] fancy box around text

2008-09-12 Thread Jae-Joon Lee
Thanks John, I think I'd better use a sf patch initially so that you or others can review and improve it. I'll definitely need some help with documentation as my English can be horrible sometime. On the other hand, it would be much easier for me to do some maintenance work if I can commit the chan

Re: [matplotlib-devel] fancy box around text

2008-09-12 Thread John Hunter
On Thu, Sep 11, 2008 at 4:19 PM, Jae-Joon Lee <[EMAIL PROTECTED]> wrote: > Thanks John, > > I'm afraid that I'm not quite sure what you're suggesting, and will be > grateful if you describe it more specifically. Sorry Jae-Joon -- I was in a big hurry yesterday (in the financial industry we're a bi

Re: [matplotlib-devel] fancy box around text

2008-09-11 Thread Jae-Joon Lee
Thanks John, I'm afraid that I'm not quite sure what you're suggesting, and will be grateful if you describe it more specifically. As of now, textbox.py has two classes (+Text class which is not needed with text.py patch). TextBoxBase and its derivatives : despite its name (which could be a poo

Re: [matplotlib-devel] fancy box around text

2008-09-11 Thread John Hunter
On Thu, Sep 11, 2008 at 1:13 PM, Jae-Joon Lee <[EMAIL PROTECTED]> wrote: > It would be good if these can be included in the matplotlib. At least, > can the patch for the text.py be applied? I am happy to include this functionality, but let's build it into the standard bbox rather than introduce a