Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-31 Thread Michael Droettboom
There was a thread on this a few weeks ago (which unfortunately I can't find). Supporting wx 2.6 is not a goal for the Wx backend in 0.98.x. It is impossible to support matplotlib's new drawing API (which includes Bezier curves and alpha transparency) with the old wx API. If you need to use

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-25 Thread David Kaplan
Hi, I am still getting crashes using the WX backend with the latest SVN. For example: In [1]: figure() Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/matplotlib/backends/backend_wx.py", line 1092, in _onSize

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-24 Thread Paul Kienzle
On Thu, Jul 24, 2008 at 05:14:42PM +0200, David Kaplan wrote: > Hi, > > No, it doesn't appear to work with or without my changes. Also, it > looks to me like the following code is now misplaced in backend_wx.py: > > # Event binding code changed after version 2.5 > if wx.VERSION_STRING >= '2.5':

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-24 Thread David Kaplan
Hi, No, it doesn't appear to work with or without my changes. Also, it looks to me like the following code is now misplaced in backend_wx.py: # Event binding code changed after version 2.5 if wx.VERSION_STRING >= '2.5': def bind(actor,event,action,**kw): actor.Bind(event,action,**kw)

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-24 Thread Paul Kienzle
On Thu, Jul 24, 2008 at 12:12:21PM +0200, David Kaplan wrote: > 4) In WX, I used the code submitted by Paul, but was unable to check it > because when I tried to use the WX backend, I got an error about no > GraphicsContext (below). This looks bad. I am using wxPython: 2.6.3.2. Does wx work for

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-24 Thread David Kaplan
Hi, I have finally committed a changeset for moving the "event loop" stuff into the backends. I have hopefully found a compromise that will please most. Since this is close to release date, I suggest that everyone who can give it a look (r5831) and if there is any problem, just role the changes

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-23 Thread John Hunter
On Fri, Jul 18, 2008 at 2:32 PM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > Well, yeah. I think this would mean a lot of the same code in many > backends. I also like the idea of a deeper hierarchy with a > FigureCanvasUserInterface class that inherits FigureCanvasBase but adds > functional st

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-19 Thread David M. Kaplan
Hi, On Fri, 2008-07-18 at 15:47 -0400, Paul Kienzle wrote: > The cases I'm thinking about (e.g., select fit range) have a specific > number of points. Other cases (e.g., select shape outline) have an > indefinite number of points. I can't think of case off hand where > I would want e.g., six or

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-18 Thread Paul Kienzle
On Fri, Jul 18, 2008 at 09:17:02PM +0200, David M. Kaplan wrote: > For ginput, there are a number of ways that an impartial list could be > returned and this is often a desired outcome (for example, I often > decide after the fact that I want fewer points than I initially > thought). Can't you use

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-18 Thread David M. Kaplan
Hi, On Fri, 2008-07-18 at 09:24 -0500, John Hunter wrote: > On Fri, Jul 18, 2008 at 4:27 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > I'm not a huge fan of mixins. We use them occassionally, eg for > FigureCanvasGtkAgg and their are some good uses for them, but they can > quickly lead to ove

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-18 Thread David M. Kaplan
Hi, On Fri, 2008-07-18 at 11:52 -0400, Paul Kienzle wrote: > If exceptions aren't used, then non-interactive backends should > return [] > I think I have changed my mind on this one - an error seems more appropriate. The real-world use cases for this are (1) someone doesn't realize they are in

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-18 Thread David M. Kaplan
Hi, My bad - I forgot strings are iterable. This should now be fixed. Cheers, David On Fri, 2008-07-18 at 09:41 -0500, John Hunter wrote: > On Fri, Jul 18, 2008 at 3:50 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > > >> I would probably write a cbook method is_sequence_of_strings and just

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-18 Thread Paul Kienzle
On Fri, Jul 18, 2008 at 11:27:50AM +0200, David M. Kaplan wrote: > Hi, > > On Thu, 2008-07-17 at 16:55 -0400, Paul Kienzle wrote: > >FigureCanvasBase: > >def start_event_loop(self, ...): > >raise NotImplemented > >FigureCanvasEventLoopMixin: > >def start_event_

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-18 Thread John Hunter
On Fri, Jul 18, 2008 at 3:50 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: >> I would probably write a cbook method is_sequence_of_strings and just >> call that since it will be more readable and reusable... >> > > Method added to cbook. This method will return true on a string, which is probabl

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-18 Thread John Hunter
On Fri, Jul 18, 2008 at 4:27 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > So just to make sure that I understand this, "MyInteractiveBackend" > would be any backend canvas class for whom we want to implement the > standard generic mixin. For example, the class FigureCanvasGTK would > inherit

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-18 Thread David M. Kaplan
Hi, On Thu, 2008-07-17 at 16:55 -0400, Paul Kienzle wrote: >FigureCanvasBase: >def start_event_loop(self, ...): >raise NotImplemented >FigureCanvasEventLoopMixin: >def start_event_loop(self, ...): >generic interactive using time.sleep >MyInterac

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-18 Thread David M. Kaplan
Hi, I just committed some changes to deal with these comments. Responses below. Cheers, David On Thu, 2008-07-17 at 15:16 -0500, John Hunter wrote: > def __init__(self, fig, eventslist=()): > self.fig = fig > assert isinstance(eventslist, tuple), "Requires a tuple of > even

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread Gael Varoquaux
On Thu, Jul 17, 2008 at 04:55:42PM -0400, Paul Kienzle wrote: > On Thu, Jul 17, 2008 at 09:44:48PM +0200, David M. Kaplan wrote: > > Another option would be to create a start_event_loop function like Paul > > suggested and overload that function in those backends that aren't > > interactive so that

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread Paul Kienzle
On Thu, Jul 17, 2008 at 09:44:48PM +0200, David M. Kaplan wrote: > Another option would be to create a start_event_loop function like Paul > suggested and overload that function in those backends that aren't > interactive so that it returns an error, but this requires writing one > such function fo

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread John Hunter
On Thu, Jul 17, 2008 at 2:44 PM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > Hi all, > > I committed to svn (revision 5782) a version of the patch for clabel and > waitforbuttonpress. I haven't perfected label rotation yet, but it > works at the moment. I also haven't yet followed Paul Kienzle's

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread David M. Kaplan
Hi all, I committed to svn (revision 5782) a version of the patch for clabel and waitforbuttonpress. I haven't perfected label rotation yet, but it works at the moment. I also haven't yet followed Paul Kienzle's suggestions (though I think they are a good idea), as I wanted to get a bit more inf

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread David Kaplan
Hi, This sounds like a great idea. My trunk version of matplotlib does not have these changes. I presume you would like me to commit them? If so, let me know and it would be great if you could give your code a test using the wx backend afterward. Cheers, David On Thu, 2008-07-17 at 12:13 -0

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread Paul Kienzle
On Thu, Jul 17, 2008 at 09:46:16AM +0200, David M. Kaplan wrote: > I don't think the blocking code will be that hard to maintain. It > basically just depends on events, callback functions and time.sleep. If > those are cross-platform, then it shouldn't be a problem. But only time > will tell. M

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread Manuel Metz
Paul Kienzle wrote: > On Thu, Jul 17, 2008 at 08:50:03AM +0200, Manuel Metz wrote: >> Just because the discussion about clabel started, I want to post a short >> snipplet of code that I found useful. It was some sort of hack to get a >> nicer float formating for contours: contour lines represente

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread Paul Kienzle
On Thu, Jul 17, 2008 at 08:50:03AM +0200, Manuel Metz wrote: > Just because the discussion about clabel started, I want to post a short > snipplet of code that I found useful. It was some sort of hack to get a > nicer float formating for contours: contour lines represented confidence > levels of

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread Gael Varoquaux
On Thu, Jul 17, 2008 at 04:41:36PM +0200, David M. Kaplan wrote: > Attached is a new version of the patch that includes ginput, > waitforbuttonpress and clabel changes. It is already quite functional, > but there are a couple of issues that need improving that I would like > to solicit comments on

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread David M. Kaplan
Hi, On Thu, 2008-07-17 at 07:47 -0700, [EMAIL PROTECTED] wrote: > Just because the discussion about clabel started, I want to post a > short > snipplet of code that I found useful. It was some sort of hack to get > a > nicer float formating for contours: contour lines represented > confidence

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread Darren Dale
On Thursday 17 July 2008 10:59:23 am John Hunter wrote: > On Thu, Jul 17, 2008 at 2:46 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > > Thanks for the comments. My sourceforge ID is dmkaplan. Please add me > > Hi David -- I've added you as a developer so you should be able to > commit now. The

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread John Hunter
On Thu, Jul 17, 2008 at 2:46 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > Thanks for the comments. My sourceforge ID is dmkaplan. Please add me Hi David -- I've added you as a developer so you should be able to commit now. The developer's guide is here: http://matplotlib.sourceforge.net

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread David M. Kaplan
Hi, Attached is a new version of the patch that includes ginput, waitforbuttonpress and clabel changes. It is already quite functional, but there are a couple of issues that need improving that I would like to solicit comments on. I explain below after detailing what I have done. I decided to u

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-17 Thread David M. Kaplan
Hi all, Thanks for the comments. My sourceforge ID is dmkaplan. Please add me as a developer. I will commit to the trunk and try to not break things, but I am VERY new to python and it is a possibility. If things don't work out, we can always fall back to creating a branch, though I admit that

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-16 Thread Manuel Metz
John Hunter wrote: > On Wed, Jul 16, 2008 at 7:20 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > > Thanks for the submission -- I await more informed commentary from > those who actually use contouring > Just because the discussion about clabel started, I want to post a short snipplet of

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-16 Thread Eric Firing
John Hunter wrote: > On Wed, Jul 16, 2008 at 7:20 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > >> The patch isn't done - manually selected labels won't be rotated or >> inline. There is also a need for general cleaning up and documentation. >> I just want to see what people think about the ap

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-16 Thread Michael Droettboom
John Hunter wrote: > On Wed, Jul 16, 2008 at 7:20 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > >> Please let me know what you think. Also, I am wondering if the powers >> that be would be willing to give me commit access to my own branch of >> the matplotlib svn. I don't want to modify the

Re: [matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-16 Thread John Hunter
On Wed, Jul 16, 2008 at 7:20 AM, David M. Kaplan <[EMAIL PROTECTED]> wrote: > The patch isn't done - manually selected labels won't be rotated or > inline. There is also a need for general cleaning up and documentation. > I just want to see what people think about the approach before investing >

[matplotlib-devel] patch for adding manual label location selection to clabel

2008-07-16 Thread David M. Kaplan
Hi, Attached is a patch (created by issuing svn diff from the matplotlib/trunk/matplotlib directory) for adding the capability to manually select the location of contour labels in clabel. Though the existing algorithm for automatically placing contour labels is very good, for complex figures with