Re: Further Midnight Commander development

2008-12-29 Thread Slava Zanko
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Enrico Weigelt wrote: * Slava Zanko slavaza...@gmail.com schrieb: Hi, huh, I'm not sure whether mvc fits in here. mcvfs - VIEW; core (signal handling, User events etc) - CONTROLLER, slang,mcslang,ncurses - VIEWs.. Why not? :) you meant: mcvfs

Re: Further Midnight Commander development

2008-12-29 Thread Miguel de Icaza
Hellom IMHO we should start with the latest stable release (4.6.1 ?) and apply all the vendor/distro patches floating around step by step (*1). Once that's done, we should make a new official release very soon. I agree with this approach, we should start by reviewing those patches as well,

Re: [PATCH] segfault-on-invalid-mtime fix

2008-12-29 Thread Miguel de Icaza
Hello, This patch looks good, but there are two uses of strftime as well, it might make sense to wrap the use of strftime in a new routine that always make this check (when localtime returns NULL). mc-4.6.1/src/util.c ___ Mc-devel mailing list

Re: [PATCH] some bash support fixups

2008-12-29 Thread Miguel de Icaza
Hello, This patch looks pretty dubious, specially considering that MC is used on system other than latest Linux distro with the latest bash. Do we have more information as to what this patch is trying to fix? ___ Mc-devel mailing list

Re: [PATCH] ebuild syntax file

2008-12-29 Thread Miguel de Icaza
This patch looks like an extension, it looks harmless and should go into the tree. http://patches.metux.de/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] cons.saver: non-blocking console

2008-12-29 Thread Miguel de Icaza
Hello, Opening the console in non-blocking mode is a bad idea, as it means that every call that is done later on the console_fd needs to check for EWOULDBLOCK. Most of the time, it would be not return that, it would only return that under unique situations which means that testing this

Re: [PATCH] find file fixups

2008-12-29 Thread Miguel de Icaza
This patch looks OK to go in. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] largefile fixups

2008-12-29 Thread Miguel de Icaza
This patch looks OK to go in. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: HAVE_MMAP still necessary ?

2008-12-29 Thread Miguel de Icaza
a) cmd.c: compare_files() - it uses the mmap() call directly (w/o going over mcvfs), and it seems to work on local files only. wouldn't it make sense to let it run via mcvfs ? b) view.c: it tries to mmap() in the file, obviously to let the kernel do all the loading. BUT:

Re: Further Midnight Commander development

2008-12-29 Thread Marco Ciampa
On Mon, Dec 29, 2008 at 12:33:44PM -0500, Miguel de Icaza wrote: Hellom IMHO we should start with the latest stable release (4.6.1 ?) and apply all the vendor/distro patches floating around step by step (*1). Once that's done, we should make a new official release very soon. I agree

Re: HAVE_MMAP still necessary ?

2008-12-29 Thread Enrico Weigelt
* Miguel de Icaza mig...@novell.com schrieb: Hi, mmap is more efficient, because the kernel can throw those pages out at any time (as it knows what the backing store for the file is), so under memory pressure it can alleviate the system load easily. Absolutely right, but we have to keep in

Re: [PATCH] ebuild syntax file

2008-12-29 Thread Enrico Weigelt
* Miguel de Icaza mig...@novell.com schrieb: This patch looks like an extension, it looks harmless and should go into the tree. ACK. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/

RFC: Workflow for stable branch patches

2008-12-29 Thread Enrico Weigelt
Hi folks, just a little suggestion for the workflow of committing patches to the stable tree: * new patches are sent to the list ([PATCH]-prefix) for discussion * if there are no more objections left, they get committed * after commit, the stable tree maintainer drops a note in the

Re: Further Midnight Commander development

2008-12-29 Thread Enrico Weigelt
* Roland Illig roland.il...@gmx.de schrieb: Hi, I'd like to. If there is some more action in mc development (like in 2005, when it was great fun), I'm definitely willing to invest some time into it. :) Maybe we even get all the different UTF-8 patches incorporated into mc. If that's

autoconf warnings (AC_AIX, ...)

2008-12-29 Thread Enrico Weigelt
Hi folks, while regenerating the autoconf files, I get bunch of warnings: (but ./configure is created nevertheless) configure.ac:105: warning: AC_COMPILE_IFELSE was called before AC_USE_SYSTEM_EXTENSIONS ../../lib/autoconf/specific.m4:389: AC_USE_SYSTEM_EXTENSIONS is expanded from...

Re: [PATCH] segfault-on-invalid-mtime fix

2008-12-29 Thread Enrico Weigelt
* Miguel de Icaza mig...@novell.com schrieb: Hi, This patch looks good, but there are two uses of strftime as well, it might make sense to wrap the use of strftime in a new routine that always make this check (when localtime returns NULL). I'm working on that. BTW: we've got some

[PATCH] some time formatting fixes

2008-12-29 Thread Enrico Weigelt
Hi folks, this patch goes a bit deeper into the strftime()+localtime() issue. a) introduce some new shortcut macros and use them in some places b) adds additional checks (where the macros dont fit) cu -- -- Enrico Weigelt,

[PATCH] Fix autoconf warnings on AC_AIX/AC_MINIX

2008-12-29 Thread Enrico Weigelt
-- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ cellphone: +49 174 7066481 email: i...@metux.de skype: nekrad666 -- Embedded-Linux /