[patch #5893] integrated side-by-side textmode diff viewer

2007-05-08 Thread Daniel Borca
Follow-up Comment #19, patch #5893 (project mc): --- me <[EMAIL PROTECTED]> wrote: [snip] > > Follow-up Comment #18, patch #5893 (project mc): > > [...] > > this kind of feature should be part of a filemanager > and should provide a > consistent behaviour with the available gui. It does. >

[patch #5893] integrated side-by-side textmode diff viewer

2007-05-05 Thread Daniel Borca
Follow-up Comment #16, patch #5893 (project mc): You just can't let it go away, now can you? What is exactly the part that you don't get from my previous message? I don't really care about glib. It is not useful for me. I am pretty sure I wrote: "I *personally* find useless". And I won't lea

[patch #5893] integrated side-by-side textmode diff viewer

2007-05-05 Thread Daniel Borca
Follow-up Comment #14, patch #5893 (project mc): --- Pavel Tsekov <[EMAIL PROTECTED]> wrote: > > Follow-up Comment #13, patch #5893 (project mc): > > Regarding the off-by-one issue - indeed you are right. > In my local copy I've changed "diff" to "gdiff" without > changing 14 to 15. Which on

[patch #5893] integrated side-by-side textmode diff viewer

2007-05-04 Thread Daniel Borca
Follow-up Comment #12, patch #5893 (project mc): You say that the attached piece of code is off by one char? I say it's not. This is the piece of code that is used in all patches inside dff_execute (horizontal diff doesn't affect that portion). (file #12698) __

[patch #5893] integrated side-by-side textmode diff viewer

2007-05-04 Thread Daniel Borca
Follow-up Comment #11, patch #5893 (project mc): I see I hit a soft spot here. Chill! Primo: FYI, I wasn't saying glib is good or bad. I said it's uninteresting to me, as a general concept. Secundo: I think I said that I am not against it. But the fact I wasn't even aware of g_try_malloc() s

[patch #5893] integrated side-by-side textmode diff viewer

2007-05-04 Thread Daniel Borca
Follow-up Comment #8, patch #5893 (project mc): Regarding the colorscheme, you're totally right. I guess I didn't knew what I was doing. No particular reason to be the way it is right now. ___ Reply to this item at:

[patch #5893] integrated side-by-side textmode diff viewer

2007-05-04 Thread Daniel Borca
Follow-up Comment #7, patch #5893 (project mc): Your feedback is welcomed. @1 no there isn't :) check again! @2 I saw this one coming, after FBUF. I don't use glib, and probably I won't use it in the foreseeable future. One of the reasons is that I don't find it very useful, with a few notabl

[patch #5893] integrated side-by-side textmode diff viewer

2007-05-04 Thread Daniel Borca
Follow-up Comment #4, patch #5893 (project mc): Hi, the primary reason to use FBUF was exactly to allow open/close/write/read/etc routines to be replaced by their mc_ counterparts and eventually make the whole thing work on vfs files. So, yes, you hit the nail right on its head :) Another (min

[patch #5893] integrated side-by-side textmode diff viewer

2007-05-03 Thread Daniel Borca
Follow-up Comment #2, patch #5893 (project mc): I just poured in horizontal diff highlight a la xxdiff. (file #12685, file #12686) ___ Additional Item Attachment: File name: mc-4.6.1.ydiff.patch.gzSize:15 KB File name: mc-4.6.1_20