[PATCH] xnc.hlp converted to mandoc format

2007-02-22 Thread Grigory Trenin
Hello, I converted binary xnc.hlp to mandoc format and merged it with mc.1.in. Here are the patches to src/man2hlp.c, doc/mc.1.in (English version), and doc/Makefile.am. You can do $ diff mc.hlp.old mc.hlp to see that nothing was broken by the patch... Of course, there are some minor

Re: [PATCH] Help Viewer - mouse issues

2007-01-10 Thread Grigory Trenin
Pavel Tsekov wrote: On Tue, 2007-01-09 at 19:08, Grigory Trenin wrote: Pavel Tsekov wrote: I am not quite satisfied with that simple solution too. What do you think if I convert xnc.hlp to mandoc format and patch man2hlp respectively? I think it will be sufficient to add to man2hlp

Re: [PATCH] Help Viewer - mouse issues

2007-01-09 Thread Grigory Trenin
Pavel Tsekov wrote: Well, we can go with the simple solution for now - but it should be documented somewhere to prevent further confusion. As to whether it is worth the effort - think about this: Me and you together spent a considerable amount of time on a simple issue - was it worth it ?

Re: [PATCH] Help Viewer - mouse issues

2007-01-05 Thread Grigory Trenin
Pavel Tsekov wrote: Implementing either solution would not remove the necessity of this: [...] need to revise the help files for all languages, to check if they fit in the window, and fix them if necessary. [...] To fix this there should be no preformatted pages involved, IMO. But I may be

Re: [PATCH] Help Viewer - mouse issues

2007-01-04 Thread Grigory Trenin
Pavel Tsekov wrote: I had this idea now. How about fixing the code that captures mouse events from xterm instead ? I.e. when it receives a mouse down event it will record which key was pressed and it will copy this information to the mouse up event ? This will be not always reliable. Suppose

Re: [PATCH] Help Viewer - mouse issues

2007-01-04 Thread Grigory Trenin
Pavel Tsekov wrote: On Wed, 2007-01-03 at 19:19, Grigory Trenin wrote: This is patch is OK, but there are still problems. See this: create_dlg (0, 0, help_lines + 4, HELP_WINDOW_WIDTH + 4, ^^ HELP_WINDOW_WIDTH already is large enough

[PATCH] Help Viewer - mouse issues

2007-01-03 Thread Grigory Trenin
Hello, Here are 3 patches to the mouse issues in the Help Viewer. 1) mouse-rightbutton.patch Returning to a previous node by pressing right mouse button doesn't work in xterm. It works only in Linux console with GPM. The problem is that help_event() catches only GPM_UP event, and it seems that

Re: [PATCH] Help Viewer - mouse issues

2007-01-03 Thread Grigory Trenin
Pavel Tsekov wrote: How about fixing help_follow_link() instead ? IMO, this would be a proper fix if we agree that the leading '\n' is not desired. Good point! Certainly, this would be better. The help format documentation says: The hypertext file is a file that may have one or more

Re: [PATCH] Help Viewer - mouse issues

2007-01-03 Thread Grigory Trenin
Pavel Tsekov wrote: This is patch is OK, but there are still problems. See this: create_dlg (0, 0, help_lines + 4, HELP_WINDOW_WIDTH + 4, ^^ HELP_WINDOW_WIDTH already is large enough to hold the dialog frame. As a resylt if you try to

Re: [PATCH] Help Viewer - mouse issues

2007-01-03 Thread Grigory Trenin
Pavel Tsekov wrote: It seems like man2hlp is producing output with line lengths larget than HELP_TEXT_WIDTH which is incorrect IMO. In some nodes (eg, Menu File Edit) preformatted text is used (it is marked by .nf tag). In that case man2hlp will output the text as is, without trying to wrap

Re: mc, ftp and filmview (fwd)

2006-12-15 Thread Grigory Trenin
OK, but can you tell me a hotkey in mc to copy a full address of file in command line? Try Ctrl+Shift+Enter. It may not work on some terminals, but it works for me. It will copy the full pathname to the command line, eg: /#ftp:ftp.server.local/films/verygoodfilm.avi However, you have to edit

Re: [PATCH] Help Viewer - incorrect behaviour of up arrrow key

2006-12-11 Thread Grigory Trenin
Pavel Tsekov wrote: I am not convinced that this patch is better than your first one. Its basically the same and removes a valid check - it doesn't fix the issue. It does fix the _original_ issue. And that one you are talking about is quite a different thing (see below). It isn't related to

Re: [PATCH] Help Viewer - incorrect behaviour of up arrrow key

2006-12-04 Thread Grigory Trenin
Hello Pavel, Pavel Tsekov wrote: I think the correct solution would be to keep both 'startpoint' and 'currentpoint' in the history but I am open to suggestions. Yes, I thought about it too. This is a good and safe fix. But I have a suggestion. Actually, 'startpoint' is used only once at

Re: [PATCH] Help Viewer - incorrect behaviour of up arrrow key

2006-12-01 Thread Grigory Trenin
Pavel Tsekov wrote: I won't apply this patch yet. I want to investigate further. Oh, now I see that I had hurried over to make that patch. I'll check everything and make another one. Without haste. Regards, Grigory ___ Mc-devel mailing list

[PATCH] Help Viewer - incorrect behaviour of up arrrow key

2006-11-29 Thread Grigory Trenin
, and it should be used here. And by the way, 'startpoint' variable seems to be totally useless. So in my patch I replaced 'startpoint' with 'currentpoint' and removed the 'startpoint' variable completely. Regards, Grigory Trenin --- help.c.orig 2006-11-29 18:06:27.0 +0300 +++ help.c 2006-11-29

Re: [PATCH] Help Viewer - incorrect behaviour of up arrrow key

2006-11-29 Thread Grigory Trenin
s/right arrow/left arrow/g Of course I meant left arrow key when I was talking about going back to the previous topic. Sorry for that. -- Grigory. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel