Viewer's cursor position and growing view (was Re: code improvements for the viewer)

2005-08-08 Thread Pavel Tsekov
Hello, On Mon, 11 Jul 2005, Roland Illig wrote: Pavel Tsekov wrote: Another problem that I see here (though this might be related to some local changes). If growing view is used i.e. viewing .bz2, .gz2, .rpm, etc, the cursor is displayed at the end of the status line until the last page

Re: code improvements for the viewer

2005-07-11 Thread Pavel Tsekov
Hello, On Mon, 11 Jul 2005, Roland Illig wrote: Pavel Tsekov wrote: Another problem that I see here (though this might be related to some local changes). If growing view is used i.e. viewing .bz2, .gz2, .rpm, etc, the cursor is displayed at the end of the status line until the last page

Re: code improvements for the viewer

2005-07-11 Thread Roland Illig
Pavel Tsekov wrote: Now seriously, I do not believe that there are people on this list who we actively following your changes to the viewer. If one does not have knowledge of the code how is he/she supposed to review it? I'd like mcview to be documented as good as possible. Does anyone of you

Re: code improvements for the viewer

2005-07-08 Thread Pavel Tsekov
Hello, On Thu, 7 Jul 2005, Roland Illig wrote: The at all is not correct. Indeed, I have left out the case where mcview is shown in the right panel. I have fixed it. Thanks for testing and the quick note. Ok, it works fine now. Another problem that I see here (though this might be related

Re: code improvements for the viewer

2005-07-07 Thread Roland Illig
Pavel Tsekov wrote: Ok, here we go. I saw this coming but anyway. And no I don't like to blame you. Quick View mode isn't working anymore. It is even funnier because the behaviour differs between slang and ncurses. You deserve to be blamed because you haven't tested the Quick View mode at all.

Re: code improvements for the viewer

2005-07-06 Thread Roland Illig
Pavel Tsekov wrote: Just out of curiosity - can you outline the most important changes that you are going to commmit. The main change is that, for example in the view_display_text() function, coordinate computation had been done relative to the top left corner of the WView widget. One

code improvements for the viewer

2005-07-05 Thread Roland Illig
I have rewritten some parts of the internal viewer (once again). Does anyone want to review that or should I just commit it and prepare to get blamed? It's in the newly created branch with the name rillig-experimental. Do view the differences, just type: cvs diff -rrillig-experimental