Re: mcslang2

2005-09-28 Thread Pavel Tsekov
On Tue, 27 Sep 2005, Roland Illig wrote: Pavel Tsekov wrote: [...] I told you many times - you are too fast, too eager. This is not the right tone for feedback. Leonard hasn't yet committed his change. If he had, this tone would be appropriate. Please choose your words to sound a little

Re: mcslang2

2005-09-28 Thread Marcel Pol
On Wed, 28 Sep 2005 11:10:49 +0300 Pavel Tsekov [EMAIL PROTECTED] wrote: On Tue, 27 Sep 2005, Roland Illig wrote: Pavel Tsekov wrote: [...] I told you many times - you are too fast, too eager. This is not the right tone for feedback. Leonard hasn't yet committed his change. If he

Re: mcslang2

2005-09-28 Thread Pavel Tsekov
On Wed, 28 Sep 2005, Marcel Pol wrote: On Wed, 28 Sep 2005 11:10:49 +0300 Pavel Tsekov [EMAIL PROTECTED] wrote: On Tue, 27 Sep 2005, Roland Illig wrote: Pavel Tsekov wrote: [...] I told you many times - you are too fast, too eager. This is not the right tone for feedback.

Re: mcslang2

2005-09-28 Thread Roland Illig
Pavel Tsekov wrote: Suddenly everyone on this list is only interested in sporting the right tone. Whatever the tone it cannot hide the fact that decisions are made from people that hardly have the skills to do so. Just to remind you: Leonard hasn't made a decision, but only a suggestion.

Re: mcslang2

2005-09-28 Thread Pavel Tsekov
On Wed, 28 Sep 2005, Roland Illig wrote: Pavel Tsekov wrote: Suddenly everyone on this list is only interested in sporting the right tone. Whatever the tone it cannot hide the fact that decisions are made from people that hardly have the skills to do so. Just to remind you: Leonard

Re: mcslang2

2005-09-28 Thread Leonard den Ottolander
Hi Pavel, On Wed, 2005-09-28 at 12:30 +0300, Pavel Tsekov wrote: Suddenly everyone on this list is only interested in sporting the right tone. Friendly or at least polite communication motivates people to help out with the project. Even criticism can very be helpful but it should be

Re: mcslang2

2005-09-28 Thread Leonard den Ottolander
Hi Pavel, On Wed, 2005-09-28 at 13:00 +0300, Pavel Tsekov wrote: He was insisting that everything is fine . I wasn't. I just wanted people to have the actual patch I used so they at least have something that applies. The original patch wasn't very useful in that sense unless you'd figured you'd

Re: mcslang2

2005-09-28 Thread Pavel Tsekov
On Wed, 28 Sep 2005, Leonard den Ottolander wrote: [...] Whatever the tone it cannot hide the fact that decisions are made from people that hardly have the skills to do so. I think you are a.o. things referring to my lack of knowledge on configure magic. Firstly I am not making decisions,

Re: mcslang2

2005-09-28 Thread Leonard den Ottolander
Hi Pavel, On Wed, 2005-09-28 at 15:12 +0300, Pavel Tsekov wrote: How convenient - loose other peoples time instead of your own. I think I've invested enough time in mc in the last year that I can expect somebody to help me out with a subject I'm not that familiar without having to feel ashamed.

Re: mcslang2

2005-09-28 Thread Pavel Tsekov
On Wed, 28 Sep 2005, Leonard den Ottolander wrote: I think I've invested enough time in mc in the last year that I can expect somebody to help me out with a subject I'm not that familiar without having to feel ashamed. Reading the autoconf manual and understanding all the macros will cost me

Re: mcslang2

2005-09-27 Thread Pavel Tsekov
On Tue, 27 Sep 2005, Leonard den Ottolander wrote: All the discussion about slang2 and the utf-8 patch has inspired me to create an internal version of slang-2.0.4 to mc. This patch might still be somewhat rough around the edges, but it builds after a configure --with-screen=mcslang2. Please

Re: mcslang2

2005-09-27 Thread Pavel Tsekov
This is plain wrong: diff -pruN mc/acinclude.m4 mc.slang2/acinclude.m4 --- mc/acinclude.m4 2005-07-20 14:45:13.0 +0200 +++ mc.slang2/acinclude.m4 2005-09-26 22:31:34.0 +0200 @@ -674,7 +674,11 @@ AC_DEFUN([MC_SLANG_PRIVATE], [ AC_CACHE_CHECK([if S-Lang exports private

Re: mcslang2

2005-09-27 Thread Leonard den Ottolander
Hi Pavel, On Tue, 2005-09-27 at 15:13 +0300, Pavel Tsekov wrote: This is plain wrong: diff -pruN mc/acinclude.m4 mc.slang2/acinclude.m4 + #if SLANG_VERSION 2 You are not writing C code here - this is shell scripting. A similar construct is used on line 684 in the original

Re: mcslang2

2005-09-27 Thread Pavel Tsekov
On Tue, 2005-09-27 at 15:13 +0300, Pavel Tsekov wrote: This is plain wrong: diff -pruN mc/acinclude.m4 mc.slang2/acinclude.m4 + #if SLANG_VERSION 2 You are not writing C code here - this is shell scripting. A similar construct is used on line 684 in the original file.

Re: mcslang2

2005-09-27 Thread Leonard den Ottolander
feedback to improve it. Sorry for not posting the correct patch immediately. configure, make distcheck and a consequent build after configure --with-screen=mcslang2 is fine (assuming the correct patch is applied, which still awaits moderator approval, but you got it already). Please explain to me why

Re: mcslang2

2005-09-27 Thread Roland Illig
was perfect yet. Looking for some feedback to improve it. Sorry for not posting the correct patch immediately. configure, make distcheck and a consequent build after configure --with-screen=mcslang2 is fine (assuming the correct patch is applied, which still awaits moderator approval, but you got

Re: mcslang2

2005-09-27 Thread Pavel Tsekov
On Tue, 2005-09-27 at 20:39 +0200, Pavel Tsekov wrote: Bootstrap the code and see the generated configure file. Similiar construct is used but in different context. I told you many times - you are too fast, too eager. I didn't say this patch was perfect yet. Looking for some feedback

Re: mcslang2

2005-09-27 Thread Leonard den Ottolander
Hi Roland, On Tue, 2005-09-27 at 21:12 +0200, Roland Illig wrote: As Pavel already said, you are writing shell programs here. So the #if, #else and #endif are actually comments. Your linker will most likely have -lslang -lslang2 somewhere in its command line. I now see the private refers to

Re: mcslang2

2005-09-27 Thread Leonard den Ottolander
Hi Pavel, On Tue, 2005-09-27 at 21:47 +0200, Pavel Tsekov wrote: It is obvious that you are missing basic knowledge on configure magic. Right :-) . Thank you for helping me out there. You did some copy/paste and you expect that it will just work ? Well, when building --with-screen=mcslang2

Re: mcslang2

2005-09-27 Thread Leonard den Ottolander
Hi, On Tue, 2005-09-27 at 21:56 +0200, Leonard den Ottolander wrote: I now see the private refers to the private slang functions in the *system* slang, Hm. I guess the above is not correct. It refers to the private functions in any version. Do we need -lslang2 when linking against slang2? Or

Re: mcslang2

2005-09-27 Thread Bart Oldeman
On Tue, 27 Sep 2005, Leonard den Ottolander wrote: All the discussion about slang2 and the utf-8 patch has inspired me to create an internal version of slang-2.0.4 to mc. This patch might still be somewhat rough around the edges, but it builds after a configure --with-screen=mcslang2. Please

Re: mcslang2

2005-09-27 Thread Roland Illig
Pavel Tsekov wrote: [...] I told you many times - you are too fast, too eager. This is not the right tone for feedback. Leonard hasn't yet committed his change. If he had, this tone would be appropriate. Please choose your words to sound a little more polite. Roland

Re: mcslang2

2005-09-27 Thread Leonard den Ottolander
with mcslang2. Not sure if this is caused by the usage of slang2 or the fact that I ran mc from the build directory.) And, no, -lslang2 doesn't make sense. It's just -lslang for both slang1 and slang2. Right. Thanks :-) . That solves the discussed issue. The discussed hunks can thus be dropped

mcslang2

2005-09-26 Thread Leonard den Ottolander
Hi, All the discussion about slang2 and the utf-8 patch has inspired me to create an internal version of slang-2.0.4 to mc. This patch might still be somewhat rough around the edges, but it builds after a configure --with-screen=mcslang2. Please review. Leonard. -- mount -t life -o ro /dev/dna