[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add bnwiki, enwiki and commons as import source in bd.wikime...

2017-01-10 Thread Urbanecm (Code Review)
Urbanecm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331584 ) Change subject: Add bnwiki, enwiki and commons as import source in bd.wikimedia.org .. Add bnwiki, enwiki and commons as import source in

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [wip] LabelWidget: Remove the need for 'simulateLabelClick'

2017-01-10 Thread Prtksxna (Code Review)
Prtksxna has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331583 ) Change subject: [wip] LabelWidget: Remove the need for 'simulateLabelClick' .. [wip] LabelWidget: Remove the need for 'simulateLabelClick'

[MediaWiki-commits] [Gerrit] oojs/ui[master]: demo: Add a LabelWidget that has a corresponding TextInputWi...

2017-01-10 Thread Prtksxna (Code Review)
Prtksxna has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331582 ) Change subject: demo: Add a LabelWidget that has a corresponding TextInputWidget .. demo: Add a LabelWidget that has a corresponding TextIn

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: don't generate iOS language JSON files

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331543 ) Change subject: Hygiene: don't generate iOS language JSON files .. Hygiene: don't generate iOS language JSON files Change-Id: I

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update: languages supported & namespace translation

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331541 ) Change subject: Update: languages supported & namespace translation .. Update: languages supported & namespace translation sc

[MediaWiki-commits] [Gerrit] oojs/ui[master]: doc: Use 'an' instead of 'a' before 'HTML'

2017-01-10 Thread Prtksxna (Code Review)
Prtksxna has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331581 ) Change subject: doc: Use 'an' instead of 'a' before 'HTML' .. doc: Use 'an' instead of 'a' before 'HTML' Change-Id: Ie8069355da4d9ff83ab61

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.messagePoster.factory.js: Use formatversion=2 for ...

2017-01-10 Thread Fomafix (Code Review)
Fomafix has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331580 ) Change subject: mediawiki.messagePoster.factory.js: Use formatversion=2 for API request .. mediawiki.messagePoster.factory.js: Use formatve

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base: missing quotes around is_virtual 'false' for ipmi

2017-01-10 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331579 ) Change subject: base: missing quotes around is_virtual 'false' for ipmi .. base: missing quotes around is_virtual 'false' for ipmi < paravoid

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.reasonSuggest: Execute API request before document...

2017-01-10 Thread Fomafix (Code Review)
Fomafix has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331578 ) Change subject: mediawiki.reasonSuggest: Execute API request before document ready .. mediawiki.reasonSuggest: Execute API request before d

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix University of Mumbai event throttle rule

2017-01-10 Thread Dereckson (Code Review)
Dereckson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331577 ) Change subject: Fix University of Mumbai event throttle rule .. Fix University of Mumbai event throttle rule Bug: T154312 Change-Id: I3f8

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: change NearbyResult reference from implementation t...

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331540 ) Change subject: Hygiene: change NearbyResult reference from implementation to interface .. Hygiene: change NearbyResult referen

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Added tests for cherry_pick function of diff module

2017-01-10 Thread Phantom42 (Code Review)
Phantom42 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331576 ) Change subject: Added tests for cherry_pick function of diff module .. Added tests for cherry_pick function of diff module Bug: T130805 C

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: add Card.title() default implementation

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331539 ) Change subject: Hygiene: add Card.title() default implementation .. Hygiene: add Card.title() default implementation Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Fix linkTitleChangeListener

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/324460 ) Change subject: Fix linkTitleChangeListener .. Fix linkTitleChangeListener I2ecf575b introduced a regression where the linkTitl

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[REL1_28]: Remove warning about missing site ID

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331571 ) Change subject: Remove warning about missing site ID .. Remove warning about missing site ID Seems to interfere with qunit some

[MediaWiki-commits] [Gerrit] mediawiki...Refreshed[master]: Remove unused wikifont directory

2017-01-10 Thread SamanthaNguyen (Code Review)
SamanthaNguyen has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331445 ) Change subject: Remove unused wikifont directory .. Remove unused wikifont directory This directory and the relevant CSS cla

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: wip Matching gifts import.

2017-01-10 Thread Eileen (Code Review)
Eileen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331575 ) Change subject: wip Matching gifts import. .. wip Matching gifts import. This is based on the assumption that we are not there with the full

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Replace assertRaises with assertRaisesRegex in bot_tests.py

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331160 ) Change subject: Replace assertRaises with assertRaisesRegex in bot_tests.py .. Replace assertRaises with assertRaisesRegex in bo

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Change preview to check *_ABANDON_END with tokens

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331570 ) Change subject: Change preview to check *_ABANDON_END with tokens .. Change preview to check *_ABANDON_END with tokens ... inst

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Don't hide preview when user dwells on link

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331374 ) Change subject: Don't hide preview when user dwells on link .. Don't hide preview when user dwells on link ... after dwelling o

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Don't reset interaction info when dwelling back to a link

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331563 ) Change subject: Don't reset interaction info when dwelling back to a link .. Don't reset interaction info when dwelling back to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: (debug) test replacing require_package with package for ipmi

2017-01-10 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331574 ) Change subject: (debug) test replacing require_package with package for ipmi .. (debug) test replacing require_package with package for ipmi

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: New: make it harder to be a single lingual dev

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331573 ) Change subject: New: make it harder to be a single lingual dev .. New: make it harder to be a single lingual dev This patch may be cont

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: getFirstChars(): don't use quantifiers with user-supplied count

2017-01-10 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331572 ) Change subject: getFirstChars(): don't use quantifiers with user-supplied count .. getFirstChars(): don't use quantifiers with user-supplied

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[REL1_28]: Remove warning about missing site ID

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329774 ) Change subject: Remove warning about missing site ID .. Remove warning about missing site ID Seems to interfere with qunit some

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[REL1_28]: Remove warning about missing site ID

2017-01-10 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331571 ) Change subject: Remove warning about missing site ID .. Remove warning about missing site ID Seems to interfere with qunit somehow. Bug: T15

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Cleanup static analysis errors

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331568 ) Change subject: Cleanup static analysis errors .. Cleanup static analysis errors While prepping the code base for using etsy/ph

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Change preview to check *_ABANDON_END with tokens

2017-01-10 Thread Jhernandez (Code Review)
Jhernandez has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331570 ) Change subject: Change preview to check *_ABANDON_END with tokens .. Change preview to check *_ABANDON_END with tokens ... instead of us

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused method in SharedPreferenceCookieManager

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331569 ) Change subject: Hygiene: remove unused method in SharedPreferenceCookieManager .. Hygiene: remove unused method in SharedPreferenceCooki

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Cleanup static analysis errors

2017-01-10 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331568 ) Change subject: Cleanup static analysis errors .. Cleanup static analysis errors While prepping the code base for using etsy/phan i found a f

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: use ReleaseUtil directly instead of wrapping in Wik...

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331567 ) Change subject: Hygiene: use ReleaseUtil directly instead of wrapping in WikipediaApp .. Hygiene: use ReleaseUtil directly instead of w

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: actions: Add token to PREVIEW_ABANDON_**

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331566 ) Change subject: actions: Add token to PREVIEW_ABANDON_** .. actions: Add token to PREVIEW_ABANDON_** Change-Id: Ic84aa0c3144761

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Run previewAbandon action creator tests

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331565 ) Change subject: Run previewAbandon action creator tests .. Run previewAbandon action creator tests Unfortunately, QUnit doesn't

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toollabs: bigbrother: stop tracking jobs when rcfile is deleted

2017-01-10 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330265 ) Change subject: toollabs: bigbrother: stop tracking jobs when rcfile is deleted .. toollabs: bigbrother: stop tracking jobs wh

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Run previewAbandon action creator tests

2017-01-10 Thread Phuedx (Code Review)
Phuedx has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331565 ) Change subject: Run previewAbandon action creator tests .. Run previewAbandon action creator tests Unfortunately, QUnit doesn't complain tha

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: actions: Add token to PREVIEW_ABANDON_**

2017-01-10 Thread Phuedx (Code Review)
Phuedx has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331566 ) Change subject: actions: Add token to PREVIEW_ABANDON_** .. actions: Add token to PREVIEW_ABANDON_** Change-Id: Ic84aa0c3144761b93beff9b7b82

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs dnsrecursor: add wikimania2018

2017-01-10 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331526 ) Change subject: labs dnsrecursor: add wikimania2018 .. labs dnsrecursor: add wikimania2018 Bug: T155038 Change-Id: I4ae523fb9

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused param in MainPageCard

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331538 ) Change subject: Hygiene: remove unused param in MainPageCard .. Hygiene: remove unused param in MainPageCard Change-Id: Ibf70e7

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: change SearchClient superclass to DummyClient

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331537 ) Change subject: Hygiene: change SearchClient superclass to DummyClient .. Hygiene: change SearchClient superclass to DummyClient

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused DummyClient generic parameter

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331536 ) Change subject: Hygiene: remove unused DummyClient generic parameter .. Hygiene: remove unused DummyClient generic parameter Ch

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Dwelling back on a link won't reset the preview state

2017-01-10 Thread Jhernandez (Code Review)
Jhernandez has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331563 ) Change subject: Dwelling back on a link won't reset the preview state .. Dwelling back on a link won't reset the preview state Change-Id

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix span Parcelable implementations

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331434 ) Change subject: Fix span Parcelable implementations .. Fix span Parcelable implementations Change-Id: I0d22917c9f90623c4834bb42

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Create ve.isClipboardMimeTypeSupported

2017-01-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331562 ) Change subject: Create ve.isClipboardMimeTypeSupported .. Create ve.isClipboardMimeTypeSupported Centralizes some logic so we can reuse it e

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Simplified if-else

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331102 ) Change subject: Simplified if-else .. Simplified if-else Change-Id: Ic20984d51392b35a96cbfb6fb53ef028cffc3472 --- M repo/includ

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: move SyntaxHighlight styling classes to enum

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331431 ) Change subject: Hygiene: move SyntaxHighlight styling classes to enum .. Hygiene: move SyntaxHighlight styling classes to enum

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert SyntaxHighlighter comments to code

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331421 ) Change subject: Hygiene: convert SyntaxHighlighter comments to code .. Hygiene: convert SyntaxHighlighter comments to code Chan

[MediaWiki-commits] [Gerrit] mediawiki...Nimbus[master]: Fix jshint test

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331251 ) Change subject: Fix jshint test .. Fix jshint test Partial fix was by @MtDu Also use jshint in grunt. Bug: T154802 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Fix class annotations

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/328862 ) Change subject: Fix class annotations .. Fix class annotations Change-Id: I854fafea726fcd5ea82246b5cf1c4c08d9ec258a --- M utils

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: HTMLForm: Use HTMLMultiSelectField for HTMLTagFilter

2017-01-10 Thread Florianschmidtwelzow (Code Review)
Florianschmidtwelzow has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331561 ) Change subject: HTMLForm: Use HTMLMultiSelectField for HTMLTagFilter .. HTMLForm: Use HTMLMultiSelectField for HTMLTagFilter I

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Add fields to composer.json

2017-01-10 Thread Samwilson (Code Review)
Samwilson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331560 ) Change subject: Add fields to composer.json .. Add fields to composer.json This change adds some missing fields to the Composer file. Ch

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Adds Page: pages outputted by tag as dependenc...

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/301924 ) Change subject: Adds Page: pages outputted by tag as dependencies of the current page .. Adds Page: pages outputted by tag as

[MediaWiki-commits] [Gerrit] mediawiki...Gadgets[master]: Localisation of the namespaces in French

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296080 ) Change subject: Localisation of the namespaces in French .. Localisation of the namespaces in French Change-Id: I7be4a1b78f5f4a

[MediaWiki-commits] [Gerrit] integration/config[master]: Replace -phpunit with -composer-hhvm-jessie for operations/m...

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331099 ) Change subject: Replace -phpunit with -composer-hhvm-jessie for operations/mediawiki-config .. Replace -phpunit with -composer-

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: build: Update PHPUnit from 3.7 to 4.8, add phplint to compos...

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331093 ) Change subject: build: Update PHPUnit from 3.7 to 4.8, add phplint to composer-test .. build: Update PHPUnit from 3.7 to 4.8, a

[MediaWiki-commits] [Gerrit] integration/docroot[master]: doc: Remove unused htaccess file

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331559 ) Change subject: doc: Remove unused htaccess file .. doc: Remove unused htaccess file doc.wikimedia.org was upgraded to Apache 2

[MediaWiki-commits] [Gerrit] integration/docroot[master]: doc: Remove unused htaccess file

2017-01-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331559 ) Change subject: doc: Remove unused htaccess file .. doc: Remove unused htaccess file doc.wikimedia.org was upgraded to Apache 2.4 and overr

[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint: Re-add dir.php to doc.wm.org DirectoryIndex

2017-01-10 Thread Krinkle (Code Review)
Hello Thcipriani, Hashar, jenkins-bot, Dzahn, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/331558 to review the following change. Change subject: contint: Re-add dir.php to doc.wm.org DirectoryIndex .

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.7]: API/getLangLinks: Use isset when looking up $langnames

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331556 ) Change subject: API/getLangLinks: Use isset when looking up $langnames .. API/getLangLinks: Use isset when looking up $langnames

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: API/getLangLinks: Use isset when looking up $langnames

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331554 ) Change subject: API/getLangLinks: Use isset when looking up $langnames .. API/getLangLinks: Use isset when looking up $langnames

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Bump grunt-css-url-embed to latest

2017-01-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331557 ) Change subject: build: Bump grunt-css-url-embed to latest .. build: Bump grunt-css-url-embed to latest grunt-css-url-embed 1.6.1 →

[MediaWiki-commits] [Gerrit] operations/puppet[production]: gerrit: Reduce tableEven/OddRowColor contrast.

2017-01-10 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331553 ) Change subject: gerrit: Reduce tableEven/OddRowColor contrast. .. gerrit: Reduce tableEven/OddRowColor contrast. The even rows are fa

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.7]: API/getLangLinks: Use isset when looking up $langnames

2017-01-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331556 ) Change subject: API/getLangLinks: Use isset when looking up $langnames .. API/getLangLinks: Use isset when looking up $langnames This should j

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mediawiki videoscaler: include mediawiki::common role

2017-01-10 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331555 ) Change subject: mediawiki videoscaler: include mediawiki::common role .. mediawiki videoscaler: include mediawiki::common role The other medi

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: API/getLangLinks: Use isset when looking up $langnames

2017-01-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331554 ) Change subject: API/getLangLinks: Use isset when looking up $langnames .. API/getLangLinks: Use isset when looking up $langnames This should

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: consolidate parcel test logic in util

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331405 ) Change subject: Hygiene: consolidate parcel test logic in util .. Hygiene: consolidate parcel test logic in util Refactoring to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: gerrit: Reduce tableEven/OddRowColor contrast.

2017-01-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331553 ) Change subject: gerrit: Reduce tableEven/OddRowColor contrast. .. gerrit: Reduce tableEven/OddRowColor contrast. The even rows are fairly d

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused method, WikiSite.authorityToDesktop

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331400 ) Change subject: Hygiene: remove unused method, WikiSite.authorityToDesktop .. Hygiene: remove unused method, WikiSite.authorityT

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Revert "Remove MWVersion, fold its two functions int...

2017-01-10 Thread Reedy (Code Review)
Hello Thcipriani, Chad, Krinkle, 20after4, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/331552 to review the following change. Change subject: Revert "Revert "Remove MWVersion, fold its two functions into MWMultiVersion""

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: Remove obsolete check for JSONArray when checking p...

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330924 ) Change subject: Hygiene: Remove obsolete check for JSONArray when checking page protection .. Hygiene: Remove obsolete check fo

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused PageProps class

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331551 ) Change subject: Hygiene: remove unused PageProps class .. Hygiene: remove unused PageProps class Change-Id: Ic1480b187b003ca7b60743e903

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Get wikibase item ID in MW API page lead requests

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330819 ) Change subject: Get wikibase item ID in MW API page lead requests .. Get wikibase item ID in MW API page lead requests RESTBase

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.7]: Reduce WAN object cache logging spam for reject set() calls

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331549 ) Change subject: Reduce WAN object cache logging spam for reject set() calls .. Reduce WAN object cache logging spam for reject s

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Check for notifications only for 1 day after last descriptio...

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330693 ) Change subject: Check for notifications only for 1 day after last description edit. .. Check for notifications only for 1 day a

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Reduce WAN object cache logging spam for reject set() calls

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331547 ) Change subject: Reduce WAN object cache logging spam for reject set() calls .. Reduce WAN object cache logging spam for reject s

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: change terminology from night to dark mode

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331550 ) Change subject: Hygiene: change terminology from night to dark mode .. Hygiene: change terminology from night to dark mode Change-Id: I

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.7]: Reduce WAN object cache logging spam for reject set() calls

2017-01-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331549 ) Change subject: Reduce WAN object cache logging spam for reject set() calls .. Reduce WAN object cache logging spam for reject set() calls Cha

[MediaWiki-commits] [Gerrit] mediawiki...Wikilog[master]: Make static function non-static

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331530 ) Change subject: Make static function non-static .. Make static function non-static There's no reason why they need to be static

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[wmf/1.29.0-wmf.5.1]: Remove warning about missing site ID

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331548 ) Change subject: Remove warning about missing site ID .. Remove warning about missing site ID Seems to interfere with qunit some

[MediaWiki-commits] [Gerrit] mediawiki...MultiUpload[master]: Remove old SpecialUpload.1.21.3.php

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329798 ) Change subject: Remove old SpecialUpload.1.21.3.php .. Remove old SpecialUpload.1.21.3.php Bug: T154363 Change-Id: I663d754784c

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add an refresh probability comment to worthRefreshPopular()

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331206 ) Change subject: Add an refresh probability comment to worthRefreshPopular() .. Add an refresh probability comment to worthRefres

[MediaWiki-commits] [Gerrit] mediawiki...CodeReview[master]: IndexPager (which TablePager extends) is a ContextSource

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331545 ) Change subject: IndexPager (which TablePager extends) is a ContextSource .. IndexPager (which TablePager extends) is a ContextSo

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[wmf/1.29.0-wmf.5.1]: Remove warning about missing site ID

2017-01-10 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331548 ) Change subject: Remove warning about missing site ID .. Remove warning about missing site ID Seems to interfere with qunit somehow. Bug: T15

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' of https://gerrit.wikimedia.org/r/wiki...

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331546 ) Change subject: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment .. Merge bran

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Added reason suggestion in block/delete/protect forms

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330447 ) Change subject: Added reason suggestion in block/delete/protect forms .. Added reason suggestion in block/delete/protect forms

[MediaWiki-commits] [Gerrit] mediawiki...PageLanguageApi[master]: Change PHP array syntax from array(...) to [...]

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331493 ) Change subject: Change PHP array syntax from array(...) to [...] .. Change PHP array syntax from array(...) to [...] Also * Use

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.7]: registration: Don't initialize MWServices super early

2017-01-10 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331522 ) Change subject: registration: Don't initialize MWServices super early .. registration: Don't initialize MWServices super early Previo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Reduce WAN object cache logging spam for reject set() calls

2017-01-10 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331547 ) Change subject: Reduce WAN object cache logging spam for reject set() calls .. Reduce WAN object cache logging spam for reject set() ca

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga/CI: give all shell scripts a file extension

2017-01-10 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/327592 ) Change subject: icinga/CI: give all shell scripts a file extension .. icinga/CI: give all shell scripts a file extension As outlined

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' of https://gerrit.wikimedia.org/r/wiki...

2017-01-10 Thread Eileen (Code Review)
Eileen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331546 ) Change subject: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment .. Merge branch 'master' o

[MediaWiki-commits] [Gerrit] mediawiki...CodeReview[master]: IndexPager (which TablePager extends) is a ContextSource

2017-01-10 Thread Jack Phoenix (Code Review)
Jack Phoenix has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331545 ) Change subject: IndexPager (which TablePager extends) is a ContextSource .. IndexPager (which TablePager extends) is a ContextSource C

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: clean up static data

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331544 ) Change subject: Hygiene: clean up static data .. Hygiene: clean up static data • Use immutable maps • Don't use wildcard imports • Ho

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: don't generate iOS language JSON files

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331543 ) Change subject: Hygiene: don't generate iOS language JSON files .. Hygiene: don't generate iOS language JSON files Change-Id: Ieda41251

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[wmf/1.29.0-wmf.7]: Remove warning about missing site ID

2017-01-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331542 ) Change subject: Remove warning about missing site ID .. Remove warning about missing site ID Seems to interfere with qunit some

[MediaWiki-commits] [Gerrit] operations/puppet[production]: gerrit: alternate change list row colors

2017-01-10 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/49993 ) Change subject: gerrit: alternate change list row colors .. gerrit: alternate change list row colors To improve readability of Gerrit

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[wmf/1.29.0-wmf.7]: Remove warning about missing site ID

2017-01-10 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331542 ) Change subject: Remove warning about missing site ID .. Remove warning about missing site ID Seems to interfere with qunit somehow. Bug: T15

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: change NearbyResult reference from implementation t...

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331540 ) Change subject: Hygiene: change NearbyResult reference from implementation to interface .. Hygiene: change NearbyResult reference from

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused DummyClient generic parameter

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331536 ) Change subject: Hygiene: remove unused DummyClient generic parameter .. Hygiene: remove unused DummyClient generic parameter Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: add Card.title() default implementation

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331539 ) Change subject: Hygiene: add Card.title() default implementation .. Hygiene: add Card.title() default implementation Change-Id: I1f2a7e

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update: languages supported & namespace translation

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331541 ) Change subject: Update: languages supported & namespace translation .. Update: languages supported & namespace translation scripts/ge

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused param in MainPageCard

2017-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331538 ) Change subject: Hygiene: remove unused param in MainPageCard .. Hygiene: remove unused param in MainPageCard Change-Id: Ibf70e79d0fdbc3

  1   2   3   >