[MediaWiki-commits] [Gerrit] improved documentation in constraint class - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219861 Change subject: improved documentation in constraint class .. improved documentation in constraint class Change-Id: If170194af2ca7e

[MediaWiki-commits] [Gerrit] fixed tab/space issues in special page - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219860 Change subject: fixed tab/space issues in special page .. fixed tab/space issues in special page Change-Id: Id85bde4d455d8566381c61

[MediaWiki-commits] [Gerrit] updated README.md - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219858 Change subject: updated README.md .. updated README.md Change-Id: I5dd89aebf0c6cbb9c555ac961e29f3609353df41 --- M README.md 1 file

[MediaWiki-commits] [Gerrit] renamed maintenance script - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219856 Change subject: renamed maintenance script .. renamed maintenance script * also used error method of superclass Change-Id: I55fd77

[MediaWiki-commits] [Gerrit] fixed bug in multi value checker test - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219371 Change subject: fixed bug in multi value checker test .. fixed bug in multi value checker test Change-Id: Ifcbbaaa3c1aa34397e3da4a1

[MediaWiki-commits] [Gerrit] adopted violation tests to work with new setup - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: adopted violation tests to work with new setup .. adopted violation tests to work with new setup Change-Id: I4b3e850acd276657daaf5f1ec416537b603acfd

[MediaWiki-commits] [Gerrit] adopted violation tests to work with new setup - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219362 Change subject: adopted violation tests to work with new setup .. adopted violation tests to work with new setup Change-Id: I4b3e85

[MediaWiki-commits] [Gerrit] please work - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: please work .. please work Change-Id: I4f6252ff3fb4a1288234edb96313875944176535 --- A .jscsrc A .jshintignore A .jshintrc M WikibaseQualityConstrain

[MediaWiki-commits] [Gerrit] added missing i18n - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219352 Change subject: added missing i18n .. added missing i18n Change-Id: I6d3a4a75cd425a551fa4f6afbfffa279014e0fc0 --- M i18n/en.json M

[MediaWiki-commits] [Gerrit] added missing i18n - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219342 Change subject: added missing i18n .. added missing i18n Change-Id: Iab45d878f967bbe3dac9c2a891cf6770a5d77143 --- M i18n/en.json M

[MediaWiki-commits] [Gerrit] add missing internationalitation - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: add missing internationalitation .. add missing internationalitation should fix test Change-Id: I9240d1d91745fc33bdbf5fdaeeb73e95d8a638ba (cherry p

[MediaWiki-commits] [Gerrit] please work - change (mediawiki...WikibaseQualityExternalValidation)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219273 Change subject: please work .. please work Change-Id: Iacba18ac5ce7145876eb5434dc87345ca50c05ba --- M composer.json M maintenance/U

[MediaWiki-commits] [Gerrit] please work - change (mediawiki...WikibaseQualityExternalValidation)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219259 Change subject: please work .. please work Change-Id: Ibf64a886029fd74b01908a09ae7489d03a51a4ca --- A .jscsrc A .jshintignore A .js

[MediaWiki-commits] [Gerrit] please work - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219232 Change subject: please work .. please work Change-Id: I4f6252ff3fb4a1288234edb96313875944176535 --- M composer.json 1 file changed,

[MediaWiki-commits] [Gerrit] fixed buildNotice method - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219231 Change subject: fixed buildNotice method .. fixed buildNotice method Change-Id: I957e4d979333bebbbf072243b80730f2d3fdf357 --- M spe

[MediaWiki-commits] [Gerrit] beautified checkers - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219222 Change subject: beautified checkers .. beautified checkers Change-Id: I7653bd5455f0e24b3d5651162e4d5527b12959d6 --- M includes/Cons

[MediaWiki-commits] [Gerrit] add missing internationalitation - change (mediawiki...WikibaseQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: add missing internationalitation .. add missing internationalitation should fix test Change-Id: I9240d1d91745fc33bdbf5fdaeeb73e95d8a638ba --- M i18

[MediaWiki-commits] [Gerrit] Copied i18n from master to v1. - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219142 Change subject: Copied i18n from master to v1. .. Copied i18n from master to v1. Change-Id: I8ea1385a4d704577b1243a139bdb50ee8c5ff0

[MediaWiki-commits] [Gerrit] Copied i18n from master to v1. - change (mediawiki...WikidataQualityExternalValidation)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219141 Change subject: Copied i18n from master to v1. .. Copied i18n from master to v1. Change-Id: Ic104213ce284735e046fff2342571a86ef9a13

[MediaWiki-commits] [Gerrit] Copied i18n from master to v1. - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219140 Change subject: Copied i18n from master to v1. .. Copied i18n from master to v1. Change-Id: I0ed0e2dc59b738aa0350d790b4963cd7a47b6e

[MediaWiki-commits] [Gerrit] Copied i18n from master to v1. - change (mediawiki...WikidataQuality)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/219138 Change subject: Copied i18n from master to v1. .. Copied i18n from master to v1. Change-Id: I09d49430b8ef30ae61ab933ce39189319c8afd

[MediaWiki-commits] [Gerrit] implements some more of Daniels hints - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: implements some more of Daniels hints .. implements some more of Daniels hints Change-Id: I8f46bd61f93929d5475684bf319ce9e1508de2f2 --- M i18n/en.js

[MediaWiki-commits] [Gerrit] implements some of Daniels hints - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: implements some of Daniels hints .. implements some of Daniels hints done for: * EvaluateConstraintReportJobService.php * TypeCheckerHelper.php * Va

[MediaWiki-commits] [Gerrit] remove Format check due to security reasons - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: remove Format check due to security reasons .. remove Format check due to security reasons T101467 Change-Id: I28d2850f89916a759b2ecadeca721d3b9ccb

[MediaWiki-commits] [Gerrit] implements some of Daniels hints - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: implements some of Daniels hints .. implements some of Daniels hints done for: * EvaluateConstraintReportJobService.php * TypeCheckerHelper.php * Va

[MediaWiki-commits] [Gerrit] mainly i18n of violation messages in checkers - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/217279 Change subject: mainly i18n of violation messages in checkers .. mainly i18n of violation messages in checkers * also code styling

[MediaWiki-commits] [Gerrit] this time #andreasforgottocommit - change (mediawiki...WikidataQuality)

Andreasburmeister has submitted this change and it was merged. Change subject: this time #andreasforgottocommit .. this time #andreasforgottocommit Change-Id: I3441555fff974ad1688e72d5c1caf36648fbc492 --- M specials/SpecialViol

[MediaWiki-commits] [Gerrit] this time #andreasforgottocommit - change (mediawiki...WikidataQuality)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/216980 Change subject: this time #andreasforgottocommit .. this time #andreasforgottocommit Change-Id: I3441555fff974ad1688e72d5c1caf36648

[MediaWiki-commits] [Gerrit] renamed a variable with a seemingly bad name - change (mediawiki...WikidataQuality)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/216965 Change subject: renamed a variable with a seemingly bad name .. renamed a variable with a seemingly bad name Change-Id: I2c911f614e

[MediaWiki-commits] [Gerrit] Add changes introduced by displaying icons - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: Add changes introduced by displaying icons .. Add changes introduced by displaying icons Change-Id: I471d867080e820866764d39d438a94e2a2424706 ---

[MediaWiki-commits] [Gerrit] Just some grammar/spelling ... - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: Just some grammar/spelling ... .. Just some grammar/spelling ... Not important but nevertheless disturbed me ;) Change-Id: Id95083830e3fa38024ec4b7

[MediaWiki-commits] [Gerrit] add try catch in constraintReport helper that caused crash - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: add try catch in constraintReport helper that caused crash .. add try catch in constraintReport helper that caused crash + change deferred job to st

[MediaWiki-commits] [Gerrit] remove evaluation since it won't be deployed in time - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: remove evaluation since it won't be deployed in time .. remove evaluation since it won't be deployed in time Change-Id: Ib67d10aeef40a85239b6c656192

[MediaWiki-commits] [Gerrit] save parameters in violation - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: save parameters in violation .. save parameters in violation enabling us to display nice messages and distinguish bad bad and very bad violations fo

[MediaWiki-commits] [Gerrit] change job so it should finally work - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: change job so it should finally work .. change job so it should finally work only use scalars in params use full namespace Change-Id: I2cefe3504caf

[MediaWiki-commits] [Gerrit] add js to expand constraint parameters + minor changes in job - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: add js to expand constraint parameters + minor changes in job .. add js to expand constraint parameters + minor changes in job Change-Id: I3b337b347

[MediaWiki-commits] [Gerrit] minor changes for Job - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: minor changes for Job .. minor changes for Job Change-Id: If998a0b282057025ece654c316876542587cb779 --- M WikidataQualityConstraints.php M includes/

[MediaWiki-commits] [Gerrit] changed job so it uses service to write log and prepare message - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: changed job so it uses service to write log and prepare message .. changed job so it uses service to write log and prepare message therefore, adopte

[MediaWiki-commits] [Gerrit] allow different logging methods for the eval job - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/209197 Change subject: allow different logging methods for the eval job .. allow different logging methods for the eval job also fixed iss

[MediaWiki-commits] [Gerrit] add ConstraintRepositoy - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: add ConstraintRepositoy .. add ConstraintRepositoy therefore, adapt DelegatingConstraintChecker (add __DIR__ to construct of JSONFileEntityLookup be

[MediaWiki-commits] [Gerrit] fix wrong autocompletion for use Statement in ConstraintChecker - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: fix wrong autocompletion for use Statement in ConstraintChecker .. fix wrong autocompletion for use Statement in ConstraintChecker Change-Id: I0bd04

[MediaWiki-commits] [Gerrit] worked on job for evaluation - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/208118 Change subject: worked on job for evaluation .. worked on job for evaluation * changed job so as to construct a json string * used

[MediaWiki-commits] [Gerrit] fixed no/somevalue crashes in checkresult - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/207056 Change subject: fixed no/somevalue crashes in checkresult .. fixed no/somevalue crashes in checkresult Change-Id: Ic5d5b8a44bd718dd

[MediaWiki-commits] [Gerrit] remove what has something to do with class Violation - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: remove what has something to do with class Violation .. remove what has something to do with class Violation since we decided not have it in version

[MediaWiki-commits] [Gerrit] stop writing violations into table - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: stop writing violations into table .. stop writing violations into table since we decided not to have this feature in version 1 Change-Id: Iffa4944

[MediaWiki-commits] [Gerrit] Style changes in the Html classes - change (mediawiki...WikidataQuality)

Andreasburmeister has submitted this change and it was merged. Change subject: Style changes in the Html classes .. Style changes in the Html classes Change-Id: I9ca9367701e93067b486acf297ab9475bc318ed4 --- M includes/Html/Html

[MediaWiki-commits] [Gerrit] Reduce complexity in HtmlTable::__construct - change (mediawiki...WikidataQuality)

Andreasburmeister has submitted this change and it was merged. Change subject: Reduce complexity in HtmlTable::__construct .. Reduce complexity in HtmlTable::__construct Change-Id: I8311868d706197566c0181a273f1ef79803edd40 ---

[MediaWiki-commits] [Gerrit] Reduce nesting - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: Reduce nesting .. Reduce nesting Change-Id: Ia7022c78ee0f244949f8739eb6e60bf57461da41 --- M includes/ConstraintCheck/Helper/ConstraintReportHelper.p

[MediaWiki-commits] [Gerrit] Remove global scope assumptions in entry point - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: Remove global scope assumptions in entry point .. Remove global scope assumptions in entry point See http://www.bn2vs.com/blog/2013/11/24/introduct

[MediaWiki-commits] [Gerrit] minor changes in job - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: minor changes in job .. minor changes in job including when to establish db connection and how the results get serialized Change-Id: I3ee4126592bc2

[MediaWiki-commits] [Gerrit] Bugfixes as suggested by Scrutinizer - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: Bugfixes as suggested by Scrutinizer .. Bugfixes as suggested by Scrutinizer * check for value/novalue/somevalue cases * fix type hints * fix possib

[MediaWiki-commits] [Gerrit] Another round for Scrutinizer - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/206128 Change subject: Another round for Scrutinizer .. Another round for Scrutinizer (code duplication is still an issue, though) Change

[MediaWiki-commits] [Gerrit] Bugfixes as suggested by Scrutinizer - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/206107 Change subject: Bugfixes as suggested by Scrutinizer .. Bugfixes as suggested by Scrutinizer * check for value/novalue/somevalue ca

[MediaWiki-commits] [Gerrit] renaming things that got lost during merge - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: renaming things that got lost during merge .. renaming things that got lost during merge Change-Id: I203511dd5ae94c70d1b41de7f40fc771c8d1c3c4 --- M

[MediaWiki-commits] [Gerrit] remove jobClasses from WikidataQuality.php - change (mediawiki...WikidataQuality)

Andreasburmeister has submitted this change and it was merged. Change subject: remove jobClasses from WikidataQuality.php .. remove jobClasses from WikidataQuality.php since we now have a job for every extension so it does not

[MediaWiki-commits] [Gerrit] use status constant, rename job, first version of hook - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: use status constant, rename job, first version of hook .. use status constant, rename job, first version of hook CheckResult has constants for statu

[MediaWiki-commits] [Gerrit] corrected readme - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/205607 Change subject: corrected readme .. corrected readme [ci skip] Change-Id: Ic601ac9df67a5b9378bb65f4e63720658c8a2259 --- M README.m

[MediaWiki-commits] [Gerrit] corrected readme - change (mediawiki...WikidataQualityExternalValidation)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/205600 Change subject: corrected readme .. corrected readme [ci skip] Change-Id: I91534ca7f2573a77f49f22acd5184d4a73cd058d --- M README.m

[MediaWiki-commits] [Gerrit] move Job and test to this extension for now - change (mediawiki...WikidataQualityConstraints)

Andreasburmeister has submitted this change and it was merged. Change subject: move Job and test to this extension for now .. move Job and test to this extension for now Change-Id: I2699c288752a4532cecad4bd76dba7652d451346 ---

[MediaWiki-commits] [Gerrit] remove Job as discussed - change (mediawiki...WikidataQuality)

Andreasburmeister has submitted this change and it was merged. Change subject: remove Job as discussed .. remove Job as discussed Change-Id: Ie3c7b84818361aca5744abe4f3b8e2398da0c7ac --- D includes/CheckForViolationsJob.php D t

[MediaWiki-commits] [Gerrit] Renamed column in violations table - change (mediawiki...WikidataQuality)

Andreasburmeister has submitted this change and it was merged. Change subject: Renamed column in violations table .. Renamed column in violations table constraint_claim_guid -> constraint_id Change-Id: I5f638f01e26c407c705a931

[MediaWiki-commits] [Gerrit] Fixed bug in onCreateSchema hook. - change (mediawiki...WikidataQuality)

Andreasburmeister has submitted this change and it was merged. Change subject: Fixed bug in onCreateSchema hook. .. Fixed bug in onCreateSchema hook. Change-Id: Icc33190b9b7e7f9c610d242776b6968c20dec6f1 --- M WikidataQualityHoo

[MediaWiki-commits] [Gerrit] code cleanup - change (mediawiki...WikidataQuality)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/203810 Change subject: code cleanup .. code cleanup added more type hinting fixed one of checker test accordingly minor fix in sorting of

[MediaWiki-commits] [Gerrit] changed parameter of special pages to upper case - change (mediawiki...WikidataQuality)

Andreasburmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/203797 Change subject: changed parameter of special pages to upper case .. changed parameter of special pages to upper case Change-Id: I60