[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-08-30 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 9193318 Fix dumb omitted return statement 4717a1b Fix one more oversight with rec

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307657 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 9193318 Fix dumb omitted return statement 4717a1

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix one more oversight with record capture job

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307651 Change subject: Fix one more oversight with record capture job .. Fix one more oversight with record capture job Wrong way to refer to class C

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Allow overriding with dissimilar types

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307648 Change subject: Allow overriding with dissimilar types .. Allow overriding with dissimilar types Sometimes inst-args[0] needs to be an array, e

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Test for RecordCaptureJob

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307647 Change subject: Test for RecordCaptureJob .. Test for RecordCaptureJob FIXME: Dying because overriding string default inst-args[0] with an arra

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix dumb omitted return statement

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307646 Change subject: Fix dumb omitted return statement .. Fix dumb omitted return statement And add comment. Change-Id: Ic4a52199ebd58735f428c41912

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Update libs

2016-08-30 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Update libs .. Update libs Change-Id: Ic652aee6d75697c8f60abf58e5b6e12d6c5bec07 --- M vendor 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ejegg:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Update libs

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307626 Change subject: Update libs .. Update libs Change-Id: Ic652aee6d75697c8f60abf58e5b6e12d6c5bec07 --- M vendor 1 file changed, 1 insertion(+), 1

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Update libs

2016-08-30 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Update libs .. Update libs Change-Id: Iede6fe959fdf4381243ce78acb66545a5776b2a1 --- M coderkungfu/php-queue/src/PHPQueue/Backend/PDO.php M composer/installed.js

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Update libs

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307625 Change subject: Update libs .. Update libs Change-Id: Iede6fe959fdf4381243ce78acb66545a5776b2a1 --- M coderkungfu/php-queue/src/PHPQueue/Backen

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307623 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 0ff730c Remove some unused message fields 2555fc

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Don't pollute $msg with pending_id

2016-08-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307445 Change subject: Don't pollute $msg with pending_id .. Don't pollute $msg with pending_id We use pending_id to delete the database row, but we d

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' into deployment

2016-08-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307432 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment cbb5be4 Import info from pending DB, not AMQ 82f

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Check for duplicates before re-queueing MISSING_PREDECESSOR

2016-08-29 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Check for duplicates before re-queueing MISSING_PREDECESSOR .. Check for duplicates before re-queueing MISSING_PREDECESSOR When we've got a missing pending db e

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Refactor common duplicate-checking code

2016-08-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307427 Change subject: Refactor common duplicate-checking code .. Refactor common duplicate-checking code Change-Id: Ief8692304645ec6b57f3697828d41ca5

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Stop using pending queue in ProcessCaptureRequestJob

2016-08-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307359 Change subject: Stop using pending queue in ProcessCaptureRequestJob .. Stop using pending queue in ProcessCaptureRequestJob Treat pending DB a

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Update SmashPig lib, use config shortcuts

2016-08-26 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306972 Change subject: Update SmashPig lib, use config shortcuts .. Update SmashPig lib, use config shortcuts Change-Id: I66bd33e1bb7db1c1de46be1390b8

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Enablement switch for BannerHistoryLog

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306711 Change subject: Enablement switch for BannerHistoryLog .. Enablement switch for BannerHistoryLog This was the only hook-y thing lacking an off

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Use DeletePendingJob

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306840 Change subject: Use DeletePendingJob .. Use DeletePendingJob Where to initialize SmashPig config? Change-Id: I7c965b485d710e4c4fd9efcfc54f04bc

[MediaWiki-commits] [Gerrit] wikimedia...civicrm-buildkit[master]: Stop failing tests on default country code

2016-08-25 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Stop failing tests on default country code .. Stop failing tests on default country code 'XX' is totally legit for the recurring charges or could get the c

[MediaWiki-commits] [Gerrit] wikimedia...civicrm-buildkit[master]: Stop failing tests on default country code

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306809 Change subject: Stop failing tests on default country code .. Stop failing tests on default country code 'XX' is totally legit for the recurrin

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Re-enable recurring GC tests, add more

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306806 Change subject: Re-enable recurring GC tests, add more .. Re-enable recurring GC tests, add more FIXME: figure out how to indicate what success

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Use default test filename for DO_PAYMENT success

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306802 Change subject: Use default test filename for DO_PAYMENT success .. Use default test filename for DO_PAYMENT success Makes it possible to run r

[MediaWiki-commits] [Gerrit] wikimedia...civicrm-buildkit[master]: Add settings for donation-interface library

2016-08-25 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Add settings for donation-interface library .. Add settings for donation-interface library Might help I2aab09484fe5e7 pass tests Bug: T141487 Change-Id: Ie5ac8

[MediaWiki-commits] [Gerrit] wikimedia...civicrm-buildkit[master]: Add settings for donation-interface library

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306730 Change subject: Add settings for donation-interface library .. Add settings for donation-interface library Might help I2aab09484fe5e7 pass test

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Add more dirs to composer classmap

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306705 Change subject: Add more dirs to composer classmap .. Add more dirs to composer classmap We need consumer libs to know about filters etc. Bug:

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Update donation-interface lib

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306704 Change subject: Update donation-interface lib .. Update donation-interface lib Removes dependence on mediawiki hooks for fraud filters. Change

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Update DonationInterface submodule

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306693 Change subject: Update DonationInterface submodule .. Update DonationInterface submodule Change-Id: I4c8e3cc7586d53d7cbbabc5d0d13a60d9f67b9f7 -

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2016-08-25 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306692 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 7566e21 Revert "Legacy PayPal: send pending mess

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Remove unnecessary hooks

2016-08-24 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306519 Change subject: Remove unnecessary hooks .. Remove unnecessary hooks We've got 'Enable' config variables for everything that's fired by a hook,

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: runHooks for drupal WmfFramework

2016-08-24 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306478 Change subject: runHooks for drupal WmfFramework .. runHooks for drupal WmfFramework Bug: T141486 Change-Id: Ie736128279b6f7c44f3979132f2b51f26

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Reject isRequeue messages after expiry

2016-08-24 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306450 Change subject: Reject isRequeue messages after expiry .. Reject isRequeue messages after expiry FIXME: configurable variables are kinda lying.

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Fix bug re-activating utm_campaign entries

2016-08-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306239 Change subject: Fix bug re-activating utm_campaign entries .. Fix bug re-activating utm_campaign entries Was crashing when the first matching n

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Make blocks log users out if $wgBlockDisablesLogin

2016-08-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306125 Change subject: Make blocks log users out if $wgBlockDisablesLogin .. Make blocks log users out if $wgBlockDisablesLogin Issue originally repor

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: SECURITY: API: Generate head items in the context of the giv...

2016-08-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306130 Change subject: SECURITY: API: Generate head items in the context of the given title .. SECURITY: API: Generate head items in the context of th

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: SECURITY: Make $wgBlockDisablesLogin also restrict logged in...

2016-08-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306126 Change subject: SECURITY: Make $wgBlockDisablesLogin also restrict logged in permissions .. SECURITY: Make $wgBlockDisablesLogin also restrict

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: SECURITY: XSS in unclosed internal links

2016-08-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306129 Change subject: SECURITY: XSS in unclosed internal links .. SECURITY: XSS in unclosed internal links rawurldecode was being run on unclosed int

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: SECURITY: Check read permission when loading page content in...

2016-08-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306124 Change subject: SECURITY: Check read permission when loading page content in ApiParse. .. SECURITY: Check read permission when loading page con

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: SECURITY: Move 'UserGetRights' call before application of Se...

2016-08-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306132 Change subject: SECURITY: Move 'UserGetRights' call before application of Session::getAllowedUserRights() .. SECURITY: Move 'UserGetRights' cal

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Escape '<' and ']]>' in inline

2016-08-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/306128 Change subject: Escape '<' and ']]>' in inline blocks .. Escape '<' and ']]>' in inline