Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373300 )
Change subject: Remove CiteThisPage from blacklist for page previews
..
Remove CiteThisPage from blacklist for page previews
Bug:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373299 )
Change subject: Set line height to 1 for sup and sub elements
..
Set line height to 1 for sup and sub elements
Bug: T172501
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373292 )
Change subject: Verify the existence of `url` key when parsing lang objects
..
Verify the existence of `url` key when parsing lang
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373139 )
Change subject: WIP: Limit usage of global jQuery in preference of ES6
..
WIP: Limit usage of global jQuery in preference of ES6
*
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373138 )
Change subject: Hygiene: Use String.prototype.trim
..
Hygiene: Use String.prototype.trim
No need to use $.trim when we support ES5
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373120 )
Change subject: Adjust TOC print styles
..
Adjust TOC print styles
* Font size shrunk and declared in pt
* Margin adjustment
*
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373093 )
Change subject: Hygiene: Correct summary spec test
..
Hygiene: Correct summary spec test
The spec comment incorrectly says a link will
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373085 )
Change subject: QA: Do not run various toast notification browser tests on BC
..
QA: Do not run various toast notification browser tests
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373076 )
Change subject: Disable wikitext editor on non-wikitext content models
..
Disable wikitext editor on non-wikitext content models
Do not
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372882 )
Change subject: Make sure referenced file exists
..
Make sure referenced file exists
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372875 )
Change subject: Add test case for summary endpoint
..
Add test case for summary endpoint
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372838 )
Change subject: Hygiene: Remove dead config variable
..
Hygiene: Remove dead config variable
Change-Id:
Hello Pmiazga, jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/372562
to review the following change.
Change subject: Revert "Import the right files"
..
Revert "Import the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372561 )
Change subject: Enable mediawiki.special.userlogin.common.styles on mobile and
allow skins to style it
..
Enable
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372560 )
Change subject: WIP: Remove special page handling
..
WIP: Remove special page handling
This is handled by MobileFrontend now, just as it
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372558 )
Change subject: Hygiene: Remove and tidy some Minerva references
..
Hygiene: Remove and tidy some Minerva references
* Update inline
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372559 )
Change subject: MobileFrontend should not add Minerva modules for its special
pages
..
MobileFrontend should not add Minerva modules for
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372551 )
Change subject: Add mobile and desktop thresholds
..
Add mobile and desktop thresholds
This will allow us to centralise these values
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372539 )
Change subject: Import the right files
..
Import the right files
These modules are throwing Less compiler errors.
The variables being
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372538 )
Change subject: Hygiene: Do not use numbered grays
..
Hygiene: Do not use numbered grays
We have names for a reason.
We should limit our
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372472 )
Change subject: Standardise on MinervaNeue skin name
..
Standardise on MinervaNeue skin name
Bug: T171644
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372470 )
Change subject: Check if SpecialMobileWatchlist exist
..
Check if SpecialMobileWatchlist exist
If MobileFrontend doesn't exist this will
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372461 )
Change subject: Give the Special:preferences page on desktop some love
..
Give the Special:preferences page on desktop some love
The
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372420 )
Change subject: Hygiene: Correct documentation
..
Hygiene: Correct documentation
Result of code review session on 17th August 2017.
We
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372403 )
Change subject: MediawikiUI: Introduce mw-ui-icon-large
..
MediawikiUI: Introduce mw-ui-icon-large
This will allow MobileFrontend and
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372402 )
Change subject: User page should use mw-ui-icon-large
..
User page should use mw-ui-icon-large
Bug: T143264
Depends-On:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372183 )
Change subject: Do not assume MobileFrontend special pages exist
..
Do not assume MobileFrontend special pages exist
If they don't exist
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372186 )
Change subject: WIP: Break the MobileFrontend dependency on Minerva
..
WIP: Break the MobileFrontend dependency on Minerva
Remaining
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372184 )
Change subject: i18n: Add Minerva specific message key for last modified bar
..
i18n: Add Minerva specific message key for last modified
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372185 )
Change subject: WIP: Port over minimum required LESS variables
..
WIP: Port over minimum required LESS variables
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372173 )
Change subject: Return promises from QUnit test
..
Return promises from QUnit test
Simplify all our tests to return to promises
Use
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372167 )
Change subject: Use proto current not proto relative
..
Use proto current not proto relative
Per the usage instructions what we actually
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372160 )
Change subject: Roll page previews out to all wikis except en and de wiki
..
Roll page previews out to all wikis except en and de wiki
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372079 )
Change subject: Add tests for extractLeadIntroduction and fix edge case
..
Add tests for extractLeadIntroduction and fix edge case
Add
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372080 )
Change subject: Make it easier to run unit tests
..
Make it easier to run unit tests
Currently `npm test` runs integration tests which
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372077 )
Change subject: User always passed in as an argument to classes
..
User always passed in as an argument to classes
Depends-On: To be
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372062 )
Change subject: Add phan config to Popups
..
Add phan config to Popups
Bug: T133664
Change-Id: I57de60a783cd011e93aef87c81187dbbf92cb270
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372061 )
Change subject: Add phan config to MinervaNeue
..
Add phan config to MinervaNeue
phantastic!
Bug: T133664
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372060 )
Change subject: Add MinervaNeue Doxyfile
..
Add MinervaNeue Doxyfile
We forgot to copy this across when migrating Minerva out of
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371498 )
Change subject: MobileFrontend should be responsible for adding mobile.site
module
..
MobileFrontend should be responsible for adding
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371499 )
Change subject: Load mobile.site on all mobile skins
..
Load mobile.site on all mobile skins
Bug: T171062
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371129 )
Change subject: WIP: A/B test infrastructure
..
WIP: A/B test infrastructure
Introduce getUserBucket which determines whether a user is
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370924 )
Change subject: Correct config - commonswiki not commons
..
Correct config - commonswiki not commons
Bug: T170687
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370880 )
Change subject: QA: Simplify toast notification step some more
..
QA: Simplify toast notification step some more
If
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370876 )
Change subject: Merge footer hooks with Hooks
..
Merge footer hooks with Hooks
per Baha's suggestion we have no need for two Hooks files
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370844 )
Change subject: QA: Disable browser test in @chrome
..
QA: Disable browser test in @chrome
This is failing consistently due to T172835.
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370806 )
Change subject: QA: Workaround for T172835
..
QA: Workaround for T172835
Ensure the user is logged in and has made several edits to
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370754 )
Change subject: POC: Send all the links for disambiguation pages in the summary
..
POC: Send all the links for disambiguation pages in
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370736 )
Change subject: Always extract an infobox and paragraph
..
Always extract an infobox and paragraph
There is undocumented logic limiting
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370697 )
Change subject: Empty tags are omitted from summary output
..
Empty tags are omitted from summary output
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370694 )
Change subject: Per spec return summary type
..
Per spec return summary type
Change-Id: I4e1c84cc490dc86551cae86bc4b96eafad42a89e
---
M
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370692 )
Change subject: Pages with empty lead sections should send a 204
..
Pages with empty lead sections should send a 204
If preview is an
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370667 )
Change subject: QA: Relax toast notification QA steps
..
QA: Relax toast notification QA steps
It seems trying to test both the steps
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370662 )
Change subject: WebdriverIO tests should look for LocalSettings.php in selenium
folder
..
WebdriverIO tests should look for
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370657 )
Change subject: DONOTMERGE
..
DONOTMERGE
Change-Id: I31ee31b6239106d92735519b9c25028fa92a4599
---
D
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370513 )
Change subject: Reflect template change
..
Reflect template change
Link has changed
from Help:IPA/English
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370371 )
Change subject: Look for dablinks when extracting hatnotes
..
Look for dablinks when extracting hatnotes
Certain wiki pages use older
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370253 )
Change subject: Scrub #coordinates from response
..
Scrub #coordinates from response
Now we are using the MediaWiki coordinates
prop to
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370215 )
Change subject: Don't output empty footer items in desktop Minerva
..
Don't output empty footer items in desktop Minerva
These fields
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370109 )
Change subject: Hygiene: The main page check is not necessary
..
Hygiene: The main page check is not necessary
The main page in the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370105 )
Change subject: Padding tweak for all lists
..
Padding tweak for all lists
This is particularly important in references where this small
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370087 )
Change subject: Page.js getLeadSectionElement
..
Page.js getLeadSectionElement
* Add tests
* When pages are not mobile formatted return
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369666 )
Change subject: QA: Move LocalSettings to folder with other browser tests
..
QA: Move LocalSettings to folder with other browser tests
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369580 )
Change subject: MCS no longer uses mobile view API under the hood
..
MCS no longer uses mobile view API under the hood
After this change
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369561 )
Change subject: QA: Use css rather than class for finding toast
..
QA: Use css rather than class for finding toast
Bug: T170890
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369503 )
Change subject: Exclude files from Special:ShortPages on commons
..
Exclude files from Special:ShortPages on commons
Bug: T170687
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369494 )
Change subject: Disable page previews on a variety of pages
..
Disable page previews on a variety of pages
Bug: T170893
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369464 )
Change subject: Update wordmark for Wikipedia Atikamekw
..
Update wordmark for Wikipedia Atikamekw
Bug: T168203
* Editor should jump to
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369453 )
Change subject: Relax navbox hack
..
Relax navbox hack
Per discussion in T172078 let's relax these rules so navbox shows
up in the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369450 )
Change subject: QA: Make sure toast is not empty before checking text value
..
QA: Make sure toast is not empty before checking text
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369399 )
Change subject: Style Parsoid generated references
..
Style Parsoid generated references
Bug: T171727
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368959 )
Change subject: WIP: Do not use MobileView to source metadata
..
WIP: Do not use MobileView to source metadata
Bug: T103362
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368954 )
Change subject: Source coordinates from GeoData
..
Source coordinates from GeoData
Rather than rely on Parsoid HTML, source geodata from
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368953 )
Change subject: DRY: Save repetition of formatversion and format api parameters
..
DRY: Save repetition of formatversion and format api
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368942 )
Change subject: QA: Minor tweaks to how we check toast notifications
..
QA: Minor tweaks to how we check toast notifications
A toast
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368526 )
Change subject: Fix pronounication portion of API
..
Fix pronounication portion of API
Bug: T170325
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368520 )
Change subject: Fix broken tests (do not skip)
..
Fix broken tests (do not skip)
Skipping should only be used as a short term measure.
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368457 )
Change subject: WIP: Having 2 folders for browser tests is confusing.
..
WIP: Having 2 folders for browser tests is confusing.
Should we
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368452 )
Change subject: MwContentProvider should honour the skin name
..
MwContentProvider should honour the skin name
As we've discovered the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368325 )
Change subject: Allow blacklisting certain namespaces in Special:ShortPages
..
Allow blacklisting certain namespaces in
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368314 )
Change subject: Code review session: DONOTMERGE
..
Code review session: DONOTMERGE
Please comment on the lines of code in this patch.
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368313 )
Change subject: mediawiki.legacy.shared can be run in mobile target
..
mediawiki.legacy.shared can be run in mobile target
Minerva
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368306 )
Change subject: Blank parsoid styles, update thumbnail selectors for Parsoid
content
..
Blank parsoid styles, update thumbnail selectors
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368287 )
Change subject: Allow content to be sourced from Parsoid
..
Allow content to be sourced from Parsoid
This helps with testing Apps
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368260 )
Change subject: Browser tests: Use generic toast step
..
Browser tests: Use generic toast step
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368237 )
Change subject: Compute list of English Wikipedia logos
..
Compute list of English Wikipedia logos
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368236 )
Change subject: Define custom logos using wmg
..
Define custom logos using wmg
The merge strategy of arrays is problematic. To avoid
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368202 )
Change subject: Run stylelint in `npm test`
..
Run stylelint in `npm test`
This ensures Jenkin will complain if stylelint errors are
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368115 )
Change subject: DONOTMERGE: testing someting
..
DONOTMERGE: testing someting
Change-Id: I6908872ece922772ddcf5f22daae6bb61ab8ddaa
---
M
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368114 )
Change subject: Hygiene: Toast selector should be more flexible
..
Hygiene: Toast selector should be more flexible
A toast can carry
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368109 )
Change subject: DONOTMERGE: Remove main page special casing code
..
DONOTMERGE: Remove main page special casing code
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367938 )
Change subject: Update several Wikipedia projects to existing wordmarks
..
Update several Wikipedia projects to existing wordmarks
Bug:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367817 )
Change subject: Print styles: Border bottom of headings should not overlap
infoboxes
..
Print styles: Border bottom of headings should
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367814 )
Change subject: Print styles: Apply padding and margins to ol as well as ul
..
Print styles: Apply padding and margins to ol as well as
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367812 )
Change subject: Print mode: Define when to use serif and when to use sans-serif
..
Print mode: Define when to use serif and when to use
Jdlrobson has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/365042 )
Change subject: Restore default MediaWiki codesniffer configuration
..
Restore default MediaWiki codesniffer configuration
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367688 )
Change subject: Hygiene: Drop MFAllowNonJavaScriptEditing and
Special:MobileEditor
..
Hygiene: Drop MFAllowNonJavaScriptEditing and
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367627 )
Change subject: Fix stylesheet
..
Fix stylesheet
You can't nest like this. It creates the invalid selector
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367477 )
Change subject: SkinMinerva should deal with edit section link not
MobileFormatter
..
SkinMinerva should deal with edit section link not
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367471 )
Change subject: Allow us to run mobile formatter on desktop skin
..
Allow us to run mobile formatter on desktop skin
We won't use this
301 - 400 of 5253 matches
Mail list logo
