[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix code style between "

2016-11-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/322237 Change subject: Fix code style between "https://gerrit.wikimedia.org/r/322237 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Notify wikidata-monitoring on WIkibase browsertest failures

2016-11-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/322082 Change subject: Notify wikidata-monitoring on WIkibase browsertest failures .. Notify wikidata-monitoring on WIkibase browsertest

[MediaWiki-commits] [Gerrit] mediawiki...EmailAuth[master]: Fix CI errors + code review issues

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix CI errors + code review issues .. Fix CI errors + code review issues Change-Id: Ie20b8bf2de5cb6ee56099318212f036cfd7ac91c --- D README.md M

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Remove unused imports and unused code

2016-11-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/322236 Change subject: Remove unused imports and unused code .. Remove unused imports and unused code Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...EmailAuth[master]: Fix CI errors + code review issues

2016-11-17 Thread Code Review
Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/322235 Change subject: Fix CI errors + code review issues .. Fix CI errors + code review issues Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Add emailauth role

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add emailauth role .. Add emailauth role Change-Id: Ibf475d791fbefc0feafc5a445aa60648b624ca44 Depends-On: Ia6ed8f1952fd727af352646433b5f90f7083a8c2

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix server logout case when logged in user edits

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix server logout case when logged in user edits .. Fix server logout case when logged in user edits When a user is logged into the app and makes an

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: forbid unused variables and fix offenders

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: forbid unused variables and fix offenders .. Hygiene: forbid unused variables and fix offenders Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Gadgets[master]: [WIP] Implement 'peers' feature for loading extra styles-typ...

2016-11-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/322234 Change subject: [WIP] Implement 'peers' feature for loading extra styles-type gadgets .. [WIP] Implement 'peers' feature for loading extra

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: APIGenerator.set_maximum_items: Don't compare int with None

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: APIGenerator.set_maximum_items: Don't compare int with None .. APIGenerator.set_maximum_items: Don't compare int with None `query_increment` can be None.

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: wikibase_tests.py: Fix typo

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: wikibase_tests.py: Fix typo .. wikibase_tests.py: Fix typo Change-Id: Ia6d69b8ee8ced4a127727d28dc4f1289542ae3e5 --- M tests/wikibase_tests.py 1 file

[MediaWiki-commits] [Gerrit] mediawiki...Gadgets[master]: Implement support for 'hidden' feature in MediaWikiGadgetsDe...

2016-11-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/322233 Change subject: Implement support for 'hidden' feature in MediaWikiGadgetsDefinitionRepo .. Implement support for 'hidden' feature in

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: APIGenerator.set_maximum_items: Don't compare int with None

2016-11-17 Thread Dalba (Code Review)
Dalba has uploaded a new change for review. https://gerrit.wikimedia.org/r/322232 Change subject: APIGenerator.set_maximum_items: Don't compare int with None .. APIGenerator.set_maximum_items: Don't compare int with None

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Fix code coverage execution

2016-11-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. https://gerrit.wikimedia.org/r/322231 Change subject: Hygiene: Fix code coverage execution .. Hygiene: Fix code coverage execution Fix incorrect @cover statements as PHPUnit

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: use constants

2016-11-17 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. https://gerrit.wikimedia.org/r/322230 Change subject: Hygiene: use constants .. Hygiene: use constants For better maintenance use contants instead of strings Changes: -

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Adding hub image selector and embedding icon and color selec...

2016-11-17 Thread Harej (Code Review)
Harej has uploaded a new change for review. https://gerrit.wikimedia.org/r/39 Change subject: Adding hub image selector and embedding icon and color selectors in proper places. .. Adding hub image selector and embedding

[MediaWiki-commits] [Gerrit] mediawiki...EmailAuth[master]: Disable autocomplete

2016-11-17 Thread Code Review
Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/38 Change subject: Disable autocomplete .. Disable autocomplete Change-Id: I5715549e33124a545e3dca5707d08b08ccd3fa84 Depends-On:

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Log user out when their account gets globally locked

2016-11-17 Thread Code Review
Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/37 Change subject: Log user out when their account gets globally locked .. Log user out when their account gets globally locked Bug: 761269

[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: Add a maintenance script for purging unused projects

2016-11-17 Thread Kaldari (Code Review)
Kaldari has uploaded a new change for review. https://gerrit.wikimedia.org/r/36 Change subject: Add a maintenance script for purging unused projects .. Add a maintenance script for purging unused projects This is mostly

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labstore: Add account_services to secondary too

2016-11-17 Thread Yuvipanda (Code Review)
Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/34 Change subject: labstore: Add account_services to secondary too .. labstore: Add account_services to secondary too Since labstore1004 is

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: wikibase_tests.py: Fix typo

2016-11-17 Thread Dalba (Code Review)
Dalba has uploaded a new change for review. https://gerrit.wikimedia.org/r/35 Change subject: wikibase_tests.py: Fix typo .. wikibase_tests.py: Fix typo Change-Id: Ia6d69b8ee8ced4a127727d28dc4f1289542ae3e5 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Add script to fix inconsistent state for board name

2016-11-17 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. https://gerrit.wikimedia.org/r/33 Change subject: Add script to fix inconsistent state for board name .. Add script to fix inconsistent state for board name This loops

[MediaWiki-commits] [Gerrit] operations...hhvm_exporter[master]: Initial commit

2016-11-17 Thread Filippo Giunchedi (Code Review)
Filippo Giunchedi has submitted this change and it was merged. Change subject: Initial commit .. Initial commit Bug: T147423 Change-Id: Ia156b8b057d04e7b0beedbbfe313c018d1b80477 --- A .gitignore A LICENSE A README.md A

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] Solve pagegeneratrors_tests.TestFactoryGeneratorWik...

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: [bugfix] Solve pagegeneratrors_tests.TestFactoryGeneratorWikibase tests .. [bugfix] Solve pagegeneratrors_tests.TestFactoryGeneratorWikibase tests -

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/me...

2016-11-17 Thread Mooeypoo (Code Review)
Mooeypoo has uploaded a new change for review. https://gerrit.wikimedia.org/r/32 Change subject: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core into review/mooeypoo/mw-recentchanges-filters ..

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Shift 10 more extensions to use wfLoadExtension()

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Shift 10 more extensions to use wfLoadExtension() .. Shift 10 more extensions to use wfLoadExtension() Swap in extension-list too: * CodeEditor *

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Fix utf8 output of explain printer

2016-11-17 Thread EBernhardson (Code Review)
EBernhardson has uploaded a new change for review. https://gerrit.wikimedia.org/r/31 Change subject: Fix utf8 output of explain printer .. Fix utf8 output of explain printer Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: WIP Add grafana_json_datasource

2016-11-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/30 Change subject: WIP Add grafana_json_datasource .. WIP Add grafana_json_datasource Bug: T147328 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Remove unused MinfraudActionRanges global

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove unused MinfraudActionRanges global .. Remove unused MinfraudActionRanges global The MinFraud score is not considered on its own, rather it is

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.3]: Revert "Revert "resourceloader: Make cache-eval in mw.loader...

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Revert "Revert "resourceloader: Make cache-eval in mw.loader.work asynchronous"" .. Revert "Revert "resourceloader: Make cache-eval in mw.loader.work

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: registration: Set "FileExtensions" to $GLOBALS

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: registration: Set "FileExtensions" to $GLOBALS .. registration: Set "FileExtensions" to $GLOBALS Change-Id: Ie52004d25ebc06c81cd7d8d7de60479ff365ccea ---

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.3]: Revert "Revert "resourceloader: Make cache-eval in mw.loader...

2016-11-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/322219 Change subject: Revert "Revert "resourceloader: Make cache-eval in mw.loader.work asynchronous"" .. Revert "Revert "resourceloader: Make

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: Fix width of timezone column

2016-11-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/322218 Change subject: Fix width of timezone column .. Fix width of timezone column Match the source table in CiviCRM. We were getting a lot of

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.3]: Revert "resourceloader: Make cache-eval in mw.loader.work as...

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Revert "resourceloader: Make cache-eval in mw.loader.work asynchronous" .. Revert "resourceloader: Make cache-eval in mw.loader.work asynchronous" This

[MediaWiki-commits] [Gerrit] wikimedia...tools[deploy]: Merge branch 'master' into deploy

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Merge branch 'master' into deploy .. Merge branch 'master' into deploy b1006f5 Fix spacing 06124bb Paypal audit: fix checking for refunds in CiviCRM

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add REL1_28 to ExtensionDistributor

2016-11-17 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/322217 Change subject: Add REL1_28 to ExtensionDistributor .. Add REL1_28 to ExtensionDistributor Not enabling it as stable yet since there is no

[MediaWiki-commits] [Gerrit] wikimedia...tools[deploy]: Merge branch 'master' into deploy

2016-11-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/322216 Change subject: Merge branch 'master' into deploy .. Merge branch 'master' into deploy b1006f5 Fix spacing 06124bb Paypal audit: fix checking

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: Fix query snippet logging

2016-11-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/322215 Change subject: Fix query snippet logging .. Fix query snippet logging It's useless right now, because it always gets the first 80 characters

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toollabs: Fix maintain-kubeusers crashing

2016-11-17 Thread Yuvipanda (Code Review)
Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/322213 Change subject: toollabs: Fix maintain-kubeusers crashing .. toollabs: Fix maintain-kubeusers crashing Looks like if it was interrupted

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: populateContentModel: Invalidate content model and revision ...

2016-11-17 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. https://gerrit.wikimedia.org/r/322214 Change subject: populateContentModel: Invalidate content model and revision cache .. populateContentModel: Invalidate content model and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: registration: Support setting $wgPasswordPolicy in extension...

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: registration: Support setting $wgPasswordPolicy in extension.json .. registration: Support setting $wgPasswordPolicy in extension.json Bug: T149597

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.3]: [DNM] Revert "resourceloader: Make cache-eval in mw.loader.w...

2016-11-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/322212 Change subject: [DNM] Revert "resourceloader: Make cache-eval in mw.loader.work asynchronous" .. [DNM] Revert "resourceloader: Make

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [DNM] Revert "resourceloader: Make cache-eval in mw.loader.w...

2016-11-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/322211 Change subject: [DNM] Revert "resourceloader: Make cache-eval in mw.loader.work asynchronous" .. [DNM] Revert "resourceloader: Make

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wikistatus: Further attempt to solve login races

2016-11-17 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: wikistatus: Further attempt to solve login races .. wikistatus: Further attempt to solve login races - Increase the sleep between login attempts by a

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: Paypal audit: fix checking for refunds in CiviCRM

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Paypal audit: fix checking for refunds in CiviCRM .. Paypal audit: fix checking for refunds in CiviCRM We no longer refund by creating a new negative

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: Fix spacing

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix spacing .. Fix spacing Change-Id: I00560d6f5632deb03324ed13ff0936f50a8483aa --- M FundraiserStatisticsGen/fundstatgen.py M database/db.py M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Set FileExtensions to $GLOBALS

2016-11-17 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/322209 Change subject: Set FileExtensions to $GLOBALS .. Set FileExtensions to $GLOBALS Change-Id: Ie52004d25ebc06c81cd7d8d7de60479ff365ccea --- M

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: Fix spacing

2016-11-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/322210 Change subject: Fix spacing .. Fix spacing Change-Id: I00560d6f5632deb03324ed13ff0936f50a8483aa --- M FundraiserStatisticsGen/fundstatgen.py M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wikistatus: Further attempt to solve login races

2016-11-17 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/322208 Change subject: wikistatus: Further attempt to solve login races .. wikistatus: Further attempt to solve login races - Increase the

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Wikitech: Increase login throttle limits x4

2016-11-17 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/322207 Change subject: Wikitech: Increase login throttle limits x4 .. Wikitech: Increase login throttle limits x4 Hopefully high enough

[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint/doc.wm.org: drop dir.php from DirectoryIndex

2016-11-17 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: contint/doc.wm.org: drop dir.php from DirectoryIndex .. contint/doc.wm.org: drop dir.php from DirectoryIndex As hashar points out we don't want the old dir.php

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 52706ae Fix check for Amazon-generated IDs Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint/doc.wm.org: drop dir.php from DirectoryIndex

2016-11-17 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/322206 Change subject: contint/doc.wm.org: drop dir.php from DirectoryIndex .. contint/doc.wm.org: drop dir.php from DirectoryIndex As hashar points

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-11-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/322205 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 52706ae Fix check for Amazon-generated IDs

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix check for Amazon-generated IDs

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix check for Amazon-generated IDs .. Fix check for Amazon-generated IDs Oops, flubbed that equality check. Bug: T147973 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...LdapAuthentication[master]: Try and prevent CAS errors in LDAP code

2016-11-17 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/322204 Change subject: Try and prevent CAS errors in LDAP code .. Try and prevent CAS errors in LDAP code Bug: T150373 Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix check for Amazon-generated IDs

2016-11-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/322203 Change subject: Fix check for Amazon-generated IDs .. Fix check for Amazon-generated IDs Oops, flubbed that equality check. Bug: T147973

[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint/doc.wm.org: add missing DirectoryIndex, remove old 2...

2016-11-17 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: contint/doc.wm.org: add missing DirectoryIndex, remove old 2.2 syntax .. contint/doc.wm.org: add missing DirectoryIndex, remove old 2.2 syntax We moved

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Only apply wgDBschema to postgres/mssql

2016-11-17 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/322202 Change subject: Only apply wgDBschema to postgres/mssql .. Only apply wgDBschema to postgres/mssql Bug: T148956 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint/doc.wm.org: add missing DirectoryIndex, remove old 2...

2016-11-17 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/322201 Change subject: contint/doc.wm.org: add missing DirectoryIndex, remove old 2.2 syntax .. contint/doc.wm.org: add missing DirectoryIndex,

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Switch discovery-stats cronjob to a dedicated script

2016-11-17 Thread Gehel (Code Review)
Gehel has submitted this change and it was merged. Change subject: Switch discovery-stats cronjob to a dedicated script .. Switch discovery-stats cronjob to a dedicated script Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment bcb1e40 DRY finding OrderReferenceId, get_class() -> instanceOf 86d27c4

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-11-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/322196 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment bcb1e40 DRY finding OrderReferenceId,

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Link Previews -> Page Previews

2016-11-17 Thread Phuedx (Code Review)
Phuedx has uploaded a new change for review. https://gerrit.wikimedia.org/r/322179 Change subject: Link Previews -> Page Previews .. Link Previews -> Page Previews Change-Id: I08e80220c76a65cadaba20ce78b9eb2b36139095 --- M

[MediaWiki-commits] [Gerrit] mediawiki...ParsoidBatchAPI[master]: Use namespaced version of IPSet

2016-11-17 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/322161 Change subject: Use namespaced version of IPSet .. Use namespaced version of IPSet The un-namespaced version is deprecated. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: reducers: Add the nextState helper function

2016-11-17 Thread Phuedx (Code Review)
Phuedx has uploaded a new change for review. https://gerrit.wikimedia.org/r/322155 Change subject: reducers: Add the nextState helper function .. reducers: Add the nextState helper function OO.copy doesn't copy Element

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Add link title change listener

2016-11-17 Thread Phuedx (Code Review)
Phuedx has uploaded a new change for review. https://gerrit.wikimedia.org/r/322156 Change subject: Add link title change listener .. Add link title change listener Supporting changes: * Remove the preview.previousActiveLink

[MediaWiki-commits] [Gerrit] integration/docroot[master]: delete .htaccess files for doc/integration

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: delete .htaccess files for doc/integration .. delete .htaccess files for doc/integration Ief4a6a296c533bb moves the content of these files over into the

[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint: move .htaccess content for doc/integration to puppet

2016-11-17 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: contint: move .htaccess content for doc/integration to puppet .. contint: move .htaccess content for doc/integration to puppet Formerly the repository

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Test cookie blocking on Test Wikipedia

2016-11-17 Thread Kaldari (Code Review)
Kaldari has uploaded a new change for review. https://gerrit.wikimedia.org/r/322154 Change subject: Test cookie blocking on Test Wikipedia .. Test cookie blocking on Test Wikipedia Don't merge until 1.29.0-wmf.4 is deployed

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Sort member list between active/inactive.

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Sort member list between active/inactive. .. Sort member list between active/inactive. Probably needs to tweak how transclusion works. Bug: T141184

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Sort member list between active/inactive.

2016-11-17 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/322153 Change subject: Sort member list between active/inactive. .. Sort member list between active/inactive. Probably needs to tweak how

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: eslint: Re-enable valid-jsdoc and make a pass

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: eslint: Re-enable valid-jsdoc and make a pass .. eslint: Re-enable valid-jsdoc and make a pass Change-Id: I5c3c942d5a9c51628619227c4bbaefd1d92a842d --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: For using() errors, reject Promise instead of thr...

2016-11-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/322150 Change subject: mw.loader: For using() errors, reject Promise instead of throwing .. mw.loader: For using() errors, reject Promise instead

[MediaWiki-commits] [Gerrit] operations/puppet[production]: gridengine: refactor and establish norms

2016-11-17 Thread Rush (Code Review)
Rush has uploaded a new change for review. https://gerrit.wikimedia.org/r/322149 Change subject: gridengine: refactor and establish norms .. gridengine: refactor and establish norms * consistent () and {} for class params *

[MediaWiki-commits] [Gerrit] mediawiki...Linter[master]: Display self-closed tags

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Display self-closed tags .. Display self-closed tags Change-Id: I6c084a6c72114b57a21cd367d398c673c5c4d991 --- M extension.json M i18n/en.json M

[MediaWiki-commits] [Gerrit] operations/software[master]: mariadb: Update package creation method

2016-11-17 Thread Jcrespo (Code Review)
Jcrespo has uploaded a new change for review. https://gerrit.wikimedia.org/r/322147 Change subject: mariadb: Update package creation method .. mariadb: Update package creation method * Updated mariadb-deb script to indentify

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toollabs: refactor and establish norms

2016-11-17 Thread Rush (Code Review)
Rush has submitted this change and it was merged. Change subject: toollabs: refactor and establish norms .. toollabs: refactor and establish norms No Op refactor for style and cruft. * New comments * Ditch static class

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: all wikis to 1.29.0-wmf.3

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: all wikis to 1.29.0-wmf.3 .. all wikis to 1.29.0-wmf.3 Change-Id: I95f1fbafaff259c3e4741cda503324a4a27958d8 --- M wikiversions.json 1 file changed, 299

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Add Czech alias of special page

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add Czech alias of special page .. Add Czech alias of special page Change-Id: Ifa48eee319c1dbc980c4978a4b352363739dde9b --- M CentralAuth.alias.php 1

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: all wikis to 1.29.0-wmf.3

2016-11-17 Thread Thcipriani (Code Review)
Thcipriani has uploaded a new change for review. https://gerrit.wikimedia.org/r/322146 Change subject: all wikis to 1.29.0-wmf.3 .. all wikis to 1.29.0-wmf.3 Change-Id: I95f1fbafaff259c3e4741cda503324a4a27958d8 --- M

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix MediaDownloadReceiver to work with all API versions.

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix MediaDownloadReceiver to work with all API versions. .. Fix MediaDownloadReceiver to work with all API versions. This resolves one of the blockers

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: DRY up some message date code

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: DRY up some message date code .. DRY up some message date code Change-Id: Ic0ba331824d7934031f84f270cbc36e8f5344a2f --- M

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.29.0-wmf.3]: visibilitychange: Consider all changes to imply hidden

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: visibilitychange: Consider all changes to imply hidden .. visibilitychange: Consider all changes to imply hidden Previously we only emitted "hidden" if

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Store time spent reading in History entries.

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Store time spent reading in History entries. .. Store time spent reading in History entries. This improves the smartness of our History database by

[MediaWiki-commits] [Gerrit] operations/puppet[production]: prometheus: switch 'ops' prometheus to varbit encoding

2016-11-17 Thread Filippo Giunchedi (Code Review)
Filippo Giunchedi has submitted this change and it was merged. Change subject: prometheus: switch 'ops' prometheus to varbit encoding .. prometheus: switch 'ops' prometheus to varbit encoding See also: *

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Drop bad banner history entries w/o failmail

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Drop bad banner history entries w/o failmail .. Drop bad banner history entries w/o failmail No need to move 'em to the damaged queue - all the bad ones

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Get rid of some unused CSS

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Get rid of some unused CSS .. Get rid of some unused CSS adyen.css is totally unused, there are no -addl- anything elements Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix editing the titles of topics with summaries

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix editing the titles of topics with summaries .. Fix editing the titles of topics with summaries Bug: T149827 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Persist channel parameter from install referrer.

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Persist channel parameter from install referrer. .. Persist channel parameter from install referrer. This introduces a new parameter for our install

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: closeOrderReference errors don't blow up

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: closeOrderReference errors don't blow up .. closeOrderReference errors don't blow up It's nice to clean up the console, but they'll close themselves

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix Amazon order IDs for manual captures

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix Amazon order IDs for manual captures .. Fix Amazon order IDs for manual captures When a capture that we request via the front end goes through

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: DRY finding OrderReferenceId, get_class() -> instanceOf

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: DRY finding OrderReferenceId, get_class() -> instanceOf .. DRY finding OrderReferenceId, get_class() -> instanceOf Refactor AmazonApi and AmazonMessage

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Raise error when raplace is done synchronously

2016-11-17 Thread Magul (Code Review)
Magul has uploaded a new change for review. https://gerrit.wikimedia.org/r/322145 Change subject: Raise error when raplace is done synchronously .. Raise error when raplace is done synchronously Bug: T98707 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[wmf/1.29.0-wmf.3]: Backporting fix for quantity precision issue.

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Backporting fix for quantity precision issue. .. Backporting fix for quantity precision issue. The actual fix is in data-values/number, see

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Phab: Remove custom UI string translations not in use anymore

2016-11-17 Thread Aklapper (Code Review)
Aklapper has uploaded a new change for review. https://gerrit.wikimedia.org/r/322144 Change subject: Phab: Remove custom UI string translations not in use anymore .. Phab: Remove custom UI string translations not in use

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Interwiki map update

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Interwiki map update .. Interwiki map update Includes creation of projectcomwiki as well as several changes to HTTPS links Bug: T150926 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Persist channel parameter from install referrer.

2016-11-17 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. https://gerrit.wikimedia.org/r/322143 Change subject: Persist channel parameter from install referrer. .. Persist channel parameter from install referrer. This introduces a new

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to bf44547

2016-11-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Update mobileapps to bf44547 .. Update mobileapps to bf44547 List of changes: 04c08ad Announcements on other wikis also return 200 f1ea24f Hygiene:

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to bf44547

2016-11-17 Thread BearND (Code Review)
BearND has uploaded a new change for review. https://gerrit.wikimedia.org/r/322142 Change subject: Update mobileapps to bf44547 .. Update mobileapps to bf44547 List of changes: 04c08ad Announcements on other wikis also

  1   2   3   >