Dbrant has submitted this change and it was merged.
Change subject: Fix NPE in full text search
..
Fix NPE in full text search
This is more a workaround. Ideally, this should be fixed on the API level.
It looks like the two
Dbrant has submitted this change and it was merged.
Change subject: Add SuggestionsTask
..
Add SuggestionsTask
and refactor the getter for wikidataDescriptions
Also only ask for descriptions we don't already have.
(Setting
Dbrant has submitted this change and it was merged.
Change subject: Use continue parameter to avoid API warnings.
..
Use continue parameter to avoid API warnings.
So, the server doesn't need to spit out those unnecessary
Dbrant has submitted this change and it was merged.
Change subject: Ensure Wikidata description is always shown in correct language
in lead image
..
Ensure Wikidata description is always shown in correct language in lead image
Dbrant has submitted this change and it was merged.
Change subject: Avoid NPE when going from search to another page
..
Avoid NPE when going from search to another page
java.lang.NullPointerException
at
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174772
Change subject: Add event logging for suggested pages.
..
Add event logging for suggested pages.
(Not hooked up to anything yet, but ready to
Dbrant has submitted this change and it was merged.
Change subject: Add Javadoc comments to WikidataCache.
..
Add Javadoc comments to WikidataCache.
The methods in WikidataCache are quite complicated, and it might not be
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174995
Change subject: [WIP] Iron out issues in Read More component.
..
[WIP] Iron out issues in Read More component.
- Dynamically size the
Dbrant has submitted this change and it was merged.
Change subject: Improve log messages for EventLogging.
..
Improve log messages for EventLogging.
When I'm testing what events are transmitted and to what schemas, it can get
Dbrant has submitted this change and it was merged.
Change subject: Use apply method instead of commit method for SharedPreferences.
..
Use apply method instead of commit method for SharedPreferences.
The commit method updates
Dbrant has submitted this change and it was merged.
Change subject: Avoid IndexOutOfBoundsException in when loading page
..
Avoid IndexOutOfBoundsException in when loading page
Bug: 73404
Change-Id:
Dbrant has submitted this change and it was merged.
Change subject: Remove W logo icon
..
Remove W logo icon
Change-Id: I127e103f16f6f424bbba2bb9b20c3d9c20edc966
---
D icon-svgs/32/search_w.noflip.svg
M
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175224
Change subject: [WIP] Update the search button to be a text+image selector.
..
[WIP] Update the search button to be a text+image selector.
-
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175225
Change subject: [WIP] Widgets.
..
[WIP] Widgets.
- Created Search Wikipedia widget that launches the app and goes
directly to the search
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175429
Change subject: Fix checkstyle and compilation.
..
Fix checkstyle and compilation.
- The search_w icon was still being referenced in one
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175431
Change subject: Start loving tablets more.
..
Start loving tablets more.
- Now providing dimension constants for 7 and 10 tablets, for both
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175459
Change subject: Implement Search event logging.
..
Implement Search event logging.
Change-Id: I8c58836df6ff57a998470184d3501a2a65936921
---
A
Dbrant has submitted this change and it was merged.
Change subject: Updated support libraries to 21.0.2
..
Updated support libraries to 21.0.2
Please update extra-android-m2repository component
of your local Android SDK.
Dbrant has submitted this change and it was merged.
Change subject: Material Design icons
..
Material Design icons
from https://github.com/google/material-design-icons
Some svg files had to be fixed because our convert script
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175578
Change subject: Tweak the space between the page title and description.
..
Tweak the space between the page title and description.
Change-Id:
Dbrant has submitted this change and it was merged.
Change subject: Updated squareup libraries
..
Updated squareup libraries
The big change is in OkHttp from 1.3 to 2.1.
A few API changes regarding caches required code
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175651
Change subject: Added config parameter for search logging sample rate.
..
Added config parameter for search logging sample rate.
Change-Id:
Dbrant has submitted this change and it was merged.
Change subject: Remove obsolete strings from translations
..
Remove obsolete strings from translations
Had compiler warnings in Android Studio because of that.
Change-Id:
Dbrant has submitted this change and it was merged.
Change subject: Make toolbar icons lighter
..
Make toolbar icons lighter
and make them a bit more transparent;
according to Android guidelines at
Dbrant has submitted this change and it was merged.
Change subject: Set search tab text color.
..
Set search tab text color.
This fixes an issue on 2.3 where the non active tab in search
is not readable in dark mode: black
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175749
Change subject: Improve collapsed infobox formatting.
..
Improve collapsed infobox formatting.
- Pull headers from the original table, but
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175751
Change subject: Honor HTML formatting in page title.
..
Honor HTML formatting in page title.
Some pages have an italicized title, especially
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175772
Change subject: Improve infobox/edit-pencil alignment.
..
Improve infobox/edit-pencil alignment.
The real issue was that some infoboxes were
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175781
Change subject: Tweak page title spacing for Lollipop+
..
Tweak page title spacing for Lollipop+
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175857
Change subject: Update the Search funnel to have a session ID.
..
Update the Search funnel to have a session ID.
Change-Id:
Dbrant has submitted this change and it was merged.
Change subject: Change location of apk to releases dir
..
Change location of apk to releases dir
Having it outside of the Gradle build folder has the advantage that
the apks
Dbrant has submitted this change and it was merged.
Change subject: Only log theme change events if the theme was actually changed.
..
Only log theme change events if the theme was actually changed.
Right now the
Dbrant has submitted this change and it was merged.
Change subject: Make error messages in account creation slightly more prominent.
..
Make error messages in account creation slightly more prominent.
Right now, when a user
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171330
Change subject: Fix tests related to PageProperties
..
Fix tests related to PageProperties
- Also fixed error in EditPreview test.
- Also
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171850
Change subject: Remove pinch-zoom in the WebView.
..
Remove pinch-zoom in the WebView.
Finally figured out (I think) why find-in-page was
Dbrant has submitted this change and it was merged.
Change subject: Change width of tappable area for Skip in OnboardingActivity.
..
Change width of tappable area for Skip in OnboardingActivity.
We're seeing a rather large
Dbrant has submitted this change and it was merged.
Change subject: Disambiguation and page issues dialog on bottom
..
Disambiguation and page issues dialog on bottom
Change-Id: If216e2b73cfc94184fca64c384575a5d1d903add
---
A
Dbrant has submitted this change and it was merged.
Change subject: Slide up/down animations for BottomDialogs
..
Slide up/down animations for BottomDialogs
Change-Id: Id496b25b7b412986b9c277c5ff2a3f9391bfb771
---
M
Dbrant has submitted this change and it was merged.
Change subject: Left/right animation inside page info dialog
..
Left/right animation inside page info dialog
Now have two different ListViews inside a ViewFlipper
and animate
Dbrant has submitted this change and it was merged.
Change subject: Disambig items have thumbnail, title, and Wikidata description
..
Disambig items have thumbnail, title, and Wikidata description
Collecting the disambig
Dbrant has submitted this change and it was merged.
Change subject: Page info dialog header click feedback + clickable
..
Page info dialog header click feedback + clickable
- Make the TextView into Buttons
- Disable the button
Dbrant has submitted this change and it was merged.
Change subject: Faster up/down animations for bottom dialogs
..
Faster up/down animations for bottom dialogs
Change-Id: I7814aa7541491b39fe7136e7d38e9886264232ca
(cherry
Dbrant has submitted this change and it was merged.
Change subject: ToC tweaks: always on ToC
..
ToC tweaks: always on ToC
- ToC button is always visible and enabled
- still: ToC opened automatically for all pages except Main
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176001
Change subject: Fix certain links to sections within the current page.
..
Fix certain links to sections within the current page.
Bug: 71745
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176042
Change subject: Don't move any tables/infoboxes on Main Page(s).
..
Don't move any tables/infoboxes on Main Page(s).
Certain wikis rely very
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176056
Change subject: Correctly style page title in ToC.
..
Correctly style page title in ToC.
Honor capitalization and HTML formatting.
Bug:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176060
Change subject: Keep toolbar shown when scrolling to a section programmatically.
..
Keep toolbar shown when scrolling to a section
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176156
Change subject: Ignore empty full-text results when using a continue offset.
..
Ignore empty full-text results when using a continue offset.
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176735
Change subject: Implement Search event logging.
..
Implement Search event logging.
Conflicts:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176736
Change subject: Update the Search funnel to have a session ID.
..
Update the Search funnel to have a session ID.
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176737
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: I0feafbe64aeaa8a7e33f6d54efe16e538ff159c3
---
M wikipedia/build.gradle
1 file
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176741
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: Ibdbb872e4e941965b4a93eacd3258c5658ee87ee
---
M wikipedia/build.gradle
1 file
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176739
Change subject: Implement Search event logging.
..
Implement Search event logging.
Conflicts:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176740
Change subject: Update the Search funnel to have a session ID.
..
Update the Search funnel to have a session ID.
Change-Id:
Dbrant has submitted this change and it was merged.
Change subject: Remove extra quotes in string resource
..
Remove extra quotes in string resource
Change-Id: Ib0531dcbb4eca98dc78a2007aa6bdc4f614dd809
---
M
Dbrant has submitted this change and it was merged.
Change subject: Move adjustDrawableToTheme call to onCreateOptionsMenu
..
Move adjustDrawableToTheme call to onCreateOptionsMenu
Saves a call when tapping on the overflow
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176936
Change subject: [WIP] Make references collapsible (and collapse by default)
..
[WIP] Make references collapsible (and collapse by default)
-
Dbrant has submitted this change and it was merged.
Change subject: Prevent NPE in ToCHandler.scrollToSection
..
Prevent NPE in ToCHandler.scrollToSection
Bug: T75402
Change-Id: I468d8ade39170c069073491ac85f8165622a4223
---
M
Dbrant has submitted this change and it was merged.
Change subject: Check if EditSectionActivity is finished
..
Check if EditSectionActivity is finished
Bug: T73299
Change-Id: I438a77d2116237016bb2a4fd73e4f82e7adb2a0d
---
M
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177238
Change subject: Allow enabling/disabling images in pages.
..
Allow enabling/disabling images in pages.
Implement a preference that enables or
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177253
Change subject: Fix possible crash when clicking link after activity closed.
..
Fix possible crash when clicking link after activity closed.
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177254
Change subject: Fix possible crash when switching language after activity
closed.
..
Fix possible crash when switching language after
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177255
Change subject: Fix behavior of long-press in Nearby.
..
Fix behavior of long-press in Nearby.
Before this patch, long-pressing an item in
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177397
Change subject: Use new index property to sort search results.
..
Use new index property to sort search results.
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177405
Change subject: Whoops: explicitly set placeholder image for thumbnails.
..
Whoops: explicitly set placeholder image for thumbnails.
Dbrant has submitted this change and it was merged.
Change subject: Avoid rehashing when building HashMaps in staticdata
..
Avoid rehashing when building HashMaps in staticdata
Setting load factor to 1, and capacity slightly
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177556
Change subject: Add ignored CSS class for table transforms.
..
Add ignored CSS class for table transforms.
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179139
Change subject: Fix possible crash when fetching random page.
..
Fix possible crash when fetching random page.
Bug: T75237
Change-Id:
Dbrant has submitted this change and it was merged.
Change subject: Enable Lint
..
Enable Lint
Mark string files that never get translated to ignore missing translations.
Set MissingTranslation to warnings.
Change-Id:
Dbrant has submitted this change and it was merged.
Change subject: Code inspections
..
Code inspections
Fix some low hanging fruit code inspections in Android Studio
Change-Id: Ib3845d2a65a37b7dbef8c619fcce3a3d6d59afcd
---
M
Dbrant has submitted this change and it was merged.
Change subject: Enable basic ProGuard minification
..
Enable basic ProGuard minification
We can make the ProGuard config more aggressive later.
Want to keep it on the lighter
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179515
Change subject: Decrease the edge width of Drawer drag areas.
..
Decrease the edge width of Drawer drag areas.
Compromise between the default
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179529
Change subject: Refine search logic a bit.
..
Refine search logic a bit.
- No longer offer the choice of Title vs. Full-text search.
-
Dbrant has submitted this change and it was merged.
Change subject: Change Credit to Author in the image viewer.
..
Change Credit to Author in the image viewer.
The word Author should be a lot clearer to our users than Credit,
Dbrant has submitted this change and it was merged.
Change subject: Save ProGuard mapping files
..
Save ProGuard mapping files
In case we need them to unscramble stack traces.
We haven't turned up ProGuard very much but better
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179919
Change subject: Tweak styling of collapsed infoboxes.
..
Tweak styling of collapsed infoboxes.
Also removed some unused stuff.
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179920
Change subject: Minor tweaks in collapsed infobox design.
..
Minor tweaks in collapsed infobox design.
- Give it a drop shadow instead of a
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179929
Change subject: First round of design tweaks to the Gallery view.
..
First round of design tweaks to the Gallery view.
- If the aspect ratio
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179947
Change subject: Minor tweaks of the Toolbar design.
..
Minor tweaks of the Toolbar design.
- Made the drop shadow under the toolbar a bit
Dbrant has submitted this change and it was merged.
Change subject: Fix test compilation
..
Fix test compilation
Change-Id: I266d256f131ed0c19fe61bbfb6d3a2da333a5ba7
---
M
Dbrant has submitted this change and it was merged.
Change subject: Stop making gallery view info labels bold
..
Stop making gallery view info labels bold
Change-Id: I6af64b29bfda736bae85363c69400c932b0de28c
(cherry picked
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180105
Change subject: Enable lead images in Beta.
..
Enable lead images in Beta.
Change-Id: I4c1fd12af767cbda480721595cd378503763fd96
---
M
Dbrant has submitted this change and it was merged.
Change subject: Don't display Read more section if there are no read more
suggestions
..
Don't display Read more section if there are no read more suggestions
Bug: T78502
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180224
Change subject: Improve scrollbar in Gallery description text.
..
Improve scrollbar in Gallery description text.
Make it no longer overlay
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180302
Change subject: [WIP] Share images.
..
[WIP] Share images.
- Added toolbar item for sharing images.
- The function automatically saves the
Dbrant has submitted this change and it was merged.
Change subject: Fix NPE in LeadImagesHandler.beginLayout
..
Fix NPE in LeadImagesHandler.beginLayout
Bug: T78501
Change-Id: Idc1b027ceca932bf83b8a3ec3760937bca5caf55
---
M
Dbrant has submitted this change and it was merged.
Change subject: More space between wordmark and slogan
..
More space between wordmark and slogan
Also, better wordmark alignment in OnboardingActivity for Hebrew
Bug: T78350
Dbrant has submitted this change and it was merged.
Change subject: Read More only for regular pages
..
Read More only for regular pages
Don't add a ToC entry and don't even try to request
one from the server for main, file
Dbrant has submitted this change and it was merged.
Change subject: Hide system bar in GalleryActivity
..
Hide system bar in GalleryActivity
Change-Id: I00b24b5c45bfefa9ab3462532680f0d95bc14159
---
M
Dbrant has submitted this change and it was merged.
Change subject: Back button goes back to calling activity if on first page
..
Back button goes back to calling activity if on first page
The problem was that it opened the
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172735
Change subject: [WIP] Final styling tweaks for lead images / wikidata
description.
..
[WIP] Final styling tweaks for lead images / wikidata
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172818
Change subject: Fix reloading of page after editing.
..
Fix reloading of page after editing.
Bug: 73314
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172860
Change subject: Fix possible crash in full-text search.
..
Fix possible crash in full-text search.
Change-Id:
Dbrant has submitted this change and it was merged.
Change subject: Capitalise first letter of Wikidata descriptions.
..
Capitalise first letter of Wikidata descriptions.
This patch capitalises the first letter of Wikidata
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173006
Change subject: Clear Wikidata cache when switching languages.
..
Clear Wikidata cache when switching languages.
Bug: 73349
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173011
Change subject: Scroll all the way up when first section in ToC clicked.
..
Scroll all the way up when first section in ToC clicked.
Also
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173018
Change subject: Don't show title or lead image block on Main page(s).
..
Don't show title or lead image block on Main page(s).
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173029
Change subject: Update styles for collapsing of IPA spans.
..
Update styles for collapsing of IPA spans.
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173047
Change subject: Make ThemeChooser dialog inherit from BottomDialog.
..
Make ThemeChooser dialog inherit from BottomDialog.
Change-Id:
Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173087
Change subject: Styling tweaks for Search.
..
Styling tweaks for Search.
- Make Title/Full buttons fill up the whole width, and update the
1 - 100 of 1853 matches
Mail list logo
