[MediaWiki-commits] [Gerrit] Solves visibility issue on the progress bar - change (mediawiki...UploadWizard)

2014-01-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106704 Change subject: Solves visibility issue on the progress bar .. Solves visibility issue on the progress bar At first it seemed odd to me that

[MediaWiki-commits] [Gerrit] Fix the i18n source string for the chunked preference - change (mediawiki...UploadWizard)

2014-01-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106711 Change subject: Fix the i18n source string for the chunked preference .. Fix the i18n source string for the chunked preference Seemed like a

[MediaWiki-commits] [Gerrit] Make sure that the close button is always visible - change (mediawiki...MultimediaViewer)

2014-01-14 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/107379 Change subject: Make sure that the close button is always visible .. Make sure that the close button is always visible Change-Id:

[MediaWiki-commits] [Gerrit] Clicking on the chevron should open/close the details - change (mediawiki...MultimediaViewer)

2014-01-14 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/107384 Change subject: Clicking on the chevron should open/close the details .. Clicking on the chevron should open/close the details Change-Id:

[MediaWiki-commits] [Gerrit] Propagate the favicon information to getInfo() - change (mediawiki/core)

2014-01-15 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/107592 Change subject: Propagate the favicon information to getInfo() .. Propagate the favicon information to getInfo() This is needed by

[MediaWiki-commits] [Gerrit] Display the favicon of the foreign file repo when available - change (mediawiki...MultimediaViewer)

2014-01-15 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/107594 Change subject: Display the favicon of the foreign file repo when available .. Display the favicon of the foreign file repo when available

[MediaWiki-commits] [Gerrit] Adding first pass at jsduck docs - change (mediawiki...MultimediaViewer)

2014-01-21 Thread Gilles (Code Review)
Gilles has submitted this change and it was merged. Change subject: Adding first pass at jsduck docs .. Adding first pass at jsduck docs Interface, data model, and image all documented. Change-Id:

[MediaWiki-commits] [Gerrit] Add main class to jsduck - change (mediawiki...MultimediaViewer)

2014-01-21 Thread Gilles (Code Review)
Gilles has submitted this change and it was merged. Change subject: Add main class to jsduck .. Add main class to jsduck Change-Id: I774303ce4f756637bea3821ae2b2ff724351b3bb --- M docs/external.js M docs/jsduck-config.json M

[MediaWiki-commits] [Gerrit] Revert Revert Enable JPG thumbnail chaining on all wikis e... - change (operations/mediawiki-config)

2014-11-19 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174451 Change subject: Revert Revert Enable JPG thumbnail chaining on all wikis except commons .. Revert Revert Enable JPG thumbnail chaining on all

[MediaWiki-commits] [Gerrit] Don't re-apply EXIF rotation to chained thumbnails - change (mediawiki/core)

2014-11-19 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174453 Change subject: Don't re-apply EXIF rotation to chained thumbnails .. Don't re-apply EXIF rotation to chained thumbnails Change-Id:

[MediaWiki-commits] [Gerrit] Blacklist site notice banner images - change (mediawiki...MultimediaViewer)

2014-11-20 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174698 Change subject: Blacklist site notice banner images .. Blacklist site notice banner images Images inside the current WLA banner are getting

[MediaWiki-commits] [Gerrit] Backport IE and tipsy bugfixes - change (mediawiki...MultimediaViewer)

2014-11-20 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174714 Change subject: Backport IE and tipsy bugfixes .. Backport IE and tipsy bugfixes This is a compilation of those commits:

[MediaWiki-commits] [Gerrit] Backport critical Media Viewer bugfixes - change (mediawiki/core)

2014-11-20 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174715 Change subject: Backport critical Media Viewer bugfixes .. Backport critical Media Viewer bugfixes Bug: 72516 Bug: 73337 Change-Id:

[MediaWiki-commits] [Gerrit] Backport IE and tipsy bugfixes - change (mediawiki...MultimediaViewer)

2014-11-20 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174718 Change subject: Backport IE and tipsy bugfixes .. Backport IE and tipsy bugfixes This is a compilation of those commits:

[MediaWiki-commits] [Gerrit] Backport critical Media Viewer bugfixes - change (mediawiki/core)

2014-11-20 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174724 Change subject: Backport critical Media Viewer bugfixes .. Backport critical Media Viewer bugfixes Bug: 72516 Bug: 73337 Change-Id:

[MediaWiki-commits] [Gerrit] Rename Performance to PerformanceLogger - change (mediawiki...MultimediaViewer)

2014-11-21 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174928 Change subject: Rename Performance to PerformanceLogger .. Rename Performance to PerformanceLogger Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Track the most recent upload time for performance events - change (mediawiki...MultimediaViewer)

2014-11-21 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174933 Change subject: [WIP] Track the most recent upload time for performance events .. [WIP] Track the most recent upload time for performance

[MediaWiki-commits] [Gerrit] TMH now passes jslint - change (integration/config)

2014-11-25 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/175668 Change subject: TMH now passes jslint .. TMH now passes jslint Bug: T63638 Change-Id: I4fa769745a255441ee5d8afe0baa1fa57474a0b7 --- M

[MediaWiki-commits] [Gerrit] [WIP] Track the most recent upload time for duration events - change (mediawiki...MultimediaViewer)

2014-11-05 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/171228 Change subject: [WIP] Track the most recent upload time for duration events .. [WIP] Track the most recent upload time for duration events

[MediaWiki-commits] [Gerrit] Revert layout changes - change (mediawiki...MultimediaViewer)

2014-11-06 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/171521 Change subject: Revert layout changes .. Revert layout changes This reverts several commits that changed above/below-the-fold Change-Id:

[MediaWiki-commits] [Gerrit] Revert layout changes in Media viewer - change (mediawiki/core)

2014-11-06 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/171522 Change subject: Revert layout changes in Media viewer .. Revert layout changes in Media viewer Change-Id:

[MediaWiki-commits] [Gerrit] Action schema update - change (analytics/multimedia)

2014-11-06 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/171560 Change subject: Action schema update .. Action schema update Change-Id: I4c087f68818bd218ddc5d0db1178b7ff4e679c14 Mingle:

[MediaWiki-commits] [Gerrit] Make room for arbitrary i18n text length in the options dialogs - change (mediawiki...MultimediaViewer)

2014-11-06 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/171580 Change subject: Make room for arbitrary i18n text length in the options dialogs .. Make room for arbitrary i18n text length in the options

[MediaWiki-commits] [Gerrit] Add the ability to apply a different duration sampling facto... - change (mediawiki...MultimediaViewer)

2014-11-06 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/171583 Change subject: Add the ability to apply a different duration sampling factor to loggedin users .. Add the ability to apply a different

[MediaWiki-commits] [Gerrit] Fix duration population calculation - change (analytics/multimedia)

2014-11-06 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/171595 Change subject: Fix duration population calculation .. Fix duration population calculation Change-Id:

[MediaWiki-commits] [Gerrit] Update mysql command to use shared config file - change (analytics/multimedia)

2014-11-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172252 Change subject: Update mysql command to use shared config file .. Update mysql command to use shared config file Change-Id:

[MediaWiki-commits] [Gerrit] Enable JPG thumbnail chaining on all wikis except commons - change (operations/mediawiki-config)

2014-11-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172254 Change subject: Enable JPG thumbnail chaining on all wikis except commons .. Enable JPG thumbnail chaining on all wikis except commons Bug:

[MediaWiki-commits] [Gerrit] Add debug call to check that config passing to the image sca... - change (mediawiki/core)

2014-11-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172280 Change subject: Add debug call to check that config passing to the image scalers works .. Add debug call to check that config passing to the

[MediaWiki-commits] [Gerrit] Add missing messages for stash errors - change (mediawiki/core)

2014-11-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172287 Change subject: Add missing messages for stash errors .. Add missing messages for stash errors Bug: 73229 Change-Id:

[MediaWiki-commits] [Gerrit] Output script actually doesn't need the table in the SQL com... - change (analytics/multimedia)

2014-11-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172291 Change subject: Output script actually doesn't need the table in the SQL command .. Output script actually doesn't need the table in the SQL

[MediaWiki-commits] [Gerrit] Add wgDebugLog group for FSFileBackend - change (operations/mediawiki-config)

2014-11-11 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172514 Change subject: Add wgDebugLog group for FSFileBackend .. Add wgDebugLog group for FSFileBackend Bug: 73229 Change-Id:

[MediaWiki-commits] [Gerrit] Enable JPG thumbnail chaining on Commons - change (operations/mediawiki-config)

2014-12-02 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/176912 Change subject: Enable JPG thumbnail chaining on Commons .. Enable JPG thumbnail chaining on Commons Bug: T69525 Change-Id:

[MediaWiki-commits] [Gerrit] Update schema versions - change (analytics/multimedia)

2014-12-02 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/176944 Change subject: Update schema versions .. Update schema versions Bug: T76453 Change-Id: I87808b764870b159ba8d31e002f05bf701ffc4c6 --- M

[MediaWiki-commits] [Gerrit] Add gitreview config file to repo - change (phabricator/tools)

2014-12-11 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/179090 Change subject: Add gitreview config file to repo .. Add gitreview config file to repo Change-Id: I8d7ac57cb9000c0d9e0130d2a737f296704b44fc

[MediaWiki-commits] [Gerrit] Crude mingle migration script - change (phabricator/tools)

2014-12-11 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/179091 Change subject: Crude mingle migration script .. Crude mingle migration script The values included are the ones that work the the multimedia

[MediaWiki-commits] [Gerrit] Update the SQL queries for the new versions of the schemas - change (analytics/multimedia)

2014-12-11 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/179159 Change subject: Update the SQL queries for the new versions of the schemas .. Update the SQL queries for the new versions of the schemas

[MediaWiki-commits] [Gerrit] Track the most recent upload time for performance events - change (mediawiki...MultimediaViewer)

2014-12-15 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/179918 Change subject: Track the most recent upload time for performance events .. Track the most recent upload time for performance events

[MediaWiki-commits] [Gerrit] Backport Media Viewer performance tracking - change (mediawiki/core)

2014-12-15 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/179921 Change subject: Backport Media Viewer performance tracking .. Backport Media Viewer performance tracking Bug: T76035 Change-Id:

[MediaWiki-commits] [Gerrit] Query image performance by upload time - change (analytics/multimedia)

2014-12-16 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/180136 Change subject: Query image performance by upload time .. Query image performance by upload time Per month, there isn't enough data to do

[MediaWiki-commits] [Gerrit] Disable thumbnail chaining - change (operations/mediawiki-config)

2014-12-16 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/180138 Change subject: Disable thumbnail chaining .. Disable thumbnail chaining The multiple passes of sharpening that can happen are undesirable

[MediaWiki-commits] [Gerrit] Log Last-Modified header in performance logger - change (mediawiki...MultimediaViewer)

2014-12-17 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/180433 Change subject: Log Last-Modified header in performance logger .. Log Last-Modified header in performance logger Bug: T78767 Change-Id:

[MediaWiki-commits] [Gerrit] Add scroll metadata open/close events to dashboards - change (analytics...config)

2014-12-17 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/180501 Change subject: Add scroll metadata open/close events to dashboards .. Add scroll metadata open/close events to dashboards Bug: T78797

[MediaWiki-commits] [Gerrit] Allow to set a different sampling factor for logged-in users - change (mediawiki...ImageMetrics)

2014-11-12 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172713 Change subject: Allow to set a different sampling factor for logged-in users .. Allow to set a different sampling factor for logged-in users

[MediaWiki-commits] [Gerrit] Set different ImageMetrics sampling factor for logged-in users - change (operations/mediawiki-config)

2014-11-12 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172720 Change subject: Set different ImageMetrics sampling factor for logged-in users .. Set different ImageMetrics sampling factor for logged-in

[MediaWiki-commits] [Gerrit] Backport MediaViewer options menu layout fix - change (mediawiki/core)

2014-11-12 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172737 Change subject: Backport MediaViewer options menu layout fix .. Backport MediaViewer options menu layout fix Change-Id:

[MediaWiki-commits] [Gerrit] Make room for arbitrary i18n text length in the options dialogs - change (mediawiki...MultimediaViewer)

2014-11-12 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172729 Change subject: Make room for arbitrary i18n text length in the options dialogs .. Make room for arbitrary i18n text length in the options

[MediaWiki-commits] [Gerrit] Make sure that the metadata panel isn't expanded by default ... - change (mediawiki...MultimediaViewer)

2014-11-13 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172953 Change subject: Make sure that the metadata panel isn't expanded by default in IE .. Make sure that the metadata panel isn't expanded by

[MediaWiki-commits] [Gerrit] Revert Enable JPG thumbnail chaining on all wikis except co... - change (operations/mediawiki-config)

2014-11-13 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172960 Change subject: Revert Enable JPG thumbnail chaining on all wikis except commons .. Revert Enable JPG thumbnail chaining on all wikis except

[MediaWiki-commits] [Gerrit] Don't re-apply EXIF rotation to chained thumbnails - change (mediawiki/core)

2014-11-13 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/172969 Change subject: Don't re-apply EXIF rotation to chained thumbnails .. Don't re-apply EXIF rotation to chained thumbnails Change-Id:

[MediaWiki-commits] [Gerrit] Track image unviews - change (mediawiki...MultimediaViewer)

2014-11-15 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/173515 Change subject: Track image unviews .. Track image unviews Change-Id: I4441b6df511f99b73bfafea0d804171435e129d2 Mingle:

[MediaWiki-commits] [Gerrit] Track how long users are viewing images for - change (mediawiki...MultimediaViewer)

2014-11-16 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/173640 Change subject: Track how long users are viewing images for .. Track how long users are viewing images for This is complete, but it would be

[MediaWiki-commits] [Gerrit] Add marker parameter to image requests coming from MediaViewer - change (mediawiki...MultimediaViewer)

2014-11-16 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/173641 Change subject: Add marker parameter to image requests coming from MediaViewer .. Add marker parameter to image requests coming from

[MediaWiki-commits] [Gerrit] Log more details about backend-fail-internal errors - change (mediawiki/core)

2014-11-17 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/173864 Change subject: Log more details about backend-fail-internal errors .. Log more details about backend-fail-internal errors Bug: 73094

[MediaWiki-commits] [Gerrit] Turn mmv-next/mmv-prev into OO events - change (mediawiki...MultimediaViewer)

2014-11-17 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/173916 Change subject: Turn mmv-next/mmv-prev into OO events .. Turn mmv-next/mmv-prev into OO events More of those events sent to the document can

[MediaWiki-commits] [Gerrit] Ignore fake mousemove event triggered by Chrome - change (mediawiki...MultimediaViewer)

2014-11-17 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/173915 Change subject: Ignore fake mousemove event triggered by Chrome .. Ignore fake mousemove event triggered by Chrome These happen due to

[MediaWiki-commits] [Gerrit] Bug fixes for view terms view more and the caption ellipsis - change (mediawiki...MultimediaViewer)

2014-11-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174116 Change subject: Bug fixes for view terms view more and the caption ellipsis .. Bug fixes for view terms view more and the caption ellipsis

[MediaWiki-commits] [Gerrit] Backport Media Viewer bugfixes - change (mediawiki/core)

2014-11-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174118 Change subject: Backport Media Viewer bugfixes .. Backport Media Viewer bugfixes Change-Id: Ib444bcd36309196f8203cb65a5496c9866632d73 Mingle:

[MediaWiki-commits] [Gerrit] filebackend: Log more details about backend-fail-internal er... - change (mediawiki/core)

2014-11-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174128 Change subject: filebackend: Log more details about backend-fail-internal errors .. filebackend: Log more details about backend-fail-internal

[MediaWiki-commits] [Gerrit] Avoid undefined index warnings on $states array - change (mediawiki...TimedMediaHandler)

2014-11-19 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/174385 Change subject: Avoid undefined index warnings on $states array .. Avoid undefined index warnings on $states array Change-Id:

[MediaWiki-commits] [Gerrit] Log Last-Modified header in performance logger - change (mediawiki...MultimediaViewer)

2014-12-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/180742 Change subject: Log Last-Modified header in performance logger .. Log Last-Modified header in performance logger Bug: T78767 Change-Id:

[MediaWiki-commits] [Gerrit] Backport Last-Modified performance logging for Media Viewer - change (mediawiki/core)

2014-12-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/180743 Change subject: Backport Last-Modified performance logging for Media Viewer .. Backport Last-Modified performance logging for Media Viewer

[MediaWiki-commits] [Gerrit] Update network performance schema queries - change (analytics/multimedia)

2014-12-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/180744 Change subject: Update network performance schema queries .. Update network performance schema queries Bug: T84852 Change-Id:

[MediaWiki-commits] [Gerrit] Fix for broken thumbnails when the file width is in $wgThumb... - change (mediawiki/core)

2014-12-09 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/178529 Change subject: Fix for broken thumbnails when the file width is in $wgThumbnailBucket .. Fix for broken thumbnails when the file width is in

[MediaWiki-commits] [Gerrit] Fix for broken thumbnails when the file width is in $wgThumb... - change (mediawiki/core)

2014-12-09 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/178531 Change subject: Fix for broken thumbnails when the file width is in $wgThumbnailBucket .. Fix for broken thumbnails when the file width is in

[MediaWiki-commits] [Gerrit] Solves visibility issue on the progress bar - change (mediawiki...UploadWizard)

2014-01-06 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/105694 Change subject: Solves visibility issue on the progress bar .. Solves visibility issue on the progress bar At first it seemed odd to me that

[MediaWiki-commits] [Gerrit] Move the arrows and the close/fullscreen button - change (mediawiki...MultimediaViewer)

2014-01-08 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106224 Change subject: Move the arrows and the close/fullscreen button .. Move the arrows and the close/fullscreen button Looks drastic at first,

[MediaWiki-commits] [Gerrit] Make the behavior of the lightbox more consistent with scroll - change (mediawiki...MultimediaViewer)

2014-01-08 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106263 Change subject: Make the behavior of the lightbox more consistent with scroll .. Make the behavior of the lightbox more consistent with

[MediaWiki-commits] [Gerrit] Only scroll to the top when opening the lightbox - change (mediawiki...MultimediaViewer)

2014-01-09 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106533 Change subject: Only scroll to the top when opening the lightbox .. Only scroll to the top when opening the lightbox Not when going

[MediaWiki-commits] [Gerrit] Improve the test coverage to also check prev/next scroll - change (mediawiki...MultimediaViewer)

2014-01-09 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106560 Change subject: Improve the test coverage to also check prev/next scroll .. Improve the test coverage to also check prev/next scroll This

[MediaWiki-commits] [Gerrit] Track detailed content loading network performance - change (mediawiki...MultimediaViewer)

2014-02-04 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/97 Change subject: Track detailed content loading network performance .. Track detailed content loading network performance Leverages the W3C

[MediaWiki-commits] [Gerrit] Fix fullscreen and close icons - change (mediawiki...MultimediaViewer)

2014-02-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/112426 Change subject: Fix fullscreen and close icons .. Fix fullscreen and close icons Some styles got mangled when 111372 landed Change-Id:

[MediaWiki-commits] [Gerrit] Fix defullscreen icon duplicate CSS - change (mediawiki...MultimediaViewer)

2014-02-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/112428 Change subject: Fix defullscreen icon duplicate CSS .. Fix defullscreen icon duplicate CSS This one slipped through the cracks again

[MediaWiki-commits] [Gerrit] Start sampling detailed network performance for Multimedia V... - change (operations/mediawiki-config)

2014-02-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/112452 Change subject: Start sampling detailed network performance for Multimedia Viewer .. Start sampling detailed network performance for

[MediaWiki-commits] [Gerrit] Get rid of lightboxHooks - change (mediawiki...MultimediaViewer)

2014-02-11 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/112670 Change subject: Get rid of lightboxHooks .. Get rid of lightboxHooks Delete lightboxHooks, since most of them haven't proven to be useful.

[MediaWiki-commits] [Gerrit] Chevron/metadata UI behavior improvements - change (mediawiki...MultimediaViewer)

2014-01-22 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109023 Change subject: Chevron/metadata UI behavior improvements .. Chevron/metadata UI behavior improvements When the multimedia panel is closed,

[MediaWiki-commits] [Gerrit] Simple test for enter/exiting fullscreen mode - change (mediawiki...MultimediaViewer)

2014-01-27 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109677 Change subject: Simple test for enter/exiting fullscreen mode .. Simple test for enter/exiting fullscreen mode While writing the test I

[MediaWiki-commits] [Gerrit] Fixes bug where next/prev would exit fullscreen mode - change (mediawiki...MultimediaViewer)

2014-01-27 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109682 Change subject: Fixes bug where next/prev would exit fullscreen mode .. Fixes bug where next/prev would exit fullscreen mode Next/prev

[MediaWiki-commits] [Gerrit] Fix fatal in DataCollector.php - change (mediawiki...CommonsMetadata)

2014-01-28 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109857 Change subject: Fix fatal in DataCollector.php .. Fix fatal in DataCollector.php b6a5a1f17efb06a12be65fce3a708d50928cd7af introduced a fatal

[MediaWiki-commits] [Gerrit] Test metadata visibility in fullscreen mode - change (mediawiki...MultimediaViewer)

2014-01-28 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109866 Change subject: Test metadata visibility in fullscreen mode .. Test metadata visibility in fullscreen mode Add metadata visibility logic to

[MediaWiki-commits] [Gerrit] Swap position of caption and description - change (mediawiki...MultimediaViewer)

2014-01-30 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110341 Change subject: Swap position of caption and description .. Swap position of caption and description The design requested that the caption is

[MediaWiki-commits] [Gerrit] Replace $.fn.msg calls my mw.message - change (mediawiki...MultimediaViewer)

2014-01-30 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110363 Change subject: Replace $.fn.msg calls my mw.message .. Replace $.fn.msg calls my mw.message $.fn.msg breaks on beta for an unknown reason

[MediaWiki-commits] [Gerrit] Revert Replace $.fn.msg calls by mw.message - change (mediawiki...MultimediaViewer)

2014-01-30 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110364 Change subject: Revert Replace $.fn.msg calls by mw.message .. Revert Replace $.fn.msg calls by mw.message This reverts commit

[MediaWiki-commits] [Gerrit] Fix the view all uses link when there are both local and g... - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110517 Change subject: Fix the view all uses link when there are both local and global results .. Fix the view all uses link when there are both

[MediaWiki-commits] [Gerrit] Make mmv handle urlencoded hashes - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110522 Change subject: Make mmv handle urlencoded hashes .. Make mmv handle urlencoded hashes Change-Id: Id05806be4586a3d6f04b92ace2c8195b8de016bc

[MediaWiki-commits] [Gerrit] Add the ability to know if fullscreen is available - change (mediawiki/core)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110523 Change subject: Add the ability to know if fullscreen is available .. Add the ability to know if fullscreen is available Not all browsers

[MediaWiki-commits] [Gerrit] Hide the fullscren button when fullscreen is unavailable - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110525 Change subject: Hide the fullscren button when fullscreen is unavailable .. Hide the fullscren button when fullscreen is unavailable

[MediaWiki-commits] [Gerrit] Place the metadata correctly before opening the lightbox - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110530 Change subject: Place the metadata correctly before opening the lightbox .. Place the metadata correctly before opening the lightbox The

[MediaWiki-commits] [Gerrit] Hide the controls after some time when in fullscreen mode - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110579 Change subject: Hide the controls after some time when in fullscreen mode .. Hide the controls after some time when in fullscreen mode

[MediaWiki-commits] [Gerrit] Revert jquery.color.test: Use fake timers - change (mediawiki/core)

2014-03-28 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/121901 Change subject: Revert jquery.color.test: Use fake timers .. Revert jquery.color.test: Use fake timers This reverts commit

[MediaWiki-commits] [Gerrit] Revert jquery.makeCollapsible.test: Use fake timers to adva... - change (mediawiki/core)

2014-03-28 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/121904 Change subject: Revert jquery.makeCollapsible.test: Use fake timers to advance animations .. Revert jquery.makeCollapsible.test: Use fake

[MediaWiki-commits] [Gerrit] Fixes various bugs in IE - change (mediawiki...MultimediaViewer)

2014-03-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/122398 Change subject: Fixes various bugs in IE .. Fixes various bugs in IE - error caused by select() called during focus event - HTMLElement not

[MediaWiki-commits] [Gerrit] Fix error in IE 9 - change (mediawiki/core)

2014-03-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/122408 Change subject: Fix error in IE 9 .. Fix error in IE 9 These browsers don't support calling apply() on the console.log object Change-Id:

[MediaWiki-commits] [Gerrit] Disable IE 9 - change (mediawiki...MultimediaViewer)

2014-03-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/122422 Change subject: Disable IE 9 .. Disable IE 9 At the moment issues in core are preventing Media Viewer from working on IE 9. Let's disable

[MediaWiki-commits] [Gerrit] Fixes IE11 support in jquery.fullscreen - change (mediawiki/core)

2014-04-01 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/122648 Change subject: Fixes IE11 support in jquery.fullscreen .. Fixes IE11 support in jquery.fullscreen jquery.fullscreen wouldn't work properly

[MediaWiki-commits] [Gerrit] Fix breakage on beta due to type hint being too strict - change (mediawiki...MultimediaViewer)

2014-04-01 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/122713 Change subject: Fix breakage on beta due to type hint being too strict .. Fix breakage on beta due to type hint being too strict Change-Id:

[MediaWiki-commits] [Gerrit] Reduce Wikidata author vcard to creator part - change (mediawiki...CommonsMetadata)

2014-02-25 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115379 Change subject: Reduce Wikidata author vcard to creator part .. Reduce Wikidata author vcard to creator part Wikidata templates dump a vcard

[MediaWiki-commits] [Gerrit] Bugfixes and improvements for the progress bar - change (mediawiki...MultimediaViewer)

2014-02-26 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115591 Change subject: Bugfixes and improvements for the progress bar .. Bugfixes and improvements for the progress bar - the bar now starts at 5%

[MediaWiki-commits] [Gerrit] Make the SVG filter inline - change (mediawiki...MultimediaViewer)

2014-02-26 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115610 Change subject: Make the SVG filter inline .. Make the SVG filter inline The external SVG doesn't work on beta, because it's hosted on a

[MediaWiki-commits] [Gerrit] Ignore left/right key presses when there's a modifier - change (mediawiki...MultimediaViewer)

2014-02-26 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115639 Change subject: Ignore left/right key presses when there's a modifier .. Ignore left/right key presses when there's a modifier Change-Id:

[MediaWiki-commits] [Gerrit] Move uploaded by to the right spot - change (mediawiki...MultimediaViewer)

2014-02-26 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115642 Change subject: Move uploaded by to the right spot .. Move uploaded by to the right spot As specified in the acceptance criteria, it should

  1   2   3   4   5   6   7   8   9   10   >