Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54215
Change subject: Remove error suppression in Exif::isRational
..
Remove error suppression in Exif::isRational
preg_match throws warning,
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54216
Change subject: Remove spaces between parentheses in function calls
..
Remove spaces between parentheses in function calls
Change-Id: I
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54217
Change subject: Fix type of list=tags&tgcontinue
..
Fix type of list=tags&tgcontinue
Was already interpretted as string before, but wit
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54517
Change subject: Remove spaces in function signature
..
Remove spaces in function signature
Change-Id: I45aea7a7af88cd913b2f485913620a8a
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54715
Change subject: Remove (edit) from Special:Tags for non-editinterface users
..
Remove (edit) from Special:Tags for non-editinterface use
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54879
Change subject: ContentHandlerTest: Use dataProvider
..
ContentHandlerTest: Use dataProvider
Changing a global 3 times in a test is bad
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54886
Change subject: SideBarTest.php: Use dataProvider/use setMwGlobals
..
SideBarTest.php: Use dataProvider/use setMwGlobals
One test metho
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54892
Change subject: MagicVariableTest.php: Use dataProvider
..
MagicVariableTest.php: Use dataProvider
Setting a global 3 times in one test
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55095
Change subject: TimeAdjustTest: Use dataProvider
..
TimeAdjustTest: Use dataProvider
Also removes setting of wgContLang/wgLanguageCode,
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55118
Change subject: MessageTest: Split test and use setMwGlobals
..
MessageTest: Split test and use setMwGlobals
Change-Id: I9d7f16ed519622
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55121
Change subject: Tests: Use more setMwGlobals
..
Tests: Use more setMwGlobals
Change some tests to use setMwGlobals to have restoring of
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55272
Change subject: Tests: Fix case of some methods
..
Tests: Fix case of some methods
Change-Id: Iab247f805410f2e9157d325edd80880538a3e54c
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55289
Change subject: Installer: Check if /extensions is readable and a directory
..
Installer: Check if /extensions is readable and a directo
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55303
Change subject: DefaultSettings: Remove some empty lines
..
DefaultSettings: Remove some empty lines
Add a missing comment - text taken
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55460
Change subject: Pass function name to insert() in replace() in Database class
..
Pass function name to insert() in replace() in Database
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/69950
Change subject: Improve help text for list=alllinks and alltransclusions
..
Improve help text for list=alllinks and alltransclusions
Th
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/69953
Change subject: Capitalize URL in api help
..
Capitalize URL in api help
As part of bug 34965
Change-Id: Ia1df9748b5de33f6ef5088103ccc
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/69971
Change subject: date_default_timezone_set unnneeded in Parser::getVariableValue
..
date_default_timezone_set unnneeded in Parser::getVar
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/71121
Change subject: Added wf[Local]DateTime to create DateTime objects
..
Added wf[Local]DateTime to create DateTime objects
This avoids us
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58728
Change subject: Use wfAppendQuery to append a query
..
Use wfAppendQuery to append a query
Also pass a array to wfAppendQuery, which th
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58903
Change subject: Use a combined const, instead of string concat in Exif.php
..
Use a combined const, instead of string concat in Exif.php
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59180
Change subject: Fixed spacing in skins folder
..
Fixed spacing in skins folder
Added spaces inside function calls
Added spaces before i
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59654
Change subject: Add missing braces to for in wfGetCallerTest
..
Add missing braces to for in wfGetCallerTest
Change-Id: I14b7abb90e2574
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59855
Change subject: Pass array to Title::getLocalURL and friends instead of strings
..
Pass array to Title::getLocalURL and friends instead
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60028
Change subject: Fixed spacing in api folder
..
Fixed spacing in api folder
Added spaces before if, foreach
Added some braces for one li
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60107
Change subject: Remove duplicate code from Setup.php
..
Remove duplicate code from Setup.php
Change-Id: I6dadb12ec8410258d7c9c24e1d12ba
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60129
Change subject: Fixed spacing in db/debug/diff/externalstore/objectcache folder
..
Fixed spacing in db/debug/diff/externalstore/objectca
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60139
Change subject: Add doc for SpecialPage::postText
..
Add doc for SpecialPage::postText
A combined doc does not work
Add some spaces to
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60199
Change subject: Add a OneLineStatementSniff
..
Add a OneLineStatementSniff
This sniffs looks for curly braces around ifs and report mis
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60201
Change subject: Use wfShellExec in MimeMagic
..
Use wfShellExec in MimeMagic
This avoids shell execution with backticks
Change-Id: I37
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60445
Change subject: $wgNamespaceRobotPolicies for dewiki: Add 101 and 829
..
$wgNamespaceRobotPolicies for dewiki: Add 101 and 829
dewiki h
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60447
Change subject: NS_IMAGE/NS_IMAGE_TALK => NS_FILE/NS_FILE_TALK
..
NS_IMAGE/NS_IMAGE_TALK => NS_FILE/NS_FILE_TALK
Change-Id: I32f93e1786
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60452
Change subject: Use RecentChange::getTitle in ExternalChangesLine
..
Use RecentChange::getTitle in ExternalChangesLine
Title::newFromTe
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62979
Change subject: $wgFlaggedRevsNamespaces for dewiki: Add NS_MODULE
..
$wgFlaggedRevsNamespaces for dewiki: Add NS_MODULE
dewiki already
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62986
Change subject: Avoid Generic accessor in Category.php
..
Avoid Generic accessor in Category.php
This php magic is hard to read
Change
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62988
Change subject: echo is not a function
..
echo is not a function
Removed parenthesis after echo
Change-Id: Ia533aedf63b11d15dcc6a5cf75
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62994
Change subject: Fixed spacing
..
Fixed spacing
Added spaces around some parenthesis
Change-Id: If1e50e2a7b0046e91c0bbce8bf6641d8b2446a
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62999
Change subject: print is not a function
..
print is not a function
Removed parenthesis after print
Change-Id: I1343872de7aa7c64952a3d8
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63282
Change subject: jQuery.byteLimit with callback can go into a endless loop
..
jQuery.byteLimit with callback can go into a endless loop
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63288
Change subject: Do not returning external title in
ApiPageSet::getRedirectTargets
..
Do not returning external title in ApiPageSet::get
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63482
Change subject: Set english transform tables in jquery.tablesorter.test
..
Set english transform tables in jquery.tablesorter.test
Havi
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63874
Change subject: Fixed spacing and removed unneeded parenthesis
..
Fixed spacing and removed unneeded parenthesis
Added spaces after/bef
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63896
Change subject: Replaced some function calls with local vars
..
Replaced some function calls with local vars
Storing the [fix] return v
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64024
Change subject: Fix badcontinue in possible errors of paraminfo
..
Fix badcontinue in possible errors of paraminfo
Badcontinue results
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64026
Change subject: Add helpurls to some api modules
..
Add helpurls to some api modules
Change-Id: I41cc20ea5daf089e5fb26d1548d3b58cfe5f4d
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64317
Change subject: Add RC_EXTERNAL to comment in tables.sql
..
Add RC_EXTERNAL to comment in tables.sql
Change-Id: If3156984e9ff447fec6644
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64512
Change subject: Add page language to prop=info
..
Add page language to prop=info
This can be useful to determine the language of a page
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55934
Change subject: Add non DBMS depending SQL tests for DatabaseBase
..
Add non DBMS depending SQL tests for DatabaseBase
Created a Databa
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56109
Change subject: Check return value of dir() in Skin.php
..
Check return value of dir() in Skin.php
This avoids a fatal, when something
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56125
Change subject: Handle invalid titles on ProtectedPages and ProtectedTitles
..
Handle invalid titles on ProtectedPages and ProtectedTitl
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56373
Change subject: API: Set uselang as allowed param in ApiMain and document it
..
API: Set uselang as allowed param in ApiMain and documen
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57038
Change subject: API param validation: Set strict mode for in_array
..
API param validation: Set strict mode for in_array
The in_array g
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57039
Change subject: API: Add more generic possible errors
..
API: Add more generic possible errors
Added the possible errors for baduser, b
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57047
Change subject: API: Add new type 'language'
..
API: Add new type 'language'
Working the same way than 'namespace' by override the type
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57103
Change subject: API: Add new hook 'APIGetPossibleErrors'
..
API: Add new hook 'APIGetPossibleErrors'
This allows extensions to modify t
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57268
Change subject: Update limit/urlwidth param doc of prop=imageinfo
..
Update limit/urlwidth param doc of prop=imageinfo
Follow up Id0ec6
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57277
Change subject: Remove spaces around ::
..
Remove spaces around ::
Change-Id: I24fe5ad907bcf5235aa91b650785c571502456a1
---
M includes/
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57741
Change subject: fixed php doc in ApiBase
..
fixed php doc in ApiBase
Change-Id: I9c893de8c067be3e926f5de5f0b87ac47b81772d
---
M include
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57745
Change subject: Call ApiPageSet::getFinalParamDescription
..
Call ApiPageSet::getFinalParamDescription
This allows extensions to modify
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57852
Change subject: Add nosummary, minor and watchthis to Special:MyPage and friends
..
Add nosummary, minor and watchthis to Special:MyPage
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57922
Change subject: Add missing wfProfileOut before throwing an exception
..
Add missing wfProfileOut before throwing an exception
Change-I
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58108
Change subject: Add missing wfProfileOut to LocalisationCache
..
Add missing wfProfileOut to LocalisationCache
Follow up Ib94a8c18c4e27
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58120
Change subject: Fix doc and deprecated warning of Title::fixUrlQueryArgs
..
Fix doc and deprecated warning of Title::fixUrlQueryArgs
Br
Umherirrender has uploaded a new change for review.
Change subject: fix some spacing
..
fix some spacing
Change-Id: I93f0a87ba7129bc336083e7289247d3150feb606
---
M includes/cache/CacheDependency.php
M includes/cache/HTMLFileCach
Umherirrender has uploaded a new change for review.
Change subject: Show no size links on image pages with errors
..
Show no size links on image pages with errors
This avoids useless
"Size of this preview: . Other resolutions:
Umherirrender has uploaded a new change for review.
Change subject: Avoid undefined offset for $wgImageLimits
..
Avoid undefined offset for $wgImageLimits
This can happen, when customized $wgImageLimits, but not
the option in $w
Umherirrender has uploaded a new change for review.
Change subject: ForeignAPIRepo: Show thumb error from foreign repo
..
ForeignAPIRepo: Show thumb error from foreign repo
When the api of the foreign repo gives a thumb error, t
Umherirrender has uploaded a new change for review.
Change subject: fix some spacing
..
fix some spacing
Change-Id: I670a7baf3ba1e70d18346bb00938d518ba2063bd
---
M includes/actions/HistoryAction.php
M includes/api/ApiBase.php
M
Umherirrender has uploaded a new change for review.
Change subject: fix some spacing
..
fix some spacing
Change-Id: Ia9650be8b791fd2f0ccbc099436918a9d12d9968
---
M includes/installer/CliInstaller.php
M includes/installer/Databas
Umherirrender has uploaded a new change for review.
Change subject: fix some spacing
..
fix some spacing
Change-Id: I88e73d47a552918880514d88a876296a6cb80d88
---
M includes/filebackend/FSFile.php
M includes/filebackend/FileOp.ph
Umherirrender has uploaded a new change for review.
Change subject: fix some spacing
..
fix some spacing
Change-Id: I8f976013f33c5818e4402604fe8610aa3f43b0c6
---
M includes/ArrayUtils.php
M includes/Article.php
M includes/Block.
Umherirrender has uploaded a new change for review.
Change subject: apitests leaks wgUser
..
apitests leaks wgUser
1) ParserTests::testParserTest with data set #468 ('pre-save transform:
Signature expansion', '* ~~~
* ~~~
* ~~~
Umherirrender has uploaded a new change for review.
Change subject: set wgLanguageCode in NewParserTests for all tests
..
set wgLanguageCode in NewParserTests for all tests
Change one method default
Change-Id: Id8d6817c616c2898
Umherirrender has uploaded a new change for review.
Change subject: Title.php: replace some '*' with explicit fields in selects
..
Title.php: replace some '*' with explicit fields in selects
It is good practice to select only fi
Umherirrender has uploaded a new change for review.
Change subject: Add ArchivedFile::selectFields() and use it
..
Add ArchivedFile::selectFields() and use it
Change-Id: Ia19d7bc1eb2bf77f1aca9d3891cebf57e45c030b
---
M includes/f
Umherirrender has uploaded a new change for review.
Change subject: Use OldLocalFile::selectFields()
..
Use OldLocalFile::selectFields()
It is good practice to specifiy the fields in a select
Change-Id: I3faa568ed6311a585da9161
Umherirrender has uploaded a new change for review.
Change subject: fix some spacing
..
fix some spacing
Change-Id: I306091347ccaaf11dee0cdfda3019cb0c12be51b
---
M includes/EditPage.php
M includes/FeedUtils.php
M includes/Html.p
Umherirrender has uploaded a new change for review.
Change subject: Add some missing readonly checks:
..
Add some missing readonly checks:
* Do not allow working on Special:EditWatchlist
* Do not reset all notification markers
*
Umherirrender has uploaded a new change for review.
Change subject: TRUE, FALSE and NULL must be lowercase
..
TRUE, FALSE and NULL must be lowercase
From phpcs
Change-Id: I09672012be28ae3985702e314442db00d154de24
---
M includes
Umherirrender has uploaded a new change for review.
Change subject: remove space before semicolon
..
remove space before semicolon
Change-Id: Ic0d890f5e27cec017c7f7910a67d53b2edf82079
---
M includes/Article.php
M includes/EditPa
Umherirrender has uploaded a new change for review.
Change subject: remove not needed return and break
..
remove not needed return and break
break after throw is not executed
return; at end of function is not needed
Change-Id:
Umherirrender has uploaded a new change for review.
Change subject: ValidGlobalName: whitelist $messageMemc and $parserMemc
..
ValidGlobalName: whitelist $messageMemc and $parserMemc
Both are in the docs under docs\globals.txt
Umherirrender has uploaded a new change for review.
Change subject: fix hardcoded quote in BacklinkCache
..
fix hardcoded quote in BacklinkCache
Also make the IS NULL in upper case, looks better and sql reservered
words often wr
Umherirrender has uploaded a new change for review.
Change subject: SpecialPageFactory::resolveAlias returns null for invalid names
..
SpecialPageFactory::resolveAlias returns null for invalid names
Change-Id: I8def9dd88ebfbe9fc
Umherirrender has uploaded a new change for review.
Change subject: Avoid $wgUser when getting tokens in api
..
Avoid $wgUser when getting tokens in api
The api is using static user functions to obtain a token. This functions
us
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/48658
Change subject: Pass user to File::recordUpload to avoid $wgUser
..
Pass user to File::recordUpload to avoid $wgUser
Moves the giving o
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/48660
Change subject: Add url param 'extended' to Special:Watchlist
..
Add url param 'extended' to Special:Watchlist
This new url param allow
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/48871
Change subject: cleanup action=tokens
..
cleanup action=tokens
* profile of execute function is done by the caller
* $type is always lo
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49483
Change subject: [Regression] Do not trim spaces on edit preview or show changes
..
[Regression] Do not trim spaces on edit preview or sh
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/50552
Change subject: deprecated two unused methods
..
deprecated two unused methods
Change-Id: I9e8847ec37f714037ea6867aa531c2b308a02f17
---
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/50577
Change subject: Added missing wfDeprecated calls and @deprecated docs
..
Added missing wfDeprecated calls and @deprecated docs
Change-I
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/116162
Change subject: Remove AdminSettings.php hint from Installer message
..
Remove AdminSettings.php hint from Installer message
Message 'c
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/116166
Change subject: Add missing DROP SEQUENCE to postgres' tables.sql
..
Add missing DROP SEQUENCE to postgres' tables.sql
To drop all poss
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/116286
Change subject: Use a secondary db connection for Revsion::getParentLength in
api
..
Use a secondary db connection for Revsion::getPare
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/116290
Change subject: Remove final period from api module descriptions
..
Remove final period from api module descriptions
The most descripti
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/116291
Change subject: return array on prop=imageinfo for empty metadata
..
return array on prop=imageinfo for empty metadata
A array produces
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/116977
Change subject: Add @deprecated hint to $j
..
Add @deprecated hint to $j
Change-Id: I0d9204ea354316ca11f568c81ad38f4089c91e80
---
M res
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/117022
Change subject: LocalSettings.php must be readable by the server
..
LocalSettings.php must be readable by the server
Bug: 61094
Change-
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/117041
Change subject: Remove wildcard actions from list=logevents&leaction=
..
Remove wildcard actions from list=logevents&leaction=
The docu
Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/117307
Change subject: Revert "Rollback: Make update of recentchanges table later"
..
Revert "Rollback: Make update of recentchanges table late
201 - 300 of 5549 matches
Mail list logo
