[MediaWiki-commits] [Gerrit] Restore the number of rows shown on Special:Watchlist - change (mediawiki/core)

2014-07-29 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/150390 Change subject: Restore the number of rows shown on Special:Watchlist .. Restore the number of rows shown on Special:Watchlist This rev

[MediaWiki-commits] [Gerrit] Remove return from Action::checkCanExecute - change (mediawiki/core)

2014-08-03 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151437 Change subject: Remove return from Action::checkCanExecute .. Remove return from Action::checkCanExecute No need to return true on succ

[MediaWiki-commits] [Gerrit] Set relevant title on Special:RecentChangesLinked - change (mediawiki/core)

2014-08-03 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151443 Change subject: Set relevant title on Special:RecentChangesLinked .. Set relevant title on Special:RecentChangesLinked This adds title

[MediaWiki-commits] [Gerrit] Add backlinks on special pages with relevant title - change (mediawiki/core)

2014-08-03 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151445 Change subject: Add backlinks on special pages with relevant title .. Add backlinks on special pages with relevant title When a relevan

[MediaWiki-commits] [Gerrit] Fix backlink for RevertAction - change (mediawiki/core)

2014-08-03 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151448 Change subject: Fix backlink for RevertAction .. Fix backlink for RevertAction RevertAction::getDescription cannot set subtitle on Outp

[MediaWiki-commits] [Gerrit] Ignore Squiz.Classes.ValidClassName for Preprocessors - change (mediawiki...codesniffer)

2014-08-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151593 Change subject: Ignore Squiz.Classes.ValidClassName for Preprocessors .. Ignore Squiz.Classes.ValidClassName for Preprocessors See I1a7

[MediaWiki-commits] [Gerrit] Fixed spacing - change (mediawiki/core)

2014-08-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151600 Change subject: Fixed spacing .. Fixed spacing - Removed spaces around array index - Changed else if to elseif - Added space after fore

[MediaWiki-commits] [Gerrit] Fixed docs - change (mediawiki/core)

2014-08-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151602 Change subject: Fixed docs .. Fixed docs - Use short form of boolean - Use capital at begin of doc text Change-Id: Ic5afacfa7298b1938d

[MediaWiki-commits] [Gerrit] Fix doc of PPFrame_Hash::cachedExpand - change (mediawiki/core)

2014-08-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151610 Change subject: Fix doc of PPFrame_Hash::cachedExpand .. Fix doc of PPFrame_Hash::cachedExpand There is no PPNode_Hash class, use inter

[MediaWiki-commits] [Gerrit] Add gender for upload log entries - change (mediawiki/core)

2014-08-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151653 Change subject: Add gender for upload log entries .. Add gender for upload log entries With Icd8662ecb9eb0f6c0ff9841bdbd5736d6dd0d015 t

[MediaWiki-commits] [Gerrit] Migrate merge log to new log system - change (mediawiki/core)

2014-08-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151683 Change subject: Migrate merge log to new log system .. Migrate merge log to new log system This allows use of gender on Special:Log Old

[MediaWiki-commits] [Gerrit] Remove 'move' from LogPage::getTitleLink - change (mediawiki/core)

2014-08-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151684 Change subject: Remove 'move' from LogPage::getTitleLink .. Remove 'move' from LogPage::getTitleLink LogPage::getTitleLink only called

[MediaWiki-commits] [Gerrit] Migrate import log to new log system - change (mediawiki/core)

2014-08-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/151701 Change subject: Migrate import log to new log system .. Migrate import log to new log system There is no need for an extra formatter cl

[MediaWiki-commits] [Gerrit] Add missing possible errors to ApiQueryLogEvents.php - change (mediawiki/core)

2014-05-28 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/135815 Change subject: Add missing possible errors to ApiQueryLogEvents.php .. Add missing possible errors to ApiQueryLogEvents.php requireMax

[MediaWiki-commits] [Gerrit] Add comment to TableDiffFormatter::blockHeader - change (mediawiki/core)

2014-05-28 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/135876 Change subject: Add comment to TableDiffFormatter::blockHeader .. Add comment to TableDiffFormatter::blockHeader magic strings should h

[MediaWiki-commits] [Gerrit] Change message escaping on ImagePage - change (mediawiki/core)

2014-05-29 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/136134 Change subject: Change message escaping on ImagePage .. Change message escaping on ImagePage by Nikerabbit on I2a91f0ef1cf82360da2d17c7

[MediaWiki-commits] [Gerrit] Change some message escaping - change (mediawiki/core)

2014-05-29 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/136161 Change subject: Change some message escaping .. Change some message escaping Also add explizit method at one place to avoid implicit to

[MediaWiki-commits] [Gerrit] Do not wrap inside on Special:UserRights - change (mediawiki/core)

2014-06-05 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/137719 Change subject: Do not wrap inside on Special:UserRights .. Do not wrap inside on Special:UserRights Special:UserRights has a table

[MediaWiki-commits] [Gerrit] Some phpcs-strict changes on includes/revisiondelete/ - change (mediawiki/core)

2014-06-05 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/137727 Change subject: Some phpcs-strict changes on includes/revisiondelete/ .. Some phpcs-strict changes on includes/revisiondelete/ Apply th

[MediaWiki-commits] [Gerrit] Move api files to a new api folder - change (mediawiki...Gadgets)

2014-06-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/137955 Change subject: Move api files to a new api folder .. Move api files to a new api folder Change-Id: I365ead76b11f1906c698a6058f0ef37618

[MediaWiki-commits] [Gerrit] Remove Title::escapeFullURL() (deprecated since 1.19) - change (mediawiki/core)

2014-07-09 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/145019 Change subject: Remove Title::escapeFullURL() (deprecated since 1.19) .. Remove Title::escapeFullURL() (deprecated since 1.19) Change-I

[MediaWiki-commits] [Gerrit] Remove User::isValidEmailAddr() (deprecated since 1.18) - change (mediawiki/core)

2014-07-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/145366 Change subject: Remove User::isValidEmailAddr() (deprecated since 1.18) .. Remove User::isValidEmailAddr() (deprecated since 1.18) Chan

[MediaWiki-commits] [Gerrit] Remove Title::getEscapedText() (deprecated since 1.19) - change (mediawiki/core)

2014-07-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/145369 Change subject: Remove Title::getEscapedText() (deprecated since 1.19) .. Remove Title::getEscapedText() (deprecated since 1.19) Change

[MediaWiki-commits] [Gerrit] Remove WikiPage::isBigDeletion() (deprecated since 1.19) - change (mediawiki/core)

2014-07-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/145371 Change subject: Remove WikiPage::isBigDeletion() (deprecated since 1.19) .. Remove WikiPage::isBigDeletion() (deprecated since 1.19) Ch

[MediaWiki-commits] [Gerrit] Remove Language::getFallbackLanguageCode() (deprecated since... - change (mediawiki/core)

2014-07-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/145370 Change subject: Remove Language::getFallbackLanguageCode() (deprecated since 1.19) .. Remove Language::getFallbackLanguageCode() (depre

[MediaWiki-commits] [Gerrit] Add plural to message 'rcnotefrom' - change (mediawiki/core)

2014-07-14 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/146053 Change subject: Add plural to message 'rcnotefrom' .. Add plural to message 'rcnotefrom' Change-Id: I495d19258205d8713a19aa934a7657aecb

[MediaWiki-commits] [Gerrit] Fix doc of ChangesListSpecialPage::doHeader - change (mediawiki/core)

2014-07-14 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/146055 Change subject: Fix doc of ChangesListSpecialPage::doHeader .. Fix doc of ChangesListSpecialPage::doHeader The function does not return

[MediaWiki-commits] [Gerrit] Replace Article::estimateRevisionCount call - change (mediawiki...TweetANew)

2014-07-15 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/146433 Change subject: Replace Article::estimateRevisionCount call .. Replace Article::estimateRevisionCount call Article delegate to WikiPage

[MediaWiki-commits] [Gerrit] Remove WikiPage::estimateRevisionCount (deprecated since 1.19) - change (mediawiki/core)

2014-07-15 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/146435 Change subject: Remove WikiPage::estimateRevisionCount (deprecated since 1.19) .. Remove WikiPage::estimateRevisionCount (deprecated sin

[MediaWiki-commits] [Gerrit] jQuery-ify legalcy protect.js - change (mediawiki/core)

2014-06-20 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/140936 Change subject: jQuery-ify legalcy protect.js .. jQuery-ify legalcy protect.js Replaced dom functions with jquery functions and some fo

[MediaWiki-commits] [Gerrit] Remove ImageGalleryBase::useSkin() (deprecated since 1.18) - change (mediawiki/core)

2014-06-24 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/141732 Change subject: Remove ImageGalleryBase::useSkin() (deprecated since 1.18) .. Remove ImageGalleryBase::useSkin() (deprecated since 1.18)

[MediaWiki-commits] [Gerrit] Standardize version comment in OracleUpdater.php - change (mediawiki/core)

2014-06-24 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/141734 Change subject: Standardize version comment in OracleUpdater.php .. Standardize version comment in OracleUpdater.php All updaters have

[MediaWiki-commits] [Gerrit] Remove HTMLForm::addJS() (deprecated since 1.18) - change (mediawiki/core)

2014-06-24 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/141735 Change subject: Remove HTMLForm::addJS() (deprecated since 1.18) .. Remove HTMLForm::addJS() (deprecated since 1.18) Change-Id: Id174d3

[MediaWiki-commits] [Gerrit] Remove LogEventsList::showHeader() (deprecated since 1.19) - change (mediawiki/core)

2014-06-24 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/141737 Change subject: Remove LogEventsList::showHeader() (deprecated since 1.19) .. Remove LogEventsList::showHeader() (deprecated since 1.19)

[MediaWiki-commits] [Gerrit] Remove LoadBalancer::closeConnecton (deprecated since 1.18) - change (mediawiki/core)

2014-06-25 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/142016 Change subject: Remove LoadBalancer::closeConnecton (deprecated since 1.18) .. Remove LoadBalancer::closeConnecton (deprecated since 1.1

[MediaWiki-commits] [Gerrit] Remove DatabaseMysqlBase::getLagFromProcesslist() (deprecate... - change (mediawiki/core)

2014-06-25 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/142013 Change subject: Remove DatabaseMysqlBase::getLagFromProcesslist() (deprecated 1.19) .. Remove DatabaseMysqlBase::getLagFromProcesslist(

[MediaWiki-commits] [Gerrit] Remove MWNamespace::isMain() (deprecated since 1.19) - change (mediawiki/core)

2014-06-25 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/142032 Change subject: Remove MWNamespace::isMain() (deprecated since 1.19) .. Remove MWNamespace::isMain() (deprecated since 1.19) Change-Id:

[MediaWiki-commits] [Gerrit] Remove ApiBase::createContext() (deprecated since 1.19) - change (mediawiki/core)

2014-06-25 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/142031 Change subject: Remove ApiBase::createContext() (deprecated since 1.19) .. Remove ApiBase::createContext() (deprecated since 1.19) Chan

[MediaWiki-commits] [Gerrit] Remove Preferences::loadOldSearchNs() (deprecated since 1.19) - change (mediawiki/core)

2014-06-25 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/142033 Change subject: Remove Preferences::loadOldSearchNs() (deprecated since 1.19) .. Remove Preferences::loadOldSearchNs() (deprecated since

[MediaWiki-commits] [Gerrit] Skip $wgMaxImageArea for InstantCommons files - change (mediawiki/core)

2014-06-25 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/142046 Change subject: Skip $wgMaxImageArea for InstantCommons files .. Skip $wgMaxImageArea for InstantCommons files When a big image is fetc

[MediaWiki-commits] [Gerrit] Migrate block log to new log system - change (mediawiki/core)

2014-08-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152003 Change subject: Migrate block log to new log system .. Migrate block log to new log system This allows use of gender on Special:Log. Ol

[MediaWiki-commits] [Gerrit] Unset redirect param in MoveLogFormatter::getMessageParameters - change (mediawiki/core)

2014-08-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152011 Change subject: Unset redirect param in MoveLogFormatter::getMessageParameters .. Unset redirect param in MoveLogFormatter::getMessagePa

[MediaWiki-commits] [Gerrit] Migrate protect log to new log system - change (mediawiki/core)

2014-08-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152156 Change subject: Migrate protect log to new log system .. Migrate protect log to new log system This allows use of gender on Special:Log

[MediaWiki-commits] [Gerrit] Use new log system when create log entry for revision delete - change (mediawiki/core)

2014-08-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152161 Change subject: Use new log system when create log entry for revision delete .. Use new log system when create log entry for revision de

[MediaWiki-commits] [Gerrit] Restore formatting before split of RevisionDelete.php - change (mediawiki/core)

2014-08-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152910 Change subject: Restore formatting before split of RevisionDelete.php .. Restore formatting before split of RevisionDelete.php I244a66f

[MediaWiki-commits] [Gerrit] Split RevisionDeleteAbstracts.php to separate files - change (mediawiki/core)

2014-08-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152912 Change subject: Split RevisionDeleteAbstracts.php to separate files .. Split RevisionDeleteAbstracts.php to separate files Same as I244

[MediaWiki-commits] [Gerrit] Add .gitignore - change (mediawiki...Vector)

2014-08-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152944 Change subject: Add .gitignore .. Add .gitignore Used a copy of .gitignore of mediawiki/core and removed some lines, because in this ex

[MediaWiki-commits] [Gerrit] Add .gitignore - change (mediawiki...MonoBook)

2014-08-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152945 Change subject: Add .gitignore .. Add .gitignore Used a copy of .gitignore of mediawiki/core and removed some lines, because in this ex

[MediaWiki-commits] [Gerrit] Add .gitignore - change (mediawiki...Modern)

2014-08-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152946 Change subject: Add .gitignore .. Add .gitignore Used a copy of .gitignore of mediawiki/core and removed some lines, because in this ex

[MediaWiki-commits] [Gerrit] Add .gitignore - change (mediawiki...CologneBlue)

2014-08-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152947 Change subject: Add .gitignore .. Add .gitignore Used a copy of .gitignore of mediawiki/core and removed some lines, because in this ex

[MediaWiki-commits] [Gerrit] Doc: Parser::getTargetLanguage cannot return null - change (mediawiki/core)

2014-08-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152952 Change subject: Doc: Parser::getTargetLanguage cannot return null .. Doc: Parser::getTargetLanguage cannot return null Change-Id: I979d

[MediaWiki-commits] [Gerrit] Set $wgUploadNavigationUrl to false on parser and unit tests - change (mediawiki/core)

2014-08-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/152958 Change subject: Set $wgUploadNavigationUrl to false on parser and unit tests .. Set $wgUploadNavigationUrl to false on parser and unit t

[MediaWiki-commits] [Gerrit] Set page_latest for ChangesListTests - change (mediawiki/core)

2014-08-09 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153051 Change subject: Set page_latest for ChangesListTests .. Set page_latest for ChangesListTests For rollbacker the recent change has a att

[MediaWiki-commits] [Gerrit] Cleanup some docs (maintenance) - change (mediawiki/core)

2014-08-09 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153212 Change subject: Cleanup some docs (maintenance) .. Cleanup some docs (maintenance) - Fixed spacing inside docs - Makes beginning of @pa

[MediaWiki-commits] [Gerrit] Cleanup some docs (languages) - change (mediawiki/core)

2014-08-09 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153218 Change subject: Cleanup some docs (languages) .. Cleanup some docs (languages) - Makes beginning of @param in capital - Removed return

[MediaWiki-commits] [Gerrit] Remove spaces of html in NoLocalSettings.php - change (mediawiki/core)

2014-08-12 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153635 Change subject: Remove spaces of html in NoLocalSettings.php .. Remove spaces of html in NoLocalSettings.php A should not be followed

[MediaWiki-commits] [Gerrit] Docs: compatability -> compatibility - change (mediawiki/core)

2014-08-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153829 Change subject: Docs: compatability -> compatibility .. Docs: compatability -> compatibility https://en.wiktionary.org/wiki/compatabili

[MediaWiki-commits] [Gerrit] Change @return to start with type - change (mediawiki/core)

2014-08-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153833 Change subject: Change @return to start with type .. Change @return to start with type MediaWiki default is "@return type Description",

[MediaWiki-commits] [Gerrit] Fixed spacing - change (mediawiki/core)

2014-08-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153836 Change subject: Fixed spacing .. Fixed spacing - Added newline at end of files - Added/Removed spaces around comma, parentheses and neg

[MediaWiki-commits] [Gerrit] Fixed some docs - change (mediawiki/core)

2014-08-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153838 Change subject: Fixed some docs .. Fixed some docs - Added since to @deprecated - Use lowercase array on @param - Added missing type on

[MediaWiki-commits] [Gerrit] Use /** for doc comments - change (mediawiki/core)

2014-08-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153872 Change subject: Use /** for doc comments .. Use /** for doc comments /* is only a comment, which is not used when build the documentati

[MediaWiki-commits] [Gerrit] Correct variable names in @param to match method declarations - change (mediawiki/core)

2014-08-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/153877 Change subject: Correct variable names in @param to match method declarations .. Correct variable names in @param to match method declar

[MediaWiki-commits] [Gerrit] Pass user to LogEventsList::getExcludeClause - change (mediawiki/core[master])

2012-12-14 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Pass user to LogEventsList::getExcludeClause .. Pass user to LogEventsList::getExcludeClause This avoids $wgUser in that method Also removed the double strenco

[MediaWiki-commits] [Gerrit] (bug 43315) Cursor of enhancedchangelist wrong for non-toggl... - change (mediawiki/core[master])

2012-12-21 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: (bug 43315) Cursor of enhancedchangelist wrong for non-toggle lines .. (bug 43315) Cursor of enhancedchangelist wrong for non-toggle lines The class mw-enhance

[MediaWiki-commits] [Gerrit] Use NS_* constant for default namespace in api - change (mediawiki/core[master])

2012-12-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Use NS_* constant for default namespace in api .. Use NS_* constant for default namespace in api Change-Id: Ic46e7fe1877c4067b1b6bbea71216c0cdf594cb2 --- M incl

[MediaWiki-commits] [Gerrit] Fix some validation errors on Special:Import - change (mediawiki/core[master])

2012-12-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Fix some validation errors on Special:Import .. Fix some validation errors on Special:Import Fixed errors are: * Duplicate ID mw-import-table * Duplicate ID mw-

[MediaWiki-commits] [Gerrit] (bug 41733) Hide new message info at printable view - change (mediawiki/core[master])

2012-12-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: (bug 41733) Hide new message info at printable view .. (bug 41733) Hide new message info at printable view Change-Id: Iefa8158d28c8a78f21ad8155eba11d4870573b59

[MediaWiki-commits] [Gerrit] Wrong namespace in BackupDumperPageTest::testFullTextPlain - change (mediawiki/core[master])

2012-12-31 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Wrong namespace in BackupDumperPageTest::testFullTextPlain .. Wrong namespace in BackupDumperPageTest::testFullTextPlain The problem here is, that title objects

[MediaWiki-commits] [Gerrit] Add some missing parent::tearDown() - change (mediawiki/core[master])

2012-12-31 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Add some missing parent::tearDown() .. Add some missing parent::tearDown() Change-Id: Ibcdf5d440043cef25b4aa9fb08b61ec4a2c558d1 --- M tests/phpunit/includes/sea

[MediaWiki-commits] [Gerrit] Postgres: Allow array condition for HAVING - change (mediawiki/core[master])

2012-12-31 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Postgres: Allow array condition for HAVING .. Postgres: Allow array condition for HAVING Change-Id: I13bf6125fa90cf64c4e03a5145f547e21cac37ef --- M includes/db/

[MediaWiki-commits] [Gerrit] IBM DB2: Fix makeSelectOptions to support arrays - change (mediawiki/core[master])

2012-12-31 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: IBM DB2: Fix makeSelectOptions to support arrays .. IBM DB2: Fix makeSelectOptions to support arrays Change-Id: If7284cc3bbcee304c56a335ec0cd449bfeebbbfa --- M

[MediaWiki-commits] [Gerrit] MSSQL: Fix makeSelectOptions to support array conditions - change (mediawiki/core[master])

2012-12-31 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: MSSQL: Fix makeSelectOptions to support array conditions .. MSSQL: Fix makeSelectOptions to support array conditions Change-Id: I26dcea953feefd4c4aab36a819f7bdf

[MediaWiki-commits] [Gerrit] Add SpecialPage::getGroupName and use it - change (mediawiki/core[master])

2012-12-31 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Add SpecialPage::getGroupName and use it .. Add SpecialPage::getGroupName and use it Having all group mapping for Special:SpecialPages in the global $wgSpecialP

[MediaWiki-commits] [Gerrit] Bold only changed items on Watchlist - change (mediawiki/core[master])

2012-12-31 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Bold only changed items on Watchlist .. Bold only changed items on Watchlist Compare wl_notificationtimestamp against the rc_timestamp, when the rc_timestamp is

[MediaWiki-commits] [Gerrit] Pass $user from WikiPage::getContent to Revision::getContent - change (mediawiki/core[master])

2013-01-02 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Pass $user from WikiPage::getContent to Revision::getContent .. Pass $user from WikiPage::getContent to Revision::getContent Change-Id: If909ad6049869e2bf38789b

[MediaWiki-commits] [Gerrit] (bug 40667) deprecate rc_cur_time of recentchanges - change (mediawiki/core[master])

2013-01-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: (bug 40667) deprecate rc_cur_time of recentchanges .. (bug 40667) deprecate rc_cur_time of recentchanges Field is unused since many versions, so deprecate it an

[MediaWiki-commits] [Gerrit] Use Database::addQuotes instead of hardcoded quotes - change (mediawiki/core[master])

2013-01-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Use Database::addQuotes instead of hardcoded quotes .. Use Database::addQuotes instead of hardcoded quotes Change-Id: I29461e5332f3fc6523cbd899e14394aa88865d93

[MediaWiki-commits] [Gerrit] recentchanges.rc_ip is used for retroactive autoblocks - change (mediawiki/core[master])

2013-01-04 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: recentchanges.rc_ip is used for retroactive autoblocks .. recentchanges.rc_ip is used for retroactive autoblocks Document this at $wgPutIPinRC and check the glo

[MediaWiki-commits] [Gerrit] fixed timestamp validation for api - change (mediawiki/core[master])

2013-01-05 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: fixed timestamp validation for api .. fixed timestamp validation for api wfTimestamp returns false on failure. Renamed variable to output original input on fai

[MediaWiki-commits] [Gerrit] Remove old aftv5 permissions from mediawiki-config - change (operations/mediawiki-config[master])

2013-01-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Remove old aftv5 permissions from mediawiki-config .. Remove old aftv5 permissions from mediawiki-config Follow up I7c5ef9b1 This old permissions are showing o

[MediaWiki-commits] [Gerrit] AFTv5: skip rollbacker group on wikis without that - change (operations/mediawiki-config[master])

2013-01-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: AFTv5: skip rollbacker group on wikis without that .. AFTv5: skip rollbacker group on wikis without that dewiki is a wiki without rollbacker group, but on https

[MediaWiki-commits] [Gerrit] Inline SpecialPageFactory::setGroup, gets deprecated in 1.21 - change (mediawiki...OpenID[master])

2013-01-11 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Inline SpecialPageFactory::setGroup, gets deprecated in 1.21 .. Inline SpecialPageFactory::setGroup, gets deprecated in 1.21 See I1de3a186. The global gets also

[MediaWiki-commits] [Gerrit] Fix ApiCreateAccountTest for $wgEnableEmail = false; - change (mediawiki/core[master])

2013-01-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Fix ApiCreateAccountTest for $wgEnableEmail = false; .. Fix ApiCreateAccountTest for $wgEnableEmail = false; 1) ApiCreateAccountTest::testInvalidEmail Failed as

[MediaWiki-commits] [Gerrit] Fix message movepagetext: Move to a empty page not possible - change (mediawiki/core[master])

2013-01-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Fix message movepagetext: Move to a empty page not possible .. Fix message movepagetext: Move to a empty page not possible Change-Id: I55409499ce21f6155c4f92ea1

[MediaWiki-commits] [Gerrit] Pass database connection to SpecialWatchlist::countItems - change (mediawiki/core[master])

2013-01-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Pass database connection to SpecialWatchlist::countItems .. Pass database connection to SpecialWatchlist::countItems This avoids getting two connection to the '

[MediaWiki-commits] [Gerrit] Fix hardcode database quotes in Special:Watchlist - change (mediawiki/core[master])

2013-01-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Fix hardcode database quotes in Special:Watchlist .. Fix hardcode database quotes in Special:Watchlist Change-Id: I0d53a24b35a855a541fb73d8bbfcace9de74e549 ---

[MediaWiki-commits] [Gerrit] Use array for database fields - change (mediawiki/core[master])

2013-01-18 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Use array for database fields .. Use array for database fields Also reuse a existing database object Change-Id: I42cc0636b25ba6266ab37ce0a7422e5863edf741 --- M

[MediaWiki-commits] [Gerrit] Remove hardcoded quotes on integer - change (mediawiki/core[master])

2013-01-18 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Remove hardcoded quotes on integer .. Remove hardcoded quotes on integer Change-Id: Ifb1e9777fe1338a5b97d061d80355d51d52ea8da --- M includes/actions/HistoryActi

[MediaWiki-commits] [Gerrit] Use array for fields in join condition - change (mediawiki/core[master])

2013-01-19 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Use array for fields in join condition .. Use array for fields in join condition Change-Id: I52875ebd5fc67e74439faf703b8119fedd70bfc9 --- M includes/CategoryVie

[MediaWiki-commits] [Gerrit] refactor Database::makeSelectOptions - change (mediawiki/core[master])

2013-01-25 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: refactor Database::makeSelectOptions .. refactor Database::makeSelectOptions Created new method for creating the group by/having and order by sql, this avoids c

[MediaWiki-commits] [Gerrit] fix some spacing - change (mediawiki/core[master])

2013-01-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: fix some spacing .. fix some spacing Change-Id: I78a97ad87e0bfe724fc851daf6ffeeed81887800 --- M includes/search/SearchEngine.php M includes/search/SearchPostgre

[MediaWiki-commits] [Gerrit] fix some spacing - change (mediawiki/core[master])

2013-01-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: fix some spacing .. fix some spacing Change-Id: Ie7bb35871cc99237f3a655f7db22ca1f0646df5e --- M includes/Block.php M includes/ChangesList.php M includes/EditPag

[MediaWiki-commits] [Gerrit] fix some spacing - change (mediawiki/core[master])

2013-01-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: fix some spacing .. fix some spacing Change-Id: Id7eda67a43f9040117edd79fdbeb678f1c3a6da2 --- M includes/api/ApiBase.php M includes/api/ApiBlock.php M includes/

[MediaWiki-commits] [Gerrit] The abstract declaration must precede the visibility declara... - change (mediawiki/core[master])

2013-01-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: The abstract declaration must precede the visibility declaration .. The abstract declaration must precede the visibility declaration >From phpcs Change-Id: I16

[MediaWiki-commits] [Gerrit] The final declaration must precede the visibility declaratio... - change (mediawiki/core[master])

2013-01-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: The final declaration must precede the visibility declaration .. The final declaration must precede the visibility declaration >From phpcs Change-Id: I87592615

[MediaWiki-commits] [Gerrit] The static declaration must come after the visibility declar... - change (mediawiki/core[master])

2013-01-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: The static declaration must come after the visibility declaration .. The static declaration must come after the visibility declaration >From phpcs Change-Id:

[MediaWiki-commits] [Gerrit] The use of function sizeof() is forbidden; use count() inste... - change (mediawiki/core[master])

2013-01-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: The use of function sizeof() is forbidden; use count() instead .. The use of function sizeof() is forbidden; use count() instead >From phpcs Change-Id: I919c8a

[MediaWiki-commits] [Gerrit] fix some spacing - change (mediawiki/core[master])

2013-01-28 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: fix some spacing .. fix some spacing Change-Id: I2a59eb22bb8acf01b560507a48d6be55d9c87de7 --- M includes/specials/SpecialAllpages.php M includes/specials/Specia

[MediaWiki-commits] [Gerrit] fix hardcoded quote in Special:DoubleRedirects - change (mediawiki/core[master])

2013-01-29 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: fix hardcoded quote in Special:DoubleRedirects .. fix hardcoded quote in Special:DoubleRedirects Also remove the extra parentheses, will be added by Database::m

[MediaWiki-commits] [Gerrit] Use config for $wgLanguageCode in OutputPage.php - change (mediawiki/core)

2014-10-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/166015 Change subject: Use config for $wgLanguageCode in OutputPage.php .. Use config for $wgLanguageCode in OutputPage.php Follow-Up: I5e0ebc

<    4   5   6   7   8   9   10   11   12   13   >