Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/135594
Change subject: Fix failing tests
..
Fix failing tests
Guys, your tests are failing. :-( I can't submit my other patch
because
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/135604
Change subject: Remove unused code and fix missing/broken documentation
..
Remove unused code and fix missing/broken
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/135752
Change subject: Add test for Gerrit 135489
..
Add test for Gerrit 135489
See Ib0fd773dacddc782a93f53838c1189e41d16e748.
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/131952
Change subject: Unify and simplify inline documentation of all possible entry
points
..
Unify and simplify inline documentation
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/135753
Change subject: jQuery performance optimisation
..
jQuery performance optimisation
... as reported by the PHPStorm static code
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/135760
Change subject: Fix rollback by re-adding baseRevIdForSaving in EntityContent
..
Fix rollback by re-adding baseRevIdForSaving
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/136453
Change subject: Keep Monobook skin intact
..
Keep Monobook skin intact
Bug: 64741
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/136831
Change subject: Remove optional namespace from gallery example
..
Remove optional namespace from gallery example
The namespace
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/136861
Change subject: Make mini the default alias for thumb in German
..
Make mini the default alias for thumb in German
It's already
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137000
Change subject: Add missing doc stars
..
Add missing doc stars
I guess one star is for disabled code and two
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137042
Change subject: Add/fix more missing/broken inline documentations
..
Add/fix more missing/broken inline documentations
I
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137046
Change subject: Fix mistake introduced in
I45438f5d01402c633b0966ae4c5697fa18a84202
..
Fix mistake introduced
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139358
Change subject: Unregister bogus event handlers when destroying a wbtooltip
..
Unregister bogus event handlers when destroying
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139363
Change subject: Set required parameter $1 in wikibase-error-unexpected
..
Set required parameter $1 in wikibase-error-unexpected
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139369
Change subject: Fix Client widget according to new suggester interface
..
Fix Client widget according to new suggester interface
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139376
Change subject: Fix client dialog according to redefined suggester interface
..
Fix client dialog according to redefined
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139396
Change subject: Fix z-index on Client when it uses the ooMenu suggester
..
Fix z-index on Client when it uses the ooMenu
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139432
Change subject: Avoid duplicate implementations of existing checks
..
Avoid duplicate implementations of existing checks
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139895
Change subject: Allow [[Special:SetSiteLink//enwiki]]
..
Allow [[Special:SetSiteLink//enwiki]]
This allows
https
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139911
Change subject: Cleanup TermBoxView a bit
..
Cleanup TermBoxView a bit
* Replace some protected with private.
* Avoid using
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139968
Change subject: Drop getFormattedIdForEntity methods from tests
..
Drop getFormattedIdForEntity methods from tests
I assume
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140007
Change subject: Cleanup EntityView, SectionEditLinkGenerator and related
..
Cleanup EntityView, SectionEditLinkGenerator
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140140
Change subject: [WIP] Clean-up IdGenerator after redirects are done
..
[WIP] Clean-up IdGenerator after redirects are done
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140154
Change subject: Drop pointless null check
..
Drop pointless null check
It's impossible to be null after new, right?
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140175
Change subject: Cleanup SubmitEntityAction
..
Cleanup SubmitEntityAction
Follow-up to I832bef721f481bf91375174ddecdd3c268ac8dd5
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140189
Change subject: [WIP] Introduce EntityTermLoopups
..
[WIP] Introduce EntityTermLoopups
Intended to be used with entity info
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140197
Change subject: Make LanguageFallbackChain aware of EntityInfoBuilder
..
Make LanguageFallbackChain aware of EntityInfoBuilder
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140318
Change subject: Don't pass the User around as a parameter
..
Don't pass the User around as a parameter
getUser() is final
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140347
Change subject: MWException is part of the EntityContent::getEntity interface
..
MWException is part of the EntityContent
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140369
Change subject: Fix bits in MwTimeIsoFormatter
..
Fix bits in MwTimeIsoFormatter
This happens when you look at a two patch you
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140946
Change subject: Rename wrongly named UserLanguageLookupTest
..
Rename wrongly named UserLanguageLookupTest
This is a follow-up
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140958
Change subject: Clean-up EntityHandler
..
Clean-up EntityHandler
Change-Id: Idf317ef8909e357b9777970548f997a6a0a20d51
---
M
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140960
Change subject: Refactor EntityContentTest and related
..
Refactor EntityContentTest and related
I'm aware this clashes
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140961
Change subject: Test that non-legacy JSON is not recoded
..
Test that non-legacy JSON is not recoded
This would be expensive
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137448
Change subject: Stick to ContentHandler::getDefaultFormat default implementation
..
Stick to ContentHandler::getDefaultFormat
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137557
Change subject: Fix wbgetentities sitefilter
..
Fix wbgetentities sitefilter
I will add a test either to this patch (if I'm
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137945
Change subject: Cleanup bits in new redirect code
..
Cleanup bits in new redirect code
This is a follow-up to not block
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137948
Change subject: Find better name for DataUpdateClosure
..
Find better name for DataUpdateClosure
See discussion in
https
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/138100
Change subject: Refactoring/optimizing SpecialUnconnectedPages
..
Refactoring/optimizing SpecialUnconnectedPages
Some basic
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/138654
Change subject: Expand tooltip details fast
..
Expand tooltip details fast
There is no reason to slow this down so much
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/138660
Change subject: Accept array of HTML messages in tooltip JavaScript
..
Accept array of HTML messages in tooltip JavaScript
I
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/138679
Change subject: Bump ValueView to version 0.6.2
..
Bump ValueView to version 0.6.2
Because of https://github.com/wmde/ValueView
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/138790
Change subject: [WIP] Roundtrip tests for Lib\Serializers vs.
DataModelSerialization
..
[WIP] Roundtrip tests for Lib
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/138831
Change subject: Clean-up SqlStore::newEntityRevisionLookup
..
Clean-up SqlStore::newEntityRevisionLookup
This makes the three
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139084
Change subject: No strict change type validation on the client
..
No strict change type validation on the client
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139115
Change subject: Update documentation of what a section is
..
Update documentation of what a section is
There are so many
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139116
Change subject: Fix entity selector being invisible/partly hidden in MonoBook
..
Fix entity selector being invisible/partly
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149823
Change subject: Add support for numeric months in MwTimeIsoFormatter
..
Add support for numeric months in MwTimeIsoFormatter
n
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150202
Change subject: Add UnDeserializableValue to DataModelSerializationRoundtripTest
..
Add UnDeserializableValue
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150284
Change subject: Add order test to DataModelSerializationRoundtripTest
..
Add order test to DataModelSerializationRoundtripTest
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150308
Change subject: Use real cloning in ChangeOpAliasesTest
..
Use real cloning in ChangeOpAliasesTest
Clone doesn't really (deep
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150376
Change subject: Replace Aliases in WikibaseRepo class map
..
Replace Aliases in WikibaseRepo class map
I honestly don't know
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150493
Change subject: Fix mistakes and general cleanup in Wikibase\Validators
..
Fix mistakes and general cleanup in Wikibase
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150500
Change subject: Cleanup Lib Validators
..
Cleanup Lib Validators
Change-Id: I58002a4de1ae11f07f8dd66e8febea71139f5763
---
M lib
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150512
Change subject: wgTitle can be null in rare edge cases, e.g. in tests
..
wgTitle can be null in rare edge cases, e.g. in tests
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150517
Change subject: Cleanup concept (canonical) URL hooks
..
Cleanup concept (canonical) URL hooks
This is a follow-up for I69985b4
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150539
Change subject: Reduce GUI jumping around when clicking edit
..
Reduce GUI jumping around when clicking edit
When clicking
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150558
Change subject: Do not double escape HTML in form label
..
Do not double escape HTML in form label
Bug: 68221
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150797
Change subject: [DNM] Silver and golden badge icons
..
[DNM] Silver and golden badge icons
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/151090
Change subject: Add more tests to MonthNameUnlocalizerTest
..
Add more tests to MonthNameUnlocalizerTest
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/151094
Change subject: Fix messed up parameters in Recentchanges hook
..
Fix messed up parameters in Recentchanges hook
Ouch. Sorry
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/151101
Change subject: Delete unused (badge) star icons
..
Delete unused (badge) star icons
We decided to not have this in the Client
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/151596
Change subject: Cleanup Entity Serializer code
..
Cleanup Entity Serializer code
Rename an $Uppercase variable.
Remove some
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/152075
Change subject: Refine empty badge
..
Refine empty badge
Change-Id: Ib38b9f8f97ff42b5be87505683ed7edf0b30a8e4
---
M lib
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153211
Change subject: [WIP] Add MwDateFormatParser
..
[WIP] Add MwDateFormatParser
This implements the reverse operation of the date
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153296
Change subject: Fix broken test on 32-bit PHP systems
..
Fix broken test on 32-bit PHP systems
This triggers a bug in data
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153299
Change subject: Do not clamp to INT32 if not necesarry
..
Do not clamp to INT32 if not necesarry
All methods involved here
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153766
Change subject: Drop unused EntityRevisionSerializer
..
Drop unused EntityRevisionSerializer
Please note that I'm not 100% sure
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153788
Change subject: Remove misleading now from message
..
Remove misleading now from message
Bug: 69282
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153791
Change subject: Use spaces in Embed as Wikitext code
..
Use spaces in Embed as Wikitext code
The method exists. I assume
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154081
Change subject: Extends \MediaWikiTestCase
..
Extends \MediaWikiTestCase
This is the only test in Wikibase that misses
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154241
Change subject: Revert Refactor Fingerprint code out of EntityView
..
Revert Refactor Fingerprint code out of EntityView
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154250
Change subject: Fix SqlEntityInfoBuilder(Factory) constructor parameters
..
Fix SqlEntityInfoBuilder(Factory) constructor
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154252
Change subject: Refactor Fingerprint code out of EntityView
..
Refactor Fingerprint code out of EntityView
All code related
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169674
Change subject: Refactor ClientHooks::onBeforePageDisplayAddJsConfig
..
Refactor ClientHooks::onBeforePageDisplayAddJsConfig
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169684
Change subject: Fix broken option in jquery.wikibase.linkitem.js
..
Fix broken option in jquery.wikibase.linkitem.js
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170307
Change subject: [WIP] Replace useless IDatabase type in ConnectionManager
..
[WIP] Replace useless IDatabase type
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170895
Change subject: Revert uselang=... default to the wikis $wgLanguageCode
..
Revert uselang=... default to the wikis
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170906
Change subject: Refactor UrlSchemeValidators and allow more schemes
..
Refactor UrlSchemeValidators and allow more schemes
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170916
Change subject: Remove bad http and mailto url messages
..
Remove bad http and mailto url messages
Two reasons:
1. The meaning
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166006
Change subject: More clean up in SqlUsageTracker
..
More clean up in SqlUsageTracker
Oh wow, this was confusing. Sorry to say
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166013
Change subject: Remove unused use Content
..
Remove unused use Content
Uh, what was that?
Just in case you ask: Yes
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166382
Change subject: Replace deprecated getPrefixedId in Repo
..
Replace deprecated getPrefixedId in Repo
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166383
Change subject: Replace deprecated getPrefixedId in Client and Lib
..
Replace deprecated getPrefixedId in Client and Lib
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166385
Change subject: Cleanup previous EntityIdParser cleanup
..
Cleanup previous EntityIdParser cleanup
This fixes some minor
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166439
Change subject: Rewrite ORMTable::unprefixFieldNames
..
Rewrite ORMTable::unprefixFieldNames
This method is called a lot (~1000
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166568
Change subject: Make internal ORMTable::unprefixFieldNames private
..
Make internal ORMTable::unprefixFieldNames private
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166572
Change subject: Make an empty ?action= parameter default to view
..
Make an empty ?action= parameter default to view
When
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166622
Change subject: Display full year if precision is to high
..
Display full year if precision is to high
The original idea
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166719
Change subject: Revert Make enhanced recent changes and extended watchlist
default
..
Revert Make enhanced recent changes
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166748
Change subject: Add TimeFormatterParserRoundtripTest
..
Add TimeFormatterParserRoundtripTest
Wanted to add this for a long time
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166757
Change subject: Clean up after DataModel 2.0 switch
..
Clean up after DataModel 2.0 switch
Just some minor clean ups. Main
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166956
Change subject: Optimize/add missing use clauses in Client after DM 2.0 switch
..
Optimize/add missing use clauses in Client
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166958
Change subject: Clean up Scribunto code in Client
..
Clean up Scribunto code in Client
A bit of refactoring based on PHPStorm's
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166966
Change subject: Optimize/add missing use clauses in Lib after DM 2.0 switch
..
Optimize/add missing use clauses in Lib after DM
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166973
Change subject: JS and CSS clean up based on static code analysis
..
JS and CSS clean up based on static code analysis
Thanks
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167173
Change subject: Simplify background CSS
..
Simplify background CSS
PHPUnit's static code analysis complained about this, that's
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167174
Change subject: Add missing HTML element slashes to jQuery calls
..
Add missing HTML element slashes to jQuery calls
Not sure
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167175
Change subject: Remove slashes from HTML elements that aren't allowed to be
empty
..
Remove slashes from HTML elements
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167177
Change subject: Don't show dead edit links in diff/old revisions
..
Don't show dead edit links in diff/old revisions
Bug: 72177
301 - 400 of 6021 matches
Mail list logo