Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153791
Change subject: Use spaces in Embed as Wikitext code
..
Use spaces in Embed as Wikitext code
The method exists. I assume this
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165860
Change subject: Add missing PHPDoc comments and type hints
..
Add missing PHPDoc comments and type hints
There are like a
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166006
Change subject: More clean up in SqlUsageTracker
..
More clean up in SqlUsageTracker
Oh wow, this was confusing. Sorry to say
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166013
Change subject: Remove unused use Content
..
Remove unused use Content
Uh, what was that?
Just in case you ask: Yes, the
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166382
Change subject: Replace deprecated getPrefixedId in Repo
..
Replace deprecated getPrefixedId in Repo
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166383
Change subject: Replace deprecated getPrefixedId in Client and Lib
..
Replace deprecated getPrefixedId in Client and Lib
In
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166385
Change subject: Cleanup previous EntityIdParser cleanup
..
Cleanup previous EntityIdParser cleanup
This fixes some minor
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166439
Change subject: Rewrite ORMTable::unprefixFieldNames
..
Rewrite ORMTable::unprefixFieldNames
This method is called a lot (~1000
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166568
Change subject: Make internal ORMTable::unprefixFieldNames private
..
Make internal ORMTable::unprefixFieldNames private
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166572
Change subject: Make an empty "?action=" parameter default to "view"
..
Make an empty "?action=&qu
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166622
Change subject: Display full year if precision is to high
..
Display full year if precision is to high
The original idea was to
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166719
Change subject: Revert "Make enhanced recent changes and extended watchlist
default"
..
Revert "Make enhanced
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166748
Change subject: Add TimeFormatterParserRoundtripTest
..
Add TimeFormatterParserRoundtripTest
Wanted to add this for a long time
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166757
Change subject: Clean up after DataModel 2.0 switch
..
Clean up after DataModel 2.0 switch
Just some minor clean ups. Main
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166956
Change subject: Optimize/add missing use clauses in Client after DM 2.0 switch
..
Optimize/add missing use clauses in Client
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166958
Change subject: Clean up Scribunto code in Client
..
Clean up Scribunto code in Client
A bit of refactoring based on PHPStorm
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166966
Change subject: Optimize/add missing use clauses in Lib after DM 2.0 switch
..
Optimize/add missing use clauses in Lib after DM
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166973
Change subject: JS and CSS clean up based on static code analysis
..
JS and CSS clean up based on static code analysis
Thanks
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167173
Change subject: Simplify background CSS
..
Simplify background CSS
PHPUnit's static code analysis complained about this, t
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167174
Change subject: Add missing HTML element slashes to jQuery calls
..
Add missing HTML element slashes to jQuery calls
Not sure
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167175
Change subject: Remove slashes from HTML elements that aren't allowed to be
empty
..
Remove slashes from HTML elements
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167177
Change subject: Don't show dead edit links in diff/old revisions
..
Don't show dead edit links in diff/old revisions
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167182
Change subject: Do not start any JavaScript in diffs/old revisions
..
Do not start any JavaScript in diffs/old revisions
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167187
Change subject: Refactor RepoHooks::onOutputPageBodyAttributes
..
Refactor RepoHooks::onOutputPageBodyAttributes
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167313
Change subject: Do not show year "minus zero" as fallback
..
Do not show year "minus zero" as fallback
See
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167596
Change subject: Clean up introduction of usage tracking service
..
Clean up introduction of usage tracking service
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155510
Change subject: Stop using the Wikibase\ByPropertyIdArray alias
..
Stop using the Wikibase\ByPropertyIdArray alias
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155515
Change subject: Stop using EntityDiff and ItemDiff aliases
..
Stop using EntityDiff and ItemDiff aliases
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155519
Change subject: Stop using the Wikibase\ReferenceList alias
..
Stop using the Wikibase\ReferenceList alias
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155523
Change subject: Stop using the Wikibase\Reference alias
..
Stop using the Wikibase\Reference alias
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Record usage of badges
..
Record usage of badges
This only a temporary hack and will be done in a saner way after we have
an EntityParserOutput
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155715
Change subject: Drop "left in" debugging var_dump from WikiImporter
..
Drop "left in" debugging var_dump
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155728
Change subject: Stop using the Wikibase\EntityId alias
..
Stop using the Wikibase\EntityId alias
At least in all the tests
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155737
Change subject: Refactor duplicate code in EntityView and related
..
Refactor duplicate code in EntityView and related
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155757
Change subject: Refactor nested loop in entityViewInit
..
Refactor nested loop in entityViewInit
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Removed site link scraping from entityViewInit
..
Removed site link scraping from entityViewInit
requires WikibaseSerializationJavaScript 1.1.2
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Optimized jQuery.wikibase.sitelinkview.isInitialValue
..
Optimized jQuery.wikibase.sitelinkview.isInitialValue
requires
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Propagating editable state in SiteLinksView
..
Propagating editable state in SiteLinksView
Change-Id: I6ac3fc5ca088f76243052d880544bc09b1520539
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Refactor claims code out of EntityView
..
Refactor claims code out of EntityView
All code related to claims is moved into a separate ClaimsView
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Refactor duplicate code in EntityView and related
..
Refactor duplicate code in EntityView and related
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156037
Change subject: Kill all the aliases
..
Kill all the aliases
... when possible. It's not possible in classes that are dir
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Use DataModel 0.9.x
..
Use DataModel 0.9.x
Change-Id: Ibf3d660c475a52871d2f9d2f993857b249b84f94
---
M composer.json
M repo/tests/phpunit
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156042
Change subject: Proposed refactoring for ReferencedEntitiesFinder
..
Proposed refactoring for ReferencedEntitiesFinder
Change
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Use mock in SpecialPageCopyrightViewTest
..
Use mock in SpecialPageCopyrightViewTest
this fixes failure on travis, where the test
indirectly
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Purge interwiki memcached entries in populateInterwiki script
..
Purge interwiki memcached entries in populateInterwiki script
Bug: 69903
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156105
Change subject: More strict parsing of DD.MM. dates
..
More strict parsing of DD.MM. dates
See the tests.
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Remove dead code
..
Remove dead code
Change-Id: I948b69d396c1b63c59738fca3fbbb1d03fe07719
---
M client/includes/UpdateRepo.php
M client/tests
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156112
Change subject: Remove dead code
..
Remove dead code
Change-Id: I92767025aff7ac7642d0eded75d3b1d0bd026f73
---
M lib/maintenance
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156123
Change subject: Remove dead code
..
Remove dead code
Change-Id: Ib17e56c41fc19b1f20c5956edd9043e726a89e46
---
M client
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Implemented jQuery.wikibase.sitelinkgroupview
..
Implemented jQuery.wikibase.sitelinkgroupview
jQuery.wikibase.sitelinkgroupview acts as a
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Implemented jQuery.wikibase.aliasesview
..
Implemented jQuery.wikibase.aliasesview
jQuery.wikibase.aliasesview replaces the legacy components
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Move EntityTitleLookup into Wikibase\Lib\Store namespace
..
Move EntityTitleLookup into Wikibase\Lib\Store namespace
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Move EntityPermissionChecker and EntityContentFactory into
namespaces
..
Move EntityPermissionChecker and EntityContentFactory into namespaces
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Added hasConflict() to tagadata widget
..
Added hasConflict() to tagadata widget
Change-Id: I23569710e818416353f5e024f0e8aea031cc846f
---
M lib
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156265
Change subject: ClaimDifferenceVisualizer code cleanup
..
ClaimDifferenceVisualizer code cleanup
I wanted to highlight the
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Sanitized RepoApi.js
..
Sanitized RepoApi.js
Added some documentation and removed unnecessary one;
removed/replaced now obsolete getting repo
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156524
Change subject: Make ChangeOpClaimTest compatible with DM 1.0
..
Make ChangeOpClaimTest compatible with DM 1.0
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156526
Change subject: Make tests compatible with DataModel 1.0
..
Make tests compatible with DataModel 1.0
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156528
Change subject: Make CreateClaimTest compatible with DataModel 1.0
..
Make CreateClaimTest compatible with DataModel 1.0
I give
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Fix EntityTitleLookup namespace in ApiHelperFactoryTest
..
Fix EntityTitleLookup namespace in ApiHelperFactoryTest
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156530
Change subject: Merge "Fix EntityTitleLookup namespace in ApiHelperFactoryTest"
..
Merge "Fix EntityTitleLook
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Fixed jQuery.wikibase.aliasesview QUnit tests
..
Fixed jQuery.wikibase.aliasesview QUnit tests
isValid() tests are not needed anymore, since the
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Changed $.fn.applyTemplate mechanics
..
Changed $.fn.applyTemplate mechanics
applyTemplate() expects a template to have a single root node
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156770
Change subject: Do not output "(new)" in FingerprintView
..
Do not output "(new)" in FingerprintView
H
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Implemented jQuery.wikibase.labelview
..
Implemented jQuery.wikibase.labelview
jQuery.wikibase.labelview replaces EditableLabel and
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156778
Change subject: Make ChangeOpsMergeTest compatible with DataModel 1.0
..
Make ChangeOpsMergeTest compatible with DataModel 1.0
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156779
Change subject: Make Item/PropertyViewTest compatible with DataModel 1.0
..
Make Item/PropertyViewTest compatible with DataModel
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/164955
Change subject: Remove unused code from snakview
..
Remove unused code from snakview
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/164978
Change subject: Cleanup some EntityStore JavaScript code
..
Cleanup some EntityStore JavaScript code
Idx next to id is
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/164989
Change subject: Cleanup UserLanguageLookupTest
..
Cleanup UserLanguageLookupTest
"Main" reason to touch this was t
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165003
Change subject: Drop ORMTable::getFieldPrefix
..
Drop ORMTable::getFieldPrefix
Internal calls to this method show up in my
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165178
Change subject: Get rid of ORMTable::getFieldPrefix
..
Get rid of ORMTable::getFieldPrefix
See I46a0d7e.
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165203
Change subject: Fix bad assumptions in EntityParserOutputGenerator
..
Fix bad assumptions in EntityParserOutputGenerator
This
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165440
Change subject: Workaround for invalid ParserAfterParse hook call
..
Workaround for invalid ParserAfterParse hook call
Bug
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165454
Change subject: Drop ORMTable::getFieldPrefix
..
Drop ORMTable::getFieldPrefix
This patch is a no-op. It doesn't c
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165467
Change subject: Drop ORMTable::getFieldPrefix
..
Drop ORMTable::getFieldPrefix
See I46a0d7e.
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165700
Change subject: Cleanup EntityContentDiffView
..
Cleanup EntityContentDiffView
This is a follow up to I0567dde. Plus a bit of
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165720
Change subject: Stop using aliases outside Wikibase namespace
..
Stop using aliases outside Wikibase namespace
This is split
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167799
Change subject: Always use native language name
..
Always use native language name
"Native" means, the name of the l
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167808
Change subject: Don't use full qualified class names if not necesarry
..
Don't use full qualified class names if not
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167814
Change subject: Fix code smell in JS
..
Fix code smell in JS
As reported by PHPStorms static code analysis.
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167815
Change subject: Fix code smell issues in PHP
..
Fix code smell issues in PHP
As reported by PHPStorms static code analysis
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167816
Change subject: Fix code smell issues/drop unused PHP code
..
Fix code smell issues/drop unused PHP code
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Add referenceview.isInitialValue test
..
Add referenceview.isInitialValue test
Change-Id: I918fa19197b69b218939bc1c427010fb30484c8b
---
M lib
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168271
Change subject: Clean up entityChangers tests
..
Clean up entityChangers tests
Main reason for this patch are the somewhat
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Introduce DescriptionsChanger
..
Introduce DescriptionsChanger
Change-Id: I2f8c59c3e5721fa9eded6a3fbdfaa5b6348b75ff
---
A lib/resources
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Introduce LabelsChanger
..
Introduce LabelsChanger
Change-Id: Ibf2cf0b69b97041020f13e311d8b4132691bbd16
---
M lib/resources/entityChangers
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Introduce SiteLinksChanger
..
Introduce SiteLinksChanger
Bug: 56246
Change-Id: Ib315d4644e5d07910838ed96e62230104374f9cb
---
M lib/resources
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168557
Change subject: Drop pointless comments from special page code
..
Drop pointless comments from special page code
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Remove wikibase.getRevisionStore
..
Remove wikibase.getRevisionStore
Change-Id: I6cbc40e521c50e00936aeff234c68231fd1999d1
---
M lib/resources
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168575
Change subject: Remove broken options.api check, now in EntityChangersFactory
..
Remove broken options.api check, now in
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168612
Change subject: Upper case SiteLink in UsageAccumulators
..
Upper case SiteLink in UsageAccumulators
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168943
Change subject: Drop static EntityView::typeMap
..
Drop static EntityView::typeMap
I can't find any usage of this. P
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168962
Change subject: Remove meaningless default action name
..
Remove meaningless default action name
Before: Get the value of the
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Drop pointless comments from special page code
..
Drop pointless comments from special page code
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169352
Change subject: Refactor another big method in ViewEntityAction
..
Refactor another big method in ViewEntityAction
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169367
Change subject: Fix horrible typo in Wikibase.hooks
..
Fix horrible typo in Wikibase.hooks
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154081
Change subject: Extends \MediaWikiTestCase
..
Extends \MediaWikiTestCase
This is the only test in Wikibase that misses the
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154241
Change subject: Revert "Refactor Fingerprint code out of EntityView"
..
Revert "Refactor Fingerprint code ou
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154250
Change subject: Fix SqlEntityInfoBuilder(Factory) constructor parameters
..
Fix SqlEntityInfoBuilder(Factory) constructor
601 - 700 of 3880 matches
Mail list logo