Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202704
Change subject: Drop dead code and narrow interfaces in WikibaseApiTestCase
..
Drop dead code and narrow interfaces
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202723
Change subject: Un-deprecate $revisionId = 0 in EntityRevisionLookup
..
Un-deprecate $revisionId = 0 in EntityRevisionLookup
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203018
Change subject: Remove broken unlocalization from MwTimeIsoFormatter
..
Remove broken unlocalization from MwTimeIsoFormatter
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203037
Change subject: Make deprecated Settings class final
..
Make deprecated Settings class final
This also adds deprecation tags
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203045
Change subject: [DNM] Disallow EntityRevision to represent current revision
..
[DNM] Disallow EntityRevision to represent
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203112
Change subject: Simplify StringNormalizer regex
..
Simplify StringNormalizer regex
This does not change any semantics. All
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203086
Change subject: Fix broken EntityViewFactoryTest
..
Fix broken EntityViewFactoryTest
Why does Jenkins not fail
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203089
Change subject: Do not fail hard if badgeItems setting is not set
..
Do not fail hard if badgeItems setting is not set
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211985
Change subject: Make optional specialSiteLinkGroups parameters actually optional
..
Make optional specialSiteLinkGroups
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211988
Change subject: Do not count in SiteLinksView
..
Do not count in SiteLinksView
The actual number of elements is irrelevant
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211981
Change subject: Fix docu in NamespaceChecker and make optional parameter
optional
..
Fix docu in NamespaceChecker and make
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211984
Change subject: Make idBlacklist parameter in SqlIdGenerator optional
..
Make idBlacklist parameter in SqlIdGenerator optional
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212274
Change subject: Fix two failing QUnit tests
..
Fix two failing QUnit tests
These two tests fail on my local machine. I am
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212268
Change subject: Expand class level doc of RdfBuilder classes
..
Expand class level doc of RdfBuilder classes
This fixes
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211990
Change subject: More specific inline docs in TimeDetailsFormatter
..
More specific inline docs in TimeDetailsFormatter
* E.g
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Apply usage tracking in all namespaces.
..
Apply usage tracking in all namespaces.
Without arbitrary access, we only needed to track usage
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212406
Change subject: Much simpler usage aspect intersection calculation
..
Much simpler usage aspect intersection calculation
Change
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Add modifier field to EntityUsage
..
Add modifier field to EntityUsage
Bug: T93055
Change-Id: I1b4918dc023389eeb034ec87b7309c2c871c1619
---
M
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212310
Change subject: Add array type hints to ChangeHandler
..
Add array type hints to ChangeHandler
... as well as some minor fixes
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216769
Change subject: Do not mock precision int with a string
..
Do not mock precision int with a string
This is a wild guess
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216744
Change subject: Reduce number of $claimGuid variables in repo
..
Reduce number of $claimGuid variables in repo
This is a very
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216862
Change subject: Try different mocking in HtmlTimeFormatterTest
..
Try different mocking in HtmlTimeFormatterTest
An other try
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216659
Change subject: Rename ChangeOpClaimRemove to ChangeOpStatementRemove
..
Rename ChangeOpClaimRemove to ChangeOpStatementRemove
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217029
Change subject: Rework EntityTermsViewTest to not break on Travis
..
Rework EntityTermsViewTest to not break on Travis
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217243
Change subject: Phase out deprecated EntityFactory::singleton
..
Phase out deprecated EntityFactory::singleton
This patch
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215877
Change subject: Enable PHPCS sniff Generic.ControlStructures
..
Enable PHPCS sniff Generic.ControlStructures
There is only 1
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215878
Change subject: Enable PHPCS sniff Generic.Formatting.DisallowMultipleStatements
..
Enable PHPCS sniff
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215886
Change subject: Enable PHPCS sniff
Generic.Functions.OpeningFunctionBraceKernighanRitchie
..
Enable PHPCS sniff
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217159
Change subject: Fix EntityFactory calling a non-existing newEmpty method
..
Fix EntityFactory calling a non-existing newEmpty
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220141
Change subject: Fix minor bug in referenceview.js
..
Fix minor bug in referenceview.js
This patch contains some very minor bug
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219175
Change subject: Add tests for SpecialUnconnectedPages
..
Add tests for SpecialUnconnectedPages
This also fixes all issues I
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220735
Change subject: Add composer test command for Jenkins
..
Add composer test command for Jenkins
Originally I copied this line
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220737
Change subject: Run PHPCS for Wikibase
..
Run PHPCS for Wikibase
This requires https://gerrit.wikimedia.org/r/#/c/220735/
which
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220731
Change subject: Update DataValues Time to 0.8
..
Update DataValues Time to 0.8
This is the most minimal patch we could backport
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220773
Change subject: Avoid setting values that do not change in pagesuggester
..
Avoid setting values that do not change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220432
Change subject: Drop not needed private property in statementview.js
..
Drop not needed private property in statementview.js
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219363
Change subject: Fix docs in snakview.js
..
Fix docs in snakview.js
Bug: T92975
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Add more tests for statementview js
..
Add more tests for statementview js
this provides more test coverage for the isValid method,
though
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219350
Change subject: Move api/GetClaims forward to DataModel 3.x
..
Move api/GetClaims forward to DataModel 3.x
This avoids more
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220091
Change subject: Adapt statementgrouplabelscroll to DOM changes
..
Adapt statementgrouplabelscroll to DOM changes
I'm removing
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221082
Change subject: Drop duplicate EraParser
..
Drop duplicate EraParser
Replaced with an identically named but slightly refactored
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221084
Change subject: Drop leading zeros from TimeValue constructor parameters
..
Drop leading zeros from TimeValue constructor
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217474
Change subject: Update DataValues JavaScript dependency to 0.7.0
..
Update DataValues JavaScript dependency to 0.7.0
I checked
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217502
Change subject: Enable PHPCS sniff Squiz.ControlStructures.ControlSignature
..
Enable PHPCS sniff
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217498
Change subject: Enable PHPCS sniff Squiz.WhiteSpace.FunctionSpacing
..
Enable PHPCS sniff Squiz.WhiteSpace.FunctionSpacing
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218635
Change subject: Consistent order of EntityViewFactory constructor parameters
..
Consistent order of EntityViewFactory
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218306
Change subject: Turn JSON fields into textareas for the ApiSandbox
..
Turn JSON fields into textareas for the ApiSandbox
I'm
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218307
Change subject: Use json_decode instead of FormatJson::decode
..
Use json_decode instead of FormatJson::decode
The wrapper does
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218346
Change subject: Rename ClaimModificationHelper to StatementModificationHelper
..
Rename ClaimModificationHelper
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218348
Change subject: Rename some $claimGuid to $guid
..
Rename some $claimGuid to $guid
This is pure refactoring split from I54f5c79
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217798
Change subject: Make site link two words in all messages
..
Make site link two words in all messages
This was raised
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217799
Change subject: Make sitelinkgroupview.css more compatible with cached HTML
..
Make sitelinkgroupview.css more compatible
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218982
Change subject: Update api module constructors
..
Update api module constructors
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219037
Change subject: Replace Claim alias in StatementGroupListView
..
Replace Claim alias in StatementGroupListView
This is an other
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219016
Change subject: Rework EntityLabelUnitFormatter into ItemLabelUnitFormatter
..
Rework EntityLabelUnitFormatter
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219022
Change subject: Replace Claim alias with Statement
..
Replace Claim alias with Statement
This patch replaces a few instances
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218917
Change subject: Clean up architecture of unit formatting
..
Clean up architecture of unit formatting
Items are supposed
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222119
Change subject: Do not trim the T in TimeDetailsFormatter
..
Do not trim the T in TimeDetailsFormatter
I did that in I27861d4
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222095
Change subject: Add more EditEntity API tests for (non-) conflicting edits
..
Add more EditEntity API tests for (non
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222097
Change subject: Remove non-existing class name in use clause
..
Remove non-existing class name in use clause
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222597
Change subject: [WIP] Use QuantityInput expert
..
[WIP] Use QuantityInput expert
This requires a new release of ValueView
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222574
Change subject: Unify whitespace in array() functions
..
Unify whitespace in array() functions
This is an other step forward
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222585
Change subject: Unify whitespace in array() functions
..
Unify whitespace in array() functions
How did I missed
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62
Change subject: Enable PHPCS sniff Generic.Files.EndFileNewline
..
Enable PHPCS sniff Generic.Files.EndFileNewline
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/78
Change subject: Enable PHPCS sniff Generic.Functions.FunctionCallArgumentSpacing
..
Enable PHPCS sniff
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222320
Change subject: Enable PHPCS sniff Generic.NamingConventions.ConstructorName
..
Enable PHPCS sniff
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222324
Change subject: Enable PHPCS sniff PSR2.Methods.MethodDeclaration
..
Enable PHPCS sniff PSR2.Methods.MethodDeclaration
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223008
Change subject: Enable PHPCS sniff Generic.Files.LineLength
..
Enable PHPCS sniff Generic.Files.LineLength
This patch enables
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223016
Change subject: Set PHPCS' LineLength sniff to 170 characters
..
Set PHPCS' LineLength sniff to 170 characters
This patch
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223024
Change subject: Use max-width for descriptions instead of width: 50%
..
Use max-width for descriptions instead of width: 50
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222333
Change subject: Enable more Squiz.WhiteSpace.* PHPCS sniffs
..
Enable more Squiz.WhiteSpace.* PHPCS sniffs
This enables 4 more
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222560
Change subject: Remove brackets in include/require_once calls
..
Remove brackets in include/require_once calls
This patch
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212783
Change subject: Performant GUID search in RemoveClaims
..
Performant GUID search in RemoveClaims
Patch I7796537 did
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212787
Change subject: usePropertyInfoTable is not a repo but a lib setting
..
usePropertyInfoTable is not a repo but a lib setting
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223250
Change subject: Avoid counting arrays if not needed
..
Avoid counting arrays if not needed
count() tends to be one
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223253
Change subject: Fix lots and lots of code style issues
..
Fix lots and lots of code style issues
Lots and lots of smaller
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231245
Change subject: Fix minor bug in LanguageFallbackChainFactoryTest
..
Fix minor bug in LanguageFallbackChainFactoryTest
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231249
Change subject: Rename Statement $claim variables to $statement
..
Rename Statement $claim variables to $statement
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231248
Change subject: Drop dead code from ClaimHtmlGenerator
..
Drop dead code from ClaimHtmlGenerator
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231264
Change subject: End all Claim's
..
End all Claim's
Change-Id: I420b1cbcd05c161c8736994808898783562356ad
---
M repo/includes
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231273
Change subject: Remove unused use clauses
..
Remove unused use clauses
Change-Id: I38fad101d14b57885775615db39c838bf23f4aa3
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231274
Change subject: Replace all remaining usages of the Claim alias
..
Replace all remaining usages of the Claim alias
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232248
Change subject: Enable two groups of PHPCS sniffs instead of individual sniffs
..
Enable two groups of PHPCS sniffs instead
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232254
Change subject: Add trimming test to SummaryFormatterTest
..
Add trimming test to SummaryFormatterTest
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232251
Change subject: Disallow YDM format in TimeParserFactoryTest for now
..
Disallow YDM format in TimeParserFactoryTest for now
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232244
Change subject: Enable more PHPCS sniffs the code base already conforms to
..
Enable more PHPCS sniffs the code base already
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232243
Change subject: Fix wrong version range for DataValues Interfaces
..
Fix wrong version range for DataValues Interfaces
I am
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232245
Change subject: Drop some dead function parameters from tests
..
Drop some dead function parameters from tests
I found
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232246
Change subject: Remove entity view loading spinner
..
Remove entity view loading spinner
Bug: T108365
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232263
Change subject: Add proper null check to ChangeRow
..
Add proper null check to ChangeRow
Both json_decode and unserialize calls
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232481
Change subject: Simplify hasOwnProperty checks in wikibase.getLanguageNameByCode
..
Simplify hasOwnProperty checks
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232482
Change subject: Fix unchecked loop in wikibase.special.itemByTitle
..
Fix unchecked loop in wikibase.special.itemByTitle
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232509
Change subject: Remove duplicate whitespaces in arrays
..
Remove duplicate whitespaces in arrays
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Add default badges for Wikisource
..
Add default badges for Wikisource
With site css, each Wikisource community can override
these defaults
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232471
Change subject: Use factory instead of accessing configuration
..
Use factory instead of accessing configuration
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232696
Change subject: Add array type hints to public methods
..
Add array type hints to public methods
Please be careful and double
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232927
Change subject: Remove unused return from ChangeHandler::handleChange
..
Remove unused return from ChangeHandler::handleChange
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232939
Change subject: Tests for more edge cases in InterwikiSorter
..
Tests for more edge cases in InterwikiSorter
Bug: T103044
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232928
Change subject: Make TextInjector optional in EntityTermsView
..
Make TextInjector optional in EntityTermsView
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232926
Change subject: Fix failing empty( ArrayIterator ) check in ChangeHandler
..
Fix failing empty( ArrayIterator ) check
801 - 900 of 6021 matches
Mail list logo