Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com

2011-04-05 Thread Arun Ravindran
Hi Shane, We can do this one of two ways: 1) I apply these as is (with the only caveat being to please make the commit message more concise and to the point) I saw your patch, and it looks better. The key merge key handling is more robust now, please apply this as is. 2) You resubmit the

Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com

2011-04-05 Thread Shane Bryan
On Tue, 5 Apr 2011 10:16:44 +0300 Arun Ravindran ext-arun.1.ravind...@nokia.com wrote: Hi Shane, We can do this one of two ways: 1) I apply these as is (with the only caveat being to please make the commit message more concise and to the point) I saw your patch, and it looks

Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com

2011-04-04 Thread Arun Ravindran
Hi Shane, On Mon, 28 Mar 2011 14:34:42 +0300 ext-arun.1.ravind...@nokia.com wrote: From: Arun Ravindranext-arun.1.ravind...@nokia.com Added handling of multipart property in the call proxy, call item and callitem model by adding a signal to be emited for the property changes. This signal is

Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com

2011-04-04 Thread Shane Bryan
On Mon, 4 Apr 2011 11:47:49 +0300 Arun Ravindran ext-arun.1.ravind...@nokia.com wrote: Hi Shane, On Mon, 28 Mar 2011 14:34:42 +0300 ext-arun.1.ravind...@nokia.com wrote: Just a note that I have been reviewing this, but found a logic error in existing code this touches, trying to sort