Patch to allow -F option to disable flush_all

2009-07-24 Thread Adrian Otto
Hi, I've attached a patch for a tan option flag -F to disable the purge_all command in memcached. It also includes: 1) A tiny tweak to testapp.c that allowed "make test" to pass 2) Fixed a minor bug in t/binary.t with a variable scope. 3) Fixed the memcached.spec file to include the protocol_bi

Re: Patch to allow -F option to disable flush_all

2009-07-24 Thread dormando
Hey, We've rejected a few similar patches in the past. Usually if folks need this they have bigger problems... What is your particular use case? I could see this going in though. It squicks me out but I'm open to opinions from the others :) -Dormando On Fri, 24 Jul 2009, Adrian Otto wrote: >

Re: Patch to allow -F option to disable flush_all

2009-07-24 Thread Adrian Otto
Dormando, Thanks for your reply. The use case is for using memcached from a hosting environment where multiple subscribers share the same source IP address because they run application code together on the same cluster of web servers. The clusters are large, typically in the hundreds of

Re: Patch to allow -F option to disable flush_all

2009-07-25 Thread Toru Maesaka
G'day! So I just had a look at the patch and from reading Adrian's reply, I can understand why such a feature would be handy from hosting perspective. The concern is, I think that the majority of users won't need this feature. That said, it doesn't change the fact that there's a need for it so h

Re: Patch to allow -F option to disable flush_all

2009-07-25 Thread Trond Norbye
On 25. juli. 2009, at 11.14, Toru Maesaka wrote: G'day! So I just had a look at the patch and from reading Adrian's reply, I can understand why such a feature would be handy from hosting perspective. The concern is, I think that the majority of users won't need this feature. That said, it d

Re: Patch to allow -F option to disable flush_all

2009-07-28 Thread Aaron Stone
Maybe more esoteric options should come through a single flag, ala ssh, where you can have "-o UnusualOption=foo". That reduces the number of single-letter flags in the command-line flag namespace. On Sat, Jul 25, 2009 at 2:33 AM, Trond Norbye wrote: > > > On 25. juli. 2009, at 11.14, Toru Maesa

Re: Patch to allow -F option to disable flush_all

2009-07-28 Thread Adrian Otto
Aaron, That's a great suggestion. I'm willing to write the patch accordingly if I get the green light indicating we can get this into the trunk. Thanks, Adrian On Jul 28, 2009, at 11:04 AM, Aaron Stone wrote: Maybe more esoteric options should come through a single flag, ala ssh, where

Re: Patch to allow -F option to disable flush_all

2009-07-28 Thread Dustin
On Jul 28, 11:04 am, Aaron Stone wrote: > Maybe more esoteric options should come through a single flag, ala > ssh, where you can have "-o UnusualOption=foo". That reduces the > number of single-letter flags in the command-line flag namespace. Do note that we had a -o issue and some changes t

Re: Patch to allow -F option to disable flush_all

2009-07-28 Thread Aaron Stone
On Tue, Jul 28, 2009 at 12:46 PM, Dustin wrote: > > > On Jul 28, 11:04 am, Aaron Stone wrote: >> Maybe more esoteric options should come through a single flag, ala >> ssh, where you can have "-o UnusualOption=foo". That reduces the >> number of single-letter flags in the command-line flag namespa

Re: Patch to allow -F option to disable flush_all

2009-08-03 Thread dormando
Hey, I read the whole thread and thought about it for a bit... I'm not sure we should do this. Especially not as an explicit solution to a security problem with a shared hosting cluster. We can roadmap out a method of multitenancy (dustin's apparently done proof of concept before, and I can imagi

Re: Patch to allow -F option to disable flush_all

2009-08-03 Thread Adam Lee
Yeah, I'm inclined to agree with you... Disabling flush seems like a bit of a red herring. Sure, it prevents one very particular case, but at best it provides a false sense of safety. If we were going to do anything like this, perhaps we could consider doing something like how Tokyo Cabinet/Toky