On Sat, 10 Mar 2018 15:42:04 +0800
Anton Shestakov wrote:
> On Sat, 10 Mar 2018 12:46:41 +0530
> Sushil khanchi wrote:
>
> > # HG changeset patch
> > # User Sushil khanchi
> > # Date 1520665399 -19800
> > # Sat Mar
# HG changeset patch
# User Yuya Nishihara
# Date 1520664609 -32400
# Sat Mar 10 15:50:09 2018 +0900
# Node ID c38b2b364df79a9defc3520f19207ce47abcc7d8
# Parent 9ddc9aa26801bac571bd3413a8aed900c2d2efb8
ui: remove any combinations of CR|LF from prompt response
On Windows, we
On Fri, 9 Mar 2018 09:25:10 -0800, Gregory Szorc wrote:
> If you have this stdio stuff paged into your brain, you may want to look at
> hook.py and what it is doing with stdio. Essentially, it is doing dup() and
> dup2() to temporarily redirect stdout to stderr such that the wire protocol
> can
On Fri, 09 Mar 2018 23:52:16 -0500, Matt Harbison wrote:
> On Fri, 09 Mar 2018 07:35:39 -0500, Yuya Nishihara wrote:
>
> > # HG changeset patch
> > # User Yuya Nishihara
> > # Date 1520325533 21600
> > # Tue Mar 06 02:38:53 2018 -0600
> > # Node ID
On Sat, 10 Mar 2018 12:46:41 +0530
Sushil khanchi wrote:
> # HG changeset patch
> # User Sushil khanchi
> # Date 1520665399 -19800
> # Sat Mar 10 12:33:19 2018 +0530
> # Node ID 430c6b5123ee72d3a209882495302e43b26cc988
> # Parent
pulkit added a comment.
In https://phab.mercurial-scm.org/D2588#44645, @sangeet259 wrote:
> Since the current code just overwrites message each time with the newer.
What can be done to avoid losing the earlier message values?
You should look how we handle multiple `--rev` flags.
# HG changeset patch
# User Sushil khanchi
# Date 1520665399 -19800
# Sat Mar 10 12:33:19 2018 +0530
# Node ID 430c6b5123ee72d3a209882495302e43b26cc988
# Parent 4c71a26a4009d88590c9ae3d64a5912fd556d82e
forget: add --dry-run mode
diff -r 4c71a26a4009 -r
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, we called out to cgi.parse(), which for POST requests
parsed multipart/form-data and application/x-www-form-urlencoded
Content-Type requests for
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We have refactored the request side of WSGI processing into a dedicated
type. Now let's do the same thing for the response side.
We invent a
indygreg updated this revision to Diff 6820.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2773?vs=6818=6820
REVISION DETAIL
https://phab.mercurial-scm.org/D2773
AFFECTED FILES
mercurial/hgweb/request.py
tests/test-hgweb-raw.t
CHANGE DETAILS
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
My intention with refactoring the WSGI code was to make it easier
to read. I initially wanted to vendor and use WebOb, because it seems
to be a pretty
On Fri, 09 Mar 2018 07:35:39 -0500, Yuya Nishihara wrote:
# HG changeset patch
# User Yuya Nishihara
# Date 1520325533 21600
# Tue Mar 06 02:38:53 2018 -0600
# Node ID ad7ff97565b261d82952acc9f941e5dd99f11374
# Parent
sangeet259 added a comment.
Since the current code just overwrites message each time with the newer. What
can be done to avoid losing the earlier message values?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2588
To: sangeet259, #hg-reviewers
Cc: durin42,
indygreg abandoned this revision.
indygreg added a subscriber: durin42.
indygreg added a comment.
@durin42 thinks we don't need this feature. So I'll submit a patch to remove
it instead.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2772
To: indygreg,
# HG changeset patch
# User Matt Harbison
# Date 1520650747 18000
# Fri Mar 09 21:59:07 2018 -0500
# Node ID 09be2aeb8f5a364fab574ed3cf00bddbb7b9728a
# Parent 1f313a913f4356f272ef275061d5d169d9c1690e
bdiff: convert more longs to int64_t
MSVC previously flagged
# HG changeset patch
# User Matt Harbison
# Date 1520649753 18000
# Fri Mar 09 21:42:33 2018 -0500
# Node ID 1f313a913f4356f272ef275061d5d169d9c1690e
# Parent d3b978ff5c3fc50b33b3ca8f6c371df23d46404b
xdiff: silence a 32-bit shift warning on Windows
It's probably
indygreg updated this revision to Diff 6818.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2773?vs=6817=6818
REVISION DETAIL
https://phab.mercurial-scm.org/D2773
AFFECTED FILES
mercurial/hgweb/request.py
tests/test-hgweb-raw.t
CHANGE DETAILS
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2767
AFFECTED FILES
mercurial/hgweb/common.py
CHANGE DETAILS
diff --git a/mercurial/hgweb/common.py
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The previous code for draining was only invoked in a few places in
the wire protocol. Behavior wasn't consist. Furthermore, it was
difficult to reason about.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Our next step towards moving away from wsgirequest to our newer,
friendlier parsedrequest type is input stream access.
This commit exposes the input stream
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Form data exposed by hgweb is post-processed to expand certain
shortcuts. For example, URLs with "?cs=@" is essentially expanded to
"?cmd=changeset=@". And the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is kind of ugly. But upcoming commits will teach our parsedrequest
instances about how to read from the input stream and how to parse
form variables which
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is essentially a port of what wsgirequest.__init__ was doing
inline via cgi.parse().
Our version is better because - unlike cgi.parse() - we keep the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Per PEP-, the input stream from WSGI should respect EOF and
prevent reads past the end of the request body. However, not all
WSGI servers guarantee this.
quark added a comment.
I don't think the Python ".so"s should be consumed by non-Python "dlopen". So
"version" doesn't change since Python API remains the same.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2763
To: quark, #hg-reviewers, indygreg
Cc:
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG71fbceb58746: xdiff: use int64 for hash table size
(authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2765?vs=6802=6809
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe882437cc082: xdiff: replace {unsigned ,}long with
{u,}int64_t (authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4c8ffc67bac2: xdiff: remove unused flags parameter
(authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2763?vs=6800=6808
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG665958f30789: xdiff: add a preprocessing step that trims
files (authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2e2b48cca761: xdiff: remove unused xpp and xecfg parameters
(authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2764?vs=6801=6807
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG58028f6d1fb8: xdiff: add comments for fields in xdfile_t
(authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2685?vs=6798=6805
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Strictly speaking, we might want to bump the C extension version number
because of the ABI change. But I'm not sure if these functions are exported or
even used by our C extension. So
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
So. Much. Better.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2685
To: quark, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I almost accepted the last version and this one is mostly cosmetic changes.
So LGTM!
Your work here is very much appreciated. Thank you for doing the thorough
performance
indygreg added inline comments.
INLINE COMMENTS
> durin42 wrote in wireprotoserver.py:97
> Missed one?
No. This preserves the behavior since HTTP_CONTENT_LENGTH != CONTENT_LENGTH. I
fix this in a later commit by teaching the request object about both keys.
REPOSITORY
rHG Mercurial
REVISION
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
They are unused. Thus removed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2764
AFFECTED FILES
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Follow-up of the previous "long" -> "int64" change. Now xdiff only uses int
for return values and small integers (ex. booleans, shifting score, bits in
hash table
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
MSVC treats "long" as 4-byte. That could cause overflows since the xdiff
code uses "long" in places where "size_t" or "ssize_t" should be used.
Let's use explicit
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
After https://phab.mercurial-scm.org/D2683, the flags parameter in some
functions is no longer needed.
Thus removed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Since the value won't be changed inside the code (because context lines
feature was removed by https://phab.mercurial-scm.org/D2705), let's just
remove the
quark updated this revision to Diff 6797.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2686?vs=6708=6797
REVISION DETAIL
https://phab.mercurial-scm.org/D2686
AFFECTED FILES
mercurial/thirdparty/xdiff/xdiffi.c
mercurial/thirdparty/xdiff/xprepare.c
quark updated this revision to Diff 6798.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2685?vs=6643=6798
REVISION DETAIL
https://phab.mercurial-scm.org/D2685
AFFECTED FILES
mercurial/thirdparty/xdiff/xtypes.h
CHANGE DETAILS
diff --git
mharbison72 added a comment.
> IDK if this means anything, but when it is stuck and I hit Ctrl+C, instead
of terminating the test, the test simply continues with the script, and then
hangs on the next 'remote output:' line. Typically, Ctrl+C ends the test
runner.
A couple of
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG49e2ca27c10e: transaction: add a name and a __str__
implementation (API) (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5b84bdd511eb: tests: add a few tests involving --collapse
and rebase.singletransaction=1 (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG28ea00cd817e: tests: simplify test-rebase-transaction.t
(authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2756?vs=6766=6792
martinvonz updated this revision to Diff 6791.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2758?vs=6790=6791
REVISION DETAIL
https://phab.mercurial-scm.org/D2758
AFFECTED FILES
mercurial/localrepo.py
mercurial/transaction.py
CHANGE DETAILS
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0bebd4608ce3: phabricator: update doc string for deprecated
token argument (authored by joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6490b0915881: phabricator: print deprecation warning only
once (authored by joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz added a comment.
Done
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2758
To: martinvonz, #hg-reviewers
Cc: durin42, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
martinvonz updated this revision to Diff 6790.
martinvonz marked an inline comment as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2758?vs=6769=6790
REVISION DETAIL
https://phab.mercurial-scm.org/D2758
AFFECTED FILES
mercurial/localrepo.py
durin42 added a comment.
Either way, you should make sure this always returns a sysstr, otherwise
you'll cause pretty terrible python3 breakage. Look around for other __repr__
instances for examples.
INLINE COMMENTS
> transaction.py:191
>
> +def __str__(self):
> +name =
https://bz.mercurial-scm.org/show_bug.cgi?id=5811
Bug ID: 5811
Summary: fsmonitor returns bogus stat tuples, breaking after
cleanup in ffa3026d4196
Product: Mercurial
Version: default branch
Hardware: All
durin42 accepted this revision.
durin42 added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> wireprotoserver.py:94
> def forwardpayload(self, fp):
> -if b'Content-Length' in self._req.headers:
> -length =
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D2720#44396, @indygreg wrote:
> My only explanation is this is stdout output buffering and things are
really hanging on the next read operation.
>
> Maybe try sprinkling some `ui.fout.flush()` and/or `util.stdout.flush()`
Excerpts from Yuya Nishihara's message of 2018-03-08 21:33:42 +0900:
> On Tue, 6 Mar 2018 19:12:26 -0800, Jun Wu wrote:
> > Yeah, xdiff needs a migration from using "long", "int"s to "size_t" etc.
> > The git community has chosen to disallow diff >1GB files because of the
> > overflow concern [1].
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2759
AFFECTED FILES
hgext/rebase.py
tests/test-rebase-interruptions.t
CHANGE DETAILS
diff --git
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2761
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py b/hgext/rebase.py
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It looks like this was lost when the code was converted to the
ui.configoverride() context manager in
quark added inline comments.
INLINE COMMENTS
> indygreg wrote in xprepare.c:169
> Bonus points if you resubmit this with more expressive variable names. Just
> because xdiff's code is almost impossible to read doesn't mean we should
> follow suit :)
The style guide in git community recommends
indygreg added a comment.
My only explanation is this is stdout output buffering and things are really
hanging on the next read operation.
Maybe try sprinkling some `ui.fout.flush()` and/or `util.stdout.flush()`
and/or `sys.stdout.flush()` calls throughout the debug command? Maybe at
8 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/bf9a04d78084
changeset: 36779:bf9a04d78084
user:Augie Fackler
date:Sun Mar 04 21:14:24 2018 -0500
summary: hgweb: adapt to socket._fileobject changes in Python 3
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D2720#44350, @indygreg wrote:
> In https://phab.mercurial-scm.org/D2720#44293, @mharbison72 wrote:
>
> > i> write(4) -> 4:
> > i> 426\n
> > i> write(426) -> 426:
> > i>
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9a6216c18ffd: wireprotoserver: remove broken optimization
for non-httplib client (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGad13301e6479: hgweb: only recognize wire protocol commands
from query string (BC) (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG09b9a9d4612b: wireprotoserver: move all wire protocol
handling logic out of hgweb (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0c1de2e87c6e: hgweb: use parsed request to construct query
parameters (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG29b477d7f334: hgweb: parse and store HTTP request headers
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2742?vs=6748=6786
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG328d665ef23d: hgweb: use the parsed application path
directly (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3e13a21ce6b5: hgweb: parse WSGI request into a data
structure (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb48ac58ea4f6: hgweb: teach WSGI parser about query strings
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG56154c4626b9: hgweb: use computed base URL from parsed
request (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7fc80c982656: hgweb: ensure all wsgi environment values are
str (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0b18604db95e: wireproto: declare permissions requirements
in @wireprotocommand (API) (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb9b968e21f78: hgweb: rename req to wsgireq (authored by
indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2732?vs=6738=6776
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG66de4555cefd: wireproto: formalize permissions checking as
part of protocol interface (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8e1556ac01bb: hgweb: validate WSGI environment dict
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2731?vs=6737=6775
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7574c8173d5e: wireprotoserver: check if command available
before calling it (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc638a13093cf: wireprotoserver: check permissions in main
dispatch function (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added inline comments.
INLINE COMMENTS
> wireprotoserver.py:97
> else:
> length = int(self._wsgireq.env[r'CONTENT_LENGTH'])
> # If httppostargs is used, we need to read Content-Length
Missed one?
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg added a comment.
In https://phab.mercurial-scm.org/D2720#44293, @mharbison72 wrote:
> i> write(4) -> 4:
> i> 426\n
> i> write(426) -> 426:
> i>
HG10UN\x00\x00\x00\x9eh\x98b\x13\xbdD\x85\xeaQS55\xe3\xfc\x9ex\x00zq\x1f\x00\x00\x00\x00\x00\x00\x00\x0
>
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This has been useful for me for debugging.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2758
AFFECTED FILES
martinvonz added a comment.
This is now ready for review again
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2728
To: martinvonz, #hg-reviewers, durham, quark
Cc: mercurial-devel
___
Mercurial-devel mailing list
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I'm about to change the rebase code quite a bit and this was poorly
tested.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2757
martinvonz updated this revision to Diff 6768.
martinvonz edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2728?vs=6734=6768
REVISION DETAIL
https://phab.mercurial-scm.org/D2728
AFFECTED FILES
hgext/rebase.py
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The file was extracted from test-rebase-base.t in
https://phab.mercurial-scm.org/rHG8cef8f7d51d0f1e99889779ec1320d5c9c3b91de
(test-rebase-base: clarify it is
Ivzhh added a comment.
In https://phab.mercurial-scm.org/D2057#44269, @yuja wrote:
> >> Reading that page it seems to claim that filenames should be utf8, not
bytes. If utf8, this is what the code does, but if it is bytes that definitely
won't work.
> >
> > IIRC it's bytes
sangeet259 added a comment.
@durin42 Should I make any changes?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2394
To: sangeet259, durin42, #hg-reviewers
Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D2720#44288, @indygreg wrote:
> In https://phab.mercurial-scm.org/D2720#44221, @mharbison72 wrote:
>
> > This patch seems to deadlock on Windows when running
test-ssh-proto-unbundle.t. There are two python processes
On Fri, Mar 9, 2018 at 4:35 AM, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1520323525 21600
> # Tue Mar 06 02:05:25 2018 -0600
> # Node ID f7d9876d750e048b4c0e0ec0682928e86a8e8ecb
> # Parent
indygreg added a comment.
Not sure where to record this comment in this series. So I'll pick this
commit.
I think we want an explicit version header in the state files so clients know
when they may be reading a file in an old format. For example, if I start a
merge in one terminal
indygreg added a comment.
I think you should send the relative import patches to upstream. Adding `from
__future__ import absolute_import` would also be a nice touch.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2752
To: pulkit, #hg-reviewers
Cc: indygreg,
indygreg added a comment.
In https://phab.mercurial-scm.org/D2720#44221, @mharbison72 wrote:
> This patch seems to deadlock on Windows when running
test-ssh-proto-unbundle.t. There are two python processes idling:
>
> Past experience says that something needs to be flushed- stdout
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2755
AFFECTED FILES
contrib/phabricator.py
CHANGE DETAILS
diff --git
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2754
AFFECTED FILES
contrib/phabricator.py
CHANGE DETAILS
diff --git
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2753
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git
12 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/a148c67d8b09
changeset: 36767:a148c67d8b09
user:Vincent Parrett
date:Wed Mar 07 09:07:34 2018 +1100
summary: archival: fileit should not use atomictemp, causes performance
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG09b58af83d44: bookmarks: test for exchanging long bookmark
names (issue5165) (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/d382344c69aa
changeset: 36766:d382344c69aa
tag: tip
user:Gregory Szorc
date:Sat Mar 03 18:55:43 2018 -0500
summary: perf: teach perfbdiff to call blocks() and to use xdiff
# HG changeset patch
# User Yuya Nishihara
# Date 1520515382 -32400
# Thu Mar 08 22:23:02 2018 +0900
# Node ID b3f764c8098d6de1dca102f8b5b5d05721a6341f
# Parent c22e2d75938bc761554c8da98a49b85aa6bff0de
templater: split template functions to new module
It has grown enough to
1 - 100 of 122 matches
Mail list logo