D5485: log: fixes line wrap on diffstat (issue5800)

2019-01-01 Thread yuja (Yuya Nishihara)
yuja added a comment. Looks generally good. Can you add some tests with/without the -T option? There are two callers of _showpatch(). > +graphwidth = props.get('graphwidth') > +if not graphwidth: > +graphwidth = 0 Nit: can be written as

Re: D5485: log: fixes line wrap on diffstat (issue5800)

2019-01-01 Thread Yuya Nishihara
Looks generally good. Can you add some tests with/without the -T option? There are two callers of _showpatch(). > +graphwidth = props.get('graphwidth') > +if not graphwidth: > +graphwidth = 0 Nit: can be written as `props.get('graphwidth', 0)`.

Re: [PATCH 2 of 3 V2] vfs: add a `_auditpath` to abstract vfs

2019-01-01 Thread Yuya Nishihara
On Mon, 31 Dec 2018 18:37:29 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1545828263 -3600 > # Wed Dec 26 13:44:23 2018 +0100 > # Node ID 6528ebfbd28f8fc3669257404eaa4b0aa2c2a2c8 > # Parent 5479d748f59531f6669290e092a12920cbcc8349 > # EXP-Topic

Re: [PATCH 1 of 2 V2] upgrade: add '-' in optimization name

2019-01-01 Thread Yuya Nishihara
On Mon, 31 Dec 2018 16:19:23 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1531443930 -7200 > # Fri Jul 13 03:05:30 2018 +0200 > # Node ID 0713443cf6e40b7e6409cdd898d5ba22b4d02e48 > # Parent 5c68b617ba2463eb6f1372a24b139a376c6bf6bd > # EXP-Topic upgrade-test >

Re: [PATCH 6 of 7 V4] delta: have a native implementation of _findsnapshot

2019-01-01 Thread Yuya Nishihara
On Sun, 30 Dec 2018 19:43:53 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1545297320 -3600 > # Thu Dec 20 10:15:20 2018 +0100 > # Node ID a6bb015a9fb1a2c23d73f1c55e7d4160a9701191 > # Parent 5aff42c50dd1bc1e7c2e533a8e052fa42c6f9304 > # EXP-Topic sparse-revlog

Re: [PATCH 1 of 7 V4] revlog: clarify the non sparse-revlog case in `issnapshot`

2019-01-01 Thread Yuya Nishihara
On Sun, 30 Dec 2018 19:43:48 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1546182882 -3600 > # Sun Dec 30 16:14:42 2018 +0100 > # Node ID 88025ac40a127963ea8a186ae5e81f64002db39a > # Parent 88d813cd9acd56490fdac2c0b8e66c5231c63d88 > # EXP-Topic sparse-revlog

[PATCH STABLE] update: do not pass in user revspec as default destination (issue6044)

2019-01-01 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1546389664 -32400 # Wed Jan 02 09:41:04 2019 +0900 # Branch stable # Node ID 035f7a392747ac3fd720d3181e387bc42ca12845 # Parent 7542466b94e25ec658e64bd3d33105a59bebc53e update: do not pass in user revspec as default destination (issue6044)

Re: [PATCH 2 of 3] registrar: add a method to merge registrar instances

2019-01-01 Thread Yuya Nishihara
On Sun, 30 Dec 2018 22:55:08 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1546224746 18000 > # Sun Dec 30 21:52:26 2018 -0500 > # Node ID 94d4ffb62049c77f4631ae76732765b17033d2dd > # Parent a567c612e90996a1a6410c0400634447405df996 > registrar: add a

Re: [PATCH STABLE] revlog: cache delta base value under -1

2019-01-01 Thread Yuya Nishihara
On Mon, 31 Dec 2018 18:38:35 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1546182666 -3600 > # Sun Dec 30 16:11:06 2018 +0100 > # Branch stable > # Node ID 38e950b3a3bca863b5e2cabda69f5ae641d581d6 > # Parent f4113489e4d493ffb0aa6c3c58454dc7e3b82e83 > #

[Bug 6044] New: ProgrammingError with empty revspec

2019-01-01 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6044 Bug ID: 6044 Summary: ProgrammingError with empty revspec Product: Mercurial Version: default branch Hardware: PC OS: Linux Status: UNCONFIRMED Severity: