D5494: histedit: add user input to warning message on editing tagged commits

navaneeth.suresh added a comment. In https://phab.mercurial-scm.org/D5494#81855, @pulkit wrote: > Sorry for bumping on this now, can you add tests for this as follow-up? My bad. Doing that right away! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D54

[PATCH FOLLOW-UP] discovery: re-adjust a conditional wrongly changed

# HG changeset patch # User Boris Feld # Date 1547091348 -3600 # Thu Jan 10 04:35:48 2019 +0100 # Node ID 1914c8346174a7c204e5623684cbff5188a3e847 # Parent 17a1956764728e8c9dd1101573dca12523e482bb # EXP-Topic discovery-followup # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D5514: test: change test's diff generation to use mdiff for nicer output

sangeet259 updated this revision to Diff 13123. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5514?vs=13051&id=13123 REVISION DETAIL https://phab.mercurial-scm.org/D5514 AFFECTED FILES mercurial/mdiff.p

Re: [PATCH 01 of 10 V3] discovery: minor fix to some conditionals

On 06/01/2019 03:04, Yuya Nishihara wrote: > On Fri, 04 Jan 2019 23:45:20 +0100, Boris Feld wrote: >> # HG changeset patch >> # User Boris Feld >> # Date 1546620599 -3600 >> # Fri Jan 04 17:49:59 2019 +0100 >> # Node ID 562198ca3bb37b9764dfe93d56cbbf70c2bb093d >> # Parent 5c68b617ba2463eb6f1

D5547: rust-cpython: consistency in use of hg-core constructs

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While not everybody likes the `CoreLazy` and `CoreIterator` aliases, it's better not to mix them with direct references. Note: it's quite poss

D5546: rust-cpython: rustdoc improvements

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY By default, `cargo doc` builds the documentation for public constructs only, so we make public those that can. Since `cindex` is not safe, we

D5548: rust-cpython: style consistency leftovers

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In particular, during review of `LazyAncestors` bindings, most `match` statements for error conversion have been replaced by higher level meth

D5549: rust-cpython: generalised conversion function

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Because `hg::ancestors::MissingAncestors` has methods taking some `HashSet` besides `impl IntoIterator` as parameters we'll need the more gene

D5550: rust-cpython: bindings for MissingAncestors

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The exposition is rather straightforward, except for the remove_ancestors_from() method, which forces us to an inefficient conversion between

D5551: rust-cpython: using MissingAncestors from Python code

gracinet created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As precedently done with LazyAncestors on cpython.rs, we test for the presence of the 'rustext' module. For now, on Missin

Re: [PATCH FOLLOW-UP] discovery: re-adjust a conditional wrongly changed

On Thu, 10 Jan 2019 09:54:36 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1547091348 -3600 > # Thu Jan 10 04:35:48 2019 +0100 > # Node ID 1914c8346174a7c204e5623684cbff5188a3e847 > # Parent 17a1956764728e8c9dd1101573dca12523e482bb > # EXP-Topic discovery-follo

Re: [PATCH 1 of 2] phabricator: warn if unable to amend, instead of aborting after posting

On Wed, 09 Jan 2019 23:28:38 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1546719633 18000 > # Sat Jan 05 15:20:33 2019 -0500 > # Node ID 0b7c3a31e42b075b5fc1d90c85f10239d87f9e33 > # Parent 98ce494e104dca5200af6ed53d3f4ff6547962a8 > phabricator: warn if

Re: D5543: histedit: crashing with a more useful error message on empty defaultrev

Queued for stable, thanks. > +else: > +raise error.Abort('config option histedit.defaultrev can\'t be > empty') Wrapped the message with `_()`. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org

D5543: histedit: crashing with a more useful error message on empty defaultrev

yuja added a comment. Queued for stable, thanks. > +else: > +raise error.Abort('config option histedit.defaultrev can\'t be empty') Wrapped the message with `_()`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5543 To: rdamazio, durin4

D5541: histedit: drop unused constructor arguments (API)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa3a24ad10efb: histedit: drop unused constructor arguments (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5541?vs=13

D5542: histedit: use context manager for locks

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9365b8cb90e0: histedit: use context manager for locks (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5542?vs=13119&id=131

D5543: histedit: crashing with a more useful error message on empty defaultrev

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfbd168455b26: histedit: crashing with a more useful error message on empty defaultrev (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5543?vs=13120&id=131

Re: [PATCH 07 of 10 V3] discovery: add a `iscomplete` method to the `partialdiscovery` object

On Fri, 04 Jan 2019 23:45:26 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1545964783 -3600 > # Fri Dec 28 03:39:43 2018 +0100 > # Node ID 337d8bcf6807c2e0c21771851fe960218c1a9fd2 > # Parent b9f78a736cf666a008de914ab30ff84c4a9c973e > # EXP-Topic discovery-refac

Re: [PATCH] extdiff: add --mode option

On Thu, 03 Jan 2019 13:03:49 -0800, Ludovic Chabant wrote: > # HG changeset patch > # User Ludovic Chabant > # Date 1546539395 28800 > # Thu Jan 03 10:16:35 2019 -0800 > # Node ID cc964d5d3e3faca1bbbc680732c38cf785754fc2 > # Parent 5a2a6ab7bc37af9294b58edfd4d224706940ff19 > extdiff: add --mo

D5552: tests: add test for warning on histedit with tagged commits

navaneeth.suresh created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a follow-up patch to https://phab.mercurial-scm.org/D5494. REPOSITORY rHG Mercurial REVISION DETAIL https://

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh added a comment. > Could you add a test? > > (Bonus points if you add a test that shows the wrong behavior and then fix it in this change.) Sure. Will do. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490 To: navaneeth.suresh, #hg-r

Re: D5495: revset: add "branch" positional arguments to the merge revset

> I think it would be a good idea to make the "branch" arguments more > flexible. One option could be to use a stringmatcher to add support for > regular expressions as you suggest. I can look into that. However there may > be some other options worth exploring. The one you suggest is very >

D5495: revset: add "branch" positional arguments to the merge revset

yuja added a comment. > I think it would be a good idea to make the "branch" arguments more flexible. One option could be to use a stringmatcher to add support for regular expressions as you suggest. I can look into that. However there may be some other options worth exploring. The one you

[PATCH] cext: clang-format new code coming from stable branch

# HG changeset patch # User Yuya Nishihara # Date 1547123364 -32400 # Thu Jan 10 21:29:24 2019 +0900 # Node ID 33b5a23d3b3b5a8fed27e34987bbef9749e84dd7 # Parent 3dcc96582627ac701b730cf09a3bc967768a5dbe cext: clang-format new code coming from stable branch diff --git a/mercurial/cext/revlog.

[PATCH 1 of 2] amend: turn currentdate into tri-state bool so config option can be negated

# HG changeset patch # User Yuya Nishihara # Date 1547123557 -32400 # Thu Jan 10 21:32:37 2019 +0900 # Node ID d954358f5b9e810fadf9171d9724d99950b3358a # Parent 33b5a23d3b3b5a8fed27e34987bbef9749e84dd7 amend: turn currentdate into tri-state bool so config option can be negated Otherwise, re

[PATCH 2 of 2] graft: abort if --date/user specified with --currentdate/currentuser (BC)

# HG changeset patch # User Yuya Nishihara # Date 1547125041 -32400 # Thu Jan 10 21:57:21 2019 +0900 # Node ID 25fbe864cf9e28de2c9c52cb9d7aa22c327be3ec # Parent d954358f5b9e810fadf9171d9724d99950b3358a graft: abort if --date/user specified with --currentdate/currentuser (BC) They are confli

Re: [PATCH 1 of 2] amend: turn currentdate into tri-state bool so config option can be negated

On Thu, Jan 10, 2019 at 7:24 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1547123557 -32400 > # Thu Jan 10 21:32:37 2019 +0900 > # Node ID d954358f5b9e810fadf9171d9724d99950b3358a > # Parent 33b5a23d3b3b5a8fed27e34987bbef9749e84dd7 > amend: turn currentd

Re: [PATCH 1 of 2] amend: turn currentdate into tri-state bool so config option can be negated

On Thu, Jan 10, 2019 at 7:43 PM Pulkit Goyal <7895pul...@gmail.com> wrote: > > > On Thu, Jan 10, 2019 at 7:24 PM Yuya Nishihara wrote: > >> # HG changeset patch >> # User Yuya Nishihara >> # Date 1547123557 -32400 >> # Thu Jan 10 21:32:37 2019 +0900 >> # Node ID d954358f5b9e810fadf9171d9724

D5514: test: change test's diff generation to use mdiff for nicer output

durin42 added inline comments. INLINE COMMENTS > mdiff.py:554 > + > +def new_diff(expected, output, ref, err): > +exp, date1, out, date2, opts = prepare_mdiff(expected, output) At least add a docstring taht explains this is designed to be a similar API to `difflib.unified_diff`? > run-test

D5553: fuzz: stop building Python in the Makefile

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY $OUT/sanpy is now built by the build.sh in oss-fuzz, which simplifies the setup here considerably. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.merc

D5540: histedit: fix --continue and --abort when curses is enabled

durin42 updated this revision to Diff 13136. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5540?vs=13112&id=13136 REVISION DETAIL https://phab.mercurial-scm.org/D5540 AFFECTED FILES hgext/histedit.py tests/test-histedit-non-commute.t CHANGE DETAIL

D5554: histedit: added rewrite.update-timestamp to fold and mess

taapas1128 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5554 AFFECTED FILES hgext/histedit.py tests/test-histedit-fold.t

D5554: histedit: added rewrite.update-timestamp to fold and mess

taapas1128 added a subscriber: pulkit. taapas1128 added a comment. @pulkit please review. I will add a `test-histedit-mess.t` if required. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5554 To: taapas1128, durin42, #hg-reviewers Cc: pulkit, mercurial-devel

D5554: histedit: added rewrite.update-timestamp to fold and mess

taapas1128 updated this revision to Diff 13138. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5554?vs=13137&id=13138 REVISION DETAIL https://phab.mercurial-scm.org/D5554 AFFECTED FILES hgext/histedit.py tests/test-histedit-edit.t tests/test-histe

Re: [PATCH 4 of 4] mmapindex: set default to 1MB

On 08/01/2019 15:41, Yuya Nishihara wrote: > On Mon, 7 Jan 2019 09:45:32 +0100, Boris FELD wrote: >> On 03/01/2019 09:58, Yuya Nishihara wrote: >>> On Wed, 2 Jan 2019 23:40:11 +0100, Boris FELD wrote: On 04/12/2018 12:09, Yuya Nishihara wrote: > On Sun, 02 Dec 2018 17:17:43 +0100, Boris Fe

Re: 4.9-rc0 coming up - prepare accordingly

Hello, there is a couple of things we would like to conclude before the 4.9 freeze. We have a few series about the performance of computation in discovery (a refactoring, a %ld revset performance fix, some better written revsets and some Rust code). We have also the mmap feature discussion that w

Re: [PATCH 6 of 7] strip: introduce a soft strip option

On 07/01/2019 22:19, Augie Fackler wrote: > > >> On Jan 4, 2019, at 08:09, Pulkit Goyal <7895pul...@gmail.com >> > wrote: >> >> >> >> On Fri, Jan 4, 2019 at 4:31 AM Augie Fackler > > wrote: >> >> >> >> > On Jan 3, 2019, at 10:23 AM, Pulkit

Re: 4.9-rc0 coming up - prepare accordingly

On Thu, Jan 10, 2019 at 10:41 PM Boris FELD wrote: > Hello, there is a couple of things we would like to conclude before the > 4.9 freeze. > > We have a few series about the performance of computation in discovery (a > refactoring, a %ld revset performance fix, some better written revsets and > s

D5555: py3: add a test to whitelist caught by buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist b/

D5540: histedit: fix --continue and --abort when curses is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9bc7ec924234: histedit: fix --continue and --abort when curses is enabled (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D554

Re: [PATCH 6 of 7] strip: introduce a soft strip option

> On Jan 10, 2019, at 12:24, Boris FELD wrote: > > > > On 07/01/2019 22:19, Augie Fackler wrote: >> >> >>> On Jan 4, 2019, at 08:09, Pulkit Goyal <7895pul...@gmail.com> wrote: >>> >>> >>> >>> On Fri, Jan 4, 2019 at 4:31 AM Augie Fackler wrote: >>> >>> >>> > On Jan 3, 2019, at 10:23 AM

Re: Auto-formatting with yapf (was: Re: Auto-formatting code with black - object now if you have a strong opinion)

> On Jan 10, 2019, at 00:14, Matt Harbison wrote: > > On Wed, 09 Jan 2019 15:30:19 -0500, Augie Fackler wrote: > >> >> >>> On Dec 6, 2018, at 23:21, Matt Harbison wrote: >>> >>> On Wed, 05 Dec 2018 08:23:17 -0500, Yuya Nishihara wrote: >>> On Tue, 4 Dec 2018 10:06:24 -0500, Augie F

D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead

pulkit added a comment. This one removes clearbackup() while restorebackup() and savebackup() are still there. Does that means that we are sure that we won't need to manually clear the backup from store? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5504 To:

D5505: narrow: include working copy narrowspec in transaction journal

pulkit added inline comments. INLINE COMMENTS > narrowspec.py:193 > vfs.tryunlink(backupname) > -util.copyfile(vfs.join(DIRSTATE_FILENAME), vfs.join(backupname), > - hardlink=True) > +# It may not exist in old repos > +if vfs.exists(DIRSTATE_FILENAME): This chan

D5515: narrow: drop explicit dirstate write

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4475322b7533: narrow: drop explicit dirstate write (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5515?vs=13052&id=13141

Re: [PATCH 05 of 10 V3] discovery: move undecided set on the partialdiscovery

On Fri, Jan 4, 2019 at 2:54 PM Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1545963817 -3600 > # Fri Dec 28 03:23:37 2018 +0100 > # Node ID 944c2173a32073584a22f8de8c0e348245065c1e > # Parent f3c439000eb772272745c344f5257f3ecce369c0 > # EXP-Topic discovery-refactor

mercurial@41146: new changeset (1 on stable)

New changeset (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/fbd168455b26 changeset: 41146:fbd168455b26 branch: stable tag: tip parent: 41128:f467c353298c user:rdama...@google.com date:Wed Jan 09 20:00:35 2019 -0800 summary: histedit:

D5512: narrow: use merge.ACTION_GET instead of duplicating 'g' constant

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5838afea8213: narrow: use merge.ACTION_GET instead of duplicating 'g' constant (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.

D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead

martinvonz added a comment. In https://phab.mercurial-scm.org/D5504#82068, @pulkit wrote: > This one removes clearbackup() while restorebackup() and savebackup() are still there. Does that means that we are sure that we won't need to manually clear the backup from store? Good que

D5556: narrow: include journal.narrowspec in transaction journal

martinvonz created this revision. Herald added a reviewer: durin42. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We had missed this file before, which led to it lying around after the transaction completed. REPOSITORY rHG Merc

D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead

martinvonz updated this revision to Diff 13144. martinvonz edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5504?vs=13053&id=13144 REVISION DETAIL https://phab.mercurial-scm.org/D5504 AFFECTED FILES mercurial/dirstat

D5505: narrow: include working copy narrowspec in transaction journal

martinvonz updated this revision to Diff 13145. martinvonz marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5505?vs=13054&id=13145 REVISION DETAIL https://phab.mercurial-scm.org/D5505 AFFECTED FILES mercurial/localrepo.

D5507: narrow: drop now-unnecessary reassignment of repo attributes

martinvonz updated this revision to Diff 13147. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5507?vs=13056&id=13147 REVISION DETAIL https://phab.mercurial-scm.org/D5507 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git a/mercurial/lo

D5508: narrow: extract repo property for store narrowmatcher

martinvonz updated this revision to Diff 13148. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5508?vs=13057&id=13148 REVISION DETAIL https://phab.mercurial-scm.org/D5508 AFFECTED FILES hgext/lfs/__init__.py mercurial/localrepo.py CHANGE DETAILS d

D5511: narrow: reuse narrowspec.updateworkingcopy() when narrowing

martinvonz updated this revision to Diff 13150. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5511?vs=13060&id=13150 REVISION DETAIL https://phab.mercurial-scm.org/D5511 AFFECTED FILES hgext/narrow/narrowcommands.py mercurial/narrowspec.py CHANGE

D5506: narrow: copy store narrowspec to working copy immediately

martinvonz updated this revision to Diff 13146. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5506?vs=13055&id=13146 REVISION DETAIL https://phab.mercurial-scm.org/D5506 AFFECTED FILES hgext/narrow/narrowcommands.py mercurial/hg.py mercurial/loca

D5505: narrow: include working copy narrowspec in transaction journal

martinvonz added a comment. Addressed comment REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5505 To: martinvonz, #hg-reviewers Cc: pulkit, mjpieters, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@me

D5509: narrow: move copytonarrowspec() out of setnarrowpats()

martinvonz updated this revision to Diff 13149. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5509?vs=13058&id=13149 REVISION DETAIL https://phab.mercurial-scm.org/D5509 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/narrowcommands.py

D5557: testrunner: make `-j100 --runs-per-test=100 test-foo.t` use 100 jobs

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It would use only 1 job since https://phab.mercurial-scm.org/rHG1039404c5e1d12f7ee3b09eedde803f52f8b369a (run-tests: print number of tests and parallel proces

D5557: testrunner: make `-j100 --runs-per-test=100 test-foo.t` use 100 jobs

martinvonz added a comment. Could you please include a test case? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5557 To: martinvonz, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@m

D5557: testrunner: make `-j100 --runs-per-test=100 test-foo.t` use 100 jobs

martinvonz updated this revision to Diff 13152. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5557?vs=13151&id=13152 REVISION DETAIL https://phab.mercurial-scm.org/D5557 AFFECTED FILES tests/run-tests.py tests/test-run-tests.t CHANGE DETAILS diff

D5557: testrunner: make `-j100 --runs-per-test=100 test-foo.t` use 100 jobs

martinvonz added a comment. In https://phab.mercurial-scm.org/D5557#82106, @martinvonz wrote: > Could you please include a test case? Done. Also made it print the number of test runs, not number of distinct tests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercuri

[PATCH 1 of 2] convert: add missing numcommits() override to hg sources

# HG changeset patch # User Matt Harbison # Date 1547062386 18000 # Wed Jan 09 14:33:06 2019 -0500 # Branch stable # Node ID 60e7f0c9b572f995b0d196f6b946001f148d576f # Parent fbd5e2f0bba7661f6f09e6cfd2bc2ffd07559a41 convert: add missing numcommits() override to hg sources Otherwise, the pro

[PATCH 2 of 2] convert: don't drop commits that are empty in the source when using --filemap

# HG changeset patch # User Matt Harbison # Date 1547067725 18000 # Wed Jan 09 16:02:05 2019 -0500 # Branch stable # Node ID 1f267b001e4588edd3873a9039be7679f08c7560 # Parent 60e7f0c9b572f995b0d196f6b946001f148d576f convert: don't drop commits that are empty in the source when using --filema

Re: [PATCH] extdiff: add --mode option

> Sorry for late review. Almost all devs were inactive while holidays. No worries! Between the holidays and the 4.8.2 release, I figured unsolicited new features were a low priority. > First, can you break this into a series of a few patches? > > https://www.mercurial-scm.org/wiki/Contributing

Re: [PATCH 4 of 4] mmapindex: set default to 1MB

On Thu, Jan 10, 2019 at 9:03 AM Boris FELD wrote: > On 08/01/2019 15:41, Yuya Nishihara wrote: > > On Mon, 7 Jan 2019 09:45:32 +0100, Boris FELD wrote: > >> On 03/01/2019 09:58, Yuya Nishihara wrote: > >>> On Wed, 2 Jan 2019 23:40:11 +0100, Boris FELD wrote: > On 04/12/2018 12:09, Yuya Nishi

D5557: testrunner: make `-j100 --runs-per-test=100 test-foo.t` use 100 jobs

This revision was automatically updated to reflect the committed changes. Closed by commit rHG53327bfbf35d: testrunner: make `-j100 --runs-per-test=100 test-foo.t` use 100 jobs (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-

D5557: testrunner: make `-j100 --runs-per-test=100 test-foo.t` use 100 jobs

indygreg added a comment. For the record, I enjoyed @martinvonz conversing with himself on this review! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5557 To: martinvonz, #hg-reviewers Cc: indygreg, mercurial-devel __

D5558: internals: minor rewriting of revlogs documentation

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In preparation for formalizing revlog version 2. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5558 AFFECTED FILES mercurial/hel

D5559: revlog: always process opener options

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not sure when ``opener.options`` would ever be explicitly set to None. It is definitely not possible to construct a repo this way because ``localrepo.resolv

D5560: revlog: rename v to versionflags

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Single letter variables are harder to read. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5560 AFFECTED FILES mercurial/revlog.p

D5562: revlog: store mmaplargeindex as an instance attribute

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes it more consistent with everything else. It also makes it possible to move the opener/features processing into _loadindex(). REPOSITORY rHG Mercur

D5563: revlog: inline opener options logic into _loadindex()

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We always call _loadindex() during __init__. But we also call _loadindex() as part of censorrevision(). Before, when reloading the index during censorrevision()

D5564: revlog: use separate variables to track version flags

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It wasn't obvious to me that "versionflags" is used both to define the default version+features value for new revlogs and to track the value read from a revlog.

D5561: revlog: always enable generaldelta on version 2 revlogs

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit starts the process of diverging version 2 revlogs from version 1 revlogs. generaldelta is a useful feature and has been enabled by default for

D5567: revlog: assign revlog._io in version lookup conditional

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A single version lookup is desirable. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5567 AFFECTED FILES mercurial/revlog.py CHA

D5566: revlog: rename revlog I/O classes to reflect version (API)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I never liked these names. They imply the existence of exactly 2 revlog versions. We're hacking on version 2. So let's introduce better names. REPOSITORY rHG

D5565: revlog: add version 2 format flag to control sparse

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Revlog behavior should live as close to the revlog as possible. In version 1 revlogs, we engaged sparse semantics by using a repository requirement. This consti

D5568: tests: de-flake test-narrow-share.t by making dirstate predictable

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY test-narrow-share.t was sometimes (~0.5% on my machine) failing like this: @@ -61,7 +61,7 @@ A d3/g $ hg -R

[Bug 6051] New: Color on stderr falls back to ANSI on Windows with stdout redirected to N

https://bz.mercurial-scm.org/show_bug.cgi?id=6051 Bug ID: 6051 Summary: Color on stderr falls back to ANSI on Windows with stdout redirected to N Product: Mercurial Version: 4.8.1 Hardware: PC OS: Windows

D5569: tests: make HGCATAPULTSERVERPIPE imply HGTESTCATAPULTSERVERPIPE

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I had attempted to do this before, but missed this case. This makes it so that one can do the following to get catapult traces that include both the .t test nam

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh updated this revision to Diff 13166. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5490?vs=13003&id=13166 REVISION DETAIL https://phab.mercurial-scm.org/D5490 AFFECTED FILES mercurial/cmdutil.py tests/test-commit-interactive.t CHA

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh added a comment. @durin42 I've added test for the current revision. Unfortunately, I'm unable to write a test for the wrong behaviour. I'll try writing it again. Any hints from your side? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490 To

Re: Auto-formatting with yapf (was: Re: Auto-formatting code with black - object now if you have a strong opinion)

On Thu, 10 Jan 2019 13:51:12 -0500, Augie Fackler wrote: On Jan 10, 2019, at 00:14, Matt Harbison wrote: On Wed, 09 Jan 2019 15:30:19 -0500, Augie Fackler wrote: On Dec 6, 2018, at 23:21, Matt Harbison wrote: On Wed, 05 Dec 2018 08:23:17 -0500, Yuya Nishihara wrote: On Tue

[PATCH 1 of 2 V2] extdiff: move external tool command line building into separate function

# HG changeset patch # User Ludovic Chabant # Date 1547180523 28800 # Thu Jan 10 20:22:03 2019 -0800 # Node ID ef0e2f7224358c32b0f62b13e83e89ba2399c8cf # Parent e546c124217485f54b897d050a9573fc4ab97ab7 extdiff: move external tool command line building into separate function diff --git a/hge

[PATCH 2 of 2 V2] extdiff: add --mode option

# HG changeset patch # User Ludovic Chabant # Date 1547180577 28800 # Thu Jan 10 20:22:57 2019 -0800 # Node ID dfda7867497e5609a03727508dc0da2cab3218a3 # Parent ef0e2f7224358c32b0f62b13e83e89ba2399c8cf extdiff: add --mode option The new option lets the user control how the external program

[Bug 6052] New: Merge with large number of changes corrupts repository

https://bz.mercurial-scm.org/show_bug.cgi?id=6052 Bug ID: 6052 Summary: Merge with large number of changes corrupts repository Product: Mercurial Version: 4.8.1 Hardware: PC OS: Windows Status: UNCONFIRMED