D5890: diffordiffstat: avoid looking up contexts twice

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not worried about performance; this is just simpler. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5890 AFFECTED FILES

D5889: context: replace repeated "self._repo.dirstate" by "ds" variable

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5889 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py

D5888: context: delete unused undelete()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Maybe it's been unused since https://phab.mercurial-scm.org/rHGc8e2a5ea70629eae96cbd08264df46c1868ce4a5 (mq: avoid data loss upon qfold + qmv (issue3058),

D5638: branchmap: encapsulate cache updating in the map itself

martinvonz added a comment. In https://phab.mercurial-scm.org/D5638#86131, @pulkit wrote: > This looks good to me. @martinvonz do you have any concerns? Yes, looks good. Sorry, I thought this had already been queued. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH] py3: manually replace `None` with 'None' in ui.log() arguments

# HG changeset patch # User Matt Harbison # Date 1549312475 18000 # Mon Feb 04 15:34:35 2019 -0500 # Node ID b6bdc25edf05318a4571b4f34a741754f5052567 # Parent a263b7d71105414c9a1234414747533ce904ba39 py3: manually replace `None` with 'None' in ui.log() arguments Pushing to a real server

D5638: branchmap: encapsulate cache updating in the map itself

pulkit added a comment. This looks good to me. @martinvonz do you have any concerns? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5638 To: mjpieters, #hg-reviewers Cc: pulkit, martinvonz, mercurial-devel ___

D5877: tests: fix regression tests failing on CentOS 7

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf2f538725d07: tests: fix regression tests failing on CentOS 7 (authored by Mathias De Mare mathias.de_m...@nokia.com, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5876: packaging: modify rc detection to work with X.Yrc instead of X.Y-rc

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8f0e8b179842: packaging: modify rc detection to work with X.Yrc instead of X.Y-rc (authored by Mathias De Mare mathias.de_m...@nokia.com, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST

D5792: uncommit: added interactive mode(issue6062)

taapas1128 added a comment. @pulkit I have added some inline comments . So what do you suggest one way can be merging this and I will send a follow up for integrating `-n` to `hg uncommit`and then amending the tests. The other way is I should send a request for `-n` flag and then make all

D5813: revset: add expect to check the size of a set

navaneeth.suresh added a comment. @yuja I've updated the revision with the suggested changes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5813 To: navaneeth.suresh, #hg-reviewers Cc: yuja, pulkit, durin42, mjpieters, mercurial-devel

[PATCH] convert: handle exec bit removal while converting to svn

# HG changeset patch # User Nikita Slyusarev # Date 1549565330 -10800 # Thu Feb 07 21:48:50 2019 +0300 # Node ID afd7bd1378b43b306567245ac0e394c4432e944d # Parent 286eeed148932d53eab7193c8e5deda39f9131f9 convert: handle exec bit removal while converting to svn Subversion `putcommit` method

D5813: revset: add expect to check the size of a set

navaneeth.suresh updated this revision to Diff 13899. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5813?vs=13851=13899 REVISION DETAIL https://phab.mercurial-scm.org/D5813 AFFECTED FILES mercurial/revset.py tests/test-revset.t CHANGE DETAILS

D5887: subrepo: adjust subrepo prefix before calling subrepo.archive() (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5887 AFFECTED FILES hgext/largefiles/overrides.py mercurial/archival.py mercurial/subrepo.py

D5886: subrepo: adjust subrepo prefix before calling subrepo.diff() (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5886 AFFECTED FILES mercurial/logcmdutil.py mercurial/subrepo.py CHANGE DETAILS diff --git

D5884: subrepo: adjust subrepo prefix before calling subrepo.add() (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5884 AFFECTED FILES mercurial/cmdutil.py mercurial/subrepo.py CHANGE DETAILS diff --git

D5885: subrepo: adjust subrepo prefix before calling subrepo.addremove() (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5885 AFFECTED FILES mercurial/scmutil.py mercurial/subrepo.py CHANGE DETAILS diff --git

D5882: subrepo: adjust subrepo prefix before calling subrepo.removefiles() (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY That's what we do with the matcher so it seems more consistent. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5882 AFFECTED

D5881: subrepo: avoid calculating subrepo prefix twice for cat() (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5881 AFFECTED FILES mercurial/cmdutil.py CHANGE DETAILS diff --git a/mercurial/cmdutil.py

[PATCH] convert: handle empty intial commits while converting to svn

# HG changeset patch # User Nikita Slyusarev # Date 1549555074 -10800 # Thu Feb 07 18:57:54 2019 +0300 # Node ID bde6d4eed3104a49c9d4558907d1af4af8718ba1 # Parent 67e622ade4155d89270ec7ce6928f5645317a5c1 convert: handle empty intial commits while converting to svn Svn commit generation

mercurial@41598: 16 new changesets (1 on stable)

16 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/87a6e3c953e0 changeset: 41583:87a6e3c953e0 branch: stable parent: 41460:8b2892d5a9f2 user:Matt Harbison date:Tue Feb 05 20:50:54 2019 -0500 summary: subrepo: avoid false unsafe

D5792: uncommit: added interactive mode(issue6062)

pulkit added a comment. In https://phab.mercurial-scm.org/D5792#85236, @taapas1128 wrote: > @pulkit I was able to import the tests and make them compatible with `hg-stable` . Some tests which include commands like `hg obslog` , `hg amend --extract` , and `hg uncommit -n` which are not

D5880: fsmonitor: rename new verbose config knob

This revision was automatically updated to reflect the committed changes. Closed by commit rHG286eeed14893: fsmonitor: rename new verbose config knob (authored by lothiraldan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5880?vs=13890=13891#toc REPOSITORY rHG

D5880: fsmonitor: rename new verbose config knob

pulkit added a comment. I am unable to find any docs for this config option, can you add them as a follow-up? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5880 To: lothiraldan, #hg-reviewers, pulkit Cc: pulkit, mjpieters, mercurial-devel

D5880: fsmonitor: rename new verbose config knob

pulkit accepted this revision. pulkit added inline comments. INLINE COMMENTS > __init__.py:178 > if isinstance(ex, watchmanclient.Unavailable): > # experimental config: hgwatchman.verbose > +if ex.warn and ui.configbool('fsmonitor', 'verbose'): will change this one also in

D5880: fsmonitor: rename new verbose config knob

lothiraldan added a comment. Nice catch, sorry for the hasty phabsend REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5880 To: lothiraldan, #hg-reviewers Cc: pulkit, mjpieters, mercurial-devel ___ Mercurial-devel

D5880: fsmonitor: rename new verbose config knob

lothiraldan updated this revision to Diff 13890. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5880?vs=13889=13890 REVISION DETAIL https://phab.mercurial-scm.org/D5880 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh abandoned this revision. navaneeth.suresh added a comment. https://phab.mercurial-scm.org/rHG66399f2e92aac38855caab69a4c0acafead90c91 solves this issue, many thanks @spectral. Closing this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490

[Bug 6074] New: ✨ :sparkles: Support for emojis in commit messages

https://bz.mercurial-scm.org/show_bug.cgi?id=6074 Bug ID: 6074 Summary: ✨ :sparkles: Support for emojis in commit messages Product: Mercurial Version: 4.8.1 Hardware: PC OS: Linux Status: UNCONFIRMED

D5880: fsmonitor: rename new verbose config knob

pulkit added a comment. Looks like you missed updating the users of this config. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5880 To: lothiraldan, #hg-reviewers Cc: pulkit, mjpieters, mercurial-devel ___

D5880: fsmonitor: rename new verbose config knob

lothiraldan created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The config knob was introduced in this release cycle under the old extension name, rename it before it is part of a release. REPOSITORY rHG

D5855: mq: migrate to scmutil.backuppath()

martinvonz added a comment. In https://phab.mercurial-scm.org/D5855#86040, @martinvonz wrote: > In https://phab.mercurial-scm.org/D5855#86020, @yuja wrote: > > > > - absorig = scmutil.origpath(self.ui, repo, absf) + absorig = scmutil.backuppath(self.ui, repo, f)

D5855: mq: migrate to scmutil.backuppath()

martinvonz added a comment. In https://phab.mercurial-scm.org/D5855#86020, @yuja wrote: > > - absorig = scmutil.origpath(self.ui, repo, absf) + absorig = scmutil.backuppath(self.ui, repo, f) self.ui.note(_('saving current version of %s as %s\n') % > > - (f,

D5878: py3: make sure __repr__ returns str

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY No test fails but I found it while debugging test-commit-interactive-curses.t failure. 1. skip-blame because just r'' prefix REPOSITORY rHG Mercurial

mercurial@41582: 18 new changesets

18 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/bf7fb97aecf1 changeset: 41565:bf7fb97aecf1 user:Martijn Pieters date:Mon Jan 21 16:04:48 2019 + summary: branchmap: make branchcache responsible for reading

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

yuja added a comment. > @spectral @yuja Can I close this? Probably yes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490 To: navaneeth.suresh, #hg-reviewers Cc: spectral, yuja, durin42, pulkit, mercurial-devel

Re: D5490: commit: remove ignore whitespace option on --interactive (issue6042)

> @spectral @yuja Can I close this? Probably yes. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D5855: mq: migrate to scmutil.backuppath()

yuja added a comment. > - absorig = scmutil.origpath(self.ui, repo, absf) +absorig = scmutil.backuppath(self.ui, repo, f) self.ui.note(_('saving current version of %s as %s\n') % > - (f, os.path.relpath(absorig))) + (f, os.path.relpath(absorig,

Re: D5855: mq: migrate to scmutil.backuppath()

> -absorig = scmutil.origpath(self.ui, repo, absf) > +absorig = scmutil.backuppath(self.ui, repo, f) > self.ui.note(_('saving current version of %s as %s\n') % > - (f, os.path.relpath(absorig))) > +

Re: [PATCH 1 of 2] lfs: disable all authentication except Basic for HTTP(S) connections

On Wed, 06 Feb 2019 23:49:49 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1549510249 18000 > # Wed Feb 06 22:30:49 2019 -0500 > # Node ID 847900c2b99e6659cc50353ddab4f980905675c4 > # Parent 349c8879becd13143db74894490299b56524d1e1 > lfs: disable all

Re: [PATCH STABLE] subrepo: avoid false unsafe path detection on Windows

On Wed, 06 Feb 2019 23:16:43 -0500, Matt Harbison wrote: > On Wed, 06 Feb 2019 06:54:02 -0500, Yuya Nishihara wrote: > > On Tue, 05 Feb 2019 21:04:00 -0500, Matt Harbison wrote: > >> # HG changeset patch > >> # User Matt Harbison > >> # Date 1549417854 18000 > >> # Tue Feb 05 20:50:54 2019

Re: [PATCH V2 STABLE] subrepo: avoid false unsafe path detection on Windows

On Thu, 07 Feb 2019 00:03:53 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1549417854 18000 > # Tue Feb 05 20:50:54 2019 -0500 > # Branch stable > # Node ID 75d70ffee2f9fb710f58d5552b319514ece459f9 > # Parent 8b2892d5a9f2c06c998c977015a9ad3e3a3c9b5f >

D5877: tests: fix regression tests failing on CentOS 7

Mathiasdm created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5877 AFFECTED FILES tests/test-clonebundles.t tests/test-http-proxy.t

D5876: packaging: modify rc detection to work with X.Yrc instead of X.Y-rc

Mathiasdm created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY rc detection on CentOS failed without this change, resulting in upgrades from 4.9rc to 4.9 not working (4.9rc was considered more recent than 4.9).

Re: rc naming convention

On Wed, Feb 6, 2019 at 5:08 PM Augie Fackler wrote: > > > > On Feb 6, 2019, at 04:47, Mathias De Maré > wrote: > > > > Hello all, > > > > The CentOS RPMs think 4.9rc0 is more recent than 4.9 (which is somewhat > annoying). > > I noticed there is some code in contrib/packaging/packagelib.sh to >