taapas1128 added a comment.
@pulkit Can you please review this . I did not send a patch regarding `-n`
flag because tests could be completed without it and also it would mean i would
have to import large chunks of code.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5949#86909, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D5949#86908, @JordiGH wrote:
>
> > So, I haven't been here in a while. Do we still do V2s for this kind of
thing?
>
>
> Often fixed in n flight. I'll
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5949#86908, @JordiGH wrote:
> So, I haven't been here in a while. Do we still do V2s for this kind of
thing?
Often fixed in n flight. I'll still fix it later tonight if I remember.
REPOSITORY
rHG Mercurial
REVISION
JordiGH added a comment.
So, I haven't been here in a while. Do we still do V2s for this kind of thing?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5949
To: martinvonz, #hg-reviewers
Cc: JordiGH, mercurial-devel
___
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5949#86905, @JordiGH wrote:
> > fix typo in synpsis
> > in synpsis
> > synpsis
>
> https://en.wikipedia.org/wiki/Muphry%27s_law
Heh, I initially typo'ed "typo" as "typy", but I noticed that one. Impressive
tha
JordiGH added a comment.
> fix typo in synpsis
> in synpsis
> synpsis
https://en.wikipedia.org/wiki/Muphry%27s_law
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5949
To: martinvonz, #hg-reviewers
Cc: JordiGH, mercurial-devel
__
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, proxies didn't work on Python 3 for various reasons.
First, the keys to the "proxies" dict are fed into a
`setattr(self, "%s_open", ...)` call an
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There were various str/bytes mismatches in the code. This caused
the proxy server to misbehave at run-time. The manifestation
was typically premature socket dis
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The getattr() was there to handle Python versions before 2.6, which
lacked this attribute.
We /might/ be able to further delete some code here. However, the
# HG changeset patch
# User Jordi Gutiérrez Hermoso
# Date 1550009431 18000
# Tue Feb 12 17:10:31 2019 -0500
# Node ID 06f76b4009c4802a48abc184984d0eebc7d7d91e
# Parent 61415361e90684a8c7a031413e9182f51937c2e7
walkchangerevs: obey allfiles parameter when taking the slow path
When walkchange
kevincox added inline comments.
INLINE COMMENTS
> gracinet wrote in ancestors.rs:41
> I must confess to have hesitated a bit on that one. On one hand, it would
> work, but semantically if ever a new "special" revision -2 is introduced,
> this could become problematic. On the other hand, there a
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5949
AFFECTED FILES
mercurial/debugcommands.py
CHANGE DETAILS
diff --git a/mercurial/debugcommands
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I don't see a reason that it needs to require a path. Most commands
match everything when no paths are given, but here you have to do
something like `hg debug
akshjain.jain74 updated this revision to Diff 14050.
akshjain.jain74 retitled this revision from "config.txt: Add better
documentation for ui.tweakdefault
(issue6000)" to "tweakdefault: Add better documentation for ui.tweakdefault
(issue6000)".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDAT
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Otherwise we iterate over integers in Python 3 and the
character compare fails.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D594
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1ab6f5df263e: test: stabilize test-wireproto-exchangev2.t
flaky output (authored by lothiraldan, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D58
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
hgweb has the (undocument) configuration option web.view that allows
restricting visible revisions to immutable. This is useful for serving
the same s
gracinet added inline comments.
INLINE COMMENTS
> kevincox wrote in ancestors.rs:41
> Does it make sense to just default this to -1 and remove the option?
I must confess to have hesitated a bit on that one. On one hand, it would work,
but semantically if ever a new "special" revision -2 is intr
gracinet updated this revision to Diff 14046.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5945?vs=14042&id=14046
REVISION DETAIL
https://phab.mercurial-scm.org/D5945
AFFECTED FILES
rust/hg-core/src/ancestors.rs
rust/hg-core/src/dagops.rs
CHANGE
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/61415361e906
changeset: 41681:61415361e906
bookmark:@
tag: tip
user:Kyle Lippincott
date:Mon Feb 04 14:29:03 2019 -0800
summary: zsh: fix `hg resolve` completion when in a subdirectory (issue60
https://bz.mercurial-scm.org/show_bug.cgi?id=6077
Bug ID: 6077
Summary: Traceback in hg fix: TypeError: argument of type
'NoneType' is not iterable
Product: Mercurial
Version: 4.9
Hardware: PC
OS: Linux
kevincox accepted this revision.
kevincox added inline comments.
INLINE COMMENTS
> ancestors.rs:41
> bases: HashSet,
> +max_base: Option,
> }
Does it make sense to just default this to -1 and remove the option?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.o
kevincox accepted this revision.
kevincox added inline comments.
INLINE COMMENTS
> ancestors.rs:245
> self.bases.extend(new_bases);
> +self.bases.remove(&NULL_REVISION);
> }
I think it would be more clear if you filtered the NULL_REVISION out before
extending the set.
l
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG61415361e906: zsh: fix `hg resolve` completion when in a
subdirectory (issue6067) (authored by spectral, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5836?vs=13763&id=14045#t
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/8185c8abce87
changeset: 41680:8185c8abce87
bookmark:@
tag: tip
user:Navaneeth Suresh
date:Sun Feb 03 19:10:39 2019 +0530
summary: revset: add expectsize to check the size of a set
--
Reposito
gracinet added a comment.
@yuja I'm trying to find a compromise between our points of view : I'd like
very much it to be run automatically (hence an integration test), and you want
to be parametrizable. So, I'm pushing a version that has these two properties,
working with env variables, sinc
gracinet updated this revision to Diff 14044.
gracinet edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5417?vs=12856&id=14044
REVISION DETAIL
https://phab.mercurial-scm.org/D5417
AFFECTED FILES
rust/Cargo.lock
rus
pulkit added subscribers: av6, pulkit.
pulkit accepted this revision.
pulkit added a comment.
Queued as per @av6 review.
INLINE COMMENTS
> zsh_completion:251
>
> - _hg_cmd resolve -l ./$PREFIX | while read rstate rpath
> + _hg_cmd resolve -l ./$PREFIX -T'{mergestatus}\ {relpath\(path\)}\\
pulkit added inline comments.
INLINE COMMENTS
> revset.py:866
> +def expectsize(repo, subset, x, order):
> +"""Abort if the revset doesn't expect given size"""
> +args = getargsdict(x, 'expectsize', 'set size')
Can you improve this documentation as a follow-up? We should mentioned about
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/91701785c2c5
changeset: 41679:91701785c2c5
bookmark:@
tag: tip
parent: 41678:9d0d8793e847
parent: 41614:f2f538725d07
user:Augie Fackler
date:Mon Feb 11 11:18:37 2019 -0500
summary: me
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8185c8abce87: revset: add expectsize to check the size of a
set (authored by navaneeth.suresh, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5813?vs=14029&id=14043#toc
REPOSI
yuja added a comment.
> +@predicate('expectsize(set[, size])', safe=True, takeorder=True)
> +def expectrevsetsize(repo, subset, x, order):
> +"""Abort if the revset doesn't expect given size"""
> +args = getargsdict(x, 'expect', 'set size')
Fixed function name and queued,
> +@predicate('expectsize(set[, size])', safe=True, takeorder=True)
> +def expectrevsetsize(repo, subset, x, order):
> +"""Abort if the revset doesn't expect given size"""
> +args = getargsdict(x, 'expect', 'set size')
Fixed function name and queued, thanks.
___
gracinet created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Instead of iterating on the whole `self.bases` each time to find
its max, we keep the latter in a separate member attribute and
keep it up to
gracinet created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As noted in initial review of MissingAncestors, adding
NULL_REVISION in constructor in case the given `bases` is
empty wasn't really useful, y
gracinet created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
using the return values of HashSet::remove(), we can factor
pairs of `contains()/remove()` into a single `remove()`.
On a perfdiscovery run
gracinet created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This uses the boolean return of `HashSet::insert()` to factor
pairs of contains()/insert() into a single insert()
On the mozilla-central re
37 matches
Mail list logo
