D6568: abort: added support for rebase

pulkit added inline comments. INLINE COMMENTS > rebase.py:1926 > > +def hgabortrebase(ui, repo, **opts): > +if opts.get('no_backup'): we can name this function abortrebase, no need to add hg in front. > rebase.py:1928 > +if opts.get('no_backup'): > +raise error.Abort(_("rebase

D6567: abort: added support for graft

pulkit added a comment. > Tests have been shown as test-abort.t There is no such test now. :) INLINE COMMENTS > commands.py:2733 > > +def hgabortgraft(ui, repo, **opts): > +if opts.get('no_backup'): let's move this function to cmdutil.py. Should move _readgraftstate, _abortgrafts

D6566: abort: added logic for of hg abort

pulkit added inline comments. INLINE COMMENTS > commands.py:135 > > +@command('abort', > +[('', 'no-backup', False, _('do not save backup copies of files')), Can you mark this command as experimental for now, we will be close to release soon. Marking this as experimental will help us take

D6566: abort: added logic for of hg abort

taapas1128 updated this revision to Diff 15775. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6566?vs=15750&id=15775 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6566/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6566 AFFECTED FI

D6593: rust-minor-fixes: remove Deref in favor of explicit methods

Alphare added a comment. In D6593#96417 , @yuja wrote: >> Using `keys()` will change the behavior, as I actually need to expose an `Iter, u32>`. Is your issue with the naming? > > No. My point is that the refcount value is an implementatio

D6593: rust-minor-fixes: remove Deref in favor of explicit methods

yuja added a comment. > Using `keys()` will change the behavior, as I actually need to expose an `Iter, u32>`. Is your issue with the naming? No. My point is that the refcount value is an implementation detail. Do you have some plan to use the refcount value? diff --git a/rust/

Re: D6593: rust-minor-fixes: remove Deref in favor of explicit methods

> Using `keys()` will change the behavior, as I actually need to expose an > `Iter, u32>`. Is your issue with the naming? No. My point is that the refcount value is an implementation detail. Do you have some plan to use the refcount value? ``` diff --git a/rust/hg-core/src/dirstate/dirs_multis

D6593: rust-minor-fixes: remove Deref in favor of explicit methods

Alphare added a comment. > Again, > > - **contains**() -> inner.contains_key() > - iter() -> inner.**keys**() > > Somewhat similar to HashSet, which is basically a proxy type to > HashMap. `contains()` is my bad, I forgot. Using `keys()` will change the behavior, as

D6591: rust-minor-fixes: run rfmt on all hg-core/hg-cpython code

Closed by commit rHGd26e4a434fe5: rust: run rfmt on all hg-core/hg-cpython code (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES S

D6593: rust-minor-fixes: remove Deref in favor of explicit methods

Closed by commit rHGa80464e85ddd: rust: remove Deref in favor of explicit methods (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6592: rust-minor-fixes: simplify overly complicated expression

Closed by commit rHG11c025c83393: rust: simplify overly complicated expression (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SI

D6593: rust-minor-fixes: remove Deref in favor of explicit methods

yuja added a comment. > +pub fn contains_key(&self, key: &[u8]) -> bool { > +self.inner.contains_key(key) > +} > + > +pub fn iter(&self) -> Iter, u32> { > +self.inner.iter() > +} Again, - **contains**() -> inner.contains_key() - iter() ->

Re: D6593: rust-minor-fixes: remove Deref in favor of explicit methods

> +pub fn contains_key(&self, key: &[u8]) -> bool { > +self.inner.contains_key(key) > +} > + > +pub fn iter(&self) -> Iter, u32> { > +self.inner.iter() > +} Again, - **contains**() -> inner.contains_key() - iter() -> inner.**keys**() Somewhat similar to HashSet, w

D6593: rust-minor-fixes: remove Deref in favor of explicit methods

Alphare updated this revision to Diff 15771. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6593?vs=15740&id=15771 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6593/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6593 AFFECTED FILES