D7517: filemerge: byteify the open() mode

2019-11-23 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is actually `pycompat.open()`, so it need bytes. It regressed recently on default. VSCode flagged some invalid mode to open() the other day, but I

D7512: exchange: guard against method invocation on `b2caps=None` args

2019-11-23 Thread yuja (Yuya Nishihara)
yuja added a comment. > """add a changegroup part to the requested bundle""" > > - if not kwargs.get('cg', True): > > +if not kwargs.get('cg', True) or not b2caps: > > return Is it valid to call these functions with `b2caps=None`? I suspect it would be a bug or a

D7511: exchange: eliminate some bytes.format() calls

2019-11-23 Thread yuja (Yuya Nishihara)
yuja added a comment. > if invalid_includes: > raise error.Abort( > > - _(b"The following includes are not accessible for {}: {}").format( > - username, invalid_includes > - ) > > +_(b"The following includes are not accessible for %s: %s") > +%

Re: D7512: exchange: guard against method invocation on `b2caps=None` args

2019-11-23 Thread Yuya Nishihara
> """add a changegroup part to the requested bundle""" > -if not kwargs.get('cg', True): > +if not kwargs.get('cg', True) or not b2caps: > return Is it valid to call these functions with `b2caps=None`? I suspect it would be a bug or a data corruption.

Re: D7511: exchange: eliminate some bytes.format() calls

2019-11-23 Thread Yuya Nishihara
> if invalid_includes: > raise error.Abort( > -_(b"The following includes are not accessible for {}: > {}").format( > -username, invalid_includes > -) > +_(b"The following includes are not accessible for %s: %s") > +%

D7481: localrepo: recognize trivial "null" queries in `anyrev`

2019-11-23 Thread yuja (Yuya Nishihara)
yuja added a comment. > +if specs == [b'null']: > +return revset.baseset([nullrev]) This breaks `--config revsetalias.null=`. Nobody would care, but I don't know why we're so hard to optimize `-r null` query. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

Re: D7481: localrepo: recognize trivial "null" queries in `anyrev`

2019-11-23 Thread Yuya Nishihara
> +if specs == [b'null']: > +return revset.baseset([nullrev]) This breaks `--config revsetalias.null=`. Nobody would care, but I don't know why we're so hard to optimize `-r null` query. ___ Mercurial-devel mailing list

D7516: webutil: add missing argument to join()

2019-11-23 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D7516 AFFECTED FILES mercurial/hgweb/webutil.py CHANGE DETAILS diff --git

D7512: exchange: guard against method invocation on `b2caps=None` args

2019-11-23 Thread mharbison72 (Matt Harbison)
Closed by commit rHG0dbea180525c: exchange: guard against method invocation on `b2caps=None` args (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7511: exchange: eliminate some bytes.format() calls

2019-11-23 Thread mharbison72 (Matt Harbison)
Closed by commit rHG76d4bf0a652b: exchange: eliminate some bytes.format() calls (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7511?vs=18336=18378

D7510: windows: suppress pytype warnings for Windows imports and functions

2019-11-23 Thread mharbison72 (Matt Harbison)
Closed by commit rHGc6060b243163: windows: suppress pytype warnings for Windows imports and functions (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7491: changectx: mark the parents of the working copy as non filtered

2019-11-23 Thread marmoute (Pierre-Yves David)
Closed by commit rHG0e72b2518f0e: changectx: mark the parents of the working copy as non filtered (authored by marmoute). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7491?vs=18364=18376#toc REPOSITORY rHG

D7488: localrepo: introduce a `_quick_access_changeid` property

2019-11-23 Thread marmoute (Pierre-Yves David)
Closed by commit rHG82ffb92092de: localrepo: introduce a `_quick_access_changeid` property (authored by marmoute). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7488?vs=18357=18374#toc REPOSITORY rHG

D7487: changectx: use unfiltered changelog to access parents of unfiltered revs

2019-11-23 Thread marmoute (Pierre-Yves David)
Closed by commit rHG5ef259b09475: changectx: use unfiltered changelog to access parents of unfiltered revs (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7490: repoview: add an explicit set of all filter that show the wc parents

2019-11-23 Thread marmoute (Pierre-Yves David)
Closed by commit rHGa1cd36171ea1: repoview: add an explicit set of all filter that show the wc parents (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7484: localrepo: mark nullrev has never filtered

2019-11-23 Thread marmoute (Pierre-Yves David)
Closed by commit rHGc25885cc6849: localrepo: mark nullrev has never filtered (authored by marmoute). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7484?vs=18355=18370#toc REPOSITORY rHG Mercurial CHANGES

D7486: locarepo: also fastpath `nullid` lookup in __getitem__

2019-11-23 Thread marmoute (Pierre-Yves David)
Closed by commit rHGc9d1e2ec1e2e: locarepo: also fastpath `nullid` lookup in __getitem__ (authored by marmoute). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7486?vs=18356=18372#toc REPOSITORY rHG Mercurial

D7483: changectx: add a "maybe filtered" filtered attribute

2019-11-23 Thread marmoute (Pierre-Yves David)
Closed by commit rHG8a37203ab1d5: changectx: add a maybe filtered filtered attribute (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7483?vs=18362=18369

D7514: repoview: add more tests to track operation not supposed to trigger filtering

2019-11-23 Thread marmoute (Pierre-Yves David)
Closed by commit rHGe3c0f9c2c376: repoview: add more tests to track operation not supposed to trigger filtering (authored by marmoute). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7514?vs=18354=18371#toc

D7510: windows: suppress pytype warnings for Windows imports and functions

2019-11-23 Thread indygreg (Gregory Szorc)
indygreg added a comment. In D7510#110343 , @mharbison72 wrote: > I'm not sure if there are plans to vendor *.pyi files. Maybe that could be used to backfill platform specific modules instead of doing this. But for now is seems better to

D7491: changectx: mark the parents of the working copy as non filtered

2019-11-23 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added inline comments. indygreg accepted this revision. INLINE COMMENTS > context.py:1522 > +return [ > +changectx(self._repo, unfi.changelog.rev(n), n, False) for n in p > +] I'm adding a named argument in

D7515: pytype: [WIP] suppress various warnings inline to get a clean run

2019-11-23 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. mharbison72 planned changes to this revision. Adjusting this to stay out of the review queue. While most of the files only had a handful of errors (and a few could be removed from the blacklist), the few added had a bunch of errors. I didn't see any obvious

D7515: pytype: [WIP] suppress various warnings inline to get a clean run

2019-11-23 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This depends on D7295 and D7384 , which in turn was applied to f612a044a5ab

D7484: localrepo: mark nullrev has never filtered

2019-11-23 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added inline comments. indygreg accepted this revision. INLINE COMMENTS > localrepo.py:1535 > if changeid == b'null' or changeid == nullrev: > -return context.changectx(self, nullrev, nullid) > +return

D7483: changectx: add a "maybe filtered" filtered attribute

2019-11-23 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. I'm satisfied with the discussion and will proceed with reviewing this series. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7483/new/

D7492: localrepo: also fastpath access to working copy parents when possible

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18365. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7492?vs=18358=18365 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7492/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7492 AFFECTED FILES

D7502: changectx: mark parent of changesets as non filtered

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18367. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7502?vs=18309=18367 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7502/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7502 AFFECTED FILES

D7501: changectx: use unfiltered changelog to walk ancestors in annotate

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18366. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7501?vs=18308=18366 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7501 AFFECTED FILES

D7491: changectx: mark the parents of the working copy as non filtered

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18364. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7491?vs=18298=18364 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7491/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7491 AFFECTED FILES

D7487: changectx: use unfiltered changelog to access parents of unfiltered revs

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18363. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7487?vs=18350=18363 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7487/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7487 AFFECTED FILES

D7483: changectx: add a "maybe filtered" filtered attribute

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18362. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7483?vs=18290=18362 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7483/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7483 AFFECTED FILES

D7295: pytype: add a (very slow) test that executes pytype

2019-11-23 Thread durin42 (Augie Fackler)
durin42 added a comment. In D7295#110254 , @mharbison72 wrote: > In D7295#107482 , @indygreg wrote: > >> Since type checking is slow (but there are state files we can reuse to speed things

D7483: changectx: add a "maybe filtered" filtered attribute

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in context.py:484 > Add a comment explaining what this attribute means, such as "indicates that > this changeset is visible regardless of filtering". Actually, maybe it's > better to name the property something like

D7483: changectx: add a "maybe filtered" filtered attribute

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute added a comment. (grmlml, realising that I forgot to do the dual "submit" for my comment. It is 2019, why is Phabricator still not fixing this…) INLINE COMMENTS > indygreg wrote in context.py:503 > Before I accept more of this series, I'd like others to think about the > potential

D7507: phabricator: add a "phabstatus" template keyword

2019-11-23 Thread dlax (Denis Laxalde)
dlax added a comment. > I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there? Not that I am aware. Using this keyword

D7507: phabricator: add a "phabstatus" template keyword

2019-11-23 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there? REPOSITORY rHG Mercurial CHANGES

D7483: changectx: add a "maybe filtered" filtered attribute

2019-11-23 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > context.py:484 > self._node = node > +self._maybe_filtered = maybe_filtered > Add a comment explaining what this attribute means, such as "indicates that this changeset is visible regardless of filtering". Actually, maybe

D7506: phabricator: add a "phabstatus" show view

2019-11-23 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7506#110351 , @dlax wrote: > The revisions shown by the "phabstatus" view is just a subset of that of "work" view (subset of revisions with a differential). Do you see more revisions in "phabstatus" than in

D7500: repoview: add a test for changelog filtering trigger for `hg annotate`

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute abandoned this revision. This was pruned, but phab apparently does not detect this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7500/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7500 To: marmoute,

D7499: repoview: test triggering of filter computation for `hg export`

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute abandoned this revision. This was pruned, but phab apparently does not detect this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7499/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7499 To: marmoute,

D7497: repoview: add a test for filtering computation for `hg diff --change`

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute abandoned this revision. This was pruned, but phab apparently does not detect this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7497/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7497 To: marmoute,

D7496: repoview: add a test for filtering computation for `hg diff`

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute abandoned this revision. This was pruned, but phab apparently does not detect this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7496/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7496 To: marmoute,

D7493: repoview: test changelog filtering triggered by a lookup to '.'

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute abandoned this revision. This was pruned, but phab apparently does not detect this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7493/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7493 To: marmoute,

D7489: repoview: add test for filtering computation when running `hg status`

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute abandoned this revision. This was pruned, but phab apparently does not detect this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7489/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7489 To: marmoute,

D7485: repoview: test filtered computation on `hg status --change` call

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute abandoned this revision. This was pruned, but phab apparently does not detect this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7485/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7485 To: marmoute,

D7492: localrepo: also fastpath access to working copy parents when possible

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18358. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7492?vs=18351=18358 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7492/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7492 AFFECTED FILES

D7498: localrepo: also fast past the parents of working copies parents

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18361. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7498?vs=18353=18361 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7498/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7498 AFFECTED FILES

D7495: localrepo: recognize trivial request for '.'

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18360. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7495?vs=18352=18360 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7495/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7495 AFFECTED FILES

D7494: localrepo: fastpath access to "."

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18359. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7494?vs=18301=18359 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7494/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7494 AFFECTED FILES

D7488: localrepo: introduce a `_quick_access_changeid` property

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18357. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7488?vs=18295=18357 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7488/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7488 AFFECTED FILES

D7486: locarepo: also fastpath `nullid` lookup in __getitem__

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18356. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7486?vs=18293=18356 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7486/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7486 AFFECTED FILES

D7484: localrepo: mark nullrev has never filtered

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18355. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7484?vs=18349=18355 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7484/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7484 AFFECTED FILES

D7514: repoview: add more tests to track operation not supposed to trigger filtering

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This test is useful to confirm we removed filtering trigger and to prevent it to come back without us noticing. The commands tested in the test were

D7492: localrepo: also fastpath access to working copy parents when possible

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18351. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7492?vs=18299=18351 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7492/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7492 AFFECTED FILES

D7498: localrepo: also fast past the parents of working copies parents

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18353. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7498?vs=18305=18353 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7498/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7498 AFFECTED FILES

D7495: localrepo: recognize trivial request for '.'

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18352. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7495?vs=18302=18352 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7495/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7495 AFFECTED FILES

D7487: changectx: use unfiltered changelog to access parents of unfiltered revs

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18350. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7487?vs=18294=18350 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7487/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7487 AFFECTED FILES

D7484: localrepo: mark nullrev has never filtered

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18349. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7484?vs=18291=18349 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7484/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7484 AFFECTED FILES

D7481: localrepo: recognize trivial "null" queries in `anyrev`

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18348. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7481?vs=18333=18348 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7481/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7481 AFFECTED FILES

D7480: localrepo: also fastpath `nullrev` in __getitem__

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18347. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7480?vs=18332=18347 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7480/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7480 AFFECTED FILES

D7477: util: add an optional `prefix` argument to debugstacktrace

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18344. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7477?vs=18329=18344 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7477/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7477 AFFECTED FILES

D7479: repoview: add a test to track operation not supposed to trigger filtering

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute edited the summary of this revision. marmoute updated this revision to Diff 18346. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7479?vs=18331=18346 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7479/new/ REVISION DETAIL

D7475: localrepo: extract handling of some special value in __getitem__

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18342. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7475?vs=18327=18342 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7475/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7475 AFFECTED FILES

D7478: repoview: display stack trace along side the debug message

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18345. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7478?vs=18330=18345 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7478/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7478 AFFECTED FILES

D7476: repoview: add a 'devel.debug.repo-filter' option

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18343. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7476?vs=18328=18343 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7476/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7476 AFFECTED FILES

D7474: localrepo: extract handling of some special value in __getitem__

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18341. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7474?vs=18326=18341 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7474/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7474 AFFECTED FILES

D7473: localrepo: add some basic comment for block in __getitem__

2019-11-23 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18340. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7473?vs=18325=18340 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7473/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7473 AFFECTED FILES

D7513: phabricator: fix processing of tags/desc in getoldnodedrevmap()

2019-11-23 Thread dlax (Denis Laxalde)
dlax created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems that the previous logic was wrong (it essentially comes from changeset 3ab0d5767b54

D7506: phabricator: add a "phabstatus" show view

2019-11-23 Thread dlax (Denis Laxalde)
dlax edited the summary of this revision. dlax updated this revision to Diff 18338. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18320=18338 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL

D7506: phabricator: add a "phabstatus" show view

2019-11-23 Thread dlax (Denis Laxalde)
dlax added a comment. dlax planned changes to this revision. In D7506#110321 , @mharbison72 wrote: > In D7506#110288 , @mharbison72 wrote: > >> I'm not sure why, but this version seems to also