D7147: diff: use unfiltered repo if we're diffing the working copy

martinvonz added a comment. martinvonz abandoned this revision. Abandoning in favor of D7492 REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7147/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7147 To: mar

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. martinvonz abandoned this revision. I'll abandon this in favor of D7492 REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7144

D7492: localrepo: also fastpath access to working copy parents when possible

martinvonz added a comment. Hmm, I thought this entire series had been queued. I'd like to queue it. Can you include perf numbers? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7492/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7492 To: mar

D7595: status: outputting structured unfinished-operation information

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This adds a new item in the json/template output for morestatus. For backwards compatibility, I put this behind a config option (but I'd be happy to remove that

D7594: status: add template/json data about whether a file has unresolved conflicts

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7594 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-confli

D7593: status: split morestatus data loading from display

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a small refactoring in preparation for adding more morestatus functionality (notably for templated/JSON output) - the goal is to use the data inside the

D7591: status: remove pointless filtering by alwaysmatcher in morestatus

martinvonz added a comment. In D7591#111571 , @rdamazio wrote: > In D7591#111570 , @martinvonz wrote: > >> In D7591#111569 , @rdamazio wrote: >>

D7591: status: remove pointless filtering by alwaysmatcher in morestatus

rdamazio added a comment. In D7591#111570 , @martinvonz wrote: > In D7591#111569 , @rdamazio wrote: > >> FYI I'm going to send a chain that rewrites a lot of this > > To be clear, are you te

D7591: status: remove pointless filtering by alwaysmatcher in morestatus

martinvonz added a comment. In D7591#111569 , @rdamazio wrote: > FYI I'm going to send a chain that rewrites a lot of this To be clear, are you telling reviewers not to queue this one because you will be rewriting the *patch* or you're sa

D7591: status: remove pointless filtering by alwaysmatcher in morestatus

rdamazio added a comment. FYI I'm going to send a chain that rewrites a lot of this REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7591/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7591 To: martinvonz, #hg-reviewers Cc: rdamazio, mercurial-d

mercurial@43806: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/ad84fc97d120 changeset: 43805:ad84fc97d120 user:Pierre-Yves David date:Fri Nov 29 15:36:45 2019 +0100 summary: upgrade-repo: colorize some of the output https://www.mercurial-scm.org/repo/hg/rev/acbb55

D7592: fuzz: add support for fuzzing under either Python 2 or 3

durin42 added a comment. Note: please review the embedded Python segments carefully, as it's a little fidgety to get right and verify I didn't do something Really Dumb. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7592/new/ REVISION DETAIL https:/

D7592: fuzz: add support for fuzzing under either Python 2 or 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was more of a hairball than I hoped, but it appears to work. The hg-py3 branch of my oss-fuzz fork on github has the remaining changes to switch us to Pytho

[Bug 6238] New: Windows: time.clock removed from python 3.8 - prevents building/running from source.

https://bz.mercurial-scm.org/show_bug.cgi?id=6238 Bug ID: 6238 Summary: Windows: time.clock removed from python 3.8 - prevents building/running from source. Product: Mercurial Version: default branch Hardware: PC

D7591: status: remove pointless filtering by alwaysmatcher in morestatus

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The code has been like this since it was imported from FB's hg-experimental repo. It has been like that even since it was added in that repo. So I don't know

D7590: remotefilelog: remove the `ensurestart` usage

marmoute updated this revision to Diff 18557. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7590?vs=18555&id=18557 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7590/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7590 AFFECTED FILE

D7584: procutil: add a option to not fully detach background process

marmoute updated this revision to Diff 18556. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7584?vs=18549&id=18556 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7584/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7584 AFFECTED FILE

D7590: remotefilelog: remove the `ensurestart` usage

marmoute added a comment. good spot. I'll update that last patch. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7590/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7590 To: marmoute, #hg-reviewers, durin42 Cc: durin42, mjpieters, mercurial-de

D7584: procutil: add a option to not fully detach background process

This revision now requires changes to proceed. durin42 added inline comments. durin42 requested changes to this revision. INLINE COMMENTS > procutil.py:589 > + > +When `register_wait` is not None, the spawned process will not be > fully > +detached and the `record_wait` argument

D7585: remotefilelog: add a developer option to wait for background processes

durin42 added inline comments. INLINE COMMENTS > shallowrepo.py:237 > +if repo.ui.configbool(b'devel', b'remotefilelog.bg-wait'): > +kwargs['record_wait'] = repo.ui.atexit > + It took me some very careful reasoning to figure this out. Could you amend the log message

D7590: remotefilelog: remove the `ensurestart` usage

durin42 added a comment. This is wrong, because now remotefilelog will do ensurestart=True (the default) which is a significant performance hit for remotefilelog users. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7590/new/ REVISION DETAIL https:/

D7590: remotefilelog: remove the `ensurestart` usage

durin42 added a comment. Wait, I just saw the chain. Thanks for weird emails phabricator! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7590/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7590 To: marmoute, #hg-reviewers Cc: durin42, mjpieter

D7590: remotefilelog: remove the `ensurestart` usage

durin42 added a comment. This doesn't apply to stable. I also checked default, and it doesn't apply there either. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7590/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7590 To: marmoute, #hg-review

D7579: tests: add test for Rust formatting

Alphare added a comment. While I am not a huge fan of the use of a nightly toolchain, I like the fact that we get the latest features and behavior as `rustfmt` is still pre-1.0 and subject to change. So far, it has been nice to us and has not broken anything I can recall, I vote for keeping

D7590: remotefilelog: remove the `ensurestart` usage

marmoute created this revision. marmoute added a comment. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. target is the stable-branch REVISION SUMMARY The option does not seems to do what we want since it does not wait on the background process

D7589: remotefilelog: remove most of the debugwait* command in the tests

marmoute created this revision. marmoute added a comment. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. target is the stable-branch REVISION SUMMARY Since we use a dedicated developer config, we do not need them anymore. REPOSITORY rHG Mercurial REVIS

D7587: remotefilelog: remove most sleep in tests

marmoute created this revision. marmoute added a comment. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. target is the stable-branch REVISION SUMMARY Now that we removed most of the races, we can remove the infamous sleeps. REPOSITORY rHG Mercurial REV

D7588: remotefilelog: use the correct redirection in tests

marmoute created this revision. marmoute added a comment. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. target is the stable-branch REVISION SUMMARY The test were using '2>%1' which just redirect stderr in the "%1" file. The intend was '2>&1' which redi

D7586: remotefilelog: have command wait for background task in the tests

marmoute created this revision. marmoute added a comment. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. target is the stable-branch REVISION SUMMARY We leverage the feature introduced in the two previous commit to have the main command wait for the back

D7585: remotefilelog: add a developer option to wait for background processes

marmoute created this revision. marmoute added a comment. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. target is the stable-branch REVISION SUMMARY Currently, in the tests, most operation spawning background process as followed by commands waiting for

D7584: procutil: add a option to not fully detach background process

marmoute created this revision. marmoute added a comment. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. target is the stable-branch REVISION SUMMARY When writing test, it is useful to make code pretending to spawn a fully detached process while still ac

D7575: hg-core: vendor Facebook's configparser crate

Alphare added inline comments. INLINE COMMENTS > Alphare wrote in hg.rs:226 > This function looks very Facebook specific, I don't think we want to include > it at all. My bad, it looks like you took care of it in a future patch. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://p

D7576: hg-core: add configparser to library

Alphare added inline comments. INLINE COMMENTS > Cargo.toml:19 > memchr = "2.2.0" > +parking_lot = "0.9" > +pest = "2.1.0" "The current minimum required Rust version is 1.36". This disqualifies this crate from being used in `hg-core` right now. Good news is that it is supposed to offer improv

D7577: hg-core: implement Mercurial's config file discovery logic

kevincox added inline comments. kevincox accepted this revision. INLINE COMMENTS > config.rs:145 > +let paths = glob_res > +.filter_map(|x| if let Ok(x) = x { Some(x) } else { None }) > +.sorted(); I believe this can just be `.flatten()`. REPOSITORY

D7575: hg-core: vendor Facebook's configparser crate

Alphare added inline comments. INLINE COMMENTS > c_api.rs:1 > +/* > + * Copyright (c) Facebook, Inc. and its affiliates. Do we need bindings to C ? I don't see what the use-case is at this stage of the Rust development. > quark wrote in hg.rs:262-263 > You might want to respect `$PAGER`. We ig

D7574: hg-core: add utils::path to project

Alphare added inline comments. INLINE COMMENTS > Cargo.toml:12 > [dependencies] > +anyhow = "1.0.20" > byteorder = "1.3.1" Should we adopt this crate for error handling? I feel like our current solution - although it might need a refactor - is good at forcing the programmer to provide contex

D7573: hg-core: vendor Facebook's path utils module

Alphare added inline comments. Alphare accepted this revision. INLINE COMMENTS > path.rs:169 > +// > +// XXX: Doing this preprocessing has the unfortunate side-effect that > +// if an environment variable fails to expand on Windows, the resulting Would it take a lot of effort to rect