D7952: rust: add a README

Alphare added inline comments. Alphare accepted this revision. INLINE COMMENTS > README.rst:27 > + $ HGWITHRUSTEXT=cpython make tests # to run all tests > + $ (cd tests; HGWITHRUSTEXT=cpython ./run-tests.py) # only the .t > + $ ./hg debuginstall | grep rust # to validate rust is in use I thin

D7952: rust: add a README

pulkit added inline comments. pulkit added subscribers: gracinet, pulkit. INLINE COMMENTS > README.rst:25 > > -To build the Rust components:: > + $ HGWITHRUSTEXT=cpython make local # to use ./hg > + $ HGWITHRUSTEXT=cpython make tests # to run all tests IIRC, it's now possible to use `HGMODUL

D7952: rust: add a README

Alphare added inline comments. INLINE COMMENTS > pulkit wrote in README.rst:25 > IIRC, it's now possible to use `HGMODULEPOLICY=rust`. @gracinet that's > possible now right? `HGMODULEPOLICY=rust+c` to select it at runtime yes. But for not for `make local` AFAIK. REPOSITORY rHG Mercurial CH

D7952: rust: add a README

gracinet added a comment. My general feeling is that I'd like to deprecate `HGWITHRUSTEXT`. We now have `python setup.py --rust [build|install|etc]` and the coincidental `make local PURE=--rust` (works because `$PURE`, while meant to be for `--pure` is inserted blindly at the right place

D7952: rust: add a README

gracinet added a comment. "deprecate" was a bit too strong. Actually I'd like to downgrade `HGWITHRUSTEXT` to be something that'll be useful to play with alternative ways of building the Rust extension(s). Example: if someone wants to experiment with PyO3. REPOSITORY rHG Mercurial CHANGE

D7950: verify: avoid spurious integrity warnings in verbose mode (issue6172)

Closed by commit rHGe77b57e09bfa: verify: avoid spurious integrity warnings in verbose mode (issue6172) (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7950

D7951: rust: move hgcli's README out of the way

Closed by commit rHG8a3b045d9086: rust: move hgcli's README out of the way (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial C

D7953: hgdemandimport: disable on Python 3.5

Closed by commit rHG1292386dd05c: hgdemandimport: disable on Python 3.5 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7953?vs=19460&id=19466 CHANGES SINCE L

D7864: rust-utils: add Rust implementation of Python's "os.path.splitdrive"

Closed by commit rHG03aaa328b6b8: rust-utils: add Rust implementation of Python's "os.path.splitdrive" (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7864?vs=1

D7945: py3: conditionalize test-flagprocessor.t on Python 3.8

Closed by commit rHGfeb3b4d1985a: py3: conditionalize test-flagprocessor.t on Python 3.8 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7945?vs=19449&id=19468

D7943: tests: conditionalize test-hightlight.t on pygments version

Closed by commit rHGae5580ecdb38: tests: conditionalize test-hightlight.t on pygments version (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7943?vs=19447&id=

D7946: py3: add extra traceback line present on Python 3.8

Closed by commit rHG1bb24b1ef368: py3: add extra traceback line present on Python 3.8 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7946?vs=19450&id=19469 C

D7868: rust-filepatterns: remove bridge code for filepatterns-related functions

Closed by commit rHG92b9e72d4333: rust-filepatterns: remove bridge code for filepatterns-related functions (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7868?

D7947: py3: conditionalize test-lfs-serve-access.t for Python 3.8

Closed by commit rHG047ededd65ab: py3: conditionalize test-lfs-serve-access.t for Python 3.8 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7947?vs=19451&id=1

D7948: debugcommands: move away from line buffered output on binary stream

Closed by commit rHG2ae43bc51483: debugcommands: move away from line buffered output on binary stream (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7948?vs=1

D7952: rust: add a README

valentin.gatienbaron updated this revision to Diff 19472. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7952?vs=19459&id=19472 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7952/new/ REVISION DETAIL https://phab.mercuria

D7952: rust: add a README

valentin.gatienbaron added a comment. valentin.gatienbaron marked an inline comment as done. I didn't mention `setup.py --rust` because the toplevel readme doesn't mention setup.py, so I don't really know if that's really how mercurial is intended to be built or an implementation detail. RE

D7952: rust: add a README

valentin.gatienbaron added inline comments. INLINE COMMENTS > gracinet wrote in README.rst:25 > `HGMODULEPOLICY` is for runtime, it can be `rust+c` or `rust+c-allow`. > In the first form, not having the Rust extension is a failure, in the second, > there's a fallback. When I tested, setting HG

Re: D7864: rust-utils: add Rust implementation of Python's "os.path.splitdrive"

So `HgPath` type is no longer intended for "a repository-relative path"? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7864: rust-utils: add Rust implementation of Python's "os.path.splitdrive"

yuja added a comment. So `HgPath` type is no longer intended for "a repository-relative path"? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7864/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7864 To: Alphare, #hg-reviewers, kevincox, pulkit

D7952: rust: add a README

gracinet added inline comments. INLINE COMMENTS > valentin.gatienbaron wrote in README.rst:25 > When I tested, setting HGMODULEPOLICY didn't work, perhaps because of what > Raphael said. Both Raphaël and I were saying the same thin, perhaps a bit partially. Here's the whole picture: - options

mercurial@44114: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/e77b57e09bfa changeset: 44113:e77b57e09bfa user:Matt Harbison date:Sat Jan 18 01:54:17 2020 -0500 summary: verify: avoid spurious integrity warnings in verbose mode (issue6172) https://www.mercurial-s

D7949: py3: suppress unraisable exceptions in test-worker.t

Closed by commit rHGb5aaa09be18c: py3: suppress unraisable exceptions in test-worker.t (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7949?vs=19453&id=19474

D7954: hgdemandimport: apply lazy module loading to sys.meta_path finders

Closed by commit rHGf81c17ec303c: hgdemandimport: apply lazy module loading to sys.meta_path finders (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7954?vs=19

D7952: rust: add a README

Closed by commit rHGe1b8b4e4f496: rust: add a README (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7952?vs=19472&id=19473 CHANGES SINCE LAST ACT

D7920: tests: restore phabricator tests and regenerate the recordings

Closed by commit rHGa5e3f38407cb: tests: restore phabricator tests and regenerate the recordings (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7933: config: add a function to insert non-file based, but overridable settings

Closed by commit rHGe2278581b1c6: config: add a function to insert non-file based, but overridable settings (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOS

D7934: phabricator: use .arcconfig for the callsign if not set locally (issue6243)

Closed by commit rHG59b3fe1e2021: phabricator: use .arcconfig for the callsign if not set locally (issue6243) (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REP

D7935: phabricator: use .arcconfig for `phabricator.url` if not set locally

Closed by commit rHGff396501e841: phabricator: use .arcconfig for `phabricator.url` if not set locally (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7807: hgrc: introduce HGRCSKIPREPO to skip reading the repository's hgrc

Closed by commit rHGd56a2d6f34f0: hgrc: introduce HGRCSKIPREPO to skip reading the repository's hgrc (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7807?vs=19

D7790: rust-node: handling binary Node prefix

martinvonz added inline comments. INLINE COMMENTS > node.rs:79 > +let is_odd = len % 2 == 1; > +let mut buf: Vec = Vec::with_capacity(20); > +for i in 0..len / 2 { Why not use `(len + 1) / 2` as capacity? > node.rs:89 > + > +pub fn borrow<'a>(&'a self) -> NodePrefixR

D7790: rust-node: handling binary Node prefix

martinvonz added a comment. In D7790#116757 , @gracinet wrote: > @martinvonz in this code, we're in competition with the C implementation, which does something similar. > Switching to a full u8 per nybble is more than a few minutes, it means

D7787: rust-nodemap: building blocks for nodetree structures

martinvonz added a comment. Just a few nits here, but it looks like we're expecting an update on this series anyway, so maybe you can address them. INLINE COMMENTS > nodemap.rs:8 > +//! > +//! This provides a variation on the radix tree with valency 16 that is > +//! provided as "nodetree" i

D7955: relnotes: copy "next" to "5.3" and clear "next"

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is the same thing as we've done for the last two releases. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D79

D7956: lfs: drop the unused progressbar code in the `filewithprogress` class

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This has been unused since f98fac24b757 , which added worker based transfers for

D7957: lfs: explicitly close the file handle for the blob being uploaded

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous code relied on reading the blob fully to close it. The obvious problem is if an error occurs before that point. But there is also a problem wh

D7958: lfs: drop an unnecessary r'' prefix

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY No longer necessary since the source transformer was removed. 1. skip-blame for changing string prefixes REPOSITORY rHG Mercurial REVISION DETAIL http

D7959: lfs: move the initialization of the upload request into the try block

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This (almost) guarantees that the file is closed in the case of an exception. The one hole is if the `seek(SEEK_END)`/`tell()`/`seek(0)` sequence fails. But

D7960: httpconnection: allow `httpsendfile` subclasses to suppress the progressbar

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will be neccessary for LFS, which manages the progressbar outside of the file. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.o

D7961: lfs: add a method to the local blobstore to convert OIDs to file paths

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is less ugly than passing an open callback to the `httpsendfile` constuctor. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org

D7962: lfs: fix the stall and corruption issue when concurrently uploading blobs

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've avoided the issue up to this point by gating worker usage with an experimental config. See 10e62d5efa73

D7963: lfs: enable workers by default

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With the stall issue seemingly fixed, there's no reason not to use workers. The setting is left for now to keep the test output deterministic, and in case o

D7962: lfs: fix the stall and corruption issue when concurrently uploading blobs

mharbison72 added a comment. Even though this talks about fixing corruption, I don't *think* we need this in the next release. We've lived with this problem for 2 years now. But somebody who really understands how all of the URL request handling and keepalive stuff works should probably ta

D7788: rust-node: binary Node and conversion utilities

martinvonz added a comment. In D7788#116756 , @gracinet wrote: > @durin42 @martinvonz we might have a nice path forward with this, with the suggestion of @kevincox to make `Node` a truly defined type, not just an alias, with a private member

mercurial@44131: 17 new changesets (3 on stable)

17 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/e1b8b4e4f496 changeset: 44115:e1b8b4e4f496 user:Valentin Gatien-Baron date:Mon Jan 20 18:28:46 2020 -0500 summary: rust: add a README https://www.mercurial-scm.org/repo/hg/rev/b5aaa09be1

D7964: cext: change two more vars to Py_ssize_t in manifest.c

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY D7913 fixed a compiler warning with a signedness conflict in a ternary operator by changing the types of some variables to

D7791: rust-nodemap: NodeMap trait with simplest implementor

martinvonz added inline comments. INLINE COMMENTS > nodemap.rs:150 > +pub struct NodeTree { > +readonly: Box + Send>, > +} I find `Deref + Send` hard to understand. I think it would be helpful to name it. Could we at least define an alias for it? Perhaps it's even better to define a trait

D7965: py3: catch AttributeError too with ImportError

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Looks like py3 raises AttributeError instead of ImportError. This is caught on windows. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://pha

D7966: remotefilelog: only prefetch history in linkrevfixup

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The linknode is part of the history, not the data, no need to force prefetch the blobs. The commit is copied from https://github.com/facebookexperimental/ed

[Bug 6257] New: Setting ui.clonebundleprefers causes a crash in the client

https://bz.mercurial-scm.org/show_bug.cgi?id=6257 Bug ID: 6257 Summary: Setting ui.clonebundleprefers causes a crash in the client Product: Mercurial Version: 5.3rc0 Hardware: PC OS: All Status:

D7964: cext: change two more vars to Py_ssize_t in manifest.c

Closed by commit rHG0e198f1f276a: cext: change two more vars to Py_ssize_t in manifest.c (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7791: rust-nodemap: NodeMap trait with simplest implementor

Alphare added inline comments. INLINE COMMENTS > martinvonz wrote in nodemap.rs:150 > I find `Deref + Send` hard to understand. I think it would > be helpful to name it. Could we at least define an alias for it? > > Perhaps it's even better to define a trait for it and add named methods on > t

D7791: rust-nodemap: NodeMap trait with simplest implementor

martinvonz added inline comments. INLINE COMMENTS > Alphare wrote in nodemap.rs:150 > > I find Deref + Send hard to understand. I think it would > > be helpful to name it. Could we at least define an alias for it? > > Alas, trait aliases are not stable: rust#55628 >

[Bug 6258] New: hgk crashes with message "Error reading commits: unknown exception encountered"

https://bz.mercurial-scm.org/show_bug.cgi?id=6258 Bug ID: 6258 Summary: hgk crashes with message "Error reading commits: unknown exception encountered" Product: Mercurial Version: 5.2.1 Hardware: PC OS: Linu

D7967: exchange: recognize changegroup3 bundles in `getbundlespec()`

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, `hg bundle --spec $bundle` complained that changegroup3 didn't have a known bundlespec and suggested upgrading the client, even if the same binary