D8175: transaction: move constant to upper case

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These constant are internal to the module and can be safely renamed. Having them upper case help to clarify their "constant" status. (This is a gratuitous c

D8176: transaction: clarify the logic around pre-finalize/post-finalize

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I am taking a bit more verbose route, but I find it easier to follow for people who (re)discover the code. (This is a gratuitous cleanup I did while looking

D6825: hgext: start building a library for simple hooks

joerg.sonnenberger updated this revision to Diff 20371. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6825?vs=20351&id=20371 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6825/new/ REVISION DETAIL https://phab.mercurial-

D8177: hgit: fix self.gitrepo -> self._git_repo

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8177 AFFECTED FILES hgext/git/manifest.py CHANGE DETAILS diff --git a/hgext/git/mani

D8178: heptapod-ci: also run some test for chg

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I am not are of any regular effort to run test with chg. So let's at least do it here. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://ph

[Bug 6278] New: Disable hardlinks

https://bz.mercurial-scm.org/show_bug.cgi?id=6278 Bug ID: 6278 Summary: Disable hardlinks Product: Mercurial Version: 5.3 Hardware: PC OS: Windows Status: UNCONFIRMED Severity: feature Priority:

D8177: hgit: fix some issues spotted by pylint integration with editor

pulkit retitled this revision from "hgit: fix self.gitrepo -> self._git_repo" to "hgit: fix some issues spotted by pylint integration with editor". pulkit updated this revision to Diff 20374. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8177?vs=20372&id=

D8178: heptapod-ci: also run some test for chg

pulkit added a comment. Any reason why py3-chg is not included? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8178/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8178 To: marmoute, #hg-reviewers Cc: pulkit, mercurial-devel ___

D8178: heptapod-ci: also run some test for chg

marmoute added a comment. marmoute abandoned this revision. how did this go on phabricator… (probably runing phabsend with the wrong hash) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8178/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8178

D8178: heptapod-ci: also run some test for chg

marmoute added a comment. abandonning this for now. I mostly wanted to see a run on heptapod (spoiler warning about 20 test are broken) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8178/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8178 To

D8179: remotefilelog-test: glob some flaky output line

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is similar to ee0959e7d435 . The affected line is flaky underload, yet the fina

D8171: tests: handle In-Reply-To headers for line wrapping

marmoute added a comment. marmoute accepted this revision. If the test are happy, I guess we are. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8171/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8171 To: joerg.sonnenberger, #hg-reviewers, ma

D6825: hgext: start building a library for simple hooks

durin42 added a comment. durin42 added subscribers: marmoute, yuja, martinvonz. durin42 accepted this revision as: durin42. I'm happy with this, modulo my one question for other maintainers. If anyone else is happy, please feel encouraged to push it. INLINE COMMENTS > __init__.py:1 > +"""col

D7922: rust-matchers: add function to generate a regex matcher function

durin42 added a comment. durin42 accepted this revision as: durin42. I think this looks good, but I want Martin to ack that his concern is adequately resolved. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL https://phab.mer

D7922: rust-matchers: add function to generate a regex matcher function

This revision is now accepted and ready to land. martinvonz added a comment. martinvonz accepted this revision. In D7922#121720 , @durin42 wrote: > I think this looks good, but I want Martin to ack that his concern is adequately resolved.

D8157: rust-nodemap: use proper Index API instead of using the C API

marmoute updated this revision to Diff 20376. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8157?vs=20332&id=20376 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8157/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8158: rust-nodemap: add binding for `nodemap_data_all`

marmoute updated this revision to Diff 20377. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8158?vs=20333&id=20377 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8158/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8159: rust-nodemap: add binding for `nodemap_data_incremental`

marmoute updated this revision to Diff 20378. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8159?vs=20334&id=20378 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8159/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8160: rust-nodemap: add binding to `nodemap_update_data`

marmoute updated this revision to Diff 20379. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8160?vs=20335&id=20379 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8160/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8161: rust-nodemap: also clear Rust data in `clearcaches`

marmoute updated this revision to Diff 20380. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8161?vs=20336&id=20380 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8161/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8162: hghave: add a `rust` keyword to detect the use of compiled rust code

marmoute updated this revision to Diff 20381. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8162?vs=20337&id=20381 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8162/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8180: nodemap: check that a simple lookup works fine

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I realised the code was not exercised much. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8180 AFFECTED FILES

D8182: nodemap: document the docket attributes

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY More documentation rarely hurts. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8182 AFFECTED FILES mercurial/r

D8181: nodemap: add a todo list for getting out of experimental

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is all the requirement I can think off. More might be added as they emerge. The first ones are mostly simple technical matters that will be taken care of

D8183: nodemap: test that an outdated nodemap can catch up

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If the persistent nodemap does not contains all revision that the index contains, this is should be detected and dealt with. We add a test for this case. REPOS

D8164: rust-nodemap: automatically use the rust index for persistent nodemap

marmoute updated this revision to Diff 20383. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8164?vs=20356&id=20383 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8164/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8185: changelog: change the implementation of `_divertopenener`

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY During a transaction, new data to the changelog index are "diverted". The previous implementat ways pretty basic, we need something better to be able to use the

D8186: nodemap: deal with the "debugupdatecache" case using a "fake" transaction

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We are going to need more and more methods of the transaction. So lets change approach. The `hg debugupdatecache` case do not need a transaction, because has t

D8188: nodemap: make sure the nodemap docket is updated after the changelog

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It is better to have a lagging nodemap than a nodemap pointing to node that does not exists yet. (strictly speaking, the order was already right, however we

D8189: testlib: add a small scrip to help process to synchronise using file

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Creating and waiting for files is a robust way to synchronise two processes running concurrently. We already use this approach in various tests. I am adding a

D8190: nodemap: test that concurrent process don't see the pending transaction

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We don't want other client to read uncommitted data, until the transaction is really committed. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL h

D8191: nodemap: make sure on disk change get rolled back with the transaction

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In case of errors, we need to rollback the change made to the persistent nodemap. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.me

D8187: nodemap: make sure hooks have access to an up-to-date version

marmoute created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We make sure hooks can read persistent nodemap data and that they access something up-to-date with the pending transaction. RE

D8184: nodemap: track the tip_node for validation

marmoute created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8184 AFFECTED FILES mercurial/configitems.py me

D8193: nodemap: automatically "vacuum" the persistent nodemap when too sparse

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We arbitrarily pick "10%" as the threshold. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8193 AFFECTED FILES

D8192: nodemap: display percentage of unused in `hg debugnodemap`

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is useful to assess the density of the cache. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8192 AFFECTED F

D8171: tests: handle In-Reply-To headers for line wrapping

Closed by commit rHGa1908951ca42: tests: handle In-Reply-To headers for line wrapping (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mer

D8175: transaction: move constant to upper case

Closed by commit rHGbaf8c3f944eb: transaction: move constant to upper case (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D8176: transaction: clarify the logic around pre-finalize/post-finalize

Closed by commit rHGf6798c1a80fa: transaction: clarify the logic around pre-finalize/post-finalize (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D8194: tests: add test of committing with conflicts but no changes in wdir

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm about to change the behavior slightly here, so let's have a test that shows that. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://p

D8197: cleanup: remove redundant clearing of mergestate in rebase and shelve

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `repo.commit()` now clears the merge state even if it ends up not creating a commit because there were no changes to commit. REPOSITORY rHG Mercurial BRANCH

D8195: commit: error out on unresolved files even if commit would be empty

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8195 AFFECTED FILES mercurial/localrepo.py tests/test-update-branches.t CHANGE

D8196: commit: clear resolved mergestate even if working copy is clean

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If the mergestate has resolved conflicts and a commit is successfully created (either because there are changes in the working copy or because ui.allowemptyco

D6825: hgext: start building a library for simple hooks

joerg.sonnenberger added inline comments. INLINE COMMENTS > durin42 wrote in __init__.py:1 > Should we mark this as (EXPERIMENTAL) or are we comfortable holding on to > this long-term? > > /cc @marmoute @martinvonz @indygreg @yuja I'm perfectly fine with adding such a marker and a comment that

D6825: hgext: start building a library for simple hooks

martinvonz added inline comments. INLINE COMMENTS > joerg.sonnenberger wrote in __init__.py:1 > I'm perfectly fine with adding such a marker and a comment that the > functionality is meant for long-term support, but e.g. might migrate into the > notify extension. One of the big goals here is to

[Bug 6279] New: Typos in "Sorry for the delay" message when pulling commits from one machine to another

https://bz.mercurial-scm.org/show_bug.cgi?id=6279 Bug ID: 6279 Summary: Typos in "Sorry for the delay" message when pulling commits from one machine to another Product: Mercurial Version: unspecified Hardware: PC

D8198: transaction: add functionality to have multiple validators

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will help us in adding more validators which can aggregate data from transaction and prompt user whether to commit the transaction or not. The current target

D8199: scmutil: add option to register summary callbacks as transaction validators

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have a list of summary callbacks which are run after the transaction is closed to show what has changed and what not. This patch makes it possible to register

D8200: pull: add `--confirm` flag to confirm before writing changes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This introduces a new flag to pull command `--confirm` and also a config option named `pull.confirm` which if used will prompt user describing changes which are